Merge pull request #567 from ojeda/ci-werror

Fix remaining bindgen warnings & enable `WERROR` in the CI

Author: ojeda

.github/workflows/ci.yaml

@@ -313,6 +313,9 @@ jobs:
 
       - run: make ${{ env.MAKE_ARCH }} ${{ env.MAKE_CROSS_COMPILE }} ${{ env.MAKE_LLVM_IAS }} ${{ env.MAKE_TOOLCHAIN }} ${{ env.MAKE_OUTPUT }} ${{ env.MAKE_SYSROOT }} -j3
 
+      # Make sure `CONFIG_WERROR` was enabled
+      - run: grep -F 'CONFIG_WERROR=y' ${{ env.BUILD_DIR }}.config
+
       # Run
       - run: ${{ env.BUILD_DIR }}usr/gen_init_cpio .github/workflows/qemu-initramfs.desc > qemu-initramfs.img
 
@@ -438,6 +441,8 @@ jobs:
 
       # Report
       - run: |
+          cat ${{ env.BUILD_DIR }}.config
+
           ls -l \
             ${{ env.BUILD_DIR }}samples/rust/*.o \
             ${{ env.BUILD_DIR }}samples/rust/*.ko \

.github/workflows/kernel-arm-debug.config

@@ -1828,3 +1828,5 @@ CONFIG_RUST_OPT_LEVEL_2=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-arm-release.config

@@ -1786,3 +1786,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-arm64-debug-thinlto.config

@@ -1477,3 +1477,5 @@ CONFIG_RUST_OPT_LEVEL_1=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-arm64-debug.config

@@ -1472,3 +1472,5 @@ CONFIG_RUST_OPT_LEVEL_1=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-arm64-release-thinlto.config

@@ -1394,3 +1394,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-arm64-release.config

@@ -1389,3 +1389,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-ppc64le-debug.config

@@ -1593,3 +1593,5 @@ CONFIG_RUST_BUILD_ASSERT_ALLOW=y
 # CONFIG_RUST_BUILD_ASSERT_WARN is not set
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-ppc64le-release.config

@@ -1497,3 +1497,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-riscv64-debug.config

@@ -1321,3 +1321,5 @@ CONFIG_RUST_BUILD_ASSERT_ALLOW=y
 # CONFIG_RUST_BUILD_ASSERT_WARN is not set
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-riscv64-release.config

@@ -1236,3 +1236,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-x86_64-debug-thinlto.config

@@ -1544,3 +1544,5 @@ CONFIG_RUST_BUILD_ASSERT_ALLOW=y
 # CONFIG_RUST_BUILD_ASSERT_WARN is not set
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-x86_64-debug.config

@@ -1547,3 +1547,5 @@ CONFIG_RUST_BUILD_ASSERT_ALLOW=y
 # CONFIG_RUST_BUILD_ASSERT_WARN is not set
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-x86_64-release-thinlto.config

@@ -1444,3 +1444,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

.github/workflows/kernel-x86_64-release.config

@@ -1439,3 +1439,5 @@ CONFIG_RUST_OPT_LEVEL_SIMILAR_AS_CHOSEN_FOR_C=y
 CONFIG_RUST_BUILD_ASSERT_DENY=y
 # end of Rust hacking
 # end of Kernel hacking
+
+CONFIG_WERROR=y

rust/Makefile

@@ -211,8 +211,11 @@ bindgen_skip_c_flags := -mno-fp-ret-in-387 -mpreferred-stack-boundary=% \
 	-Wno-packed-not-aligned -Wno-format-truncation -Wno-format-overflow \
 	-Wno-stringop-truncation -Wno-unused-but-set-variable \
 	-Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized \
-	-Werror=designated-init -Wno-zero-length-bounds -Wimplicit-fallthrough=% \
-	--param=% --param asan-%
+	-Werror=designated-init -Wno-zero-length-bounds \
+	-Wno-alloc-size-larger-than --param=% --param asan-%
+
+# We need to keep the quotes for this one -- it comes from a `Kconfig`
+bindgen_skip_c_flags += "-Wimplicit-fallthrough=%"
 
 # PowerPC
 bindgen_skip_c_flags += -mtraceback=no -mno-pointers-to-nested-functions \
@@ -226,7 +229,9 @@ BINDGEN_TARGET_riscv	:= riscv64-linux-gnu
 BINDGEN_TARGET_x86	:= x86_64-linux-gnu
 BINDGEN_TARGET		:= $(BINDGEN_TARGET_$(SRCARCH))
 
-bindgen_extra_c_flags = --target=$(BINDGEN_TARGET) -Wno-address-of-packed-member
+bindgen_extra_c_flags = --target=$(BINDGEN_TARGET) \
+	-Wno-address-of-packed-member \
+	-Wno-gnu-variable-sized-type-not-at-end
 bindgen_c_flags = $(filter-out $(bindgen_skip_c_flags), $(c_flags)) \
 	$(bindgen_extra_c_flags)
 endif