Skip to content

Fix travis (again) #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cobrand opened this issue Apr 13, 2017 · 5 comments
Closed

Fix travis (again) #633

Cobrand opened this issue Apr 13, 2017 · 5 comments

Comments

@Cobrand
Copy link
Member

Cobrand commented Apr 13, 2017

Looks like there is an issue with rustup on nightly: https://travis-ci.org/AngryLawyer/rust-sdl2/jobs/221621182

@Xaeroxe
Copy link
Contributor

Xaeroxe commented Apr 13, 2017

Nightly is definitely prone to random failure, and provides zero stability guarantees. I recommend leaving nightly as an "allowed failure" in the .travis.yml. I can make a PR to do this if you want.

@Cobrand
Copy link
Member Author

Cobrand commented Apr 13, 2017

Except it's not nightly itself that fails, it's the download of nightly via rustup.rs . My guess is that either it was a mistake on their end, or they deprecated "nigtly" as a target and thus it doesn't work anymore.

Precisely, this fails :
curl -sSf https://sh.rustup.rs | sh -s -- --default-toolchain=$TRAVIS_RUST_VERSION -y

And we definitely want to adapt to nightly as well. Too many users develop on nightly to ignore this. Random failures are fine, we can run travis once more, but this looks like something became deprecated on rustup without our knowledge.

@Xaeroxe
Copy link
Contributor

Xaeroxe commented Apr 13, 2017

Personally I'm of the opinion that trying to support nightly users is an exercise in futility, but this also isn't my repository. This also pretty clearly looks like an upstream problem to me, and I can't find anything from Rustup saying they no longer support nightly, so perhaps an issue should be filed upstream with them?

@Cobrand
Copy link
Member Author

Cobrand commented Apr 14, 2017

Travis is back ! We just had to ask nicely.

@Cobrand Cobrand closed this as completed Apr 14, 2017
@Cobrand
Copy link
Member Author

Cobrand commented Apr 14, 2017

rust-lang/rustup#1062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants