'rust-warn += -Wno-unused-parameter' #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
approved these changes
Dec 1, 2022
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
Thank you Thomas! I'll open an issue to remove it once we merge the cleaned up trunk branch. Or we can keep that warning disabled if it annoys people too much :)
tschwinge
deleted the
tschwinge/gcc-patch-dev_rust-warn-Wno-unused-parameter
branch
Member
|
I use no-unused-parameters only because when we have prototypes like the abstract visitors etc it seems to complain but ideally we shouldn't rely on turning it off because we miss a lot of real good warnings and we should fix those and then remove this when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... addressing #1626, https://inbox.sourceware.org/gcc-patches/CAFiYyc1NQT+bBZXALTs7Qhc-ECbKKBt1tVKip_6C241y3ozT6w@mail.gmail.com.