Add python 3 support to cpplint_unittest #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-chaturvedi
force-pushed
the
py3_support
branch
from
1f01682 to
38f6a4d
Compare
Author
|
When we tried to make this change upstream, it spawned a discussion: CI testing: RobotLocomotion/drake#12776 |
jwnimmer-tri
approved these changes
Mar 2, 2020
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
- python2: fail master, pass PR
- python3: pass master, pass PR
We could change the shebang to python3, but since it passes with both I guess we'll leave it alone.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, platform LGTM from [jwnimmer-tri]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is