fix: could not download application with existing name (#795)

* improved error message when trying to duplicate application with existing name

* remove console log

---------

Co-authored-by: Antoine Hurard <[email protected]>

Author: estelafs

src/i18n/en.json

@@ -82,7 +82,8 @@
 			},
 			"duplicate": {
 				"errors": {
-					"invalidArguments": "Application name must be provided."
+					"invalidArguments": "Application name must be provided.",
+					"namedDuplicated": "Application with name {{name}} already exists. This name cannot be used. Please provide a different name."
 				}
 			},
 			"edit": {

src/i18n/test.json

@@ -82,7 +82,8 @@
 			},
 			"duplicate": {
 				"errors": {
-					"invalidArguments": "******"
+					"invalidArguments": "******",
+					"namedDuplicated": "****** {{name}} ******"
 				}
 			},
 			"edit": {

src/schema/mutation/duplicateApplication.mutation.ts

@@ -70,6 +70,18 @@ export default {
       if (ability.can('create', 'Application')) {
         // Check that a name was provided for the application
         if (args.name !== '') {
+          //  check if name is unique
+          const applicationWithName = await Application.findOne({
+            name: args.name,
+          });
+          if (applicationWithName) {
+            throw new GraphQLError(
+              context.i18next.t(
+                'mutations.application.duplicate.errors.namedDuplicated',
+                { name: args.name }
+              )
+            );
+          }
           // Copy application, and its permissions
           const application = new Application({
             name: args.name,