close connection on graph destruction (#130)

* close connection on graph object destruction only when the connection was created by the constructor (by passing host and port)

* close connection on graph object destruction only when the connection was created by the constructor (by passing host and port)

* Add test and change the default host and port to host='localhost', port=6379

Co-authored-by: Guy Korland <[email protected]>

Author: AvitalFineRedis

redisgraph/graph.py

@@ -10,12 +10,16 @@ class Graph:
     Graph, collection of nodes and edges.
     """
 
-    def __init__(self, name, redis_con):
+    def __init__(self, name, redis_con=None, host='localhost', port=6379, password=None):
         """
         Create a new graph.
         """
         self.name = name                 # Graph key
-        self.redis_con = redis_con
+        if redis_con is not None:
+            self.redis_con = redis_con
+        else:
+            self.redis_con = redis.Redis(host, port, password=password)
+
         self.nodes = {}
         self.edges = []
         self._labels = []                # List of node labels.

tests/functional/test_all.py

@@ -46,6 +46,19 @@ def test_graph_creation(self):
         # All done, remove graph.
         redis_graph.delete()
 
+    def test_graph_connection(self):
+        connections = len(self.r.client_list())
+        redis_graph = Graph('social', self.r)
+        del redis_graph
+        self.assertTrue(self.r.ping())
+        self.assertTrue(len(self.r.client_list()) == connections)
+
+        new_graph = Graph('social-new')
+        self.assertTrue(new_graph.redis_con.ping())
+        self.assertTrue(len(self.r.client_list()) == connections + 1)
+        del new_graph
+        self.assertTrue(len(self.r.client_list()) == connections)
+
     def test_array_functions(self):
         redis_graph = Graph('social', self.r)