Skip to content

Commit ee4ec61

Browse files
committed
remove redundant test
1 parent c153965 commit ee4ec61

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

test/Rx/Functional/FunctionalTestCase.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ static function getScheduler() {
4040
*/
4141
public function assertMessages(array $expected, array $recorded)
4242
{
43-
$this->scheduler->start();
44-
4543
if (count($expected) !== count($recorded)) {
4644
$this->fail(sprintf('Expected message count %d does not match actual count %d.', count($expected), count($recorded)));
4745
}
@@ -61,8 +59,6 @@ public function assertMessages(array $expected, array $recorded)
6159
*/
6260
public function assertMessagesNotEqual(array $expected, array $recorded)
6361
{
64-
$this->scheduler->start();
65-
6662
if (count($expected) !== count($recorded)) {
6763
$this->assertTrue(true);
6864
return;
@@ -80,8 +76,6 @@ public function assertMessagesNotEqual(array $expected, array $recorded)
8076

8177
public function assertSubscription(HotObservable $observable, Subscription $expected)
8278
{
83-
$this->scheduler->start();
84-
8579
$subscriptionCount = count($observable->getSubscriptions());
8680

8781
if ($subscriptionCount === 0) {
@@ -103,8 +97,6 @@ public function assertSubscription(HotObservable $observable, Subscription $expe
10397

10498
public function assertSubscriptions(array $expected, array $recorded)
10599
{
106-
$this->scheduler->start();
107-
108100
if (count($expected) !== count($recorded)) {
109101
$this->fail(sprintf('Expected subscription count %d does not match actual count %d.', count($expected), count($recorded)));
110102
}

test/Rx/Testing/RecordedTest.php

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -72,35 +72,6 @@ public function compare_cold_observables_not_equal()
7272
$this->assertFalse($records1->equals($records2));
7373
}
7474

75-
/**
76-
* @test
77-
*/
78-
public function automatic_mock_observer_doesnt_create_loggable_subscription()
79-
{
80-
$inner = $this->createColdObservable([
81-
onNext(150, 1),
82-
onNext(200, 2),
83-
onNext(250, 3),
84-
onCompleted(300),
85-
]);
86-
// Thanks to OnNextObservableNotification this internally creates
87-
// an instance of MockHigherOrderObserver which is not logged
88-
// by the ColdObservable::subscribe() method.
89-
$records = onNext(100, $inner);
90-
91-
$expected = onNext(100, $this->createColdObservable([
92-
onNext(150, 1),
93-
onNext(200, 2),
94-
onNext(250, 3),
95-
onCompleted(300),
96-
]));
97-
98-
$this->assertMessages([$records], [$expected]);
99-
$this->assertTrue($records->equals($expected));
100-
101-
$this->assertSubscriptions([], $inner->getSubscriptions());
102-
}
103-
10475
/**
10576
* @test
10677
*/
@@ -153,8 +124,6 @@ public function observables_at_different_time_with_same_records_arent_equal()
153124
onNext(100, 2),
154125
]));
155126

156-
$this->scheduler->start();
157-
158127
$this->assertFalse($records1->equals($records2));
159128
$this->assertEquals('[OnNext(1)@50, OnNext(2)@100]@50', $records1->__toString());
160129
}
@@ -173,8 +142,6 @@ public function observables_with_inner_records_at_different_time_arent_equal()
173142
onNext(100, 2),
174143
]));
175144

176-
$this->scheduler->start();
177-
178145
$this->assertFalse($records1->equals($records2));
179146
$this->assertEquals('[OnNext(1)@50, OnNext(2)@150]@100', $records1->__toString());
180147
}

0 commit comments

Comments
 (0)