From 33b7d55b58500a56cc0bbfba1ad281e52e03d54d Mon Sep 17 00:00:00 2001 From: Vesko Iliev Date: Mon, 30 Apr 2018 21:25:54 +0100 Subject: [PATCH 1/2] Add marble diagrams to a few Single.doOnX methods. --- src/main/java/io/reactivex/Single.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/main/java/io/reactivex/Single.java b/src/main/java/io/reactivex/Single.java index d18170b221..f91c19274f 100644 --- a/src/main/java/io/reactivex/Single.java +++ b/src/main/java/io/reactivex/Single.java @@ -2173,6 +2173,9 @@ public final Single doAfterTerminate(Action onAfterTerminate) { * is executed once per subscription. *

Note that the {@code onFinally} action is shared between subscriptions and as such * should be thread-safe. + *

+ * + *

*
*
Scheduler:
*
{@code doFinally} does not operate by default on a particular {@link Scheduler}.
@@ -2192,6 +2195,9 @@ public final Single doFinally(Action onFinally) { /** * Calls the shared consumer with the Disposable sent through the onSubscribe for each * SingleObserver that subscribes to the current Single. + *

+ * + *

*
*
Scheduler:
*
{@code doOnSubscribe} does not operate by default on a particular {@link Scheduler}.
@@ -2210,6 +2216,9 @@ public final Single doOnSubscribe(final Consumer onSubscr /** * Calls the shared consumer with the success value sent via onSuccess for each * SingleObserver that subscribes to the current Single. + *

+ * + *

*
*
Scheduler:
*
{@code doOnSuccess} does not operate by default on a particular {@link Scheduler}.
@@ -2246,6 +2255,9 @@ public final Single doOnEvent(final BiConsumer /** * Calls the shared consumer with the error sent via onError for each * SingleObserver that subscribes to the current Single. + *

+ * + *

*
*
Scheduler:
*
{@code doOnError} does not operate by default on a particular {@link Scheduler}.
@@ -2264,6 +2276,9 @@ public final Single doOnError(final Consumer onError) { /** * Calls the shared {@code Action} if a SingleObserver subscribed to the current Single * disposes the common Disposable it received via onSubscribe. + *

+ * + *

*
*
Scheduler:
*
{@code doOnDispose} does not operate by default on a particular {@link Scheduler}.
From d6059a1903c1325f295bb880eb79708fde173332 Mon Sep 17 00:00:00 2001 From: Vesko Iliev Date: Mon, 30 Apr 2018 22:29:24 +0100 Subject: [PATCH 2/2] Use correct marble diagram urls for couple of Single.doOnXX methods --- src/main/java/io/reactivex/Single.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/io/reactivex/Single.java b/src/main/java/io/reactivex/Single.java index f91c19274f..240415c0f9 100644 --- a/src/main/java/io/reactivex/Single.java +++ b/src/main/java/io/reactivex/Single.java @@ -2174,7 +2174,7 @@ public final Single doAfterTerminate(Action onAfterTerminate) { *

Note that the {@code onFinally} action is shared between subscriptions and as such * should be thread-safe. *

- * + * *

*
*
Scheduler:
@@ -2196,7 +2196,7 @@ public final Single doFinally(Action onFinally) { * Calls the shared consumer with the Disposable sent through the onSubscribe for each * SingleObserver that subscribes to the current Single. *

- * + * *

*
*
Scheduler:
@@ -2217,7 +2217,7 @@ public final Single doOnSubscribe(final Consumer onSubscr * Calls the shared consumer with the success value sent via onSuccess for each * SingleObserver that subscribes to the current Single. *

- * + * *

*
*
Scheduler:
@@ -2256,7 +2256,7 @@ public final Single doOnEvent(final BiConsumer * Calls the shared consumer with the error sent via onError for each * SingleObserver that subscribes to the current Single. *

- * + * *

*
*
Scheduler:
@@ -2277,7 +2277,7 @@ public final Single doOnError(final Consumer onError) { * Calls the shared {@code Action} if a SingleObserver subscribed to the current Single * disposes the common Disposable it received via onSubscribe. *

- * + * *

*
*
Scheduler: