diff --git a/src/main/java/io/reactivex/Completable.java b/src/main/java/io/reactivex/Completable.java index 134119fa08..f0e57a6a11 100644 --- a/src/main/java/io/reactivex/Completable.java +++ b/src/main/java/io/reactivex/Completable.java @@ -2286,9 +2286,9 @@ public final Completable unsubscribeOn(final Scheduler scheduler) { @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test() { - TestObserver ts = new TestObserver(); - subscribe(ts); - return ts; + TestObserver to = new TestObserver(); + subscribe(to); + return to; } /** @@ -2305,12 +2305,12 @@ public final TestObserver test() { @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test(boolean cancelled) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); if (cancelled) { - ts.cancel(); + to.cancel(); } - subscribe(ts); - return ts; + subscribe(to); + return to; } } diff --git a/src/main/java/io/reactivex/Maybe.java b/src/main/java/io/reactivex/Maybe.java index f3d8cec1a6..cb3b18145d 100644 --- a/src/main/java/io/reactivex/Maybe.java +++ b/src/main/java/io/reactivex/Maybe.java @@ -4496,9 +4496,9 @@ public final Maybe zipWith(MaybeSource other, BiFunction< @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test() { - TestObserver ts = new TestObserver(); - subscribe(ts); - return ts; + TestObserver to = new TestObserver(); + subscribe(to); + return to; } /** @@ -4514,13 +4514,13 @@ public final TestObserver test() { @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test(boolean cancelled) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); if (cancelled) { - ts.cancel(); + to.cancel(); } - subscribe(ts); - return ts; + subscribe(to); + return to; } } diff --git a/src/main/java/io/reactivex/Observable.java b/src/main/java/io/reactivex/Observable.java index 5337cdbb3b..f4a5412a64 100644 --- a/src/main/java/io/reactivex/Observable.java +++ b/src/main/java/io/reactivex/Observable.java @@ -15079,9 +15079,9 @@ public final Observable zipWith(ObservableSource other, @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test() { // NoPMD - TestObserver ts = new TestObserver(); - subscribe(ts); - return ts; + TestObserver to = new TestObserver(); + subscribe(to); + return to; } /** @@ -15099,11 +15099,11 @@ public final TestObserver test() { // NoPMD @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test(boolean dispose) { // NoPMD - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); if (dispose) { - ts.dispose(); + to.dispose(); } - subscribe(ts); - return ts; + subscribe(to); + return to; } } diff --git a/src/main/java/io/reactivex/Single.java b/src/main/java/io/reactivex/Single.java index 2ef5a5d63e..d3c1bf6aca 100644 --- a/src/main/java/io/reactivex/Single.java +++ b/src/main/java/io/reactivex/Single.java @@ -3654,9 +3654,9 @@ public final Single zipWith(SingleSource other, BiFunction test() { - TestObserver ts = new TestObserver(); - subscribe(ts); - return ts; + TestObserver to = new TestObserver(); + subscribe(to); + return to; } /** @@ -3673,14 +3673,14 @@ public final TestObserver test() { @CheckReturnValue @SchedulerSupport(SchedulerSupport.NONE) public final TestObserver test(boolean cancelled) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); if (cancelled) { - ts.cancel(); + to.cancel(); } - subscribe(ts); - return ts; + subscribe(to); + return to; } private static Single toSingle(Flowable source) { diff --git a/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java b/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java index f32b58dfbc..64853d362b 100644 --- a/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java +++ b/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java @@ -64,13 +64,13 @@ public static Flowable multicastSelector( * Child Subscribers will observe the events of the ConnectableObservable on the * specified scheduler. * @param the value type - * @param co the ConnectableFlowable to wrap + * @param cf the ConnectableFlowable to wrap * @param scheduler the target scheduler * @return the new ConnectableObservable instance */ - public static ConnectableFlowable observeOn(final ConnectableFlowable co, final Scheduler scheduler) { - final Flowable observable = co.observeOn(scheduler); - return RxJavaPlugins.onAssembly(new ConnectableFlowableReplay(co, observable)); + public static ConnectableFlowable observeOn(final ConnectableFlowable cf, final Scheduler scheduler) { + final Flowable observable = cf.observeOn(scheduler); + return RxJavaPlugins.onAssembly(new ConnectableFlowableReplay(cf, observable)); } /** @@ -1100,9 +1100,9 @@ static final class MulticastFlowable extends Flowable { @Override protected void subscribeActual(Subscriber child) { - ConnectableFlowable co; + ConnectableFlowable cf; try { - co = ObjectHelper.requireNonNull(connectableFactory.call(), "The connectableFactory returned null"); + cf = ObjectHelper.requireNonNull(connectableFactory.call(), "The connectableFactory returned null"); } catch (Throwable e) { Exceptions.throwIfFatal(e); EmptySubscription.error(e, child); @@ -1111,7 +1111,7 @@ protected void subscribeActual(Subscriber child) { Publisher observable; try { - observable = ObjectHelper.requireNonNull(selector.apply(co), "The selector returned a null Publisher"); + observable = ObjectHelper.requireNonNull(selector.apply(cf), "The selector returned a null Publisher"); } catch (Throwable e) { Exceptions.throwIfFatal(e); EmptySubscription.error(e, child); @@ -1122,7 +1122,7 @@ protected void subscribeActual(Subscriber child) { observable.subscribe(srw); - co.connect(new DisposableConsumer(srw)); + cf.connect(new DisposableConsumer(srw)); } final class DisposableConsumer implements Consumer { @@ -1140,17 +1140,17 @@ public void accept(Disposable r) { } static final class ConnectableFlowableReplay extends ConnectableFlowable { - private final ConnectableFlowable co; + private final ConnectableFlowable cf; private final Flowable observable; - ConnectableFlowableReplay(ConnectableFlowable co, Flowable observable) { - this.co = co; + ConnectableFlowableReplay(ConnectableFlowable cf, Flowable observable) { + this.cf = cf; this.observable = observable; } @Override public void connect(Consumer connection) { - co.connect(connection); + cf.connect(connection); } @Override diff --git a/src/main/java/io/reactivex/observers/TestObserver.java b/src/main/java/io/reactivex/observers/TestObserver.java index 761414de01..18d9b41faf 100644 --- a/src/main/java/io/reactivex/observers/TestObserver.java +++ b/src/main/java/io/reactivex/observers/TestObserver.java @@ -18,8 +18,8 @@ import io.reactivex.disposables.Disposable; import io.reactivex.functions.Consumer; import io.reactivex.internal.disposables.DisposableHelper; -import io.reactivex.internal.fuseable.QueueDisposable; -import io.reactivex.internal.util.*; +import io.reactivex.internal.fuseable.*; +import io.reactivex.internal.util.ExceptionHelper; /** * An Observer that records events and allows making assertions about them. @@ -309,9 +309,9 @@ final TestObserver assertFusionMode(int mode) { static String fusionModeToString(int mode) { switch (mode) { - case QueueDisposable.NONE : return "NONE"; - case QueueDisposable.SYNC : return "SYNC"; - case QueueDisposable.ASYNC : return "ASYNC"; + case QueueFuseable.NONE : return "NONE"; + case QueueFuseable.SYNC : return "SYNC"; + case QueueFuseable.ASYNC : return "ASYNC"; default: return "Unknown(" + mode + ")"; } } diff --git a/src/test/java/io/reactivex/CheckLocalVariablesInTests.java b/src/test/java/io/reactivex/CheckLocalVariablesInTests.java new file mode 100644 index 0000000000..9139738b9f --- /dev/null +++ b/src/test/java/io/reactivex/CheckLocalVariablesInTests.java @@ -0,0 +1,191 @@ +/** + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is + * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See + * the License for the specific language governing permissions and limitations under the License. + */ + +package io.reactivex; + +import java.io.*; +import java.util.*; +import java.util.regex.Pattern; + +import org.junit.Test; + +/** + * Checks for commonly copy-pasted but not-renamed local variables in unit tests. + *
    + *
  • {@code TestSubscriber} named as {@code to*}
  • + *
  • {@code TestObserver} named as {@code ts*}
  • + *
  • {@code PublishProcessor} named as {@code ps*}
  • + *
  • {@code PublishSubject} named as {@code pp*}
  • + *
+ */ +public class CheckLocalVariablesInTests { + + static void findPattern(String pattern) throws Exception { + File f = MaybeNo2Dot0Since.findSource("Flowable"); + if (f == null) { + System.out.println("Unable to find sources of RxJava"); + return; + } + + Queue dirs = new ArrayDeque(); + + StringBuilder fail = new StringBuilder(); + fail.append("The following code pattern was found: ").append(pattern).append("\n"); + + File parent = f.getParentFile(); + + dirs.offer(new File(parent.getAbsolutePath().replace('\\', '/').replace("src/main/java", "src/test/java"))); + + Pattern p = Pattern.compile(pattern); + + int total = 0; + + while (!dirs.isEmpty()) { + f = dirs.poll(); + + File[] list = f.listFiles(); + if (list != null && list.length != 0) { + + for (File u : list) { + if (u.isDirectory()) { + dirs.offer(u); + } else { + String fname = u.getName(); + if (fname.endsWith(".java")) { + + int lineNum = 0; + BufferedReader in = new BufferedReader(new FileReader(u)); + try { + for (;;) { + String line = in.readLine(); + if (line != null) { + lineNum++; + + line = line.trim(); + + if (!line.startsWith("//") && !line.startsWith("*")) { + if (p.matcher(line).find()) { + fail + .append(fname) + .append("#L").append(lineNum) + .append(" ").append(line) + .append("\n"); + total++; + } + } + } else { + break; + } + } + } finally { + in.close(); + } + } + } + } + } + } + if (total != 0) { + fail.append("Found ") + .append(total) + .append(" instances"); + System.out.println(fail); + throw new AssertionError(fail.toString()); + } + } + + @Test + public void testSubscriberAsTo() throws Exception { + findPattern("TestSubscriber<.*>\\s+to"); + } + + @Test + public void testObserverAsTs() throws Exception { + findPattern("TestObserver<.*>\\s+ts"); + } + + @Test + public void publishSubjectAsPp() throws Exception { + findPattern("PublishSubject<.*>\\s+pp"); + } + + @Test + public void publishProcessorAsPs() throws Exception { + findPattern("PublishProcessor<.*>\\s+ps"); + } + + @Test + public void behaviorProcessorAsBs() throws Exception { + findPattern("BehaviorProcessor<.*>\\s+bs"); + } + + @Test + public void behaviorSubjectAsBp() throws Exception { + findPattern("BehaviorSubject<.*>\\s+bp"); + } + + @Test + public void connectableFlowableAsCo() throws Exception { + findPattern("ConnectableFlowable<.*>\\s+co(0-9|\\b)"); + } + + @Test + public void connectableObservableAsCf() throws Exception { + findPattern("ConnectableObservable<.*>\\s+cf(0-9|\\b)"); + } + + @Test + public void queueDisposableInsteadOfQueueFuseable() throws Exception { + findPattern("QueueDisposable\\.(NONE|SYNC|ASYNC|ANY|BOUNDARY)"); + } + + @Test + public void queueSubscriptionInsteadOfQueueFuseable() throws Exception { + findPattern("QueueSubscription\\.(NONE|SYNC|ASYNC|ANY|BOUNDARY)"); + } + + @Test + public void singleSourceAsMs() throws Exception { + findPattern("SingleSource<.*>\\s+ms"); + } + + @Test + public void singleSourceAsCs() throws Exception { + findPattern("SingleSource<.*>\\s+cs"); + } + + @Test + public void maybeSourceAsSs() throws Exception { + findPattern("MaybeSource<.*>\\s+ss"); + } + + @Test + public void maybeSourceAsCs() throws Exception { + findPattern("MaybeSource<.*>\\s+cs"); + } + + @Test + public void completableSourceAsSs() throws Exception { + findPattern("CompletableSource<.*>\\s+ss"); + } + + @Test + public void completableSourceAsMs() throws Exception { + findPattern("CompletableSource<.*>\\s+ms"); + } + + @Test + public void observableAsC() throws Exception { + findPattern("Observable<.*>\\s+c\\b"); + } +} diff --git a/src/test/java/io/reactivex/TestHelper.java b/src/test/java/io/reactivex/TestHelper.java index b6660c19d6..2a4ac1ee58 100644 --- a/src/test/java/io/reactivex/TestHelper.java +++ b/src/test/java/io/reactivex/TestHelper.java @@ -217,8 +217,8 @@ public static void assertUndeliverable(List list, int index, Class ts, int index, Class clazz) { - Throwable ex = ts.errors().get(0); + public static void assertError(TestObserver to, int index, Class clazz) { + Throwable ex = to.errors().get(0); try { if (ex instanceof CompositeException) { CompositeException ce = (CompositeException) ex; @@ -244,8 +244,8 @@ public static void assertError(TestSubscriber ts, int index, Class ts, int index, Class clazz, String message) { - Throwable ex = ts.errors().get(0); + public static void assertError(TestObserver to, int index, Class clazz, String message) { + Throwable ex = to.errors().get(0); if (ex instanceof CompositeException) { CompositeException ce = (CompositeException) ex; List cel = ce.getExceptions(); @@ -514,14 +514,14 @@ public void accept(TestSubscriber ts) throws Exception { public static Consumer> observerSingleNot(final T value) { return new Consumer>() { @Override - public void accept(TestObserver ts) throws Exception { - ts + public void accept(TestObserver to) throws Exception { + to .assertSubscribed() .assertValueCount(1) .assertNoErrors() .assertComplete(); - T v = ts.values().get(0); + T v = to.values().get(0); assertNotEquals(value, v); } }; @@ -2271,16 +2271,16 @@ public static void assertCompositeExceptions(TestSubscriber ts, Object... cla /** * Check if the TestSubscriber has a CompositeException with the specified class * of Throwables in the given order. - * @param ts the TestSubscriber instance + * @param to the TestSubscriber instance * @param classes the array of expected Throwables inside the Composite */ - public static void assertCompositeExceptions(TestObserver ts, Class... classes) { - ts + public static void assertCompositeExceptions(TestObserver to, Class... classes) { + to .assertSubscribed() .assertError(CompositeException.class) .assertNotComplete(); - List list = compositeList(ts.errors().get(0)); + List list = compositeList(to.errors().get(0)); assertEquals(classes.length, list.size()); @@ -2292,18 +2292,18 @@ public static void assertCompositeExceptions(TestObserver ts, Class ts, Object... classes) { - ts + public static void assertCompositeExceptions(TestObserver to, Object... classes) { + to .assertSubscribed() .assertError(CompositeException.class) .assertNotComplete(); - List list = compositeList(ts.errors().get(0)); + List list = compositeList(to.errors().get(0)); assertEquals(classes.length, list.size()); @@ -2357,9 +2357,9 @@ public void onSubscribe(Disposable d) { QueueDisposable qd = (QueueDisposable) d; state[0] = true; - int m = qd.requestFusion(QueueDisposable.ANY); + int m = qd.requestFusion(QueueFuseable.ANY); - if (m != QueueDisposable.NONE) { + if (m != QueueFuseable.NONE) { state[1] = true; state[2] = qd.isEmpty(); @@ -2423,9 +2423,9 @@ public void onSubscribe(Subscription d) { QueueSubscription qd = (QueueSubscription) d; state[0] = true; - int m = qd.requestFusion(QueueSubscription.ANY); + int m = qd.requestFusion(QueueFuseable.ANY); - if (m != QueueSubscription.NONE) { + if (m != QueueFuseable.NONE) { state[1] = true; state[2] = qd.isEmpty(); @@ -2481,11 +2481,11 @@ public static List errorList(TestObserver to) { /** * Returns an expanded error list of the given test consumer. - * @param to the test consumer instance + * @param ts the test consumer instance * @return the list */ - public static List errorList(TestSubscriber to) { - return compositeList(to.errors().get(0)); + public static List errorList(TestSubscriber ts) { + return compositeList(ts.errors().get(0)); } /** @@ -2557,23 +2557,23 @@ protected void subscribeActual(Observer observer) { if (o instanceof Publisher) { Publisher os = (Publisher) o; - TestSubscriber to = new TestSubscriber(); + TestSubscriber ts = new TestSubscriber(); - os.subscribe(to); + os.subscribe(ts); - to.awaitDone(5, TimeUnit.SECONDS); + ts.awaitDone(5, TimeUnit.SECONDS); - to.assertSubscribed(); + ts.assertSubscribed(); if (expected != null) { - to.assertValues(expected); + ts.assertValues(expected); } if (error) { - to.assertError(TestException.class) + ts.assertError(TestException.class) .assertErrorMessage("error") .assertNotComplete(); } else { - to.assertNoErrors().assertComplete(); + ts.assertNoErrors().assertComplete(); } } @@ -2716,23 +2716,23 @@ protected void subscribeActual(Subscriber observer) { if (o instanceof Publisher) { Publisher os = (Publisher) o; - TestSubscriber to = new TestSubscriber(); + TestSubscriber ts = new TestSubscriber(); - os.subscribe(to); + os.subscribe(ts); - to.awaitDone(5, TimeUnit.SECONDS); + ts.awaitDone(5, TimeUnit.SECONDS); - to.assertSubscribed(); + ts.assertSubscribed(); if (expected != null) { - to.assertValues(expected); + ts.assertValues(expected); } if (error) { - to.assertError(TestException.class) + ts.assertError(TestException.class) .assertErrorMessage("error") .assertNotComplete(); } else { - to.assertNoErrors().assertComplete(); + ts.assertNoErrors().assertComplete(); } } diff --git a/src/test/java/io/reactivex/XFlatMapTest.java b/src/test/java/io/reactivex/XFlatMapTest.java index 028814e5ec..8a6ec939c5 100644 --- a/src/test/java/io/reactivex/XFlatMapTest.java +++ b/src/test/java/io/reactivex/XFlatMapTest.java @@ -154,7 +154,7 @@ public Maybe apply(Integer v) throws Exception { public void flowableCompletable() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Flowable.just(1) + TestObserver to = Flowable.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -167,13 +167,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -217,7 +217,7 @@ public Completable apply(Integer v) throws Exception { public void observableFlowable() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Observable.just(1) + TestObserver to = Observable.just(1) .subscribeOn(Schedulers.io()) .flatMap(new Function>() { @Override @@ -230,13 +230,13 @@ public Observable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -248,7 +248,7 @@ public Observable apply(Integer v) throws Exception { public void observerSingle() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Observable.just(1) + TestObserver to = Observable.just(1) .subscribeOn(Schedulers.io()) .flatMapSingle(new Function>() { @Override @@ -261,13 +261,13 @@ public Single apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -279,7 +279,7 @@ public Single apply(Integer v) throws Exception { public void observerMaybe() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Observable.just(1) + TestObserver to = Observable.just(1) .subscribeOn(Schedulers.io()) .flatMapMaybe(new Function>() { @Override @@ -292,13 +292,13 @@ public Maybe apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -310,7 +310,7 @@ public Maybe apply(Integer v) throws Exception { public void observerCompletable() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Observable.just(1) + TestObserver to = Observable.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -323,13 +323,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -341,7 +341,7 @@ public Completable apply(Integer v) throws Exception { public void observerCompletable2() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Observable.just(1) + TestObserver to = Observable.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -355,13 +355,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -373,7 +373,7 @@ public Completable apply(Integer v) throws Exception { public void singleSingle() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Single.just(1) + TestObserver to = Single.just(1) .subscribeOn(Schedulers.io()) .flatMap(new Function>() { @Override @@ -386,13 +386,13 @@ public Single apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -404,7 +404,7 @@ public Single apply(Integer v) throws Exception { public void singleMaybe() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Single.just(1) + TestObserver to = Single.just(1) .subscribeOn(Schedulers.io()) .flatMapMaybe(new Function>() { @Override @@ -417,13 +417,13 @@ public Maybe apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -435,7 +435,7 @@ public Maybe apply(Integer v) throws Exception { public void singleCompletable() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Single.just(1) + TestObserver to = Single.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -448,13 +448,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -466,7 +466,7 @@ public Completable apply(Integer v) throws Exception { public void singleCompletable2() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Single.just(1) + TestObserver to = Single.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -480,13 +480,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -498,7 +498,7 @@ public Completable apply(Integer v) throws Exception { public void maybeSingle() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .subscribeOn(Schedulers.io()) .flatMapSingle(new Function>() { @Override @@ -511,13 +511,13 @@ public Single apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -529,7 +529,7 @@ public Single apply(Integer v) throws Exception { public void maybeMaybe() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .subscribeOn(Schedulers.io()) .flatMap(new Function>() { @Override @@ -542,13 +542,13 @@ public Maybe apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -560,7 +560,7 @@ public Maybe apply(Integer v) throws Exception { public void maybeCompletable() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -573,13 +573,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { @@ -591,7 +591,7 @@ public Completable apply(Integer v) throws Exception { public void maybeCompletable2() throws Exception { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .subscribeOn(Schedulers.io()) .flatMapCompletable(new Function() { @Override @@ -605,13 +605,13 @@ public Completable apply(Integer v) throws Exception { cb.await(); - beforeCancelSleep(ts); + beforeCancelSleep(to); - ts.cancel(); + to.cancel(); Thread.sleep(SLEEP_AFTER_CANCEL); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(errors.toString(), errors.isEmpty()); } finally { diff --git a/src/test/java/io/reactivex/completable/CompletableTest.java b/src/test/java/io/reactivex/completable/CompletableTest.java index 9b0b914a66..010ba0c619 100644 --- a/src/test/java/io/reactivex/completable/CompletableTest.java +++ b/src/test/java/io/reactivex/completable/CompletableTest.java @@ -2599,24 +2599,24 @@ public void run() { } @Test(timeout = 5000) public void subscribeObserverNormal() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - normal.completable.toObservable().subscribe(ts); + normal.completable.toObservable().subscribe(to); - ts.assertComplete(); - ts.assertNoValues(); - ts.assertNoErrors(); + to.assertComplete(); + to.assertNoValues(); + to.assertNoErrors(); } @Test(timeout = 5000) public void subscribeObserverError() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - error.completable.toObservable().subscribe(ts); + error.completable.toObservable().subscribe(to); - ts.assertNotComplete(); - ts.assertNoValues(); - ts.assertError(TestException.class); + to.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); } @Test(timeout = 5000) @@ -2978,12 +2978,12 @@ public void ambArraySingleError() { @Test(timeout = 5000) public void ambArrayOneFires() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = Completable.ambArray(c1, c2); @@ -2996,25 +2996,25 @@ public void run() { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps1.onComplete(); + pp1.onComplete(); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get()); } @Test(timeout = 5000) public void ambArrayOneFiresError() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = Completable.ambArray(c1, c2); @@ -3027,25 +3027,25 @@ public void accept(Throwable v) { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps1.onError(new TestException()); + pp1.onError(new TestException()); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get() instanceof TestException); } @Test(timeout = 5000) public void ambArraySecondFires() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = Completable.ambArray(c1, c2); @@ -3058,25 +3058,25 @@ public void run() { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps2.onComplete(); + pp2.onComplete(); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get()); } @Test(timeout = 5000) public void ambArraySecondFiresError() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = Completable.ambArray(c1, c2); @@ -3089,13 +3089,13 @@ public void accept(Throwable v) { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps2.onError(new TestException()); + pp2.onError(new TestException()); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get() instanceof TestException); } @@ -3199,12 +3199,12 @@ public void ambWithNull() { @Test(timeout = 5000) public void ambWithArrayOneFires() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = c1.ambWith(c2); @@ -3217,25 +3217,25 @@ public void run() { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps1.onComplete(); + pp1.onComplete(); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get()); } @Test(timeout = 5000) public void ambWithArrayOneFiresError() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = c1.ambWith(c2); @@ -3248,25 +3248,25 @@ public void accept(Throwable v) { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps1.onError(new TestException()); + pp1.onError(new TestException()); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get() instanceof TestException); } @Test(timeout = 5000) public void ambWithArraySecondFires() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = c1.ambWith(c2); @@ -3279,25 +3279,25 @@ public void run() { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps2.onComplete(); + pp2.onComplete(); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get()); } @Test(timeout = 5000) public void ambWithArraySecondFiresError() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Completable c1 = Completable.fromPublisher(ps1); + Completable c1 = Completable.fromPublisher(pp1); - Completable c2 = Completable.fromPublisher(ps2); + Completable c2 = Completable.fromPublisher(pp2); Completable c = c1.ambWith(c2); @@ -3310,13 +3310,13 @@ public void accept(Throwable v) { } }); - Assert.assertTrue("First subject no subscribers", ps1.hasSubscribers()); - Assert.assertTrue("Second subject no subscribers", ps2.hasSubscribers()); + Assert.assertTrue("First subject no subscribers", pp1.hasSubscribers()); + Assert.assertTrue("Second subject no subscribers", pp2.hasSubscribers()); - ps2.onError(new TestException()); + pp2.onError(new TestException()); - Assert.assertFalse("First subject has subscribers", ps1.hasSubscribers()); - Assert.assertFalse("Second subject has subscribers", ps2.hasSubscribers()); + Assert.assertFalse("First subject has subscribers", pp1.hasSubscribers()); + Assert.assertFalse("Second subject has subscribers", pp2.hasSubscribers()); Assert.assertTrue("Not completed", complete.get() instanceof TestException); } @@ -3395,7 +3395,7 @@ public void startWithFlowableError() { @Test(timeout = 5000) public void startWithObservableNormal() { final AtomicBoolean run = new AtomicBoolean(); - Observable c = normal.completable + Observable o = normal.completable .startWith(Observable.fromCallable(new Callable() { @Override public Object call() throws Exception { @@ -3404,32 +3404,32 @@ public Object call() throws Exception { } })); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - c.subscribe(ts); + o.subscribe(to); Assert.assertTrue("Did not start with other", run.get()); normal.assertSubscriptions(1); - ts.assertValue(1); - ts.assertComplete(); - ts.assertNoErrors(); + to.assertValue(1); + to.assertComplete(); + to.assertNoErrors(); } @Test(timeout = 5000) public void startWithObservableError() { - Observable c = normal.completable + Observable o = normal.completable .startWith(Observable.error(new TestException())); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - c.subscribe(ts); + o.subscribe(to); normal.assertSubscriptions(0); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test(expected = NullPointerException.class) diff --git a/src/test/java/io/reactivex/flowable/FlowableFuseableTest.java b/src/test/java/io/reactivex/flowable/FlowableFuseableTest.java index 64e886e614..f9594a6220 100644 --- a/src/test/java/io/reactivex/flowable/FlowableFuseableTest.java +++ b/src/test/java/io/reactivex/flowable/FlowableFuseableTest.java @@ -17,8 +17,8 @@ import org.junit.Test; import io.reactivex.Flowable; -import io.reactivex.internal.fuseable.QueueSubscription; -import io.reactivex.subscribers.*; +import io.reactivex.internal.fuseable.*; +import io.reactivex.subscribers.SubscriberFusion; public class FlowableFuseableTest { @@ -26,8 +26,8 @@ public class FlowableFuseableTest { public void syncRange() { Flowable.range(1, 10) - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -37,8 +37,8 @@ public void syncRange() { public void syncArray() { Flowable.fromArray(new Integer[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 }) - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -48,8 +48,8 @@ public void syncArray() { public void syncIterable() { Flowable.fromIterable(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)) - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -59,9 +59,9 @@ public void syncIterable() { public void syncRangeHidden() { Flowable.range(1, 10).hide() - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) .assertOf(SubscriberFusion.assertNotFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -71,9 +71,9 @@ public void syncRangeHidden() { public void syncArrayHidden() { Flowable.fromArray(new Integer[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 }) .hide() - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) .assertOf(SubscriberFusion.assertNotFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -83,9 +83,9 @@ public void syncArrayHidden() { public void syncIterableHidden() { Flowable.fromIterable(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)) .hide() - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) .assertOf(SubscriberFusion.assertNotFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); diff --git a/src/test/java/io/reactivex/flowable/FlowableSubscriberTest.java b/src/test/java/io/reactivex/flowable/FlowableSubscriberTest.java index e9e0da5159..c944d63092 100644 --- a/src/test/java/io/reactivex/flowable/FlowableSubscriberTest.java +++ b/src/test/java/io/reactivex/flowable/FlowableSubscriberTest.java @@ -749,11 +749,11 @@ public void accept(Throwable e) throws Exception { @Test public void methodTestCancelled() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.test(Long.MAX_VALUE, true); + pp.test(Long.MAX_VALUE, true); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test @@ -767,11 +767,11 @@ public void safeSubscriberAlreadySafe() { @Test public void methodTestNoCancel() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.test(Long.MAX_VALUE, false); + pp.test(Long.MAX_VALUE, false); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); } @Test diff --git a/src/test/java/io/reactivex/internal/disposables/EmptyDisposableTest.java b/src/test/java/io/reactivex/internal/disposables/EmptyDisposableTest.java index 7e25cbcd4f..d373560413 100644 --- a/src/test/java/io/reactivex/internal/disposables/EmptyDisposableTest.java +++ b/src/test/java/io/reactivex/internal/disposables/EmptyDisposableTest.java @@ -14,10 +14,11 @@ package io.reactivex.internal.disposables; import static org.junit.Assert.*; + import org.junit.Test; import io.reactivex.TestHelper; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; public class EmptyDisposableTest { @@ -28,8 +29,8 @@ public void noOffer() { @Test public void asyncFusion() { - assertEquals(QueueDisposable.NONE, EmptyDisposable.INSTANCE.requestFusion(QueueDisposable.SYNC)); - assertEquals(QueueDisposable.ASYNC, EmptyDisposable.INSTANCE.requestFusion(QueueDisposable.ASYNC)); + assertEquals(QueueFuseable.NONE, EmptyDisposable.INSTANCE.requestFusion(QueueFuseable.SYNC)); + assertEquals(QueueFuseable.ASYNC, EmptyDisposable.INSTANCE.requestFusion(QueueFuseable.ASYNC)); } @Test diff --git a/src/test/java/io/reactivex/internal/observers/DeferredScalarObserverTest.java b/src/test/java/io/reactivex/internal/observers/DeferredScalarObserverTest.java index ff0dc18984..75918d345a 100644 --- a/src/test/java/io/reactivex/internal/observers/DeferredScalarObserverTest.java +++ b/src/test/java/io/reactivex/internal/observers/DeferredScalarObserverTest.java @@ -20,8 +20,7 @@ import io.reactivex.*; import io.reactivex.disposables.*; import io.reactivex.exceptions.TestException; -import io.reactivex.internal.fuseable.QueueDisposable; -import io.reactivex.internal.observers.DeferredScalarObserver; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; public class DeferredScalarObserverTest { @@ -106,7 +105,7 @@ public void dispose() { @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); TakeFirst source = new TakeFirst(to); @@ -115,7 +114,7 @@ public void fused() { source.onSubscribe(d); to.assertOf(ObserverFusion.assertFuseable()); - to.assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)); + to.assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)); source.onNext(1); source.onNext(1); @@ -129,7 +128,7 @@ public void fused() { @Test public void fusedReject() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); TakeFirst source = new TakeFirst(to); @@ -138,7 +137,7 @@ public void fusedReject() { source.onSubscribe(d); to.assertOf(ObserverFusion.assertFuseable()); - to.assertOf(ObserverFusion.assertFusionMode(QueueDisposable.NONE)); + to.assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)); source.onNext(1); source.onNext(1); @@ -168,7 +167,7 @@ public void onNext(Integer value) { @Test public void nonfusedTerminateMore() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.NONE); + TestObserver to = ObserverFusion.newTest(QueueFuseable.NONE); TakeLast source = new TakeLast(to); @@ -186,7 +185,7 @@ public void nonfusedTerminateMore() { @Test public void nonfusedError() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.NONE); + TestObserver to = ObserverFusion.newTest(QueueFuseable.NONE); TakeLast source = new TakeLast(to); @@ -204,7 +203,7 @@ public void nonfusedError() { @Test public void fusedTerminateMore() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); TakeLast source = new TakeLast(to); @@ -222,7 +221,7 @@ public void fusedTerminateMore() { @Test public void fusedError() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); TakeLast source = new TakeLast(to); @@ -240,7 +239,7 @@ public void fusedError() { @Test public void disposed() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.NONE); + TestObserver to = ObserverFusion.newTest(QueueFuseable.NONE); TakeLast source = new TakeLast(to); @@ -295,7 +294,7 @@ public void onComplete() { @Test public void fusedEmpty() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); TakeLast source = new TakeLast(to); @@ -310,7 +309,7 @@ public void fusedEmpty() { @Test public void nonfusedEmpty() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.NONE); + TestObserver to = ObserverFusion.newTest(QueueFuseable.NONE); TakeLast source = new TakeLast(to); @@ -335,7 +334,7 @@ public void customFusion() { public void onSubscribe(Disposable d) { this.d = (QueueDisposable)d; to.onSubscribe(d); - this.d.requestFusion(QueueDisposable.ANY); + this.d.requestFusion(QueueFuseable.ANY); } @Override @@ -385,7 +384,7 @@ public void customFusionClear() { public void onSubscribe(Disposable d) { this.d = (QueueDisposable)d; to.onSubscribe(d); - this.d.requestFusion(QueueDisposable.ANY); + this.d.requestFusion(QueueFuseable.ANY); } @Override @@ -414,7 +413,7 @@ public void onComplete() { @Test public void offerThrow() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.NONE); + TestObserver to = ObserverFusion.newTest(QueueFuseable.NONE); TakeLast source = new TakeLast(to); @@ -433,7 +432,7 @@ public void customFusionDontConsume() { public void onSubscribe(Disposable d) { this.d = (QueueDisposable)d; to.onSubscribe(d); - this.d.requestFusion(QueueDisposable.ANY); + this.d.requestFusion(QueueFuseable.ANY); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/completable/CompletableCacheTest.java b/src/test/java/io/reactivex/internal/operators/completable/CompletableCacheTest.java index 0a20999b98..c32ea2c9ba 100644 --- a/src/test/java/io/reactivex/internal/operators/completable/CompletableCacheTest.java +++ b/src/test/java/io/reactivex/internal/operators/completable/CompletableCacheTest.java @@ -85,50 +85,50 @@ public void error() { public void crossDispose() { PublishSubject ps = PublishSubject.create(); - final TestObserver ts1 = new TestObserver(); + final TestObserver to1 = new TestObserver(); - final TestObserver ts2 = new TestObserver() { + final TestObserver to2 = new TestObserver() { @Override public void onComplete() { super.onComplete(); - ts1.cancel(); + to1.cancel(); } }; Completable c = ps.ignoreElements().cache(); - c.subscribe(ts2); - c.subscribe(ts1); + c.subscribe(to2); + c.subscribe(to1); ps.onComplete(); - ts1.assertEmpty(); - ts2.assertResult(); + to1.assertEmpty(); + to2.assertResult(); } @Test public void crossDisposeOnError() { PublishSubject ps = PublishSubject.create(); - final TestObserver ts1 = new TestObserver(); + final TestObserver to1 = new TestObserver(); - final TestObserver ts2 = new TestObserver() { + final TestObserver to2 = new TestObserver() { @Override public void onError(Throwable ex) { super.onError(ex); - ts1.cancel(); + to1.cancel(); } }; Completable c = ps.ignoreElements().cache(); - c.subscribe(ts2); - c.subscribe(ts1); + c.subscribe(to2); + c.subscribe(to1); ps.onError(new TestException()); - ts1.assertEmpty(); - ts2.assertFailure(TestException.class); + to1.assertEmpty(); + to2.assertFailure(TestException.class); } @Test @@ -139,31 +139,31 @@ public void dispose() { assertFalse(ps.hasObservers()); - TestObserver ts1 = c.test(); + TestObserver to1 = c.test(); assertTrue(ps.hasObservers()); - ts1.cancel(); + to1.cancel(); assertTrue(ps.hasObservers()); - TestObserver ts2 = c.test(); + TestObserver to2 = c.test(); - TestObserver ts3 = c.test(); - ts3.cancel(); + TestObserver to3 = c.test(); + to3.cancel(); - TestObserver ts4 = c.test(true); - ts3.cancel(); + TestObserver to4 = c.test(true); + to3.cancel(); ps.onComplete(); - ts1.assertEmpty(); + to1.assertEmpty(); - ts2.assertResult(); + to2.assertResult(); - ts3.assertEmpty(); + to3.assertEmpty(); - ts4.assertEmpty(); + to4.assertEmpty(); } @Test @@ -173,20 +173,20 @@ public void subscribeRace() { final Completable c = ps.ignoreElements().cache(); - final TestObserver ts1 = new TestObserver(); + final TestObserver to1 = new TestObserver(); - final TestObserver ts2 = new TestObserver(); + final TestObserver to2 = new TestObserver(); Runnable r1 = new Runnable() { @Override public void run() { - c.subscribe(ts1); + c.subscribe(to1); } }; Runnable r2 = new Runnable() { @Override public void run() { - c.subscribe(ts2); + c.subscribe(to2); } }; @@ -194,8 +194,8 @@ public void run() { ps.onComplete(); - ts1.assertResult(); - ts2.assertResult(); + to1.assertResult(); + to2.assertResult(); } } @@ -206,20 +206,20 @@ public void subscribeDisposeRace() { final Completable c = ps.ignoreElements().cache(); - final TestObserver ts1 = c.test(); + final TestObserver to1 = c.test(); - final TestObserver ts2 = new TestObserver(); + final TestObserver to2 = new TestObserver(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - c.subscribe(ts2); + c.subscribe(to2); } }; @@ -227,8 +227,8 @@ public void run() { ps.onComplete(); - ts1.assertEmpty(); - ts2.assertResult(); + to1.assertEmpty(); + to2.assertResult(); } } @@ -236,31 +236,31 @@ public void run() { public void doubleDispose() { PublishSubject ps = PublishSubject.create(); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); ps.ignoreElements().cache() .subscribe(new CompletableObserver() { @Override public void onSubscribe(Disposable d) { - ts.onSubscribe(EmptyDisposable.INSTANCE); + to.onSubscribe(EmptyDisposable.INSTANCE); d.dispose(); d.dispose(); } @Override public void onComplete() { - ts.onComplete(); + to.onComplete(); } @Override public void onError(Throwable e) { - ts.onError(e); + to.onError(e); } }); ps.onComplete(); - ts.assertEmpty(); + to.assertEmpty(); } } diff --git a/src/test/java/io/reactivex/internal/operators/completable/CompletableConcatTest.java b/src/test/java/io/reactivex/internal/operators/completable/CompletableConcatTest.java index a72faf078b..218180b4a7 100644 --- a/src/test/java/io/reactivex/internal/operators/completable/CompletableConcatTest.java +++ b/src/test/java/io/reactivex/internal/operators/completable/CompletableConcatTest.java @@ -73,30 +73,30 @@ public void errorRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestObserver to = Completable.concat(ps1.map(new Function() { + TestObserver to = Completable.concat(pp1.map(new Function() { @Override public Completable apply(Integer v) throws Exception { - return ps2.ignoreElements(); + return pp2.ignoreElements(); } })).test(); - ps1.onNext(1); + pp1.onNext(1); final TestException ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex); + pp1.onError(ex); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex); + pp2.onError(ex); } }; diff --git a/src/test/java/io/reactivex/internal/operators/completable/CompletableSubscribeOnTest.java b/src/test/java/io/reactivex/internal/operators/completable/CompletableSubscribeOnTest.java index fdb64a94c5..cfbc1e6a00 100644 --- a/src/test/java/io/reactivex/internal/operators/completable/CompletableSubscribeOnTest.java +++ b/src/test/java/io/reactivex/internal/operators/completable/CompletableSubscribeOnTest.java @@ -35,13 +35,13 @@ public void normal() { try { TestScheduler scheduler = new TestScheduler(); - TestObserver ts = Completable.complete() + TestObserver to = Completable.complete() .subscribeOn(scheduler) .test(); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ts.assertResult(); + to.assertResult(); assertTrue(list.toString(), list.isEmpty()); } finally { diff --git a/src/test/java/io/reactivex/internal/operators/completable/CompletableTimerTest.java b/src/test/java/io/reactivex/internal/operators/completable/CompletableTimerTest.java index 1d611a6287..6bd5afd62b 100644 --- a/src/test/java/io/reactivex/internal/operators/completable/CompletableTimerTest.java +++ b/src/test/java/io/reactivex/internal/operators/completable/CompletableTimerTest.java @@ -38,7 +38,7 @@ public void timerInterruptible() throws Exception { try { for (Scheduler s : new Scheduler[] { Schedulers.single(), Schedulers.computation(), Schedulers.newThread(), Schedulers.io(), Schedulers.from(exec) }) { final AtomicBoolean interrupted = new AtomicBoolean(); - TestObserver ts = Completable.timer(1, TimeUnit.MILLISECONDS, s) + TestObserver to = Completable.timer(1, TimeUnit.MILLISECONDS, s) .doOnComplete(new Action() { @Override public void run() throws Exception { @@ -53,7 +53,7 @@ public void run() throws Exception { Thread.sleep(500); - ts.cancel(); + to.cancel(); Thread.sleep(500); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAllTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAllTest.java index 8f184a92ec..9f578b2d2d 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAllTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAllTest.java @@ -146,40 +146,40 @@ public Publisher apply(Boolean t1) { @Test @Ignore("No backpressure in Single") public void testBackpressureIfNoneRequestedNoneShouldBeDelivered() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Flowable.empty().all(new Predicate() { @Override public boolean test(Object t1) { return false; } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); } @Test public void testBackpressureIfOneRequestedOneShouldBeDelivered() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Flowable.empty().all(new Predicate() { @Override public boolean test(Object t) { return false; } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertTerminated(); + to.assertNoErrors(); + to.assertComplete(); - ts.assertValue(true); + to.assertValue(true); } @Test public void testPredicateThrowsExceptionAndValueInCauseMessage() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); @@ -189,12 +189,12 @@ public boolean test(String v) { throw ex; } }) - .subscribe(ts); + .subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME need to decide about adding the value that probably caused the crash in some way // assertTrue(ex.getCause().getMessage().contains("Boo!")); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAmbTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAmbTest.java index 7a1fcdf2ce..839d04e3e1 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAmbTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAmbTest.java @@ -353,20 +353,20 @@ public void testMultipleUse() { @SuppressWarnings("unchecked") @Test public void ambIterable() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); TestSubscriber ts = TestSubscriber.create(); - Flowable.amb(Arrays.asList(ps1, ps2)).subscribe(ts); + Flowable.amb(Arrays.asList(pp1, pp2)).subscribe(ts); ts.assertNoValues(); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - assertFalse(ps1.hasSubscribers()); - assertFalse(ps2.hasSubscribers()); + assertFalse(pp1.hasSubscribers()); + assertFalse(pp2.hasSubscribers()); ts.assertValue(1); ts.assertNoErrors(); @@ -376,20 +376,20 @@ public void ambIterable() { @SuppressWarnings("unchecked") @Test public void ambIterable2() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); TestSubscriber ts = TestSubscriber.create(); - Flowable.amb(Arrays.asList(ps1, ps2)).subscribe(ts); + Flowable.amb(Arrays.asList(pp1, pp2)).subscribe(ts); ts.assertNoValues(); - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); - assertFalse(ps1.hasSubscribers()); - assertFalse(ps2.hasSubscribers()); + assertFalse(pp1.hasSubscribers()); + assertFalse(pp2.hasSubscribers()); ts.assertValue(2); ts.assertNoErrors(); @@ -568,28 +568,28 @@ public void singleIterable() { @Test public void onNextRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); @SuppressWarnings("unchecked") - TestSubscriber to = Flowable.ambArray(ps1, ps2).test(); + TestSubscriber ts = Flowable.ambArray(pp1, pp2).test(); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onNext(1); + pp1.onNext(1); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onNext(1); + pp2.onNext(1); } }; TestHelper.race(r1, r2); - to.assertSubscribed().assertNoErrors() + ts.assertSubscribed().assertNoErrors() .assertNotComplete().assertValueCount(1); } } @@ -597,52 +597,52 @@ public void run() { @Test public void onCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); @SuppressWarnings("unchecked") - TestSubscriber to = Flowable.ambArray(ps1, ps2).test(); + TestSubscriber ts = Flowable.ambArray(pp1, pp2).test(); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onComplete(); + pp1.onComplete(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onComplete(); + pp2.onComplete(); } }; TestHelper.race(r1, r2); - to.assertResult(); + ts.assertResult(); } } @Test public void onErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); @SuppressWarnings("unchecked") - TestSubscriber to = Flowable.ambArray(ps1, ps2).test(); + TestSubscriber ts = Flowable.ambArray(pp1, pp2).test(); final Throwable ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex); + pp1.onError(ex); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex); + pp2.onError(ex); } }; @@ -653,7 +653,7 @@ public void run() { RxJavaPlugins.reset(); } - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAnyTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAnyTest.java index 7484568ac2..90d05f7ac1 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAnyTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAnyTest.java @@ -239,7 +239,7 @@ public Publisher apply(Boolean t1) { @Test @Ignore("Single doesn't do backpressure") public void testBackpressureIfNoneRequestedNoneShouldBeDelivered() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Flowable.just(1).any(new Predicate() { @Override @@ -247,32 +247,32 @@ public boolean test(Integer t) { return true; } }) - .subscribe(ts); + .subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); } @Test public void testBackpressureIfOneRequestedOneShouldBeDelivered() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Flowable.just(1).any(new Predicate() { @Override public boolean test(Integer v) { return true; } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertComplete(); - ts.assertValue(true); + to.assertTerminated(); + to.assertNoErrors(); + to.assertComplete(); + to.assertValue(true); } @Test public void testPredicateThrowsExceptionAndValueInCauseMessage() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); Flowable.just("Boo!").any(new Predicate() { @@ -280,12 +280,12 @@ public void testPredicateThrowsExceptionAndValueInCauseMessage() { public boolean test(String v) { throw ex; } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME value as last cause? // assertTrue(ex.getCause().getMessage().contains("Boo!")); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAutoConnectTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAutoConnectTest.java index be92d5ac56..0e70a5070e 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableAutoConnectTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableAutoConnectTest.java @@ -23,10 +23,10 @@ public class FlowableAutoConnectTest { @Test public void autoConnectImmediately() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish().autoConnect(0); + pp.publish().autoConnect(0); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableBlockingTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableBlockingTest.java index 50edb0ac6d..09c246016a 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableBlockingTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableBlockingTest.java @@ -291,12 +291,12 @@ public void blockingSingleEmpty() { @Test public void onCompleteDelayed() { - TestSubscriber to = new TestSubscriber(); + TestSubscriber ts = new TestSubscriber(); Flowable.empty().delay(100, TimeUnit.MILLISECONDS) - .blockingSubscribe(to); + .blockingSubscribe(ts); - to.assertResult(); + ts.assertResult(); } @Test @@ -306,24 +306,24 @@ public void utilityClass() { @Test public void disposeUpFront() { - TestSubscriber to = new TestSubscriber(); - to.dispose(); - Flowable.just(1).blockingSubscribe(to); + TestSubscriber ts = new TestSubscriber(); + ts.dispose(); + Flowable.just(1).blockingSubscribe(ts); - to.assertEmpty(); + ts.assertEmpty(); } @SuppressWarnings("rawtypes") @Test public void delayed() throws Exception { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); final Subscriber[] s = { null }; Schedulers.single().scheduleDirect(new Runnable() { @SuppressWarnings("unchecked") @Override public void run() { - to.dispose(); + ts.dispose(); s[0].onNext(1); } }, 200, TimeUnit.MILLISECONDS); @@ -334,13 +334,13 @@ protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); s[0] = observer; } - }.blockingSubscribe(to); + }.blockingSubscribe(ts); - while (!to.isDisposed()) { + while (!ts.isDisposed()) { Thread.sleep(100); } - to.assertEmpty(); + ts.assertEmpty(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableBufferTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableBufferTest.java index a65442a895..3a32a81c38 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableBufferTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableBufferTest.java @@ -1100,29 +1100,29 @@ public void testPostCompleteBackpressure() { @Test public void timeAndSkipOverlap() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber> ts = TestSubscriber.create(); - ps.buffer(2, 1, TimeUnit.SECONDS, scheduler).subscribe(ts); + pp.buffer(2, 1, TimeUnit.SECONDS, scheduler).subscribe(ts); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(2); + pp.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(3); + pp.onNext(3); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(4); + pp.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onComplete(); + pp.onComplete(); ts.assertValues( Arrays.asList(1, 2), @@ -1140,29 +1140,29 @@ public void timeAndSkipOverlap() { @Test public void timeAndSkipSkip() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber> ts = TestSubscriber.create(); - ps.buffer(2, 3, TimeUnit.SECONDS, scheduler).subscribe(ts); + pp.buffer(2, 3, TimeUnit.SECONDS, scheduler).subscribe(ts); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(2); + pp.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(3); + pp.onNext(3); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(4); + pp.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onComplete(); + pp.onComplete(); ts.assertValues( Arrays.asList(1, 2), @@ -1185,29 +1185,29 @@ public Scheduler apply(Scheduler t) { }); try { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber> ts = TestSubscriber.create(); - ps.buffer(2, 1, TimeUnit.SECONDS).subscribe(ts); + pp.buffer(2, 1, TimeUnit.SECONDS).subscribe(ts); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(2); + pp.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(3); + pp.onNext(3); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(4); + pp.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onComplete(); + pp.onComplete(); ts.assertValues( Arrays.asList(1, 2), @@ -1236,29 +1236,29 @@ public Scheduler apply(Scheduler t) { try { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber> ts = TestSubscriber.create(); - ps.buffer(2, 3, TimeUnit.SECONDS).subscribe(ts); + pp.buffer(2, 3, TimeUnit.SECONDS).subscribe(ts); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(2); + pp.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(3); + pp.onNext(3); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onNext(4); + pp.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ps.onComplete(); + pp.onComplete(); ts.assertValues( Arrays.asList(1, 2), @@ -1849,9 +1849,9 @@ public void bufferTimedOverlapEmpty() { public void bufferTimedExactSupplierCrash() { TestScheduler scheduler = new TestScheduler(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber> to = ps + TestSubscriber> ts = pp .buffer(1, TimeUnit.MILLISECONDS, scheduler, 1, new Callable>() { int calls; @Override @@ -1864,13 +1864,13 @@ public List call() throws Exception { }, true) .test(); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(1, TimeUnit.MILLISECONDS); - ps.onNext(2); + pp.onNext(2); - to + ts .assertFailure(TestException.class, Arrays.asList(1)); } @@ -1879,15 +1879,15 @@ public List call() throws Exception { public void bufferTimedExactBoundedError() { TestScheduler scheduler = new TestScheduler(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber> to = ps + TestSubscriber> ts = pp .buffer(1, TimeUnit.MILLISECONDS, scheduler, 1, Functions.createArrayList(16), true) .test(); - ps.onError(new TestException()); + pp.onError(new TestException()); - to + ts .assertFailure(TestException.class); } @@ -1981,19 +1981,19 @@ public void withTimeAndSizeCapacityRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final TestScheduler scheduler = new TestScheduler(); - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber> ts = ps.buffer(1, TimeUnit.SECONDS, scheduler, 5).test(); + TestSubscriber> ts = pp.buffer(1, TimeUnit.SECONDS, scheduler, 5).test(); - ps.onNext(1); - ps.onNext(2); - ps.onNext(3); - ps.onNext(4); + pp.onNext(1); + pp.onNext(2); + pp.onNext(3); + pp.onNext(4); Runnable r1 = new Runnable() { @Override public void run() { - ps.onNext(5); + pp.onNext(5); } }; @@ -2006,7 +2006,7 @@ public void run() { TestHelper.race(r1, r2); - ps.onComplete(); + pp.onComplete(); int items = 0; for (List o : ts.values()) { @@ -2456,7 +2456,7 @@ public void bufferExactBoundarySecondBufferCrash() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor b = PublishProcessor.create(); - TestSubscriber> to = pp.buffer(b, new Callable>() { + TestSubscriber> ts = pp.buffer(b, new Callable>() { int calls; @Override public List call() throws Exception { @@ -2469,7 +2469,7 @@ public List call() throws Exception { b.onNext(1); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); } @SuppressWarnings("unchecked") diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCacheTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCacheTest.java index 50b9d69d05..2524d5eb28 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCacheTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCacheTest.java @@ -316,18 +316,18 @@ public void disposeOnArrival2() { @Test public void subscribeEmitRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final Flowable cache = ps.cache(); + final Flowable cache = pp.cache(); cache.test(); - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - cache.subscribe(to); + cache.subscribe(ts); } }; @@ -335,15 +335,15 @@ public void run() { @Override public void run() { for (int j = 0; j < 500; j++) { - ps.onNext(j); + pp.onNext(j); } - ps.onComplete(); + pp.onComplete(); } }; TestHelper.race(r1, r2); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertSubscribed().assertValueCount(500).assertComplete().assertNoErrors(); } @@ -351,22 +351,22 @@ public void run() { @Test public void observers() { - PublishProcessor ps = PublishProcessor.create(); - FlowableCache cache = (FlowableCache)Flowable.range(1, 5).concatWith(ps).cache(); + PublishProcessor pp = PublishProcessor.create(); + FlowableCache cache = (FlowableCache)Flowable.range(1, 5).concatWith(pp).cache(); assertFalse(cache.hasSubscribers()); assertEquals(0, cache.cachedEventCount()); - TestSubscriber to = cache.test(); + TestSubscriber ts = cache.test(); assertTrue(cache.hasSubscribers()); assertEquals(5, cache.cachedEventCount()); - ps.onComplete(); + pp.onComplete(); - to.assertResult(1, 2, 3, 4, 5); + ts.assertResult(1, 2, 3, 4, 5); } @Test @@ -460,33 +460,33 @@ public void subscribeSubscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Flowable cache = Flowable.range(1, 500).cache(); - final TestSubscriber to1 = new TestSubscriber(); - final TestSubscriber to2 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); + final TestSubscriber ts2 = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - cache.subscribe(to1); + cache.subscribe(ts1); } }; Runnable r2 = new Runnable() { @Override public void run() { - cache.subscribe(to2); + cache.subscribe(ts2); } }; TestHelper.race(r1, r2); - to1 + ts1 .awaitDone(5, TimeUnit.SECONDS) .assertSubscribed() .assertValueCount(500) .assertComplete() .assertNoErrors(); - to2 + ts2 .awaitDone(5, TimeUnit.SECONDS) .assertSubscribed() .assertValueCount(500) @@ -498,31 +498,31 @@ public void run() { @Test public void subscribeCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final Flowable cache = ps.cache(); + final Flowable cache = pp.cache(); cache.test(); - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - cache.subscribe(to); + cache.subscribe(ts); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps.onComplete(); + pp.onComplete(); } }; TestHelper.race(r1, r2); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertResult(); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCastTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCastTest.java index 02928041fb..370f32d18a 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCastTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCastTest.java @@ -56,17 +56,17 @@ public void testCastWithWrongType() { @Test public void castCrashUnsubscribes() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = TestSubscriber.create(); - ps.cast(String.class).subscribe(ts); + pp.cast(String.class).subscribe(ts); - Assert.assertTrue("Not subscribed?", ps.hasSubscribers()); + Assert.assertTrue("Not subscribed?", pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - Assert.assertFalse("Subscribed?", ps.hasSubscribers()); + Assert.assertFalse("Subscribed?", pp.hasSubscribers()); ts.assertError(ClassCastException.class); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCombineLatestTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCombineLatestTest.java index 1abc20903f..dd95488500 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCombineLatestTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCombineLatestTest.java @@ -1242,14 +1242,14 @@ public Object apply(Object a, Object b) throws Exception { @Test public void cancelWhileSubscribing() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Flowable.combineLatest( Flowable.just(1) .doOnNext(new Consumer() { @Override public void accept(Integer v) throws Exception { - to.cancel(); + ts.cancel(); } }), Flowable.never(), @@ -1259,7 +1259,7 @@ public Object apply(Object a, Object b) throws Exception { return a; } }) - .subscribe(to); + .subscribe(ts); } @Test @@ -1267,10 +1267,10 @@ public void onErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber to = Flowable.combineLatest(ps1, ps2, new BiFunction() { + TestSubscriber ts = Flowable.combineLatest(pp1, pp2, new BiFunction() { @Override public Integer apply(Integer a, Integer b) throws Exception { return a; @@ -1283,30 +1283,30 @@ public Integer apply(Integer a, Integer b) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex1); + pp1.onError(ex1); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex2); + pp2.onError(ex2); } }; TestHelper.race(r1, r2); - if (to.errorCount() != 0) { - if (to.errors().get(0) instanceof CompositeException) { - to.assertSubscribed() + if (ts.errorCount() != 0) { + if (ts.errors().get(0) instanceof CompositeException) { + ts.assertSubscribed() .assertNotComplete() .assertNoValues(); - for (Throwable e : TestHelper.errorList(to)) { + for (Throwable e : TestHelper.errorList(ts)) { assertTrue(e.toString(), e instanceof TestException); } } else { - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableConcatMapEagerTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableConcatMapEagerTest.java index 37cd8bf3d6..90c0c59691 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableConcatMapEagerTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableConcatMapEagerTest.java @@ -859,46 +859,46 @@ public void innerOuterRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber to = ps1.concatMapEager(new Function>() { + TestSubscriber ts = pp1.concatMapEager(new Function>() { @Override public Flowable apply(Integer v) throws Exception { - return ps2; + return pp2; } }).test(); final TestException ex1 = new TestException(); final TestException ex2 = new TestException(); - ps1.onNext(1); + pp1.onNext(1); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex1); + pp1.onError(ex1); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex2); + pp2.onError(ex2); } }; TestHelper.race(r1, r2); - to.assertSubscribed().assertNoValues().assertNotComplete(); + ts.assertSubscribed().assertNoValues().assertNotComplete(); - Throwable ex = to.errors().get(0); + Throwable ex = ts.errors().get(0); if (ex instanceof CompositeException) { - List es = TestHelper.errorList(to); + List es = TestHelper.errorList(ts); TestHelper.assertError(es, 0, TestException.class); TestHelper.assertError(es, 1, TestException.class); } else { - to.assertError(TestException.class); + ts.assertError(TestException.class); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); } @@ -943,7 +943,7 @@ public void innerErrorAfterPoll() { final UnicastProcessor us = UnicastProcessor.create(); us.onNext(1); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -958,18 +958,18 @@ public Flowable apply(Integer v) throws Exception { return us; } }, 1, 128) - .subscribe(to); + .subscribe(ts); - to + ts .assertFailure(TestException.class, 1); } @Test public void nextCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); - final TestSubscriber to = ps1.concatMapEager(new Function>() { + final TestSubscriber ts = pp1.concatMapEager(new Function>() { @Override public Flowable apply(Integer v) throws Exception { return Flowable.never(); @@ -979,37 +979,37 @@ public Flowable apply(Integer v) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onNext(1); + pp1.onNext(1); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; TestHelper.race(r1, r2); - to.assertEmpty(); + ts.assertEmpty(); } } @Test public void mapperCancels() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Flowable.just(1).hide() .concatMapEager(new Function>() { @Override public Flowable apply(Integer v) throws Exception { - to.cancel(); + ts.cancel(); return Flowable.never(); } }, 1, 128) - .subscribe(to); + .subscribe(ts); - to.assertEmpty(); + ts.assertEmpty(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCreateTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCreateTest.java index de6e10417c..786dd5cb1e 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableCreateTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableCreateTest.java @@ -800,7 +800,7 @@ public void run() { @Test public void serializedConcurrentOnNextOnComplete() { for (BackpressureStrategy m : BackpressureStrategy.values()) { - TestSubscriber to = Flowable.create(new FlowableOnSubscribe() { + TestSubscriber ts = Flowable.create(new FlowableOnSubscribe() { @Override public void subscribe(FlowableEmitter e) throws Exception { final FlowableEmitter f = e.serialize(); @@ -831,7 +831,7 @@ public void run() { .assertSubscribed().assertComplete() .assertNoErrors(); - int c = to.valueCount(); + int c = ts.valueCount(); assertTrue("" + c, c >= 100); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDebounceTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDebounceTest.java index b87cd59fbf..fbd14694f0 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDebounceTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDebounceTest.java @@ -422,36 +422,36 @@ public Flowable apply(Flowable o) throws Exception { @Test public void disposeInOnNext() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); BehaviorProcessor.createDefault(1) .debounce(new Function>() { @Override public Flowable apply(Integer o) throws Exception { - to.cancel(); + ts.cancel(); return Flowable.never(); } }) - .subscribeWith(to) + .subscribeWith(ts) .assertEmpty(); - assertTrue(to.isDisposed()); + assertTrue(ts.isDisposed()); } @Test public void disposedInOnComplete() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); new Flowable() { @Override protected void subscribeActual(Subscriber subscriber) { subscriber.onSubscribe(new BooleanSubscription()); - to.cancel(); + ts.cancel(); subscriber.onComplete(); } } .debounce(Functions.justFunction(Flowable.never())) - .subscribeWith(to) + .subscribeWith(ts) .assertEmpty(); } @@ -459,7 +459,7 @@ protected void subscribeActual(Subscriber subscriber) { public void emitLate() { final AtomicReference> ref = new AtomicReference>(); - TestSubscriber to = Flowable.range(1, 2) + TestSubscriber ts = Flowable.range(1, 2) .debounce(new Function>() { @Override public Flowable apply(Integer o) throws Exception { @@ -479,7 +479,7 @@ protected void subscribeActual(Subscriber subscriber) { ref.get().onNext(1); - to + ts .assertResult(2); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java index 40e6ff58fb..d86f5f5469 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java @@ -768,17 +768,17 @@ public Integer apply(Integer t) { public void testErrorRunsBeforeOnNext() { TestScheduler test = new TestScheduler(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(); - ps.delay(1, TimeUnit.SECONDS, test).subscribe(ts); + pp.delay(1, TimeUnit.SECONDS, test).subscribe(ts); - ps.onNext(1); + pp.onNext(1); test.advanceTimeBy(500, TimeUnit.MILLISECONDS); - ps.onError(new TestException()); + pp.onError(new TestException()); test.advanceTimeBy(1, TimeUnit.SECONDS); @@ -789,7 +789,7 @@ public void testErrorRunsBeforeOnNext() { @Test public void testDelaySupplierSimple() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); Flowable source = Flowable.range(1, 5); @@ -798,7 +798,7 @@ public void testDelaySupplierSimple() { source.delaySubscription(Flowable.defer(new Callable>() { @Override public Publisher call() { - return ps; + return pp; } })).subscribe(ts); @@ -806,7 +806,7 @@ public Publisher call() { ts.assertNoErrors(); ts.assertNotComplete(); - ps.onNext(1); + pp.onNext(1); ts.assertValues(1, 2, 3, 4, 5); ts.assertComplete(); @@ -815,7 +815,7 @@ public Publisher call() { @Test public void testDelaySupplierCompletes() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); Flowable source = Flowable.range(1, 5); @@ -824,7 +824,7 @@ public void testDelaySupplierCompletes() { source.delaySubscription(Flowable.defer(new Callable>() { @Override public Publisher call() { - return ps; + return pp; } })).subscribe(ts); @@ -833,7 +833,7 @@ public Publisher call() { ts.assertNotComplete(); // FIXME should this complete the source instead of consuming it? - ps.onComplete(); + pp.onComplete(); ts.assertValues(1, 2, 3, 4, 5); ts.assertComplete(); @@ -842,7 +842,7 @@ public Publisher call() { @Test public void testDelaySupplierErrors() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); Flowable source = Flowable.range(1, 5); @@ -851,7 +851,7 @@ public void testDelaySupplierErrors() { source.delaySubscription(Flowable.defer(new Callable>() { @Override public Publisher call() { - return ps; + return pp; } })).subscribe(ts); @@ -859,7 +859,7 @@ public Publisher call() { ts.assertNoErrors(); ts.assertNotComplete(); - ps.onError(new TestException()); + pp.onError(new TestException()); ts.assertNoValues(); ts.assertNotComplete(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctTest.java index 0404682e9d..3584224000 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctTest.java @@ -143,29 +143,29 @@ public void error() { @Test public void fusedSync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 1, 2, 1, 3, 2, 4, 5, 4) .distinct() - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedAsync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor us = UnicastProcessor.create(); us .distinct() - .subscribe(to); + .subscribe(ts); TestHelper.emit(us, 1, 1, 2, 1, 3, 2, 4, 5, 4); - SubscriberFusion.assertFusion(to, QueueDisposable.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctUntilChangedTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctUntilChangedTest.java index f63ded514c..2e5e97bb67 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctUntilChangedTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDistinctUntilChangedTest.java @@ -182,9 +182,9 @@ public boolean test(Integer a, Integer b) { return a.equals(b); } }) - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 2, 4, 1, 2); } @@ -203,9 +203,9 @@ public boolean test(Integer v) { return true; } }) - .to(SubscriberFusion.test(Long.MAX_VALUE, QueueSubscription.ANY, false)) + .to(SubscriberFusion.test(Long.MAX_VALUE, QueueFuseable.ANY, false)) .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 2, 4, 1, 2); } @@ -272,7 +272,7 @@ public boolean test(String a, String b) { @Test public void fused() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 2, 2, 3, 3, 4, 5) .distinctUntilChanged(new BiPredicate() { @@ -281,17 +281,17 @@ public boolean test(Integer a, Integer b) throws Exception { return a.equals(b); } }) - .subscribe(to); + .subscribe(ts); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.SYNC)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5) ; } @Test public void fusedAsync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -302,12 +302,12 @@ public boolean test(Integer a, Integer b) throws Exception { return a.equals(b); } }) - .subscribe(to); + .subscribe(ts); TestHelper.emit(up, 1, 2, 2, 3, 3, 4, 5); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.ASYNC)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5) ; } @@ -438,7 +438,7 @@ public boolean test(Integer v) throws Exception { @Test public void conditionalFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 2, 1, 3, 3, 4, 3, 5, 5) .distinctUntilChanged() @@ -450,13 +450,13 @@ public boolean test(Integer v) throws Exception { }) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(2, 4); } @Test public void conditionalAsyncFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); up @@ -472,7 +472,7 @@ public boolean test(Integer v) throws Exception { TestHelper.emit(up, 1, 2, 1, 3, 3, 4, 3, 5, 5); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(2, 4); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNextTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNextTest.java index 78b9f05f7d..338d0b0f50 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNextTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNextTest.java @@ -23,7 +23,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.Consumer; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.processors.UnicastProcessor; import io.reactivex.subscribers.*; @@ -88,13 +88,13 @@ public void empty() { @Test public void syncFused() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5) .doAfterNext(afterNext) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts0, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -102,13 +102,13 @@ public void syncFused() { @Test public void asyncFusedRejected() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.ASYNC); Flowable.range(1, 5) .doAfterNext(afterNext) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts0, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -116,7 +116,7 @@ public void asyncFusedRejected() { @Test public void asyncFused() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.ASYNC); UnicastProcessor up = UnicastProcessor.create(); @@ -126,7 +126,7 @@ public void asyncFused() { .doAfterNext(afterNext) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts0, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -183,14 +183,14 @@ public void emptyConditional() { @Test public void syncFusedConditional() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts0, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -198,14 +198,14 @@ public void syncFusedConditional() { @Test public void asyncFusedRejectedConditional() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.ASYNC); Flowable.range(1, 5) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts0, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -213,7 +213,7 @@ public void asyncFusedRejectedConditional() { @Test public void asyncFusedConditional() { - TestSubscriber ts0 = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts0 = SubscriberFusion.newTest(QueueFuseable.ASYNC); UnicastProcessor up = UnicastProcessor.create(); @@ -224,7 +224,7 @@ public void asyncFusedConditional() { .filter(Functions.alwaysTrue()) .subscribe(ts0); - SubscriberFusion.assertFusion(ts0, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts0, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoFinallyTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoFinallyTest.java index 8a775ea310..943d92ff03 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoFinallyTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoFinallyTest.java @@ -24,7 +24,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.*; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.processors.UnicastProcessor; import io.reactivex.subscribers.*; @@ -97,13 +97,13 @@ public Publisher apply(Flowable f) throws Exception { @Test public void syncFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5) .doFinally(this) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -111,13 +111,13 @@ public void syncFused() { @Test public void syncFusedBoundary() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC | QueueSubscription.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC | QueueFuseable.BOUNDARY); Flowable.range(1, 5) .doFinally(this) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -125,7 +125,7 @@ public void syncFusedBoundary() { @Test public void asyncFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); UnicastProcessor up = UnicastProcessor.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -134,7 +134,7 @@ public void asyncFused() { .doFinally(this) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -142,7 +142,7 @@ public void asyncFused() { @Test public void asyncFusedBoundary() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ASYNC | QueueSubscription.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC | QueueFuseable.BOUNDARY); UnicastProcessor up = UnicastProcessor.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -151,7 +151,7 @@ public void asyncFusedBoundary() { .doFinally(this) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -205,14 +205,14 @@ public void normalTakeConditional() { @Test public void syncFusedConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5) .doFinally(this) .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -220,13 +220,13 @@ public void syncFusedConditional() { @Test public void nonFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5).hide() .doFinally(this) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -234,14 +234,14 @@ public void nonFused() { @Test public void nonFusedConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5).hide() .doFinally(this) .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -249,14 +249,14 @@ public void nonFusedConditional() { @Test public void syncFusedBoundaryConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC | QueueSubscription.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC | QueueFuseable.BOUNDARY); Flowable.range(1, 5) .doFinally(this) .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -264,7 +264,7 @@ public void syncFusedBoundaryConditional() { @Test public void asyncFusedConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); UnicastProcessor up = UnicastProcessor.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -274,7 +274,7 @@ public void asyncFusedConditional() { .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -282,7 +282,7 @@ public void asyncFusedConditional() { @Test public void asyncFusedBoundaryConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ASYNC | QueueSubscription.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC | QueueFuseable.BOUNDARY); UnicastProcessor up = UnicastProcessor.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -292,7 +292,7 @@ public void asyncFusedBoundaryConditional() { .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -357,7 +357,7 @@ public void onSubscribe(Subscription s) { @SuppressWarnings("unchecked") QueueSubscription qs = (QueueSubscription)s; - qs.requestFusion(QueueSubscription.ANY); + qs.requestFusion(QueueFuseable.ANY); assertFalse(qs.isEmpty()); @@ -404,7 +404,7 @@ public void onSubscribe(Subscription s) { @SuppressWarnings("unchecked") QueueSubscription qs = (QueueSubscription)s; - qs.requestFusion(QueueSubscription.ANY); + qs.requestFusion(QueueFuseable.ANY); assertFalse(qs.isEmpty()); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoOnEachTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoOnEachTest.java index d55c6be3a9..225859575e 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoOnEachTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDoOnEachTest.java @@ -504,7 +504,7 @@ public void accept(Throwable e) throws Exception { @Test public void fused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -524,7 +524,7 @@ public void run() throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -533,7 +533,7 @@ public void run() throws Exception { @Test public void fusedOnErrorCrash() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0 }; @@ -553,7 +553,7 @@ public void run() throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertFailure(TestException.class); assertEquals(0, call[0]); @@ -561,7 +561,7 @@ public void run() throws Exception { @Test public void fusedConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -582,7 +582,7 @@ public void run() throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -591,7 +591,7 @@ public void run() throws Exception { @Test public void fusedOnErrorCrashConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0 }; @@ -612,7 +612,7 @@ public void run() throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertFailure(TestException.class); assertEquals(0, call[0]); @@ -620,7 +620,7 @@ public void run() throws Exception { @Test public void fusedAsync() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -644,7 +644,7 @@ public void run() throws Exception { TestHelper.emit(up, 1, 2, 3, 4, 5); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -653,7 +653,7 @@ public void run() throws Exception { @Test public void fusedAsyncConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -678,7 +678,7 @@ public void run() throws Exception { TestHelper.emit(up, 1, 2, 3, 4, 5); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -687,7 +687,7 @@ public void run() throws Exception { @Test public void fusedAsyncConditional2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -712,7 +712,7 @@ public void run() throws Exception { TestHelper.emit(up, 1, 2, 3, 4, 5); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -736,7 +736,7 @@ public Flowable apply(Flowable o) throws Exception { @Test public void doOnNextDoOnErrorFused() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .doOnNext(new Consumer() { @Override public void accept(Integer v) throws Exception { @@ -751,8 +751,8 @@ public void accept(Throwable e) throws Exception { }) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); @@ -762,7 +762,7 @@ public void accept(Throwable e) throws Exception { @Test public void doOnNextDoOnErrorCombinedFused() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .compose(new FlowableTransformer() { @Override public Publisher apply(Flowable v) { @@ -787,8 +787,8 @@ public void accept(Throwable e) throws Exception { }) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); @@ -798,7 +798,7 @@ public void accept(Throwable e) throws Exception { @Test public void doOnNextDoOnErrorFused2() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .doOnNext(new Consumer() { @Override public void accept(Integer v) throws Exception { @@ -819,8 +819,8 @@ public void accept(Throwable e) throws Exception { }) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); @@ -831,7 +831,7 @@ public void accept(Throwable e) throws Exception { @Test public void doOnNextDoOnErrorFusedConditional() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .doOnNext(new Consumer() { @Override public void accept(Integer v) throws Exception { @@ -847,8 +847,8 @@ public void accept(Throwable e) throws Exception { .filter(Functions.alwaysTrue()) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); @@ -858,7 +858,7 @@ public void accept(Throwable e) throws Exception { @Test public void doOnNextDoOnErrorFusedConditional2() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .doOnNext(new Consumer() { @Override public void accept(Integer v) throws Exception { @@ -880,8 +880,8 @@ public void accept(Throwable e) throws Exception { .filter(Functions.alwaysTrue()) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); @@ -892,7 +892,7 @@ public void accept(Throwable e) throws Exception { @Test public void doOnNextDoOnErrorCombinedFusedConditional() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .compose(new FlowableTransformer() { @Override public Publisher apply(Flowable v) { @@ -918,8 +918,8 @@ public void accept(Throwable e) throws Exception { .filter(Functions.alwaysTrue()) .publish(); - TestSubscriber ts = co.test(); - co.connect(); + TestSubscriber ts = cf.test(); + cf.connect(); ts.assertFailure(CompositeException.class); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFilterTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFilterTest.java index bda46e6ac1..836ead8bca 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFilterTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFilterTest.java @@ -181,22 +181,22 @@ public void testFatalError() { @Test public void functionCrashUnsubscribes() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(); - ps.filter(new Predicate() { + pp.filter(new Predicate() { @Override public boolean test(Integer v) { throw new TestException(); } }).subscribe(ts); - Assert.assertTrue("Not subscribed?", ps.hasSubscribers()); + Assert.assertTrue("Not subscribed?", pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - Assert.assertFalse("Subscribed?", ps.hasSubscribers()); + Assert.assertFalse("Subscribed?", pp.hasSubscribers()); ts.assertError(TestException.class); } @@ -245,7 +245,7 @@ public void conditionalNone2() { @Test public void conditionalFusedSync() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(Functions.alwaysTrue()) @@ -253,13 +253,13 @@ public void conditionalFusedSync() { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); } @Test public void conditionalFusedSync2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(Functions.alwaysFalse()) @@ -267,13 +267,13 @@ public void conditionalFusedSync2() { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(); } @Test public void conditionalFusedAsync() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -290,13 +290,13 @@ public void conditionalFusedAsync() { up.onComplete(); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5); } @Test public void conditionalFusedNoneAsync() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -313,13 +313,13 @@ public void conditionalFusedNoneAsync() { up.onComplete(); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } @Test public void conditionalFusedNoneAsync2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -336,7 +336,7 @@ public void conditionalFusedNoneAsync2() { up.onComplete(); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } @@ -415,33 +415,33 @@ public boolean test(Integer v) throws Exception { @Test public void syncFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(Functions.alwaysTrue()) .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); } @Test public void syncNoneFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(Functions.alwaysFalse()) .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(); } @Test public void syncNoneFused2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(Functions.alwaysFalse()) @@ -449,7 +449,7 @@ public void syncNoneFused2() { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(); } @@ -563,7 +563,7 @@ public Flowable apply(Flowable o) throws Exception { @Test public void fusedSync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .filter(new Predicate() { @@ -572,15 +572,15 @@ public boolean test(Integer v) throws Exception { return v % 2 == 0; } }) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(2, 4); } @Test public void fusedAsync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor us = UnicastProcessor.create(); @@ -591,17 +591,17 @@ public boolean test(Integer v) throws Exception { return v % 2 == 0; } }) - .subscribe(to); + .subscribe(ts); TestHelper.emit(us, 1, 2, 3, 4, 5); - SubscriberFusion.assertFusion(to, QueueDisposable.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(2, 4); } @Test public void fusedReject() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY | QueueDisposable.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY | QueueFuseable.BOUNDARY); Flowable.range(1, 5) .filter(new Predicate() { @@ -610,9 +610,9 @@ public boolean test(Integer v) throws Exception { return v % 2 == 0; } }) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(2, 4); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapCompletableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapCompletableTest.java index d132f56f7b..3e7ea75c66 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapCompletableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapCompletableTest.java @@ -49,9 +49,9 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void mapperThrowsFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -60,20 +60,20 @@ public CompletableSource apply(Integer v) throws Exception { }).toFlowable() .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void mapperReturnsNullFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -82,13 +82,13 @@ public CompletableSource apply(Integer v) throws Exception { }).toFlowable() .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(NullPointerException.class); + ts.assertFailure(NullPointerException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test @@ -134,7 +134,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void normalDelayErrorAllFlowable() { - TestSubscriber to = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) + TestSubscriber ts = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -144,7 +144,7 @@ public CompletableSource apply(Integer v) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); for (int i = 0; i < 11; i++) { TestHelper.assertError(errors, i, TestException.class); @@ -153,7 +153,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void normalDelayInnerErrorAllFlowable() { - TestSubscriber to = Flowable.range(1, 10) + TestSubscriber ts = Flowable.range(1, 10) .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -163,7 +163,7 @@ public CompletableSource apply(Integer v) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); for (int i = 0; i < 10; i++) { TestHelper.assertError(errors, i, TestException.class); @@ -186,7 +186,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void fusedFlowable() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 10) .flatMapCompletable(new Function() { @@ -195,11 +195,11 @@ public CompletableSource apply(Integer v) throws Exception { return Completable.complete(); } }).toFlowable() - .subscribe(to); + .subscribe(ts); - to + ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } @@ -218,9 +218,9 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void mapperThrows() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestObserver to = ps + TestObserver to = pp .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -229,20 +229,20 @@ public CompletableSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); to.assertFailure(TestException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void mapperReturnsNull() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestObserver to = ps + TestObserver to = pp .flatMapCompletable(new Function() { @Override public CompletableSource apply(Integer v) throws Exception { @@ -251,13 +251,13 @@ public CompletableSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); to.assertFailure(NullPointerException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test @@ -341,7 +341,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void fused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 10) .flatMapCompletable(new Function() { @@ -355,7 +355,7 @@ public CompletableSource apply(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapMaybeTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapMaybeTest.java index 26762e7e4d..cee2e89628 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapMaybeTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapMaybeTest.java @@ -123,9 +123,9 @@ public MaybeSource apply(Integer v) throws Exception { @Test public void mapperThrowsFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -134,20 +134,20 @@ public MaybeSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void mapperReturnsNullFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -156,18 +156,18 @@ public MaybeSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(NullPointerException.class); + ts.assertFailure(NullPointerException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void normalDelayErrorAll() { - TestSubscriber to = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) + TestSubscriber ts = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) .flatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -177,7 +177,7 @@ public MaybeSource apply(Integer v) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); for (int i = 0; i < 11; i++) { TestHelper.assertError(errors, i, TestException.class); @@ -352,46 +352,46 @@ public MaybeSource apply(Integer v) throws Exception { @Test public void successError() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = Flowable.range(1, 2) + TestSubscriber ts = Flowable.range(1, 2) .flatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { if (v == 2) { - return ps.singleElement(); + return pp.singleElement(); } return Maybe.error(new TestException()); } }, true, Integer.MAX_VALUE) .test(); - ps.onNext(1); - ps.onComplete(); + pp.onNext(1); + pp.onComplete(); - to + ts .assertFailure(TestException.class, 1); } @Test public void completeError() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = Flowable.range(1, 2) + TestSubscriber ts = Flowable.range(1, 2) .flatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { if (v == 2) { - return ps.singleElement(); + return pp.singleElement(); } return Maybe.error(new TestException()); } }, true, Integer.MAX_VALUE) .test(); - ps.onComplete(); + pp.onComplete(); - to + ts .assertFailure(TestException.class); } @@ -451,72 +451,72 @@ protected void subscribeActual(MaybeObserver observer) { @Test public void emissionQueueTrigger() { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); } } }; - Flowable.just(ps1, ps2) + Flowable.just(pp1, pp2) .flatMapMaybe(new Function, MaybeSource>() { @Override public MaybeSource apply(PublishProcessor v) throws Exception { return v.singleElement(); } }) - .subscribe(to); + .subscribe(ts); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void emissionQueueTrigger2() { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); - final PublishProcessor ps3 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); + final PublishProcessor pp3 = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); } } }; - Flowable.just(ps1, ps2, ps3) + Flowable.just(pp1, pp2, pp3) .flatMapMaybe(new Function, MaybeSource>() { @Override public MaybeSource apply(PublishProcessor v) throws Exception { return v.singleElement(); } }) - .subscribe(to); + .subscribe(ts); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - ps3.onComplete(); + pp3.onComplete(); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void disposeInner() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Flowable.just(1).flatMapMaybe(new Function>() { @Override @@ -528,30 +528,30 @@ protected void subscribeActual(MaybeObserver observer) { assertFalse(((Disposable)observer).isDisposed()); - to.dispose(); + ts.dispose(); assertTrue(((Disposable)observer).isDisposed()); } }; } }) - .subscribe(to); + .subscribe(ts); - to + ts .assertEmpty(); } @Test public void innerSuccessCompletesAfterMain() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = Flowable.just(1).flatMapMaybe(Functions.justFunction(ps.singleElement())) + TestSubscriber ts = Flowable.just(1).flatMapMaybe(Functions.justFunction(pp.singleElement())) .test(); - ps.onNext(2); - ps.onComplete(); + pp.onNext(2); + pp.onComplete(); - to + ts .assertResult(2); } @@ -585,19 +585,19 @@ public void errorDelayed() { @Test public void requestCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestSubscriber to = Flowable.just(1).concatWith(Flowable.never()) + final TestSubscriber ts = Flowable.just(1).concatWith(Flowable.never()) .flatMapMaybe(Functions.justFunction(Maybe.just(2))).test(0); Runnable r1 = new Runnable() { @Override public void run() { - to.request(1); + ts.request(1); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapSingleTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapSingleTest.java index 14a0dfa569..78217c9330 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapSingleTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapSingleTest.java @@ -110,9 +110,9 @@ public SingleSource apply(Integer v) throws Exception { @Test public void mapperThrowsFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -121,20 +121,20 @@ public SingleSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void mapperReturnsNullFlowable() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps + TestSubscriber ts = pp .flatMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -143,18 +143,18 @@ public SingleSource apply(Integer v) throws Exception { }) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(NullPointerException.class); + ts.assertFailure(NullPointerException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void normalDelayErrorAll() { - TestSubscriber to = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) + TestSubscriber ts = Flowable.range(1, 10).concatWith(Flowable.error(new TestException())) .flatMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -164,7 +164,7 @@ public SingleSource apply(Integer v) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); for (int i = 0; i < 11; i++) { TestHelper.assertError(errors, i, TestException.class); @@ -284,24 +284,24 @@ public SingleSource apply(Integer v) throws Exception { @Test public void successError() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = Flowable.range(1, 2) + TestSubscriber ts = Flowable.range(1, 2) .flatMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { if (v == 2) { - return ps.singleOrError(); + return pp.singleOrError(); } return Single.error(new TestException()); } }, true, Integer.MAX_VALUE) .test(); - ps.onNext(1); - ps.onComplete(); + pp.onNext(1); + pp.onComplete(); - to + ts .assertFailure(TestException.class, 1); } @@ -371,38 +371,38 @@ protected void subscribeActual(SingleObserver observer) { @Test public void emissionQueueTrigger() { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); } } }; - Flowable.just(ps1, ps2) + Flowable.just(pp1, pp2) .flatMapSingle(new Function, SingleSource>() { @Override public SingleSource apply(PublishProcessor v) throws Exception { return v.singleOrError(); } }) - .subscribe(to); + .subscribe(ts); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void disposeInner() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Flowable.just(1).flatMapSingle(new Function>() { @Override @@ -414,30 +414,30 @@ protected void subscribeActual(SingleObserver observer) { assertFalse(((Disposable)observer).isDisposed()); - to.dispose(); + ts.dispose(); assertTrue(((Disposable)observer).isDisposed()); } }; } }) - .subscribe(to); + .subscribe(ts); - to + ts .assertEmpty(); } @Test public void innerSuccessCompletesAfterMain() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = Flowable.just(1).flatMapSingle(Functions.justFunction(ps.singleOrError())) + TestSubscriber ts = Flowable.just(1).flatMapSingle(Functions.justFunction(pp.singleOrError())) .test(); - ps.onNext(2); - ps.onComplete(); + pp.onNext(2); + pp.onComplete(); - to + ts .assertResult(2); } @@ -471,19 +471,19 @@ public void errorDelayed() { @Test public void requestCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestSubscriber to = Flowable.just(1).concatWith(Flowable.never()) + final TestSubscriber ts = Flowable.just(1).concatWith(Flowable.never()) .flatMapSingle(Functions.justFunction(Single.just(2))).test(0); Runnable r1 = new Runnable() { @Override public void run() { - to.request(1); + ts.request(1); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapTest.java index 9e53cbe70a..9b3037a4c2 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapTest.java @@ -656,11 +656,11 @@ public Flowable apply(Integer v) { @Test public void castCrashUnsubscribes() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = TestSubscriber.create(); - ps.flatMap(new Function>() { + pp.flatMap(new Function>() { @Override public Publisher apply(Integer t) { throw new TestException(); @@ -672,11 +672,11 @@ public Integer apply(Integer t1, Integer t2) { } }).subscribe(ts); - Assert.assertTrue("Not subscribed?", ps.hasSubscribers()); + Assert.assertTrue("Not subscribed?", pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - Assert.assertFalse("Subscribed?", ps.hasSubscribers()); + Assert.assertFalse("Subscribed?", pp.hasSubscribers()); ts.assertError(TestException.class); } @@ -780,68 +780,68 @@ public Object call() throws Exception { @Test public void scalarReentrant() { - final PublishProcessor> ps = PublishProcessor.create(); + final PublishProcessor> pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps.onNext(Flowable.just(2)); + pp.onNext(Flowable.just(2)); } } }; - Flowable.merge(ps) - .subscribe(to); + Flowable.merge(pp) + .subscribe(ts); - ps.onNext(Flowable.just(1)); - ps.onComplete(); + pp.onNext(Flowable.just(1)); + pp.onComplete(); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void scalarReentrant2() { - final PublishProcessor> ps = PublishProcessor.create(); + final PublishProcessor> pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps.onNext(Flowable.just(2)); + pp.onNext(Flowable.just(2)); } } }; - Flowable.merge(ps, 2) - .subscribe(to); + Flowable.merge(pp, 2) + .subscribe(ts); - ps.onNext(Flowable.just(1)); - ps.onComplete(); + pp.onNext(Flowable.just(1)); + pp.onComplete(); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void innerCompleteCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = Flowable.merge(Flowable.just(ps)).test(); + final TestSubscriber ts = Flowable.merge(Flowable.just(pp)).test(); Runnable r1 = new Runnable() { @Override public void run() { - ps.onComplete(); + pp.onComplete(); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; @@ -870,7 +870,7 @@ public Object apply(Integer w) throws Exception { @Test public void fusedInnerThrows2() { - TestSubscriber to = Flowable.range(1, 2).hide() + TestSubscriber ts = Flowable.range(1, 2).hide() .flatMap(new Function>() { @Override public Flowable apply(Integer v) throws Exception { @@ -885,7 +885,7 @@ public Integer apply(Integer w) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.errorList(to); + List errors = TestHelper.errorList(ts); TestHelper.assertError(errors, 0, TestException.class); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlattenIterableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlattenIterableTest.java index b4cb5b5f5f..8448e1db06 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlattenIterableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFlattenIterableTest.java @@ -26,7 +26,7 @@ import io.reactivex.exceptions.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.operators.flowable.FlowableFlattenIterable.FlattenIterableSubscriber; import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.internal.util.ExceptionHelper; @@ -395,9 +395,9 @@ public void remove() { } }; - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps + pp .concatMapIterable(new Function>() { @Override public Iterable apply(Integer v) { @@ -406,13 +406,13 @@ public Iterable apply(Integer v) { }) .subscribe(ts); - ps.onNext(1); + pp.onNext(1); ts.assertNoValues(); ts.assertError(TestException.class); ts.assertNotComplete(); - Assert.assertFalse("PublishProcessor has Subscribers?!", ps.hasSubscribers()); + Assert.assertFalse("PublishProcessor has Subscribers?!", pp.hasSubscribers()); } @Test @@ -498,9 +498,9 @@ public void remove() { } }; - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps + pp .concatMapIterable(new Function>() { @Override public Iterable apply(Integer v) { @@ -510,13 +510,13 @@ public Iterable apply(Integer v) { .take(1) .subscribe(ts); - ps.onNext(1); + pp.onNext(1); ts.assertValue(1); ts.assertNoErrors(); ts.assertComplete(); - Assert.assertFalse("PublishProcessor has Subscribers?!", ps.hasSubscribers()); + Assert.assertFalse("PublishProcessor has Subscribers?!", pp.hasSubscribers()); Assert.assertEquals(1, counter.get()); } @@ -617,7 +617,7 @@ public void onSubscribe(Subscription s) { @SuppressWarnings("unchecked") QueueSubscription qs = (QueueSubscription)s; - assertEquals(QueueSubscription.SYNC, qs.requestFusion(QueueSubscription.ANY)); + assertEquals(QueueFuseable.SYNC, qs.requestFusion(QueueFuseable.ANY)); try { assertFalse("Source reports being empty!", qs.isEmpty()); @@ -672,7 +672,7 @@ public void smallPrefetch2() { @Test public void mixedInnerSource() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 2, 3) .flatMapIterable(new Function>() { @@ -686,13 +686,13 @@ public Iterable apply(Integer v) throws Exception { }) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2, 1, 2); } @Test public void mixedInnerSource2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 2, 3) .flatMapIterable(new Function>() { @@ -706,13 +706,13 @@ public Iterable apply(Integer v) throws Exception { }) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2); } @Test public void fusionRejected() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1, 2, 3).hide() .flatMapIterable(new Function>() { @@ -723,7 +723,7 @@ public Iterable apply(Integer v) throws Exception { }) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 1, 2, 1, 2); } @@ -745,7 +745,7 @@ public void onSubscribe(Subscription s) { @SuppressWarnings("unchecked") QueueSubscription qs = (QueueSubscription)s; - assertEquals(QueueSubscription.SYNC, qs.requestFusion(QueueSubscription.ANY)); + assertEquals(QueueFuseable.SYNC, qs.requestFusion(QueueFuseable.ANY)); try { assertFalse("Source reports being empty!", qs.isEmpty()); @@ -1085,16 +1085,16 @@ public void fusionRequestedState() throws Exception { f.onSubscribe(new BooleanSubscription()); - f.fusionMode = QueueSubscription.NONE; + f.fusionMode = QueueFuseable.NONE; - assertEquals(QueueSubscription.NONE, f.requestFusion(QueueSubscription.SYNC)); + assertEquals(QueueFuseable.NONE, f.requestFusion(QueueFuseable.SYNC)); - assertEquals(QueueSubscription.NONE, f.requestFusion(QueueSubscription.ASYNC)); + assertEquals(QueueFuseable.NONE, f.requestFusion(QueueFuseable.ASYNC)); - f.fusionMode = QueueSubscription.SYNC; + f.fusionMode = QueueFuseable.SYNC; - assertEquals(QueueSubscription.SYNC, f.requestFusion(QueueSubscription.SYNC)); + assertEquals(QueueFuseable.SYNC, f.requestFusion(QueueFuseable.SYNC)); - assertEquals(QueueSubscription.NONE, f.requestFusion(QueueSubscription.ASYNC)); + assertEquals(QueueFuseable.NONE, f.requestFusion(QueueFuseable.ASYNC)); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFromIterableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFromIterableTest.java index 7a23049928..f606ee6eb4 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableFromIterableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableFromIterableTest.java @@ -551,7 +551,7 @@ public void remove() { @Test public void fusionWithConcatMap() { - TestSubscriber to = new TestSubscriber(); + TestSubscriber ts = new TestSubscriber(); Flowable.fromIterable(Arrays.asList(1, 2, 3, 4)).concatMap( new Function>() { @@ -559,11 +559,11 @@ public void fusionWithConcatMap() { public Flowable apply(Integer v) { return Flowable.range(v, 2); } - }).subscribe(to); + }).subscribe(ts); - to.assertValues(1, 2, 2, 3, 3, 4, 4, 5); - to.assertNoErrors(); - to.assertComplete(); + ts.assertValues(1, 2, 2, 3, 3, 4, 4, 5); + ts.assertNoErrors(); + ts.assertComplete(); } @Test @@ -868,12 +868,12 @@ public void run() { @Test public void fusionRejected() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); Flowable.fromIterable(Arrays.asList(1, 2, 3)) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3); } @@ -886,7 +886,7 @@ public void onSubscribe(Subscription d) { @SuppressWarnings("unchecked") QueueSubscription qd = (QueueSubscription)d; - qd.requestFusion(QueueSubscription.ANY); + qd.requestFusion(QueueFuseable.ANY); try { assertEquals(1, qd.poll().intValue()); @@ -932,7 +932,7 @@ public void hasNext2Throws() { @Test public void hasNextCancels() { - final TestSubscriber to = new TestSubscriber(); + final TestSubscriber ts = new TestSubscriber(); Flowable.fromIterable(new Iterable() { @Override @@ -943,7 +943,7 @@ public Iterator iterator() { @Override public boolean hasNext() { if (++count == 2) { - to.cancel(); + ts.cancel(); } return true; } @@ -960,9 +960,9 @@ public void remove() { }; } }) - .subscribe(to); + .subscribe(ts); - to.assertValue(1) + ts.assertValue(1) .assertNoErrors() .assertNotComplete(); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupByTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupByTest.java index e5a18c80af..3e6dcca7ac 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupByTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupByTest.java @@ -22,24 +22,22 @@ import java.util.concurrent.*; import java.util.concurrent.atomic.*; -import io.reactivex.subjects.PublishSubject; import org.junit.Test; import org.mockito.Mockito; import org.reactivestreams.*; -import com.google.common.cache.CacheBuilder; -import com.google.common.cache.RemovalListener; -import com.google.common.cache.RemovalNotification; +import com.google.common.cache.*; import io.reactivex.*; import io.reactivex.exceptions.TestException; import io.reactivex.flowables.GroupedFlowable; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.processors.PublishProcessor; import io.reactivex.schedulers.Schedulers; +import io.reactivex.subjects.PublishSubject; import io.reactivex.subscribers.*; public class FlowableGroupByTest { @@ -1604,9 +1602,9 @@ public void accept(GroupedFlowable g) { @Test public void outerInnerFusion() { - final TestSubscriber ts1 = SubscriberFusion.newTest(QueueSubscription.ANY); + final TestSubscriber ts1 = SubscriberFusion.newTest(QueueFuseable.ANY); - final TestSubscriber> ts2 = SubscriberFusion.newTest(QueueSubscription.ANY); + final TestSubscriber> ts2 = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 10).groupBy(new Function() { @Override @@ -1628,13 +1626,13 @@ public void accept(GroupedFlowable g) { .subscribe(ts2); ts1 - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertValues(2, 3, 4, 5, 6, 7, 8, 9, 10, 11) .assertNoErrors() .assertComplete(); ts2 - .assertOf(SubscriberFusion.>assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.>assertFusionMode(QueueFuseable.ASYNC)) .assertValueCount(1) .assertNoErrors() .assertComplete(); @@ -1686,47 +1684,47 @@ public void accept(GroupedFlowable g) throws Exception { @Test public void reentrantComplete() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps.onComplete(); + pp.onComplete(); } } }; - Flowable.merge(ps.groupBy(Functions.justFunction(1))) - .subscribe(to); + Flowable.merge(pp.groupBy(Functions.justFunction(1))) + .subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertResult(1); + ts.assertResult(1); } @Test public void reentrantCompleteCancel() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); if (t == 1) { - ps.onComplete(); + pp.onComplete(); dispose(); } } }; - Flowable.merge(ps.groupBy(Functions.justFunction(1))) - .subscribe(to); + Flowable.merge(pp.groupBy(Functions.justFunction(1))) + .subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertSubscribed().assertValue(1).assertNoErrors().assertNotComplete(); + ts.assertSubscribed().assertValue(1).assertNoErrors().assertNotComplete(); } @Test @@ -1740,13 +1738,13 @@ public void delayErrorSimpleComplete() { @Test public void mainFusionRejected() { - TestSubscriber> ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber> ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.just(1) .groupBy(Functions.justFunction(1)) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertValueCount(1) .assertComplete() .assertNoErrors(); @@ -1799,25 +1797,25 @@ public Publisher apply(GroupedFlowable g) throws Excep @Test public void errorFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.error(new TestException()) .groupBy(Functions.justFunction(1)) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertFailure(TestException.class); } @Test public void errorFusedDelayed() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.error(new TestException()) .groupBy(Functions.justFunction(1), true) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertFailure(TestException.class); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupJoinTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupJoinTest.java index 9bc958c730..0d27bc2280 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupJoinTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableGroupJoinTest.java @@ -508,25 +508,25 @@ public Flowable apply(Integer r, Flowable l) throws Exception @Test public void innerErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); List errors = TestHelper.trackPluginErrors(); try { - TestSubscriber> to = Flowable.just(1) + TestSubscriber> ts = Flowable.just(1) .groupJoin( Flowable.just(2).concatWith(Flowable.never()), new Function>() { @Override public Flowable apply(Integer left) throws Exception { - return ps1; + return pp1; } }, new Function>() { @Override public Flowable apply(Integer right) throws Exception { - return ps2; + return pp2; } }, new BiFunction, Flowable>() { @@ -544,28 +544,28 @@ public Flowable apply(Integer r, Flowable l) throws Exception Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex1); + pp1.onError(ex1); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex2); + pp2.onError(ex2); } }; TestHelper.race(r1, r2); - to.assertError(Throwable.class).assertSubscribed().assertNotComplete().assertValueCount(1); + ts.assertError(Throwable.class).assertSubscribed().assertNotComplete().assertValueCount(1); - Throwable exc = to.errors().get(0); + Throwable exc = ts.errors().get(0); if (exc instanceof CompositeException) { List es = TestHelper.compositeList(exc); TestHelper.assertError(es, 0, TestException.class); TestHelper.assertError(es, 1, TestException.class); } else { - to.assertError(TestException.class); + ts.assertError(TestException.class); } if (!errors.isEmpty()) { @@ -580,15 +580,15 @@ public void run() { @Test public void outerErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); List errors = TestHelper.trackPluginErrors(); try { - TestSubscriber to = ps1 + TestSubscriber ts = pp1 .groupJoin( - ps2, + pp2, new Function>() { @Override public Flowable apply(Object left) throws Exception { @@ -617,28 +617,28 @@ public Flowable apply(Object r, Flowable l) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex1); + pp1.onError(ex1); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex2); + pp2.onError(ex2); } }; TestHelper.race(r1, r2); - to.assertError(Throwable.class).assertSubscribed().assertNotComplete().assertNoValues(); + ts.assertError(Throwable.class).assertSubscribed().assertNotComplete().assertNoValues(); - Throwable exc = to.errors().get(0); + Throwable exc = ts.errors().get(0); if (exc instanceof CompositeException) { List es = TestHelper.compositeList(exc); TestHelper.assertError(es, 0, TestException.class); TestHelper.assertError(es, 1, TestException.class); } else { - to.assertError(TestException.class); + ts.assertError(TestException.class); } if (!errors.isEmpty()) { @@ -652,12 +652,12 @@ public void run() { @Test public void rightEmission() { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber to = ps1 + TestSubscriber ts = pp1 .groupJoin( - ps2, + pp2, new Function>() { @Override public Flowable apply(Object left) throws Exception { @@ -680,14 +680,14 @@ public Flowable apply(Object r, Flowable l) throws Exception { .flatMap(Functions.>identity()) .test(); - ps2.onNext(2); + pp2.onNext(2); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - ps2.onComplete(); + pp2.onComplete(); - to.assertResult(2); + ts.assertResult(2); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableIgnoreElementsTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableIgnoreElementsTest.java index 4c07e86ffb..6d2d42aeaf 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableIgnoreElementsTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableIgnoreElementsTest.java @@ -18,12 +18,12 @@ import java.util.concurrent.atomic.*; import org.junit.Test; -import org.reactivestreams.*; +import org.reactivestreams.Subscription; import io.reactivex.*; import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.processors.PublishProcessor; import io.reactivex.subscribers.*; @@ -174,22 +174,22 @@ public void accept(Integer t) { @Test public void testCompletedOk() { - TestObserver ts = new TestObserver(); - Flowable.range(1, 10).ignoreElements().subscribe(ts); - ts.assertNoErrors(); - ts.assertNoValues(); - ts.assertTerminated(); + TestObserver to = new TestObserver(); + Flowable.range(1, 10).ignoreElements().subscribe(to); + to.assertNoErrors(); + to.assertNoValues(); + to.assertTerminated(); } @Test public void testErrorReceived() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); TestException ex = new TestException("boo"); - Flowable.error(ex).ignoreElements().subscribe(ts); - ts.assertNoValues(); - ts.assertTerminated(); - ts.assertError(TestException.class); - ts.assertErrorMessage("boo"); + Flowable.error(ex).ignoreElements().subscribe(to); + to.assertNoValues(); + to.assertTerminated(); + to.assertError(TestException.class); + to.assertErrorMessage("boo"); } @Test @@ -252,13 +252,13 @@ public void cancel() { @Test public void fused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.just(1).hide().ignoreElements().toFlowable() .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableJoinTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableJoinTest.java index a1512f577b..a44b07608f 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableJoinTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableJoinTest.java @@ -339,9 +339,9 @@ public Integer apply(Integer a, Integer b) throws Exception { @Test public void rightClose() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps.join(Flowable.just(2), + TestSubscriber ts = pp.join(Flowable.just(2), Functions.justFunction(Flowable.never()), Functions.justFunction(Flowable.empty()), new BiFunction() { @@ -353,16 +353,16 @@ public Integer apply(Integer a, Integer b) throws Exception { .test() .assertEmpty(); - ps.onNext(1); + pp.onNext(1); - to.assertEmpty(); + ts.assertEmpty(); } @Test public void resultSelectorThrows2() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps.join( + TestSubscriber ts = pp.join( Flowable.just(2), Functions.justFunction(Flowable.never()), Functions.justFunction(Flowable.never()), @@ -374,10 +374,10 @@ public Integer apply(Integer a, Integer b) throws Exception { }) .test(); - ps.onNext(1); - ps.onComplete(); + pp.onNext(1); + pp.onComplete(); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); } @Test @@ -417,7 +417,7 @@ public void badEndSource() { @SuppressWarnings("rawtypes") final Subscriber[] o = { null }; - TestSubscriber to = Flowable.just(1) + TestSubscriber ts = Flowable.just(1) .join(Flowable.just(2), Functions.justFunction(Flowable.never()), Functions.justFunction(new Flowable() { @@ -438,7 +438,7 @@ public Integer apply(Integer a, Integer b) throws Exception { o[0].onError(new TestException("Second")); - to + ts .assertFailureAndMessage(TestException.class, "First"); TestHelper.assertUndeliverable(errors, 0, TestException.class, "Second"); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapNotificationTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapNotificationTest.java index 287b83fb59..245fb9b581 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapNotificationTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapNotificationTest.java @@ -104,9 +104,9 @@ public Integer call() { public void noBackpressure() { TestSubscriber ts = TestSubscriber.create(0L); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - new FlowableMapNotification(ps, + new FlowableMapNotification(pp, new Function() { @Override public Integer apply(Integer item) { @@ -131,10 +131,10 @@ public Integer call() { ts.assertNoErrors(); ts.assertNotComplete(); - ps.onNext(1); - ps.onNext(2); - ps.onNext(3); - ps.onComplete(); + pp.onNext(1); + pp.onNext(2); + pp.onNext(3); + pp.onComplete(); ts.assertNoValues(); ts.assertNoErrors(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapTest.java index e74f5bc961..20022bf843 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMapTest.java @@ -339,22 +339,22 @@ public void verifyExceptionIsThrownIfThereIsNoExceptionHandler() { @Test public void functionCrashUnsubscribes() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(); - ps.map(new Function() { + pp.map(new Function() { @Override public Integer apply(Integer v) { throw new TestException(); } }).subscribe(ts); - Assert.assertTrue("Not subscribed?", ps.hasSubscribers()); + Assert.assertTrue("Not subscribed?", pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - Assert.assertFalse("Subscribed?", ps.hasSubscribers()); + Assert.assertFalse("Subscribed?", pp.hasSubscribers()); ts.assertError(TestException.class); } @@ -418,7 +418,7 @@ public boolean test(Integer v) throws Exception { @Test public void mapFilterFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 2) .map(new Function() { @@ -436,13 +436,13 @@ public boolean test(Integer v) throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(2, 3); } @Test public void mapFilterFusedHidden() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 2).hide() .map(new Function() { @@ -460,7 +460,7 @@ public boolean test(Integer v) throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(2, 3); } @@ -496,7 +496,7 @@ public Object apply(Integer v) throws Exception { @Test public void mapFilterMapperCrashFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 2).hide() .map(new Function() { @@ -514,7 +514,7 @@ public boolean test(Integer v) throws Exception { .subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertFailure(TestException.class); } @@ -556,7 +556,7 @@ public boolean test(Integer v) throws Exception { @Test public void mapFilterFused2() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -580,7 +580,7 @@ public boolean test(Integer v) throws Exception { up.onComplete(); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(2, 3); } @@ -638,41 +638,41 @@ public Flowable apply(Flowable o) throws Exception { @Test public void fusedSync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .map(Functions.identity()) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedAsync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor us = UnicastProcessor.create(); us .map(Functions.identity()) - .subscribe(to); + .subscribe(ts); TestHelper.emit(us, 1, 2, 3, 4, 5); - SubscriberFusion.assertFusion(to, QueueDisposable.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedReject() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY | QueueDisposable.BOUNDARY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY | QueueFuseable.BOUNDARY); Flowable.range(1, 5) .map(Functions.identity()) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeDelayErrorTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeDelayErrorTest.java index fd4a8a9a21..d9be86f909 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeDelayErrorTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeDelayErrorTest.java @@ -604,22 +604,22 @@ public void mergeIterable() { public void iterableMaxConcurrent() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Flowable.mergeDelayError(Arrays.asList(ps1, ps2), 1).subscribe(ts); + Flowable.mergeDelayError(Arrays.asList(pp1, pp2), 1).subscribe(ts); - assertTrue("ps1 has no subscribers?!", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?!", ps2.hasSubscribers()); + assertTrue("ps1 has no subscribers?!", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?!", pp2.hasSubscribers()); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - assertFalse("ps1 has subscribers?!", ps1.hasSubscribers()); - assertTrue("ps2 has no subscribers?!", ps2.hasSubscribers()); + assertFalse("ps1 has subscribers?!", pp1.hasSubscribers()); + assertTrue("ps2 has no subscribers?!", pp2.hasSubscribers()); - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); ts.assertValues(1, 2); ts.assertNoErrors(); @@ -631,22 +631,22 @@ public void iterableMaxConcurrent() { public void iterableMaxConcurrentError() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Flowable.mergeDelayError(Arrays.asList(ps1, ps2), 1).subscribe(ts); + Flowable.mergeDelayError(Arrays.asList(pp1, pp2), 1).subscribe(ts); - assertTrue("ps1 has no subscribers?!", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?!", ps2.hasSubscribers()); + assertTrue("ps1 has no subscribers?!", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?!", pp2.hasSubscribers()); - ps1.onNext(1); - ps1.onError(new TestException()); + pp1.onNext(1); + pp1.onError(new TestException()); - assertFalse("ps1 has subscribers?!", ps1.hasSubscribers()); - assertTrue("ps2 has no subscribers?!", ps2.hasSubscribers()); + assertFalse("ps1 has subscribers?!", pp1.hasSubscribers()); + assertTrue("ps2 has no subscribers?!", pp2.hasSubscribers()); - ps2.onNext(2); - ps2.onError(new TestException()); + pp2.onNext(2); + pp2.onError(new TestException()); ts.assertValues(1, 2); ts.assertError(CompositeException.class); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeTest.java index e4e68f3922..085b9d1720 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableMergeTest.java @@ -1494,22 +1494,22 @@ public void mergeMany() throws Exception { public void mergeArrayMaxConcurrent() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); - Flowable.mergeArray(1, 128, new Flowable[] { ps1, ps2 }).subscribe(ts); + Flowable.mergeArray(1, 128, new Flowable[] { pp1, pp2 }).subscribe(ts); - assertTrue("ps1 has no subscribers?!", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?!", ps2.hasSubscribers()); + assertTrue("ps1 has no subscribers?!", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?!", pp2.hasSubscribers()); - ps1.onNext(1); - ps1.onComplete(); + pp1.onNext(1); + pp1.onComplete(); - assertFalse("ps1 has subscribers?!", ps1.hasSubscribers()); - assertTrue("ps2 has no subscribers?!", ps2.hasSubscribers()); + assertFalse("ps1 has subscribers?!", pp1.hasSubscribers()); + assertTrue("ps2 has no subscribers?!", pp2.hasSubscribers()); - ps2.onNext(2); - ps2.onComplete(); + pp2.onNext(2); + pp2.onComplete(); ts.assertValues(1, 2); ts.assertNoErrors(); @@ -1571,15 +1571,15 @@ public void noInnerReordering() { new FlowableFlatMap.MergeSubscriber, Integer>(ts, Functions.>identity(), false, 128, 128); ms.onSubscribe(new BooleanSubscription()); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ms.onNext(ps); + ms.onNext(pp); - ps.onNext(1); + pp.onNext(1); BackpressureHelper.add(ms.requested, 2); - ps.onNext(2); + pp.onNext(2); ms.drain(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableObserveOnTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableObserveOnTest.java index dab9f09e72..3344a30a65 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableObserveOnTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableObserveOnTest.java @@ -1006,7 +1006,7 @@ public void cancelCleanup() { @Test public void conditionalConsumerFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .observeOn(Schedulers.single()) @@ -1020,14 +1020,14 @@ public boolean test(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .awaitDone(5, TimeUnit.SECONDS) .assertResult(2, 4); } @Test public void conditionalConsumerFusedReject() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5) .observeOn(Schedulers.single()) @@ -1041,7 +1041,7 @@ public boolean test(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .awaitDone(5, TimeUnit.SECONDS) .assertResult(2, 4); } @@ -1071,7 +1071,7 @@ public void requestOneConditional() throws Exception { @Test public void conditionalConsumerFusedAsync() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -1094,14 +1094,14 @@ public boolean test(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .awaitDone(5, TimeUnit.SECONDS) .assertResult(2, 4); } @Test public void conditionalConsumerHidden() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5).hide() .observeOn(Schedulers.single()) @@ -1115,14 +1115,14 @@ public boolean test(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .awaitDone(5, TimeUnit.SECONDS) .assertResult(2, 4); } @Test public void conditionalConsumerBarrier() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5) .map(Functions.identity()) @@ -1137,7 +1137,7 @@ public boolean test(Integer v) throws Exception { ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .awaitDone(5, TimeUnit.SECONDS) .assertResult(2, 4); } @@ -1162,7 +1162,7 @@ public void badSource() { List errors = TestHelper.trackPluginErrors(); try { TestScheduler scheduler = new TestScheduler(); - TestSubscriber to = new Flowable() { + TestSubscriber ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1177,7 +1177,7 @@ protected void subscribeActual(Subscriber observer) { scheduler.triggerActions(); - to.assertResult(); + ts.assertResult(); TestHelper.assertUndeliverable(errors, 0, TestException.class); } finally { @@ -1198,11 +1198,11 @@ public void inputSyncFused() { public void inputAsyncFused() { UnicastProcessor us = UnicastProcessor.create(); - TestSubscriber to = us.observeOn(Schedulers.single()).test(); + TestSubscriber ts = us.observeOn(Schedulers.single()).test(); TestHelper.emit(us, 1, 2, 3, 4, 5); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertResult(1, 2, 3, 4, 5); } @@ -1211,11 +1211,11 @@ public void inputAsyncFused() { public void inputAsyncFusedError() { UnicastProcessor us = UnicastProcessor.create(); - TestSubscriber to = us.observeOn(Schedulers.single()).test(); + TestSubscriber ts = us.observeOn(Schedulers.single()).test(); us.onError(new TestException()); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @@ -1224,77 +1224,77 @@ public void inputAsyncFusedError() { public void inputAsyncFusedErrorDelayed() { UnicastProcessor us = UnicastProcessor.create(); - TestSubscriber to = us.observeOn(Schedulers.single(), true).test(); + TestSubscriber ts = us.observeOn(Schedulers.single(), true).test(); us.onError(new TestException()); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @Test public void outputFused() { - TestSubscriber to = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 5).hide() .observeOn(Schedulers.single()) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertResult(1, 2, 3, 4, 5); } @Test public void outputFusedReject() { - TestSubscriber to = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.range(1, 5).hide() .observeOn(Schedulers.single()) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .awaitDone(5, TimeUnit.SECONDS) .assertResult(1, 2, 3, 4, 5); } @Test public void inputOutputAsyncFusedError() { - TestSubscriber to = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor us = UnicastProcessor.create(); us.observeOn(Schedulers.single()) - .subscribe(to); + .subscribe(ts); us.onError(new TestException()); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); - SubscriberFusion.assertFusion(to, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @Test public void inputOutputAsyncFusedErrorDelayed() { - TestSubscriber to = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); UnicastProcessor us = UnicastProcessor.create(); us.observeOn(Schedulers.single(), true) - .subscribe(to); + .subscribe(ts); us.onError(new TestException()); - to + ts .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); - SubscriberFusion.assertFusion(to, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @@ -1312,7 +1312,7 @@ public void outputFusedCancelReentrant() throws Exception { @Override public void onSubscribe(Subscription d) { this.d = d; - ((QueueSubscription)d).requestFusion(QueueSubscription.ANY); + ((QueueSubscription)d).requestFusion(QueueFuseable.ANY); } @Override @@ -1712,14 +1712,14 @@ public void request1Conditional() { @Test public void backFusedConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 100).hide() .observeOn(ImmediateThinScheduler.INSTANCE) .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertValueCount(100) .assertComplete() .assertNoErrors(); @@ -1727,21 +1727,21 @@ public void backFusedConditional() { @Test public void backFusedErrorConditional() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.error(new TestException()) .observeOn(ImmediateThinScheduler.INSTANCE) .filter(Functions.alwaysTrue()) .subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC) .assertFailure(TestException.class); } @Test public void backFusedCancelConditional() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + final TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); final TestScheduler scheduler = new TestScheduler(); @@ -1766,7 +1766,7 @@ public void run() { TestHelper.race(r1, r2); - SubscriberFusion.assertFusion(ts, QueueSubscription.ASYNC); + SubscriberFusion.assertFusion(ts, QueueFuseable.ASYNC); if (ts.valueCount() != 0) { ts.assertResult(1); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnBackpressureBufferTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnBackpressureBufferTest.java index 672b94cb1b..84793d3136 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnBackpressureBufferTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnBackpressureBufferTest.java @@ -24,7 +24,7 @@ import io.reactivex.Flowable; import io.reactivex.exceptions.*; import io.reactivex.functions.*; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.schedulers.Schedulers; import io.reactivex.subscribers.*; @@ -249,23 +249,23 @@ public void delayErrorBuffer() { @Test public void fusedNormal() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.range(1, 10).onBackpressureBuffer().subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); } @Test public void fusedError() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Flowable.error(new TestException()).onBackpressureBuffer().subscribe(ts); ts.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertFailure(TestException.class); } @@ -300,11 +300,11 @@ public void emptyDelayError() { @Test public void fusionRejected() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Flowable.never().onBackpressureBuffer().subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertEmpty(); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java index aeae4de368..86c12e3304 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java @@ -222,15 +222,15 @@ public Integer apply(Integer t1) { public void normalBackpressure() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.onErrorResumeNext(Flowable.range(3, 2)).subscribe(ts); + pp.onErrorResumeNext(Flowable.range(3, 2)).subscribe(ts); ts.request(2); - ps.onNext(1); - ps.onNext(2); - ps.onError(new TestException("Forced failure")); + pp.onNext(1); + pp.onNext(2); + pp.onError(new TestException("Forced failure")); ts.assertValues(1, 2); ts.assertNoErrors(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFunctionTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFunctionTest.java index 68f7737943..8d55d06f96 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFunctionTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFunctionTest.java @@ -352,9 +352,9 @@ public Integer apply(Integer t1) { public void normalBackpressure() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.onErrorResumeNext(new Function>() { + pp.onErrorResumeNext(new Function>() { @Override public Flowable apply(Throwable v) { return Flowable.range(3, 2); @@ -363,9 +363,9 @@ public Flowable apply(Throwable v) { ts.request(2); - ps.onNext(1); - ps.onNext(2); - ps.onError(new TestException("Forced failure")); + pp.onNext(1); + pp.onNext(2); + pp.onError(new TestException("Forced failure")); ts.assertValues(1, 2); ts.assertNoErrors(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorReturnTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorReturnTest.java index 676318f7fe..a22c4055e2 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorReturnTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorReturnTest.java @@ -218,9 +218,9 @@ public void run() { public void normalBackpressure() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.onErrorReturn(new Function() { + pp.onErrorReturn(new Function() { @Override public Integer apply(Throwable e) { return 3; @@ -229,9 +229,9 @@ public Integer apply(Throwable e) { ts.request(2); - ps.onNext(1); - ps.onNext(2); - ps.onError(new TestException("Forced failure")); + pp.onNext(1); + pp.onNext(2); + pp.onError(new TestException("Forced failure")); ts.assertValues(1, 2); ts.assertNoErrors(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnExceptionResumeNextViaFlowableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnExceptionResumeNextViaFlowableTest.java index 102c564024..6c6b8c9962 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnExceptionResumeNextViaFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnExceptionResumeNextViaFlowableTest.java @@ -267,15 +267,15 @@ public void run() { public void normalBackpressure() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.onExceptionResumeNext(Flowable.range(3, 2)).subscribe(ts); + pp.onExceptionResumeNext(Flowable.range(3, 2)).subscribe(ts); ts.request(2); - ps.onNext(1); - ps.onNext(2); - ps.onError(new TestException("Forced failure")); + pp.onNext(1); + pp.onNext(2); + pp.onError(new TestException("Forced failure")); ts.assertValues(1, 2); ts.assertNoErrors(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java index c05899bdc3..8dfb7584aa 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java @@ -84,17 +84,17 @@ public Flowable apply(Flowable o) { public void canBeCancelled() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return Flowable.concat(o.take(5), o.takeLast(5)); } }).subscribe(ts); - ps.onNext(1); - ps.onNext(2); + pp.onNext(1); + pp.onNext(2); ts.assertValues(1, 2); ts.assertNoErrors(); @@ -102,7 +102,7 @@ public Flowable apply(Flowable o) { ts.cancel(); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @Test @@ -120,22 +120,22 @@ public void invalidPrefetch() { public void takeCompletes() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o.take(1); } }).subscribe(ts); - ps.onNext(1); + pp.onNext(1); ts.assertValues(1); ts.assertNoErrors(); ts.assertComplete(); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @@ -151,9 +151,9 @@ public void onStart() { } }; - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o.take(1); @@ -167,54 +167,54 @@ public Flowable apply(Flowable o) { public void takeCompletesUnsafe() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o.take(1); } }).subscribe(ts); - ps.onNext(1); + pp.onNext(1); ts.assertValues(1); ts.assertNoErrors(); ts.assertComplete(); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @Test public void directCompletesUnsafe() { TestSubscriber ts = TestSubscriber.create(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o; } }).subscribe(ts); - ps.onNext(1); - ps.onComplete(); + pp.onNext(1); + pp.onComplete(); ts.assertValues(1); ts.assertNoErrors(); ts.assertComplete(); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @Test public void overflowMissingBackpressureException() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o; @@ -222,7 +222,7 @@ public Flowable apply(Flowable o) { }).subscribe(ts); for (int i = 0; i < Flowable.bufferSize() * 2; i++) { - ps.onNext(i); + pp.onNext(i); } ts.assertNoValues(); @@ -231,16 +231,16 @@ public Flowable apply(Flowable o) { Assert.assertEquals("Could not emit value due to lack of requests", ts.errors().get(0).getMessage()); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @Test public void overflowMissingBackpressureExceptionDelayed() { TestSubscriber ts = TestSubscriber.create(0); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - new FlowablePublishMulticast(ps, new Function, Flowable>() { + new FlowablePublishMulticast(pp, new Function, Flowable>() { @Override public Flowable apply(Flowable o) { return o; @@ -248,7 +248,7 @@ public Flowable apply(Flowable o) { }, Flowable.bufferSize(), true).subscribe(ts); for (int i = 0; i < Flowable.bufferSize() * 2; i++) { - ps.onNext(i); + pp.onNext(i); } ts.request(Flowable.bufferSize()); @@ -258,7 +258,7 @@ public Flowable apply(Flowable o) { ts.assertNotComplete(); Assert.assertEquals("Could not emit value due to lack of requests", ts.errors().get(0).getMessage()); - Assert.assertFalse("Source has subscribers?", ps.hasSubscribers()); + Assert.assertFalse("Source has subscribers?", pp.hasSubscribers()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishTest.java index 866e8de378..4c65265cb1 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishTest.java @@ -254,12 +254,12 @@ public void run() { @Test public void testConnectWithNoSubscriber() { TestScheduler scheduler = new TestScheduler(); - ConnectableFlowable co = Flowable.interval(10, 10, TimeUnit.MILLISECONDS, scheduler).take(3).publish(); - co.connect(); + ConnectableFlowable cf = Flowable.interval(10, 10, TimeUnit.MILLISECONDS, scheduler).take(3).publish(); + cf.connect(); // Emit 0 scheduler.advanceTimeBy(15, TimeUnit.MILLISECONDS); TestSubscriber subscriber = new TestSubscriber(); - co.subscribe(subscriber); + cf.subscribe(subscriber); // Emit 1 and 2 scheduler.advanceTimeBy(50, TimeUnit.MILLISECONDS); subscriber.assertValues(1L, 2L); @@ -401,8 +401,8 @@ public void subscribe(Subscriber t) { @Test public void syncFusedObserveOn() { - ConnectableFlowable co = Flowable.range(0, 1000).publish(); - Flowable obs = co.observeOn(Schedulers.computation()); + ConnectableFlowable cf = Flowable.range(0, 1000).publish(); + Flowable obs = cf.observeOn(Schedulers.computation()); for (int i = 0; i < 1000; i++) { for (int j = 1; j < 6; j++) { List> tss = new ArrayList>(); @@ -412,7 +412,7 @@ public void syncFusedObserveOn() { obs.subscribe(ts); } - Disposable s = co.connect(); + Disposable s = cf.connect(); for (TestSubscriber ts : tss) { ts.awaitDone(5, TimeUnit.SECONDS) @@ -428,8 +428,8 @@ public void syncFusedObserveOn() { @Test public void syncFusedObserveOn2() { - ConnectableFlowable co = Flowable.range(0, 1000).publish(); - Flowable obs = co.observeOn(ImmediateThinScheduler.INSTANCE); + ConnectableFlowable cf = Flowable.range(0, 1000).publish(); + Flowable obs = cf.observeOn(ImmediateThinScheduler.INSTANCE); for (int i = 0; i < 1000; i++) { for (int j = 1; j < 6; j++) { List> tss = new ArrayList>(); @@ -439,7 +439,7 @@ public void syncFusedObserveOn2() { obs.subscribe(ts); } - Disposable s = co.connect(); + Disposable s = cf.connect(); for (TestSubscriber ts : tss) { ts.awaitDone(5, TimeUnit.SECONDS) @@ -455,17 +455,17 @@ public void syncFusedObserveOn2() { @Test public void asyncFusedObserveOn() { - ConnectableFlowable co = Flowable.range(0, 1000).observeOn(ImmediateThinScheduler.INSTANCE).publish(); + ConnectableFlowable cf = Flowable.range(0, 1000).observeOn(ImmediateThinScheduler.INSTANCE).publish(); for (int i = 0; i < 1000; i++) { for (int j = 1; j < 6; j++) { List> tss = new ArrayList>(); for (int k = 1; k < j; k++) { TestSubscriber ts = new TestSubscriber(); tss.add(ts); - co.subscribe(ts); + cf.subscribe(ts); } - Disposable s = co.connect(); + Disposable s = cf.connect(); for (TestSubscriber ts : tss) { ts.awaitDone(5, TimeUnit.SECONDS) @@ -481,8 +481,8 @@ public void asyncFusedObserveOn() { @Test public void testObserveOn() { - ConnectableFlowable co = Flowable.range(0, 1000).hide().publish(); - Flowable obs = co.observeOn(Schedulers.computation()); + ConnectableFlowable cf = Flowable.range(0, 1000).hide().publish(); + Flowable obs = cf.observeOn(Schedulers.computation()); for (int i = 0; i < 1000; i++) { for (int j = 1; j < 6; j++) { List> tss = new ArrayList>(); @@ -492,7 +492,7 @@ public void testObserveOn() { obs.subscribe(ts); } - Disposable s = co.connect(); + Disposable s = cf.connect(); for (TestSubscriber ts : tss) { ts.awaitDone(5, TimeUnit.SECONDS) @@ -515,9 +515,9 @@ public void source() { @Test public void connectThrows() { - ConnectableFlowable co = Flowable.empty().publish(); + ConnectableFlowable cf = Flowable.empty().publish(); try { - co.connect(new Consumer() { + cf.connect(new Consumer() { @Override public void accept(Disposable s) throws Exception { throw new TestException(); @@ -532,23 +532,23 @@ public void accept(Disposable s) throws Exception { public void addRemoveRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.empty().publish(); + final ConnectableFlowable cf = Flowable.empty().publish(); - final TestSubscriber to = co.test(); + final TestSubscriber ts = cf.test(); - final TestSubscriber to2 = new TestSubscriber(); + final TestSubscriber ts2 = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - co.subscribe(to2); + cf.subscribe(ts2); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; @@ -558,9 +558,9 @@ public void run() { @Test public void disposeOnArrival() { - ConnectableFlowable co = Flowable.empty().publish(); + ConnectableFlowable cf = Flowable.empty().publish(); - co.test(Long.MAX_VALUE, true).assertEmpty(); + cf.test(Long.MAX_VALUE, true).assertEmpty(); } @Test @@ -579,65 +579,65 @@ public void dispose() { @Test public void empty() { - ConnectableFlowable co = Flowable.empty().publish(); + ConnectableFlowable cf = Flowable.empty().publish(); - co.connect(); + cf.connect(); } @Test public void take() { - ConnectableFlowable co = Flowable.range(1, 2).publish(); + ConnectableFlowable cf = Flowable.range(1, 2).publish(); - TestSubscriber to = co.take(1).test(); + TestSubscriber ts = cf.take(1).test(); - co.connect(); + cf.connect(); - to.assertResult(1); + ts.assertResult(1); } @Test public void just() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - ConnectableFlowable co = ps.publish(); + ConnectableFlowable cf = pp.publish(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); - ps.onComplete(); + pp.onComplete(); } }; - co.subscribe(to); - co.connect(); + cf.subscribe(ts); + cf.connect(); - ps.onNext(1); + pp.onNext(1); - to.assertResult(1); + ts.assertResult(1); } @Test public void nextCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final ConnectableFlowable co = ps.publish(); + final ConnectableFlowable cf = pp.publish(); - final TestSubscriber to = co.test(); + final TestSubscriber ts = cf.test(); Runnable r1 = new Runnable() { @Override public void run() { - ps.onNext(1); + pp.onNext(1); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; @@ -675,9 +675,9 @@ protected void subscribeActual(Subscriber observer) { public void noErrorLoss() { List errors = TestHelper.trackPluginErrors(); try { - ConnectableFlowable co = Flowable.error(new TestException()).publish(); + ConnectableFlowable cf = Flowable.error(new TestException()).publish(); - co.connect(); + cf.connect(); TestHelper.assertUndeliverable(errors, 0, TestException.class); } finally { @@ -689,12 +689,12 @@ public void noErrorLoss() { public void subscribeDisconnectRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final ConnectableFlowable co = ps.publish(); + final ConnectableFlowable cf = pp.publish(); - final Disposable d = co.connect(); - final TestSubscriber to = new TestSubscriber(); + final Disposable d = cf.connect(); + final TestSubscriber ts = new TestSubscriber(); Runnable r1 = new Runnable() { @Override @@ -706,7 +706,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - co.subscribe(to); + cf.subscribe(ts); } }; @@ -716,9 +716,9 @@ public void run() { @Test public void selectorDisconnectsIndependentSource() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable v) throws Exception { return Flowable.range(1, 2); @@ -727,7 +727,7 @@ public Flowable apply(Flowable v) throws Exception { .test() .assertResult(1, 2); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test(timeout = 5000) @@ -753,9 +753,9 @@ public void mainError() { @Test public void selectorInnerError() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.publish(new Function, Flowable>() { + pp.publish(new Function, Flowable>() { @Override public Flowable apply(Flowable v) throws Exception { return Flowable.error(new TestException()); @@ -764,21 +764,21 @@ public Flowable apply(Flowable v) throws Exception { .test() .assertFailure(TestException.class); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); } @Test public void preNextConnect() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.empty().publish(); + final ConnectableFlowable cf = Flowable.empty().publish(); - co.connect(); + cf.connect(); Runnable r1 = new Runnable() { @Override public void run() { - co.test(); + cf.test(); } }; @@ -790,12 +790,12 @@ public void run() { public void connectRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.empty().publish(); + final ConnectableFlowable cf = Flowable.empty().publish(); Runnable r1 = new Runnable() { @Override public void run() { - co.connect(); + cf.connect(); } }; @@ -902,7 +902,7 @@ public void disposeRace() { final AtomicReference ref = new AtomicReference(); - final ConnectableFlowable co = new Flowable() { + final ConnectableFlowable cf = new Flowable() { @Override protected void subscribeActual(Subscriber s) { s.onSubscribe(new BooleanSubscription()); @@ -910,7 +910,7 @@ protected void subscribeActual(Subscriber s) { } }.publish(); - co.connect(); + cf.connect(); Runnable r1 = new Runnable() { @Override @@ -927,7 +927,7 @@ public void run() { public void removeNotPresent() { final AtomicReference> ref = new AtomicReference>(); - final ConnectableFlowable co = new Flowable() { + final ConnectableFlowable cf = new Flowable() { @Override @SuppressWarnings("unchecked") protected void subscribeActual(Subscriber s) { @@ -936,7 +936,7 @@ protected void subscribeActual(Subscriber s) { } }.publish(); - co.connect(); + cf.connect(); ref.get().add(new InnerSubscriber(new TestSubscriber())); ref.get().remove(null); @@ -945,9 +945,9 @@ protected void subscribeActual(Subscriber s) { @Test @Ignore("publish() keeps consuming the upstream if there are no subscribers, 3.x should change this") public void subscriberSwap() { - final ConnectableFlowable co = Flowable.range(1, 5).publish(); + final ConnectableFlowable cf = Flowable.range(1, 5).publish(); - co.connect(); + cf.connect(); TestSubscriber ts1 = new TestSubscriber() { @Override @@ -958,12 +958,12 @@ public void onNext(Integer t) { } }; - co.subscribe(ts1); + cf.subscribe(ts1); ts1.assertResult(1); TestSubscriber ts2 = new TestSubscriber(0); - co.subscribe(ts2); + cf.subscribe(ts2); ts2 .assertEmpty() @@ -973,7 +973,7 @@ public void onNext(Integer t) { @Test public void subscriberLiveSwap() { - final ConnectableFlowable co = Flowable.range(1, 5).publish(); + final ConnectableFlowable cf = Flowable.range(1, 5).publish(); final TestSubscriber ts2 = new TestSubscriber(0); @@ -983,13 +983,13 @@ public void onNext(Integer t) { super.onNext(t); cancel(); onComplete(); - co.subscribe(ts2); + cf.subscribe(ts2); } }; - co.subscribe(ts1); + cf.subscribe(ts1); - co.connect(); + cf.connect(); ts1.assertResult(1); @@ -1261,13 +1261,13 @@ public void run() { public void publishCancelOneAsync2() { final PublishProcessor pp = PublishProcessor.create(); - ConnectableFlowable co = pp.publish(); + ConnectableFlowable cf = pp.publish(); final TestSubscriber ts1 = new TestSubscriber(); final AtomicReference> ref = new AtomicReference>(); - co.subscribe(new FlowableSubscriber() { + cf.subscribe(new FlowableSubscriber() { @SuppressWarnings("unchecked") @Override public void onSubscribe(Subscription s) { @@ -1291,9 +1291,9 @@ public void onComplete() { ts1.onComplete(); } }); - TestSubscriber ts2 = co.test(); + TestSubscriber ts2 = cf.test(); - co.connect(); + cf.connect(); ref.get().set(Long.MIN_VALUE); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeLongTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeLongTest.java index 2fbd1be6c3..bf6130b027 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeLongTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeLongTest.java @@ -26,7 +26,7 @@ import io.reactivex.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.subscribers.*; public class FlowableRangeLongTest { @@ -290,21 +290,21 @@ public void countOne() { @Test public void fused() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); - Flowable.rangeLong(1, 2).subscribe(to); + Flowable.rangeLong(1, 2).subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1L, 2L); } @Test public void fusedReject() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); - Flowable.rangeLong(1, 2).subscribe(to); + Flowable.rangeLong(1, 2).subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1L, 2L); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeTest.java index 86dd5dbb58..d6e2821d84 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRangeTest.java @@ -26,7 +26,7 @@ import io.reactivex.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.subscribers.*; public class FlowableRangeTest { @@ -283,12 +283,12 @@ public void negativeCount() { @Test public void requestWrongFusion() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); Flowable.range(1, 5) - .subscribe(to); + .subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); } @@ -301,21 +301,21 @@ public void countOne() { @Test public void fused() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); - Flowable.range(1, 2).subscribe(to); + Flowable.range(1, 2).subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.SYNC) + SubscriberFusion.assertFusion(ts, QueueFuseable.SYNC) .assertResult(1, 2); } @Test public void fusedReject() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ASYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ASYNC); - Flowable.range(1, 2).subscribe(to); + Flowable.range(1, 2).subscribe(ts); - SubscriberFusion.assertFusion(to, QueueDisposable.NONE) + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE) .assertResult(1, 2); } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRefCountTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRefCountTest.java index 9de049a90d..eafd7873f8 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRefCountTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRefCountTest.java @@ -775,18 +775,18 @@ public Object call() throws Exception { @Test public void replayIsUnsubscribed() { - ConnectableFlowable co = Flowable.just(1) + ConnectableFlowable cf = Flowable.just(1) .replay(); - assertTrue(((Disposable)co).isDisposed()); + assertTrue(((Disposable)cf).isDisposed()); - Disposable s = co.connect(); + Disposable s = cf.connect(); - assertFalse(((Disposable)co).isDisposed()); + assertFalse(((Disposable)cf).isDisposed()); s.dispose(); - assertTrue(((Disposable)co).isDisposed()); + assertTrue(((Disposable)cf).isDisposed()); } static final class BadFlowableSubscribe extends ConnectableFlowable { diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableReplayTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableReplayTest.java index 72a65fe1d3..5941a8f4e2 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableReplayTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableReplayTest.java @@ -46,14 +46,14 @@ public class FlowableReplayTest { public void testBufferedReplay() { PublishProcessor source = PublishProcessor.create(); - ConnectableFlowable co = source.replay(3); - co.connect(); + ConnectableFlowable cf = source.replay(3); + cf.connect(); { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); source.onNext(1); source.onNext(2); @@ -76,7 +76,7 @@ public void testBufferedReplay() { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); inOrder.verify(observer1, times(1)).onNext(2); inOrder.verify(observer1, times(1)).onNext(3); @@ -91,14 +91,14 @@ public void testBufferedReplay() { public void testBufferedWindowReplay() { PublishProcessor source = PublishProcessor.create(); TestScheduler scheduler = new TestScheduler(); - ConnectableFlowable co = source.replay(3, 100, TimeUnit.MILLISECONDS, scheduler); - co.connect(); + ConnectableFlowable cf = source.replay(3, 100, TimeUnit.MILLISECONDS, scheduler); + cf.connect(); { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); source.onNext(1); scheduler.advanceTimeBy(10, TimeUnit.MILLISECONDS); @@ -128,7 +128,7 @@ public void testBufferedWindowReplay() { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); inOrder.verify(observer1, times(1)).onNext(4); inOrder.verify(observer1, times(1)).onNext(5); @@ -143,14 +143,14 @@ public void testWindowedReplay() { PublishProcessor source = PublishProcessor.create(); - ConnectableFlowable co = source.replay(100, TimeUnit.MILLISECONDS, scheduler); - co.connect(); + ConnectableFlowable cf = source.replay(100, TimeUnit.MILLISECONDS, scheduler); + cf.connect(); { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); source.onNext(1); scheduler.advanceTimeBy(60, TimeUnit.MILLISECONDS); @@ -174,7 +174,7 @@ public void testWindowedReplay() { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); inOrder.verify(observer1, never()).onNext(3); inOrder.verify(observer1, times(1)).onComplete(); @@ -371,14 +371,14 @@ public Flowable apply(Flowable t1) { public void testBufferedReplayError() { PublishProcessor source = PublishProcessor.create(); - ConnectableFlowable co = source.replay(3); - co.connect(); + ConnectableFlowable cf = source.replay(3); + cf.connect(); { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); source.onNext(1); source.onNext(2); @@ -402,7 +402,7 @@ public void testBufferedReplayError() { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); inOrder.verify(observer1, times(1)).onNext(2); inOrder.verify(observer1, times(1)).onNext(3); @@ -419,14 +419,14 @@ public void testWindowedReplayError() { PublishProcessor source = PublishProcessor.create(); - ConnectableFlowable co = source.replay(100, TimeUnit.MILLISECONDS, scheduler); - co.connect(); + ConnectableFlowable cf = source.replay(100, TimeUnit.MILLISECONDS, scheduler); + cf.connect(); { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); source.onNext(1); scheduler.advanceTimeBy(60, TimeUnit.MILLISECONDS); @@ -450,7 +450,7 @@ public void testWindowedReplayError() { Subscriber observer1 = TestHelper.mockSubscriber(); InOrder inOrder = inOrder(observer1); - co.subscribe(observer1); + cf.subscribe(observer1); inOrder.verify(observer1, never()).onNext(3); inOrder.verify(observer1, times(1)).onError(any(RuntimeException.class)); @@ -807,17 +807,17 @@ public void accept(long t) { requested.addAndGet(t); } }); - ConnectableFlowable co = source.replay(); + ConnectableFlowable cf = source.replay(); TestSubscriber ts1 = new TestSubscriber(10L); TestSubscriber ts2 = new TestSubscriber(90L); - co.subscribe(ts1); - co.subscribe(ts2); + cf.subscribe(ts1); + cf.subscribe(ts2); ts2.request(10); - co.connect(); + cf.connect(); ts1.assertValueCount(10); ts1.assertNotTerminated(); @@ -838,17 +838,17 @@ public void accept(long t) { requested.addAndGet(t); } }); - ConnectableFlowable co = source.replay(50); + ConnectableFlowable cf = source.replay(50); TestSubscriber ts1 = new TestSubscriber(10L); TestSubscriber ts2 = new TestSubscriber(90L); - co.subscribe(ts1); - co.subscribe(ts2); + cf.subscribe(ts1); + cf.subscribe(ts2); ts2.request(10); - co.connect(); + cf.connect(); ts1.assertValueCount(10); ts1.assertNotTerminated(); @@ -1306,12 +1306,12 @@ public void source() { @Test public void connectRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.range(1, 3).replay(); + final ConnectableFlowable cf = Flowable.range(1, 3).replay(); Runnable r = new Runnable() { @Override public void run() { - co.connect(); + cf.connect(); } }; @@ -1322,22 +1322,22 @@ public void run() { @Test public void subscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.range(1, 3).replay(); + final ConnectableFlowable cf = Flowable.range(1, 3).replay(); - final TestSubscriber to1 = new TestSubscriber(); - final TestSubscriber to2 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); + final TestSubscriber ts2 = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - co.subscribe(to1); + cf.subscribe(ts1); } }; Runnable r2 = new Runnable() { @Override public void run() { - co.subscribe(to2); + cf.subscribe(ts2); } }; @@ -1348,24 +1348,24 @@ public void run() { @Test public void addRemoveRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.range(1, 3).replay(); + final ConnectableFlowable cf = Flowable.range(1, 3).replay(); - final TestSubscriber to1 = new TestSubscriber(); - final TestSubscriber to2 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); + final TestSubscriber ts2 = new TestSubscriber(); - co.subscribe(to1); + cf.subscribe(ts1); Runnable r1 = new Runnable() { @Override public void run() { - to1.cancel(); + ts1.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - co.subscribe(to2); + cf.subscribe(ts2); } }; @@ -1384,12 +1384,12 @@ public void cancelOnArrival() { @Test public void cancelOnArrival2() { - ConnectableFlowable co = PublishProcessor.create() + ConnectableFlowable cf = PublishProcessor.create() .replay(Integer.MAX_VALUE); - co.test(); + cf.test(); - co + cf .autoConnect() .test(Long.MAX_VALUE, true) .assertEmpty(); @@ -1397,11 +1397,11 @@ public void cancelOnArrival2() { @Test public void connectConsumerThrows() { - ConnectableFlowable co = Flowable.range(1, 2) + ConnectableFlowable cf = Flowable.range(1, 2) .replay(); try { - co.connect(new Consumer() { + cf.connect(new Consumer() { @Override public void accept(Disposable t) throws Exception { throw new TestException(); @@ -1412,11 +1412,11 @@ public void accept(Disposable t) throws Exception { // expected } - co.test().assertEmpty().cancel(); + cf.test().assertEmpty().cancel(); - co.connect(); + cf.connect(); - co.test().assertResult(1, 2); + cf.test().assertResult(1, 2); } @Test @@ -1446,16 +1446,16 @@ protected void subscribeActual(Subscriber observer) { @Test public void subscribeOnNextRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final ConnectableFlowable co = ps.replay(); + final ConnectableFlowable cf = pp.replay(); - final TestSubscriber to1 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); Runnable r1 = new Runnable() { @Override public void run() { - co.subscribe(to1); + cf.subscribe(ts1); } }; @@ -1463,7 +1463,7 @@ public void run() { @Override public void run() { for (int j = 0; j < 1000; j++) { - ps.onNext(j); + pp.onNext(j); } } }; @@ -1475,18 +1475,18 @@ public void run() { @Test public void unsubscribeOnNextRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final ConnectableFlowable co = ps.replay(); + final ConnectableFlowable cf = pp.replay(); - final TestSubscriber to1 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); - co.subscribe(to1); + cf.subscribe(ts1); Runnable r1 = new Runnable() { @Override public void run() { - to1.dispose(); + ts1.dispose(); } }; @@ -1494,7 +1494,7 @@ public void run() { @Override public void run() { for (int j = 0; j < 1000; j++) { - ps.onNext(j); + pp.onNext(j); } } }; @@ -1506,23 +1506,23 @@ public void run() { @Test public void unsubscribeReplayRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final ConnectableFlowable co = Flowable.range(1, 1000).replay(); + final ConnectableFlowable cf = Flowable.range(1, 1000).replay(); - final TestSubscriber to1 = new TestSubscriber(); + final TestSubscriber ts1 = new TestSubscriber(); - co.connect(); + cf.connect(); Runnable r1 = new Runnable() { @Override public void run() { - co.subscribe(to1); + cf.subscribe(ts1); } }; Runnable r2 = new Runnable() { @Override public void run() { - to1.dispose(); + ts1.dispose(); } }; @@ -1532,90 +1532,90 @@ public void run() { @Test public void reentrantOnNext() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t == 1) { - ps.onNext(2); - ps.onComplete(); + pp.onNext(2); + pp.onComplete(); } super.onNext(t); } }; - ps.replay().autoConnect().subscribe(to); + pp.replay().autoConnect().subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void reentrantOnNextBound() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t == 1) { - ps.onNext(2); - ps.onComplete(); + pp.onNext(2); + pp.onComplete(); } super.onNext(t); } }; - ps.replay(10).autoConnect().subscribe(to); + pp.replay(10).autoConnect().subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertResult(1, 2); + ts.assertResult(1, 2); } @Test public void reentrantOnNextCancel() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t == 1) { - ps.onNext(2); + pp.onNext(2); cancel(); } super.onNext(t); } }; - ps.replay().autoConnect().subscribe(to); + pp.replay().autoConnect().subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertValues(1); + ts.assertValues(1); } @Test public void reentrantOnNextCancelBounded() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t == 1) { - ps.onNext(2); + pp.onNext(2); cancel(); } super.onNext(t); } }; - ps.replay(10).autoConnect().subscribe(to); + pp.replay(10).autoConnect().subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertValues(1); + ts.assertValues(1); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRetryWithPredicateTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRetryWithPredicateTest.java index 9f94cc267c..72a9f518ce 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableRetryWithPredicateTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableRetryWithPredicateTest.java @@ -392,7 +392,7 @@ public boolean test(Integer t1, Throwable t2) { @Test public void predicateThrows() { - TestSubscriber to = Flowable.error(new TestException("Outer")) + TestSubscriber ts = Flowable.error(new TestException("Outer")) .retry(new Predicate() { @Override public boolean test(Throwable e) throws Exception { @@ -402,7 +402,7 @@ public boolean test(Throwable e) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "Outer"); TestHelper.assertError(errors, 1, TestException.class, "Inner"); @@ -419,36 +419,36 @@ public void dontRetry() { @Test public void retryDisposeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = ps.retry(Functions.alwaysTrue()).test(); + final TestSubscriber ts = pp.retry(Functions.alwaysTrue()).test(); final TestException ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - ps.onError(ex); + pp.onError(ex); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; TestHelper.race(r1, r2); - to.assertEmpty(); + ts.assertEmpty(); } } @Test public void bipredicateThrows() { - TestSubscriber to = Flowable.error(new TestException("Outer")) + TestSubscriber ts = Flowable.error(new TestException("Outer")) .retry(new BiPredicate() { @Override public boolean test(Integer n, Throwable e) throws Exception { @@ -458,7 +458,7 @@ public boolean test(Integer n, Throwable e) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "Outer"); TestHelper.assertError(errors, 1, TestException.class, "Inner"); @@ -467,9 +467,9 @@ public boolean test(Integer n, Throwable e) throws Exception { @Test public void retryBiPredicateDisposeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = ps.retry(new BiPredicate() { + final TestSubscriber ts = pp.retry(new BiPredicate() { @Override public boolean test(Object t1, Object t2) throws Exception { return true; @@ -481,20 +481,20 @@ public boolean test(Object t1, Object t2) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps.onError(ex); + pp.onError(ex); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; TestHelper.race(r1, r2); - to.assertEmpty(); + ts.assertEmpty(); } } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableScalarXMapTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableScalarXMapTest.java index 191f90bbea..14f98a6c76 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableScalarXMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableScalarXMapTest.java @@ -178,9 +178,9 @@ public Publisher apply(Integer v) throws Exception { @Test public void scalarDisposableStateCheck() { - TestSubscriber to = new TestSubscriber(); - ScalarSubscription sd = new ScalarSubscription(to, 1); - to.onSubscribe(sd); + TestSubscriber ts = new TestSubscriber(); + ScalarSubscription sd = new ScalarSubscription(ts, 1); + ts.onSubscribe(sd); assertFalse(sd.isCancelled()); @@ -192,7 +192,7 @@ public void scalarDisposableStateCheck() { assertTrue(sd.isEmpty()); - to.assertResult(1); + ts.assertResult(1); try { sd.offer(1); @@ -212,9 +212,9 @@ public void scalarDisposableStateCheck() { @Test public void scalarDisposableRunDisposeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - TestSubscriber to = new TestSubscriber(); - final ScalarSubscription sd = new ScalarSubscription(to, 1); - to.onSubscribe(sd); + TestSubscriber ts = new TestSubscriber(); + final ScalarSubscription sd = new ScalarSubscription(ts, 1); + ts.onSubscribe(sd); Runnable r1 = new Runnable() { @Override diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSequenceEqualTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSequenceEqualTest.java index f4dc1441d0..a71e68f696 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSequenceEqualTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSequenceEqualTest.java @@ -313,9 +313,9 @@ public void simpleInequalObservable() { @Test public void onNextCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestObserver to = Flowable.sequenceEqual(Flowable.never(), ps).test(); + final TestObserver to = Flowable.sequenceEqual(Flowable.never(), pp).test(); Runnable r1 = new Runnable() { @Override @@ -327,7 +327,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ps.onNext(1); + pp.onNext(1); } }; @@ -340,27 +340,27 @@ public void run() { @Test public void onNextCancelRaceObservable() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = Flowable.sequenceEqual(Flowable.never(), ps).toFlowable().test(); + final TestSubscriber ts = Flowable.sequenceEqual(Flowable.never(), pp).toFlowable().test(); Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps.onNext(1); + pp.onNext(1); } }; TestHelper.race(r1, r2); - to.assertEmpty(); + ts.assertEmpty(); } } @@ -519,14 +519,14 @@ protected void subscribeActual(Subscriber s) { }; for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); final PublishProcessor pp = PublishProcessor.create(); boolean swap = (i & 1) == 0; Flowable.sequenceEqual(swap ? pp : neverNever, swap ? neverNever : pp) - .subscribe(ts); + .subscribe(to); Runnable r1 = new Runnable() { @Override @@ -538,13 +538,13 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; TestHelper.race(r1, r2); - ts.assertEmpty(); + to.assertEmpty(); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSkipLastTimedTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSkipLastTimedTest.java index 23d5a7b987..f82e172f23 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSkipLastTimedTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSkipLastTimedTest.java @@ -197,21 +197,21 @@ public Flowable apply(Flowable o) throws Exception { public void onNextDisposeRace() { TestScheduler scheduler = new TestScheduler(); for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = ps.skipLast(1, TimeUnit.DAYS, scheduler).test(); + final TestSubscriber ts = pp.skipLast(1, TimeUnit.DAYS, scheduler).test(); Runnable r1 = new Runnable() { @Override public void run() { - ps.onComplete(); + pp.onComplete(); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSwitchTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSwitchTest.java index 41a13caa60..8aeda04f47 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableSwitchTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableSwitchTest.java @@ -723,27 +723,27 @@ public void accept(Integer v) throws Exception { @Test public void switchOnNextDelayErrorWithError() { - PublishProcessor> ps = PublishProcessor.create(); + PublishProcessor> pp = PublishProcessor.create(); - TestSubscriber ts = Flowable.switchOnNextDelayError(ps).test(); + TestSubscriber ts = Flowable.switchOnNextDelayError(pp).test(); - ps.onNext(Flowable.just(1)); - ps.onNext(Flowable.error(new TestException())); - ps.onNext(Flowable.range(2, 4)); - ps.onComplete(); + pp.onNext(Flowable.just(1)); + pp.onNext(Flowable.error(new TestException())); + pp.onNext(Flowable.range(2, 4)); + pp.onComplete(); ts.assertFailure(TestException.class, 1, 2, 3, 4, 5); } @Test public void switchOnNextDelayErrorBufferSize() { - PublishProcessor> ps = PublishProcessor.create(); + PublishProcessor> pp = PublishProcessor.create(); - TestSubscriber ts = Flowable.switchOnNextDelayError(ps, 2).test(); + TestSubscriber ts = Flowable.switchOnNextDelayError(pp, 2).test(); - ps.onNext(Flowable.just(1)); - ps.onNext(Flowable.range(2, 4)); - ps.onComplete(); + pp.onNext(Flowable.just(1)); + pp.onNext(Flowable.range(2, 4)); + pp.onComplete(); ts.assertResult(1, 2, 3, 4, 5); } @@ -825,14 +825,14 @@ public void nextSourceErrorRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - ps1.switchMap(new Function>() { + pp1.switchMap(new Function>() { @Override public Flowable apply(Integer v) throws Exception { if (v == 1) { - return ps2; + return pp2; } return Flowable.never(); } @@ -842,7 +842,7 @@ public Flowable apply(Integer v) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onNext(2); + pp1.onNext(2); } }; @@ -851,7 +851,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex); + pp2.onError(ex); } }; @@ -872,14 +872,14 @@ public void outerInnerErrorRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - ps1.switchMap(new Function>() { + pp1.switchMap(new Function>() { @Override public Flowable apply(Integer v) throws Exception { if (v == 1) { - return ps2; + return pp2; } return Flowable.never(); } @@ -891,7 +891,7 @@ public Flowable apply(Integer v) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex1); + pp1.onError(ex1); } }; @@ -900,7 +900,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex2); + pp2.onError(ex2); } }; @@ -918,9 +918,9 @@ public void run() { @Test public void nextCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps1 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); - final TestSubscriber to = ps1.switchMap(new Function>() { + final TestSubscriber ts = pp1.switchMap(new Function>() { @Override public Flowable apply(Integer v) throws Exception { return Flowable.never(); @@ -931,14 +931,14 @@ public Flowable apply(Integer v) throws Exception { Runnable r1 = new Runnable() { @Override public void run() { - ps1.onNext(2); + pp1.onNext(2); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; @@ -1024,44 +1024,44 @@ protected void subscribeActual(Subscriber observer) { @Test public void innerCompletesReentrant() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); - ps.onComplete(); + pp.onComplete(); } }; Flowable.just(1).hide() - .switchMap(Functions.justFunction(ps)) - .subscribe(to); + .switchMap(Functions.justFunction(pp)) + .subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertResult(1); + ts.assertResult(1); } @Test public void innerErrorsReentrant() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); - ps.onError(new TestException()); + pp.onError(new TestException()); } }; Flowable.just(1).hide() - .switchMap(Functions.justFunction(ps)) - .subscribe(to); + .switchMap(Functions.justFunction(pp)) + .subscribe(ts); - ps.onNext(1); + pp.onNext(1); - to.assertFailure(TestException.class, 1); + ts.assertFailure(TestException.class, 1); } @Test @@ -1159,7 +1159,7 @@ public void innerCancelledOnMainError() { final PublishProcessor main = PublishProcessor.create(); final PublishProcessor inner = PublishProcessor.create(); - TestSubscriber to = main.switchMap(Functions.justFunction(inner)) + TestSubscriber ts = main.switchMap(Functions.justFunction(inner)) .test(); assertTrue(main.hasSubscribers()); @@ -1172,6 +1172,6 @@ public void innerCancelledOnMainError() { assertFalse(inner.hasSubscribers()); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); } } diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTakeLastTimedTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTakeLastTimedTest.java index f27411ef0e..a0bce236de 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTakeLastTimedTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTakeLastTimedTest.java @@ -208,19 +208,19 @@ public void testContinuousDelivery() { TestSubscriber ts = new TestSubscriber(0L); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - ps.takeLast(1000, TimeUnit.MILLISECONDS, scheduler).subscribe(ts); + pp.takeLast(1000, TimeUnit.MILLISECONDS, scheduler).subscribe(ts); - ps.onNext(1); + pp.onNext(1); scheduler.advanceTimeBy(500, TimeUnit.MILLISECONDS); - ps.onNext(2); + pp.onNext(2); scheduler.advanceTimeBy(500, TimeUnit.MILLISECONDS); - ps.onNext(3); + pp.onNext(3); scheduler.advanceTimeBy(500, TimeUnit.MILLISECONDS); - ps.onNext(4); + pp.onNext(4); scheduler.advanceTimeBy(500, TimeUnit.MILLISECONDS); - ps.onComplete(); + pp.onComplete(); scheduler.advanceTimeBy(500, TimeUnit.MILLISECONDS); ts.assertNoValues(); @@ -292,21 +292,21 @@ public void observeOn() { @Test public void cancelCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = ps.takeLast(1, TimeUnit.DAYS).test(); + final TestSubscriber ts = pp.takeLast(1, TimeUnit.DAYS).test(); Runnable r1 = new Runnable() { @Override public void run() { - ps.onComplete(); + pp.onComplete(); } }; Runnable r2 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutTests.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutTests.java index b95a03d7be..b119bd00e4 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutTests.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutTests.java @@ -480,36 +480,36 @@ protected void subscribeActual(Subscriber observer) { @Test public void timedTake() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps.timeout(1, TimeUnit.DAYS) + TestSubscriber ts = pp.timeout(1, TimeUnit.DAYS) .take(1) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @Test public void timedFallbackTake() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = ps.timeout(1, TimeUnit.DAYS, Flowable.just(2)) + TestSubscriber ts = pp.timeout(1, TimeUnit.DAYS, Flowable.just(2)) .take(1) .test(); - assertTrue(ps.hasSubscribers()); + assertTrue(pp.hasSubscribers()); - ps.onNext(1); + pp.onNext(1); - assertFalse(ps.hasSubscribers()); + assertFalse(pp.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java index 3641de632c..b1667e1e56 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableTimeoutWithSelectorTest.java @@ -416,13 +416,13 @@ public void error() { public void emptyInner() { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = pp + TestSubscriber ts = pp .timeout(Functions.justFunction(Flowable.empty())) .test(); pp.onNext(1); - to.assertFailure(TimeoutException.class, 1); + ts.assertFailure(TimeoutException.class, 1); } @Test @@ -431,7 +431,7 @@ public void badInnerSource() { try { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = pp + TestSubscriber ts = pp .timeout(Functions.justFunction(new Flowable() { @Override protected void subscribeActual(Subscriber observer) { @@ -446,7 +446,7 @@ protected void subscribeActual(Subscriber observer) { pp.onNext(1); - to.assertFailureAndMessage(TestException.class, "First", 1); + ts.assertFailureAndMessage(TestException.class, "First", 1); TestHelper.assertUndeliverable(errors, 0, TestException.class, "Second"); } finally { @@ -460,7 +460,7 @@ public void badInnerSourceOther() { try { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = pp + TestSubscriber ts = pp .timeout(Functions.justFunction(new Flowable() { @Override protected void subscribeActual(Subscriber observer) { @@ -475,7 +475,7 @@ protected void subscribeActual(Subscriber observer) { pp.onNext(1); - to.assertFailureAndMessage(TestException.class, "First", 1); + ts.assertFailureAndMessage(TestException.class, "First", 1); TestHelper.assertUndeliverable(errors, 0, TestException.class, "Second"); } finally { @@ -515,7 +515,7 @@ protected void subscribeActual(Subscriber observer) { public void selectorTake() { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = pp + TestSubscriber ts = pp .timeout(Functions.justFunction(Flowable.never())) .take(1) .test(); @@ -526,14 +526,14 @@ public void selectorTake() { assertFalse(pp.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @Test public void selectorFallbackTake() { PublishProcessor pp = PublishProcessor.create(); - TestSubscriber to = pp + TestSubscriber ts = pp .timeout(Functions.justFunction(Flowable.never()), Flowable.just(2)) .take(1) .test(); @@ -544,7 +544,7 @@ public void selectorFallbackTake() { assertFalse(pp.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableToListTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableToListTest.java index 6babda3c89..4c18a1ce29 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableToListTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableToListTest.java @@ -231,25 +231,25 @@ public void testListWithBlockingFirst() { @Ignore("Single doesn't do backpressure") public void testBackpressureHonored() { Single> w = Flowable.just(1, 2, 3, 4, 5).toList(); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); - w.subscribe(ts); + w.subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); // ts.request(1); - ts.assertValue(Arrays.asList(1, 2, 3, 4, 5)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 2, 3, 4, 5)); + to.assertNoErrors(); + to.assertComplete(); // ts.request(1); - ts.assertValue(Arrays.asList(1, 2, 3, 4, 5)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 2, 3, 4, 5)); + to.assertNoErrors(); + to.assertComplete(); } @Test(timeout = 2000) @Ignore("PublishProcessor no longer emits without requests so this test fails due to the race of onComplete and request") @@ -264,8 +264,8 @@ public void testAsyncRequested() { Single> sorted = source.toList(); final CyclicBarrier cb = new CyclicBarrier(2); - final TestObserver> ts = new TestObserver>(); - sorted.subscribe(ts); + final TestObserver> to = new TestObserver>(); + sorted.subscribe(to); w.schedule(new Runnable() { @Override @@ -277,10 +277,10 @@ public void run() { source.onNext(1); await(cb); source.onComplete(); - ts.awaitTerminalEvent(1, TimeUnit.SECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValue(Arrays.asList(1)); + to.awaitTerminalEvent(1, TimeUnit.SECONDS); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValue(Arrays.asList(1)); } } finally { w.dispose(); @@ -395,7 +395,7 @@ public Collection call() throws Exception { public void onNextCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final PublishProcessor pp = PublishProcessor.create(); - final TestObserver> ts = pp.toList().test(); + final TestObserver> to = pp.toList().test(); Runnable r1 = new Runnable() { @Override @@ -406,7 +406,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableToSortedListTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableToSortedListTest.java index 8a840f4b30..db118e2ab1 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableToSortedListTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableToSortedListTest.java @@ -204,25 +204,25 @@ public void testWithFollowingFirst() { @Ignore("Single doesn't do backpressure") public void testBackpressureHonored() { Single> w = Flowable.just(1, 3, 2, 5, 4).toSortedList(); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); - w.subscribe(ts); + w.subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); // ts.request(1); - ts.assertValue(Arrays.asList(1, 2, 3, 4, 5)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 2, 3, 4, 5)); + to.assertNoErrors(); + to.assertComplete(); // ts.request(1); - ts.assertValue(Arrays.asList(1, 2, 3, 4, 5)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 2, 3, 4, 5)); + to.assertNoErrors(); + to.assertComplete(); } @Test(timeout = 2000) @@ -238,8 +238,8 @@ public void testAsyncRequested() { Single> sorted = source.toSortedList(); final CyclicBarrier cb = new CyclicBarrier(2); - final TestObserver> ts = new TestObserver>(); - sorted.subscribe(ts); + final TestObserver> to = new TestObserver>(); + sorted.subscribe(to); w.schedule(new Runnable() { @Override public void run() { @@ -250,10 +250,10 @@ public void run() { source.onNext(1); await(cb); source.onComplete(); - ts.awaitTerminalEvent(1, TimeUnit.SECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValue(Arrays.asList(1)); + to.awaitTerminalEvent(1, TimeUnit.SECONDS); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValue(Arrays.asList(1)); } } finally { w.dispose(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableUsingTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableUsingTest.java index ebb7a9722b..4638086065 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableUsingTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableUsingTest.java @@ -525,7 +525,7 @@ public Flowable apply(Object v) throws Exception { @Test public void supplierDisposerCrash() { - TestSubscriber to = Flowable.using(new Callable() { + TestSubscriber ts = Flowable.using(new Callable() { @Override public Object call() throws Exception { return 1; @@ -544,7 +544,7 @@ public void accept(Object e) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "First"); TestHelper.assertError(errors, 1, TestException.class, "Second"); @@ -552,7 +552,7 @@ public void accept(Object e) throws Exception { @Test public void eagerOnErrorDisposerCrash() { - TestSubscriber to = Flowable.using(new Callable() { + TestSubscriber ts = Flowable.using(new Callable() { @Override public Object call() throws Exception { return 1; @@ -571,7 +571,7 @@ public void accept(Object e) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "First"); TestHelper.assertError(errors, 1, TestException.class, "Second"); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithFlowableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithFlowableTest.java index d9912f0b01..1bdb7a95e6 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithFlowableTest.java @@ -474,13 +474,13 @@ public void boundaryDispose2() { @Test public void boundaryOnError() { - TestSubscriber to = Flowable.error(new TestException()) + TestSubscriber ts = Flowable.error(new TestException()) .window(Flowable.never()) .flatMap(Functions.>identity(), true) .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(to.errors().get(0)); + List errors = TestHelper.compositeList(ts.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class); } @@ -534,7 +534,7 @@ public Flowable apply(Flowable v) throws Exception { public void reentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -552,11 +552,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -565,7 +565,7 @@ public Flowable apply(Flowable v) throws Exception { public void reentrantCallable() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -593,11 +593,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -738,7 +738,7 @@ public void upstreamDisposedWhenOutputsDisposed() { PublishProcessor source = PublishProcessor.create(); PublishProcessor boundary = PublishProcessor.create(); - TestSubscriber to = source.window(boundary) + TestSubscriber ts = source.window(boundary) .take(1) .flatMap(new Function, Flowable>() { @Override @@ -754,7 +754,7 @@ public Flowable apply( assertFalse("source not disposed", source.hasSubscribers()); assertFalse("boundary not disposed", boundary.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @@ -764,7 +764,7 @@ public void mainAndBoundaryBothError() { try { final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = Flowable.error(new TestException("main")) + TestSubscriber> ts = Flowable.error(new TestException("main")) .window(new Flowable() { @Override protected void subscribeActual(Subscriber observer) { @@ -774,7 +774,7 @@ protected void subscribeActual(Subscriber observer) { }) .test(); - to + ts .assertValueCount(1) .assertError(TestException.class) .assertErrorMessage("main") @@ -798,7 +798,7 @@ public void mainCompleteBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -829,7 +829,7 @@ public void run() { TestHelper.race(r1, r2); - to + ts .assertValueCount(1) .assertTerminated(); @@ -848,7 +848,7 @@ public void mainNextBoundaryNextRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -879,7 +879,7 @@ public void run() { TestHelper.race(r1, r2); - to + ts .assertValueCount(2) .assertNotComplete() .assertNoErrors(); @@ -891,7 +891,7 @@ public void takeOneAnotherBoundary() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -907,13 +907,13 @@ protected void subscribeActual(Subscriber observer) { }) .test(); - to.assertValueCount(1) + ts.assertValueCount(1) .assertNotTerminated() .cancel(); ref.get().onNext(1); - to.assertValueCount(1) + ts.assertValueCount(1) .assertNotTerminated(); } @@ -923,7 +923,7 @@ public void disposeMainBoundaryCompleteRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - final TestSubscriber> to = new Flowable() { + final TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -956,7 +956,7 @@ public void request(long n) { Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; Runnable r2 = new Runnable() { @@ -980,7 +980,7 @@ public void disposeMainBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - final TestSubscriber> to = new Flowable() { + final TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1013,7 +1013,7 @@ public void request(long n) { Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; Runnable r2 = new Runnable() { @@ -1045,7 +1045,7 @@ public void selectorUpstreamDisposedWhenOutputsDisposed() { PublishProcessor source = PublishProcessor.create(); PublishProcessor boundary = PublishProcessor.create(); - TestSubscriber to = source.window(Functions.justCallable(boundary)) + TestSubscriber ts = source.window(Functions.justCallable(boundary)) .take(1) .flatMap(new Function, Flowable>() { @Override @@ -1061,7 +1061,7 @@ public Flowable apply( assertFalse("source not disposed", source.hasSubscribers()); assertFalse("boundary not disposed", boundary.hasSubscribers()); - to.assertResult(1); + ts.assertResult(1); } @Test @@ -1070,7 +1070,7 @@ public void supplierMainAndBoundaryBothError() { try { final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = Flowable.error(new TestException("main")) + TestSubscriber> ts = Flowable.error(new TestException("main")) .window(Functions.justCallable(new Flowable() { @Override protected void subscribeActual(Subscriber observer) { @@ -1080,7 +1080,7 @@ protected void subscribeActual(Subscriber observer) { })) .test(); - to + ts .assertValueCount(1) .assertError(TestException.class) .assertErrorMessage("main") @@ -1104,7 +1104,7 @@ public void supplierMainCompleteBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1135,7 +1135,7 @@ public void run() { TestHelper.race(r1, r2); - to + ts .assertValueCount(1) .assertTerminated(); @@ -1154,7 +1154,7 @@ public void supplierMainNextBoundaryNextRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1185,7 +1185,7 @@ public void run() { TestHelper.race(r1, r2); - to + ts .assertValueCount(2) .assertNotComplete() .assertNoErrors(); @@ -1197,7 +1197,7 @@ public void supplierTakeOneAnotherBoundary() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - TestSubscriber> to = new Flowable() { + TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1213,13 +1213,13 @@ protected void subscribeActual(Subscriber observer) { })) .test(); - to.assertValueCount(1) + ts.assertValueCount(1) .assertNotTerminated() .cancel(); ref.get().onNext(1); - to.assertValueCount(1) + ts.assertValueCount(1) .assertNotTerminated(); } @@ -1229,7 +1229,7 @@ public void supplierDisposeMainBoundaryCompleteRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - final TestSubscriber> to = new Flowable() { + final TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1262,7 +1262,7 @@ public void request(long n) { Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; Runnable r2 = new Runnable() { @@ -1288,7 +1288,7 @@ public void supplierDisposeMainBoundaryErrorRace() { final AtomicReference> refMain = new AtomicReference>(); final AtomicReference> ref = new AtomicReference>(); - final TestSubscriber> to = new Flowable() { + final TestSubscriber> ts = new Flowable() { @Override protected void subscribeActual(Subscriber observer) { observer.onSubscribe(new BooleanSubscription()); @@ -1330,7 +1330,7 @@ public void request(long n) { Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; Runnable r2 = new Runnable() { diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java index 73535ff5c2..561deaf7bb 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithStartEndFlowableTest.java @@ -269,7 +269,7 @@ public void dispose() { public void reentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -287,11 +287,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -312,7 +312,7 @@ public void boundarySelectorNormal() { PublishProcessor start = PublishProcessor.create(); final PublishProcessor end = PublishProcessor.create(); - TestSubscriber to = source.window(start, new Function>() { + TestSubscriber ts = source.window(start, new Function>() { @Override public Flowable apply(Integer v) throws Exception { return end; @@ -339,7 +339,7 @@ public Flowable apply(Integer v) throws Exception { TestHelper.emit(source, 7, 8); - to.assertResult(1, 2, 3, 4, 5, 5, 6, 6, 7, 8); + ts.assertResult(1, 2, 3, 4, 5, 5, 6, 6, 7, 8); } @Test @@ -348,7 +348,7 @@ public void startError() { PublishProcessor start = PublishProcessor.create(); final PublishProcessor end = PublishProcessor.create(); - TestSubscriber to = source.window(start, new Function>() { + TestSubscriber ts = source.window(start, new Function>() { @Override public Flowable apply(Integer v) throws Exception { return end; @@ -359,7 +359,7 @@ public Flowable apply(Integer v) throws Exception { start.onError(new TestException()); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); assertFalse("Source has observers!", source.hasSubscribers()); assertFalse("Start has observers!", start.hasSubscribers()); @@ -372,7 +372,7 @@ public void endError() { PublishProcessor start = PublishProcessor.create(); final PublishProcessor end = PublishProcessor.create(); - TestSubscriber to = source.window(start, new Function>() { + TestSubscriber ts = source.window(start, new Function>() { @Override public Flowable apply(Integer v) throws Exception { return end; @@ -384,7 +384,7 @@ public Flowable apply(Integer v) throws Exception { start.onNext(1); end.onError(new TestException()); - to.assertFailure(TestException.class); + ts.assertFailure(TestException.class); assertFalse("Source has observers!", source.hasSubscribers()); assertFalse("Start has observers!", start.hasSubscribers()); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithTimeTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithTimeTest.java index 6d48c40f49..019c2d101f 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithTimeTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWindowWithTimeTest.java @@ -561,7 +561,7 @@ public void exactUnboundedReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -579,11 +579,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -594,7 +594,7 @@ public void exactBoundedReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -612,11 +612,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -627,7 +627,7 @@ public void exactBoundedReentrant2() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -645,11 +645,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -660,7 +660,7 @@ public void skipReentrant() { final FlowableProcessor ps = PublishProcessor.create(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { super.onNext(t); @@ -678,11 +678,11 @@ public Flowable apply(Flowable v) throws Exception { return v; } }) - .subscribe(to); + .subscribe(ts); ps.onNext(1); - to + ts .awaitDone(1, TimeUnit.SECONDS) .assertResult(1, 2); } @@ -690,9 +690,9 @@ public Flowable apply(Flowable v) throws Exception { @Test public void sizeTimeTimeout() { TestScheduler scheduler = new TestScheduler(); - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); - TestSubscriber> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 100) + TestSubscriber> ts = pp.window(5, TimeUnit.MILLISECONDS, scheduler, 100) .test() .assertValueCount(1); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWithLatestFromTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWithLatestFromTest.java index 0151fbbe90..360aa9c3bc 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableWithLatestFromTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableWithLatestFromTest.java @@ -313,36 +313,36 @@ public String apply(Object[] args) { @Test public void manySources() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); - PublishProcessor ps3 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); + PublishProcessor pp3 = PublishProcessor.create(); PublishProcessor main = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(); - main.withLatestFrom(new Flowable[] { ps1, ps2, ps3 }, toArray) + main.withLatestFrom(new Flowable[] { pp1, pp2, pp3 }, toArray) .subscribe(ts); main.onNext("1"); ts.assertNoValues(); - ps1.onNext("a"); + pp1.onNext("a"); ts.assertNoValues(); - ps2.onNext("A"); + pp2.onNext("A"); ts.assertNoValues(); - ps3.onNext("="); + pp3.onNext("="); ts.assertNoValues(); main.onNext("2"); ts.assertValues("[2, a, A, =]"); - ps2.onNext("B"); + pp2.onNext("B"); ts.assertValues("[2, a, A, =]"); - ps3.onComplete(); + pp3.onComplete(); ts.assertValues("[2, a, A, =]"); - ps1.onNext("b"); + pp1.onNext("b"); main.onNext("3"); @@ -353,43 +353,43 @@ public void manySources() { ts.assertNoErrors(); ts.assertComplete(); - assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); - assertFalse("ps3 has subscribers?", ps3.hasSubscribers()); + assertFalse("ps1 has subscribers?", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?", pp2.hasSubscribers()); + assertFalse("ps3 has subscribers?", pp3.hasSubscribers()); } @Test public void manySourcesIterable() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); - PublishProcessor ps3 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); + PublishProcessor pp3 = PublishProcessor.create(); PublishProcessor main = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(); - main.withLatestFrom(Arrays.>asList(ps1, ps2, ps3), toArray) + main.withLatestFrom(Arrays.>asList(pp1, pp2, pp3), toArray) .subscribe(ts); main.onNext("1"); ts.assertNoValues(); - ps1.onNext("a"); + pp1.onNext("a"); ts.assertNoValues(); - ps2.onNext("A"); + pp2.onNext("A"); ts.assertNoValues(); - ps3.onNext("="); + pp3.onNext("="); ts.assertNoValues(); main.onNext("2"); ts.assertValues("[2, a, A, =]"); - ps2.onNext("B"); + pp2.onNext("B"); ts.assertValues("[2, a, A, =]"); - ps3.onComplete(); + pp3.onComplete(); ts.assertValues("[2, a, A, =]"); - ps1.onNext("b"); + pp1.onNext("b"); main.onNext("3"); @@ -400,9 +400,9 @@ public void manySourcesIterable() { ts.assertNoErrors(); ts.assertComplete(); - assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); - assertFalse("ps3 has subscribers?", ps3.hasSubscribers()); + assertFalse("ps1 has subscribers?", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?", pp2.hasSubscribers()); + assertFalse("ps3 has subscribers?", pp3.hasSubscribers()); } @Test @@ -439,12 +439,12 @@ public void manySourcesIterableSweep() { @Test public void backpressureNoSignal() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(0); - Flowable.range(1, 10).withLatestFrom(new Flowable[] { ps1, ps2 }, toArray) + Flowable.range(1, 10).withLatestFrom(new Flowable[] { pp1, pp2 }, toArray) .subscribe(ts); ts.assertNoValues(); @@ -455,24 +455,24 @@ public void backpressureNoSignal() { ts.assertNoErrors(); ts.assertComplete(); - assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); + assertFalse("ps1 has subscribers?", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?", pp2.hasSubscribers()); } @Test public void backpressureWithSignal() { - PublishProcessor ps1 = PublishProcessor.create(); - PublishProcessor ps2 = PublishProcessor.create(); + PublishProcessor pp1 = PublishProcessor.create(); + PublishProcessor pp2 = PublishProcessor.create(); TestSubscriber ts = new TestSubscriber(0); - Flowable.range(1, 3).withLatestFrom(new Flowable[] { ps1, ps2 }, toArray) + Flowable.range(1, 3).withLatestFrom(new Flowable[] { pp1, pp2 }, toArray) .subscribe(ts); ts.assertNoValues(); - ps1.onNext("1"); - ps2.onNext("1"); + pp1.onNext("1"); + pp2.onNext("1"); ts.request(1); @@ -488,8 +488,8 @@ public void backpressureWithSignal() { ts.assertNoErrors(); ts.assertComplete(); - assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); - assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); + assertFalse("ps1 has subscribers?", pp1.hasSubscribers()); + assertFalse("ps2 has subscribers?", pp2.hasSubscribers()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeCacheTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeCacheTest.java index 652ddf6e0a..57c856b472 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeCacheTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeCacheTest.java @@ -73,7 +73,7 @@ public void onlineSuccess() { assertNotNull(((MaybeCache)source).source.get()); - TestObserver ts = source.test(); + TestObserver to = source.test(); assertNull(((MaybeCache)source).source.get()); @@ -81,12 +81,12 @@ public void onlineSuccess() { source.test(true).assertEmpty(); - ts.assertEmpty(); + to.assertEmpty(); pp.onNext(1); pp.onComplete(); - ts.assertResult(1); + to.assertResult(1); source.test().assertResult(1); @@ -103,7 +103,7 @@ public void onlineError() { assertNotNull(((MaybeCache)source).source.get()); - TestObserver ts = source.test(); + TestObserver to = source.test(); assertNull(((MaybeCache)source).source.get()); @@ -111,11 +111,11 @@ public void onlineError() { source.test(true).assertEmpty(); - ts.assertEmpty(); + to.assertEmpty(); pp.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); source.test().assertFailure(TestException.class); @@ -132,7 +132,7 @@ public void onlineComplete() { assertNotNull(((MaybeCache)source).source.get()); - TestObserver ts = source.test(); + TestObserver to = source.test(); assertNull(((MaybeCache)source).source.get()); @@ -140,11 +140,11 @@ public void onlineComplete() { source.test(true).assertEmpty(); - ts.assertEmpty(); + to.assertEmpty(); pp.onComplete(); - ts.assertResult(); + to.assertResult(); source.test().assertResult(); @@ -246,20 +246,20 @@ public void removeRemoveRace() { final Maybe source = pp.singleElement().cache(); - final TestObserver ts1 = source.test(); - final TestObserver ts2 = source.test(); + final TestObserver to1 = source.test(); + final TestObserver to2 = source.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ts2.cancel(); + to2.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeConcatIterableTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeConcatIterableTest.java index 545c15225f..1ae2ac56bb 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeConcatIterableTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeConcatIterableTest.java @@ -64,7 +64,7 @@ public void successCancelRace() { final PublishProcessor pp = PublishProcessor.create(); - final TestSubscriber to = Maybe.concat(Arrays.asList(pp.singleElement())) + final TestSubscriber ts = Maybe.concat(Arrays.asList(pp.singleElement())) .test(); pp.onNext(1); @@ -72,7 +72,7 @@ public void successCancelRace() { Runnable r1 = new Runnable() { @Override public void run() { - to.cancel(); + ts.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeContainsTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeContainsTest.java index e1172ce5d7..588de845a8 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeContainsTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeContainsTest.java @@ -50,11 +50,11 @@ public void error() { public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().contains(1).test(); + TestObserver to = pp.singleElement().contains(1).test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeCountTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeCountTest.java index be5e117214..3a0d29ab9c 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeCountTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeCountTest.java @@ -45,11 +45,11 @@ public void error() { public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().count().test(); + TestObserver to = pp.singleElement().count().test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayOtherTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayOtherTest.java index ce23150c9a..40cb873836 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayOtherTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayOtherTest.java @@ -33,10 +33,10 @@ public class MaybeDelayOtherTest { public void justWithOnNext() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -44,17 +44,17 @@ public void justWithOnNext() { assertFalse(pp.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @Test public void justWithOnComplete() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -62,7 +62,7 @@ public void justWithOnComplete() { assertFalse(pp.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @@ -70,10 +70,10 @@ public void justWithOnComplete() { public void justWithOnError() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -81,17 +81,17 @@ public void justWithOnError() { assertFalse(pp.hasSubscribers()); - ts.assertFailureAndMessage(TestException.class, "Other"); + to.assertFailureAndMessage(TestException.class, "Other"); } @Test public void emptyWithOnNext() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.empty() + TestObserver to = Maybe.empty() .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -99,7 +99,7 @@ public void emptyWithOnNext() { assertFalse(pp.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @@ -107,10 +107,10 @@ public void emptyWithOnNext() { public void emptyWithOnComplete() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.empty() + TestObserver to = Maybe.empty() .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -118,17 +118,17 @@ public void emptyWithOnComplete() { assertFalse(pp.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @Test public void emptyWithOnError() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.empty() + TestObserver to = Maybe.empty() .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -136,17 +136,17 @@ public void emptyWithOnError() { assertFalse(pp.hasSubscribers()); - ts.assertFailureAndMessage(TestException.class, "Other"); + to.assertFailureAndMessage(TestException.class, "Other"); } @Test public void errorWithOnNext() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.error(new TestException("Main")) + TestObserver to = Maybe.error(new TestException("Main")) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -154,17 +154,17 @@ public void errorWithOnNext() { assertFalse(pp.hasSubscribers()); - ts.assertFailureAndMessage(TestException.class, "Main"); + to.assertFailureAndMessage(TestException.class, "Main"); } @Test public void errorWithOnComplete() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.error(new TestException("Main")) + TestObserver to = Maybe.error(new TestException("Main")) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -172,17 +172,17 @@ public void errorWithOnComplete() { assertFalse(pp.hasSubscribers()); - ts.assertFailureAndMessage(TestException.class, "Main"); + to.assertFailureAndMessage(TestException.class, "Main"); } @Test public void errorWithOnError() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.error(new TestException("Main")) + TestObserver to = Maybe.error(new TestException("Main")) .delay(pp).test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp.hasSubscribers()); @@ -190,9 +190,9 @@ public void errorWithOnError() { assertFalse(pp.hasSubscribers()); - ts.assertFailure(CompositeException.class); + to.assertFailure(CompositeException.class); - List list = TestHelper.compositeList(ts.errors().get(0)); + List list = TestHelper.compositeList(to.errors().get(0)); assertEquals(2, list.size()); TestHelper.assertError(list, 0, TestException.class, "Main"); diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelaySubscriptionTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelaySubscriptionTest.java index a684ff68ff..0b082b5899 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelaySubscriptionTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelaySubscriptionTest.java @@ -36,18 +36,18 @@ public class MaybeDelaySubscriptionTest { public void normal() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Maybe.just(1).delaySubscription(pp) + TestObserver to = Maybe.just(1).delaySubscription(pp) .test(); assertTrue(pp.hasSubscribers()); - ts.assertEmpty(); + to.assertEmpty(); pp.onNext("one"); assertFalse(pp.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -70,19 +70,19 @@ public void timedEmpty() { public void timedTestScheduler() { TestScheduler scheduler = new TestScheduler(); - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .delaySubscription(100, TimeUnit.MILLISECONDS, scheduler) .test(); - ts.assertEmpty(); + to.assertEmpty(); scheduler.advanceTimeBy(99, TimeUnit.MILLISECONDS); - ts.assertEmpty(); + to.assertEmpty(); scheduler.advanceTimeBy(1, TimeUnit.MILLISECONDS); - ts.assertResult(1); + to.assertResult(1); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayTest.java index a392f5f11f..c6b9fdbd4c 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDelayTest.java @@ -66,25 +66,25 @@ public void nullScheduler() { public void disposeDuringDelay() { TestScheduler scheduler = new TestScheduler(); - TestObserver ts = Maybe.just(1).delay(100, TimeUnit.MILLISECONDS, scheduler) + TestObserver to = Maybe.just(1).delay(100, TimeUnit.MILLISECONDS, scheduler) .test(); - ts.cancel(); + to.cancel(); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ts.assertEmpty(); + to.assertEmpty(); } @Test public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().delay(100, TimeUnit.MILLISECONDS).test(); + TestObserver to = pp.singleElement().delay(100, TimeUnit.MILLISECONDS).test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDoAfterSuccessTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDoAfterSuccessTest.java index cee3a213f2..31e046c41f 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeDoAfterSuccessTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeDoAfterSuccessTest.java @@ -38,7 +38,7 @@ public void accept(Integer e) throws Exception { } }; - final TestObserver ts = new TestObserver() { + final TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); @@ -50,7 +50,7 @@ public void onNext(Integer t) { public void just() { Maybe.just(1) .doAfterSuccess(afterSuccess) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -60,7 +60,7 @@ public void just() { public void error() { Maybe.error(new TestException()) .doAfterSuccess(afterSuccess) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); @@ -70,7 +70,7 @@ public void error() { public void empty() { Maybe.empty() .doAfterSuccess(afterSuccess) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(); assertTrue(values.isEmpty()); @@ -86,7 +86,7 @@ public void justConditional() { Maybe.just(1) .doAfterSuccess(afterSuccess) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -97,7 +97,7 @@ public void errorConditional() { Maybe.error(new TestException()) .doAfterSuccess(afterSuccess) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); @@ -108,7 +108,7 @@ public void emptyConditional() { Maybe.empty() .doAfterSuccess(afterSuccess) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(); assertTrue(values.isEmpty()); diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java index bc9617c293..c44782fa3c 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableFlowableTest.java @@ -19,7 +19,7 @@ import java.util.concurrent.TimeUnit; import org.junit.Test; -import org.reactivestreams.*; +import org.reactivestreams.Subscription; import io.reactivex.*; import io.reactivex.exceptions.TestException; @@ -121,7 +121,7 @@ public Iterable apply(Integer v) throws Exception { @Test public void fused() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.just(1).flattenAsFlowable(new Function>() { @Override @@ -129,17 +129,17 @@ public Iterable apply(Integer v) throws Exception { return Arrays.asList(v, v + 1); } }) - .subscribe(to); + .subscribe(ts); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.ASYNC)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2); ; } @Test public void fusedNoSync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Maybe.just(1).flattenAsFlowable(new Function>() { @Override @@ -147,10 +147,10 @@ public Iterable apply(Integer v) throws Exception { return Arrays.asList(v, v + 1); } }) - .subscribe(to); + .subscribe(ts); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.NONE)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2); ; } @@ -305,7 +305,7 @@ public Iterable apply(Object v) throws Exception { public void onSubscribe(Subscription d) { qd = (QueueSubscription)d; - assertEquals(QueueSubscription.ASYNC, qd.requestFusion(QueueSubscription.ANY)); + assertEquals(QueueFuseable.ASYNC, qd.requestFusion(QueueFuseable.ANY)); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java index 5da9082918..c4648d8331 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeFlatMapIterableObservableTest.java @@ -13,10 +13,11 @@ package io.reactivex.internal.operators.maybe; +import static org.junit.Assert.*; + import java.util.*; import java.util.concurrent.TimeUnit; -import static org.junit.Assert.*; import org.junit.Test; import io.reactivex.*; @@ -24,7 +25,7 @@ import io.reactivex.disposables.Disposable; import io.reactivex.exceptions.TestException; import io.reactivex.functions.Function; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.util.CrashingIterable; import io.reactivex.observers.*; import io.reactivex.schedulers.Schedulers; @@ -98,7 +99,7 @@ public Iterable apply(Integer v) throws Exception { @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Maybe.just(1).flattenAsObservable(new Function>() { @Override @@ -109,14 +110,14 @@ public Iterable apply(Integer v) throws Exception { .subscribe(to); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2); ; } @Test public void fusedNoSync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Maybe.just(1).flattenAsObservable(new Function>() { @Override @@ -127,7 +128,7 @@ public Iterable apply(Integer v) throws Exception { .subscribe(to); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.NONE)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2); ; } @@ -307,7 +308,7 @@ public Iterable apply(Object v) throws Exception { public void onSubscribe(Disposable d) { qd = (QueueDisposable)d; - assertEquals(QueueDisposable.ASYNC, qd.requestFusion(QueueDisposable.ANY)); + assertEquals(QueueFuseable.ASYNC, qd.requestFusion(QueueFuseable.ANY)); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeMergeArrayTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeMergeArrayTest.java index 2d65eb5b67..b5833c1941 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeMergeArrayTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeMergeArrayTest.java @@ -23,7 +23,7 @@ import io.reactivex.*; import io.reactivex.disposables.Disposables; import io.reactivex.exceptions.TestException; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.operators.maybe.MaybeMergeArray.MergeMaybeObserver; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.subjects.PublishSubject; @@ -34,26 +34,26 @@ public class MaybeMergeArrayTest { @SuppressWarnings("unchecked") @Test public void normal() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Maybe.mergeArray(Maybe.just(1), Maybe.just(2)) .subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2); } @SuppressWarnings("unchecked") @Test public void fusedPollMixed() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.mergeArray(Maybe.just(1), Maybe.empty(), Maybe.just(2)) .subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2); } @@ -67,7 +67,7 @@ public void fusedEmptyCheck() { public void onSubscribe(Subscription d) { qd = (QueueSubscription)d; - assertEquals(QueueSubscription.ASYNC, qd.requestFusion(QueueSubscription.ANY)); + assertEquals(QueueFuseable.ASYNC, qd.requestFusion(QueueFuseable.ANY)); } @Override @@ -119,13 +119,13 @@ public void firstErrors() { @SuppressWarnings("unchecked") @Test public void errorFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.mergeArray(Maybe.error(new TestException()), Maybe.just(2)) .subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertFailure(TestException.class); } diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeOfTypeTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeOfTypeTest.java index ba93e61c6b..814a0c8e16 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeOfTypeTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeOfTypeTest.java @@ -32,38 +32,38 @@ public void normal() { @Test public void normalDowncast() { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .ofType(Number.class) .test(); // don't make this fluent, target type required! - ts.assertResult((Number)1); + to.assertResult((Number)1); } @Test public void notInstance() { - TestObserver ts = Maybe.just(1) + TestObserver to = Maybe.just(1) .ofType(String.class) .test(); // don't make this fluent, target type required! - ts.assertResult(); + to.assertResult(); } @Test public void error() { - TestObserver ts = Maybe.error(new TestException()) + TestObserver to = Maybe.error(new TestException()) .ofType(Number.class) .test(); // don't make this fluent, target type required! - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void errorNotInstance() { - TestObserver ts = Maybe.error(new TestException()) + TestObserver to = Maybe.error(new TestException()) .ofType(String.class) .test(); // don't make this fluent, target type required! - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptySingleTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptySingleTest.java index 714ba98272..bacd1c1870 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptySingleTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptySingleTest.java @@ -52,11 +52,11 @@ public void errorOther() { public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().switchIfEmpty(Single.just(2)).test(); + TestObserver to = pp.singleElement().switchIfEmpty(Single.just(2)).test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } @@ -84,7 +84,7 @@ public void emptyCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final PublishProcessor pp = PublishProcessor.create(); - final TestObserver ts = pp.singleElement().switchIfEmpty(Single.just(2)).test(); + final TestObserver to = pp.singleElement().switchIfEmpty(Single.just(2)).test(); Runnable r1 = new Runnable() { @Override @@ -96,7 +96,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptyTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptyTest.java index 2ce1d6b8d7..d2e53a7225 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptyTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeSwitchIfEmptyTest.java @@ -67,11 +67,11 @@ public void emptyOtherToo() { public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().switchIfEmpty(Maybe.just(2)).test(); + TestObserver to = pp.singleElement().switchIfEmpty(Maybe.just(2)).test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } @@ -99,7 +99,7 @@ public void emptyCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final PublishProcessor pp = PublishProcessor.create(); - final TestObserver ts = pp.singleElement().switchIfEmpty(Maybe.just(2)).test(); + final TestObserver to = pp.singleElement().switchIfEmpty(Maybe.just(2)).test(); Runnable r1 = new Runnable() { @Override @@ -111,7 +111,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeTimerTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeTimerTest.java index d588be655b..05d33d7175 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeTimerTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeTimerTest.java @@ -38,7 +38,7 @@ public void timerInterruptible() throws Exception { try { for (Scheduler s : new Scheduler[] { Schedulers.single(), Schedulers.computation(), Schedulers.newThread(), Schedulers.io(), Schedulers.from(exec) }) { final AtomicBoolean interrupted = new AtomicBoolean(); - TestObserver ts = Maybe.timer(1, TimeUnit.MILLISECONDS, s) + TestObserver to = Maybe.timer(1, TimeUnit.MILLISECONDS, s) .map(new Function() { @Override public Long apply(Long v) throws Exception { @@ -54,7 +54,7 @@ public Long apply(Long v) throws Exception { Thread.sleep(500); - ts.cancel(); + to.cancel(); Thread.sleep(500); diff --git a/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapMaybeTest.java b/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapMaybeTest.java index 154508bcf7..bdedbd2055 100644 --- a/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapMaybeTest.java +++ b/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapMaybeTest.java @@ -114,9 +114,9 @@ public MaybeSource apply(Integer v) .assertComplete() .assertOf(new Consumer>() { @Override - public void accept(TestObserver ts) throws Exception { + public void accept(TestObserver to) throws Exception { for (int i = 0; i < 512; i ++) { - ts.assertValueAt(i, (i + 1) * 2); + to.assertValueAt(i, (i + 1) * 2); } } }); @@ -143,9 +143,9 @@ public void mainBoundaryErrorInnerSuccess() { PublishSubject ps = PublishSubject.create(); MaybeSubject ms = MaybeSubject.create(); - TestObserver ts = ps.concatMapMaybeDelayError(Functions.justFunction(ms), false).test(); + TestObserver to = ps.concatMapMaybeDelayError(Functions.justFunction(ms), false).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); @@ -155,11 +155,11 @@ public void mainBoundaryErrorInnerSuccess() { assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); } @Test @@ -167,9 +167,9 @@ public void mainBoundaryErrorInnerEmpty() { PublishSubject ps = PublishSubject.create(); MaybeSubject ms = MaybeSubject.create(); - TestObserver ts = ps.concatMapMaybeDelayError(Functions.justFunction(ms), false).test(); + TestObserver to = ps.concatMapMaybeDelayError(Functions.justFunction(ms), false).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); @@ -179,11 +179,11 @@ public void mainBoundaryErrorInnerEmpty() { assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onComplete(); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -264,7 +264,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference>(); - TestObserver ts = ps.concatMapMaybe( + TestObserver to = ps.concatMapMaybe( new Function>() { @Override public MaybeSource apply(Integer v) @@ -286,7 +286,7 @@ protected void subscribeActual( ps.onError(new TestException("outer")); obs.get().onError(new TestException("inner")); - ts.assertFailureAndMessage(TestException.class, "outer"); + to.assertFailureAndMessage(TestException.class, "outer"); TestHelper.assertUndeliverable(errors, 0, TestException.class, "inner"); } finally { @@ -308,8 +308,8 @@ public MaybeSource apply(Integer v) .assertFailure(CompositeException.class) .assertOf(new Consumer>() { @Override - public void accept(TestObserver ts) throws Exception { - CompositeException ce = (CompositeException)ts.errors().get(0); + public void accept(TestObserver to) throws Exception { + CompositeException ce = (CompositeException)to.errors().get(0); assertEquals(5, ce.getExceptions().size()); } }); @@ -319,7 +319,7 @@ public void accept(TestObserver ts) throws Exception { public void mapperCrash() { final PublishSubject ps = PublishSubject.create(); - TestObserver ts = ps + TestObserver to = ps .concatMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) @@ -329,13 +329,13 @@ public MaybeSource apply(Integer v) }) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); ps.onNext(1); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); assertFalse(ps.hasObservers()); } diff --git a/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapSingleTest.java b/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapSingleTest.java index 48a35df533..0a1ff4e1be 100644 --- a/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapSingleTest.java +++ b/src/test/java/io/reactivex/internal/operators/mixed/ObservableConcatMapSingleTest.java @@ -82,9 +82,9 @@ public void mainBoundaryErrorInnerSuccess() { PublishSubject ps = PublishSubject.create(); SingleSubject ms = SingleSubject.create(); - TestObserver ts = ps.concatMapSingleDelayError(Functions.justFunction(ms), false).test(); + TestObserver to = ps.concatMapSingleDelayError(Functions.justFunction(ms), false).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); @@ -94,11 +94,11 @@ public void mainBoundaryErrorInnerSuccess() { assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); } @Test @@ -179,7 +179,7 @@ public void innerErrorAfterMainError() { final AtomicReference> obs = new AtomicReference>(); - TestObserver ts = ps.concatMapSingle( + TestObserver to = ps.concatMapSingle( new Function>() { @Override public SingleSource apply(Integer v) @@ -201,7 +201,7 @@ protected void subscribeActual( ps.onError(new TestException("outer")); obs.get().onError(new TestException("inner")); - ts.assertFailureAndMessage(TestException.class, "outer"); + to.assertFailureAndMessage(TestException.class, "outer"); TestHelper.assertUndeliverable(errors, 0, TestException.class, "inner"); } finally { @@ -223,8 +223,8 @@ public SingleSource apply(Integer v) .assertFailure(CompositeException.class) .assertOf(new Consumer>() { @Override - public void accept(TestObserver ts) throws Exception { - CompositeException ce = (CompositeException)ts.errors().get(0); + public void accept(TestObserver to) throws Exception { + CompositeException ce = (CompositeException)to.errors().get(0); assertEquals(5, ce.getExceptions().size()); } }); @@ -234,7 +234,7 @@ public void accept(TestObserver ts) throws Exception { public void mapperCrash() { final PublishSubject ps = PublishSubject.create(); - TestObserver ts = ps + TestObserver to = ps .concatMapSingle(new Function>() { @Override public SingleSource apply(Integer v) @@ -244,13 +244,13 @@ public SingleSource apply(Integer v) }) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); ps.onNext(1); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); assertFalse(ps.hasObservers()); } @@ -267,9 +267,9 @@ public void mainCompletesWhileInnerActive() { PublishSubject ps = PublishSubject.create(); SingleSubject ms = SingleSubject.create(); - TestObserver ts = ps.concatMapSingleDelayError(Functions.justFunction(ms), false).test(); + TestObserver to = ps.concatMapSingleDelayError(Functions.justFunction(ms), false).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); ps.onNext(2); @@ -277,10 +277,10 @@ public void mainCompletesWhileInnerActive() { assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertResult(1, 1); + to.assertResult(1, 1); } } diff --git a/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapMaybeTest.java b/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapMaybeTest.java index 65f487a14e..4b0046bb61 100644 --- a/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapMaybeTest.java +++ b/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapMaybeTest.java @@ -127,7 +127,7 @@ public void switchOver() { final MaybeSubject ms1 = MaybeSubject.create(); final MaybeSubject ms2 = MaybeSubject.create(); - TestObserver ts = ps.switchMapMaybe(new Function>() { + TestObserver to = ps.switchMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -138,11 +138,11 @@ public MaybeSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms1.hasObservers()); @@ -155,7 +155,7 @@ public MaybeSource apply(Integer v) assertFalse(ps.hasObservers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -165,7 +165,7 @@ public void switchOverDelayError() { final MaybeSubject ms1 = MaybeSubject.create(); final MaybeSubject ms2 = MaybeSubject.create(); - TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -176,11 +176,11 @@ public MaybeSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms1.hasObservers()); @@ -191,13 +191,13 @@ public MaybeSource apply(Integer v) ms2.onError(new TestException()); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); ps.onComplete(); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -206,7 +206,7 @@ public void mainErrorInnerCompleteDelayError() { final MaybeSubject ms = MaybeSubject.create(); - TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -214,11 +214,11 @@ public MaybeSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms.hasObservers()); @@ -226,11 +226,11 @@ public MaybeSource apply(Integer v) assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onComplete(); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -239,7 +239,7 @@ public void mainErrorInnerSuccessDelayError() { final MaybeSubject ms = MaybeSubject.create(); - TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -247,11 +247,11 @@ public MaybeSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms.hasObservers()); @@ -259,11 +259,11 @@ public MaybeSource apply(Integer v) assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); } @Test @@ -282,24 +282,24 @@ public MaybeSource apply(Integer v) @Test public void disposeBeforeSwitchInOnNext() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.just(1) .switchMapMaybe(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { - ts.cancel(); + to.cancel(); return Maybe.just(1); } - }).subscribe(ts); + }).subscribe(to); - ts.assertEmpty(); + to.assertEmpty(); } @Test public void disposeOnNextAfterFirst() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.just(1, 2) .switchMapMaybe(new Function>() { @@ -307,13 +307,13 @@ public void disposeOnNextAfterFirst() { public MaybeSource apply(Integer v) throws Exception { if (v == 2) { - ts.cancel(); + to.cancel(); } return Maybe.just(1); } - }).subscribe(ts); + }).subscribe(to); - ts.assertValue(1) + to.assertValue(1) .assertNoErrors() .assertNotComplete(); } @@ -324,7 +324,7 @@ public void cancel() { final MaybeSubject ms = MaybeSubject.create(); - TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -332,16 +332,16 @@ public MaybeSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); assertTrue(ms.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(ps.hasObservers()); assertFalse(ms.hasObservers()); @@ -382,7 +382,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference>(); - TestObserver ts = new Observable() { + TestObserver to = new Observable() { @Override protected void subscribeActual(Observer s) { s.onSubscribe(Disposables.empty()); @@ -406,7 +406,7 @@ protected void subscribeActual( }) .test(); - ts.assertFailureAndMessage(TestException.class, "outer"); + to.assertFailureAndMessage(TestException.class, "outer"); moRef.get().onError(new TestException("inner")); moRef.get().onComplete(); @@ -425,7 +425,7 @@ public void nextCancelRace() { final MaybeSubject ms = MaybeSubject.create(); - final TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + final TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -443,13 +443,13 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; TestHelper.race(r1, r2); - ts.assertNoErrors() + to.assertNoErrors() .assertNotComplete(); } } @@ -466,7 +466,7 @@ public void nextInnerErrorRace() { final MaybeSubject ms = MaybeSubject.create(); - final TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + final TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -495,9 +495,9 @@ public void run() { TestHelper.race(r1, r2); - if (ts.errorCount() != 0) { + if (to.errorCount() != 0) { assertTrue(errors.isEmpty()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } else if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); } @@ -520,7 +520,7 @@ public void mainErrorInnerErrorRace() { final MaybeSubject ms = MaybeSubject.create(); - final TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + final TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -549,7 +549,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertError(new Predicate() { + to.assertError(new Predicate() { @Override public boolean test(Throwable e) throws Exception { return e instanceof TestException || e instanceof CompositeException; @@ -573,7 +573,7 @@ public void nextInnerSuccessRace() { final MaybeSubject ms = MaybeSubject.create(); - final TestObserver ts = ps.switchMapMaybeDelayError(new Function>() { + final TestObserver to = ps.switchMapMaybeDelayError(new Function>() { @Override public MaybeSource apply(Integer v) throws Exception { @@ -602,7 +602,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertNoErrors() + to.assertNoErrors() .assertNotComplete(); } } diff --git a/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapSingleTest.java b/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapSingleTest.java index cafbf15e4d..10b3dba8d8 100644 --- a/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapSingleTest.java +++ b/src/test/java/io/reactivex/internal/operators/mixed/ObservableSwitchMapSingleTest.java @@ -96,7 +96,7 @@ public void switchOver() { final SingleSubject ms1 = SingleSubject.create(); final SingleSubject ms2 = SingleSubject.create(); - TestObserver ts = ps.switchMapSingle(new Function>() { + TestObserver to = ps.switchMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -107,11 +107,11 @@ public SingleSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms1.hasObservers()); @@ -124,7 +124,7 @@ public SingleSource apply(Integer v) assertFalse(ps.hasObservers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -134,7 +134,7 @@ public void switchOverDelayError() { final SingleSubject ms1 = SingleSubject.create(); final SingleSubject ms2 = SingleSubject.create(); - TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -145,11 +145,11 @@ public SingleSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms1.hasObservers()); @@ -160,13 +160,13 @@ public SingleSource apply(Integer v) ms2.onError(new TestException()); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); ps.onComplete(); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -175,7 +175,7 @@ public void mainErrorInnerCompleteDelayError() { final SingleSubject ms = SingleSubject.create(); - TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -183,11 +183,11 @@ public SingleSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms.hasObservers()); @@ -195,11 +195,11 @@ public SingleSource apply(Integer v) assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); } @Test @@ -208,7 +208,7 @@ public void mainErrorInnerSuccessDelayError() { final SingleSubject ms = SingleSubject.create(); - TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -216,11 +216,11 @@ public SingleSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ms.hasObservers()); @@ -228,11 +228,11 @@ public SingleSource apply(Integer v) assertTrue(ms.hasObservers()); - ts.assertEmpty(); + to.assertEmpty(); ms.onSuccess(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); } @Test @@ -251,24 +251,24 @@ public SingleSource apply(Integer v) @Test public void disposeBeforeSwitchInOnNext() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.just(1) .switchMapSingle(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { - ts.cancel(); + to.cancel(); return Single.just(1); } - }).subscribe(ts); + }).subscribe(to); - ts.assertEmpty(); + to.assertEmpty(); } @Test public void disposeOnNextAfterFirst() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.just(1, 2) .switchMapSingle(new Function>() { @@ -276,13 +276,13 @@ public void disposeOnNextAfterFirst() { public SingleSource apply(Integer v) throws Exception { if (v == 2) { - ts.cancel(); + to.cancel(); } return Single.just(1); } - }).subscribe(ts); + }).subscribe(to); - ts.assertValue(1) + to.assertValue(1) .assertNoErrors() .assertNotComplete(); } @@ -293,7 +293,7 @@ public void cancel() { final SingleSubject ms = SingleSubject.create(); - TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -301,16 +301,16 @@ public SingleSource apply(Integer v) } }).test(); - ts.assertEmpty(); + to.assertEmpty(); ps.onNext(1); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(ps.hasObservers()); assertTrue(ms.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(ps.hasObservers()); assertFalse(ms.hasObservers()); @@ -351,7 +351,7 @@ public void innerErrorAfterTermination() { try { final AtomicReference> moRef = new AtomicReference>(); - TestObserver ts = new Observable() { + TestObserver to = new Observable() { @Override protected void subscribeActual(Observer s) { s.onSubscribe(Disposables.empty()); @@ -375,7 +375,7 @@ protected void subscribeActual( }) .test(); - ts.assertFailureAndMessage(TestException.class, "outer"); + to.assertFailureAndMessage(TestException.class, "outer"); moRef.get().onError(new TestException("inner")); @@ -393,7 +393,7 @@ public void nextCancelRace() { final SingleSubject ms = SingleSubject.create(); - final TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + final TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -411,13 +411,13 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; TestHelper.race(r1, r2); - ts.assertNoErrors() + to.assertNoErrors() .assertNotComplete(); } } @@ -434,7 +434,7 @@ public void nextInnerErrorRace() { final SingleSubject ms = SingleSubject.create(); - final TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + final TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -463,9 +463,9 @@ public void run() { TestHelper.race(r1, r2); - if (ts.errorCount() != 0) { + if (to.errorCount() != 0) { assertTrue(errors.isEmpty()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } else if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); } @@ -488,7 +488,7 @@ public void mainErrorInnerErrorRace() { final SingleSubject ms = SingleSubject.create(); - final TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + final TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -517,7 +517,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertError(new Predicate() { + to.assertError(new Predicate() { @Override public boolean test(Throwable e) throws Exception { return e instanceof TestException || e instanceof CompositeException; @@ -541,7 +541,7 @@ public void nextInnerSuccessRace() { final SingleSubject ms = SingleSubject.create(); - final TestObserver ts = ps.switchMapSingleDelayError(new Function>() { + final TestObserver to = ps.switchMapSingleDelayError(new Function>() { @Override public SingleSource apply(Integer v) throws Exception { @@ -570,7 +570,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertNoErrors() + to.assertNoErrors() .assertNotComplete(); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableAllTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableAllTest.java index 29d2f8eff0..d37fc5fb74 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableAllTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableAllTest.java @@ -146,7 +146,7 @@ public Observable apply(Boolean t1) { @Test public void testPredicateThrowsExceptionAndValueInCauseMessageObservable() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); @@ -156,12 +156,12 @@ public boolean test(String v) { throw ex; } }) - .subscribe(ts); + .subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME need to decide about adding the value that probably caused the crash in some way // assertTrue(ex.getCause().getMessage().contains("Boo!")); } @@ -278,7 +278,7 @@ public Observable apply(Boolean t1) { @Test public void testPredicateThrowsExceptionAndValueInCauseMessage() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); @@ -288,12 +288,12 @@ public boolean test(String v) { throw ex; } }) - .subscribe(ts); + .subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME need to decide about adding the value that probably caused the crash in some way // assertTrue(ex.getCause().getMessage().contains("Boo!")); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableAmbTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableAmbTest.java index 932b40187c..497b2894d9 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableAmbTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableAmbTest.java @@ -176,10 +176,10 @@ public void accept(Disposable s) { //this stream emits second Observable o2 = Observable.just(1).doOnSubscribe(incrementer) .delay(100, TimeUnit.MILLISECONDS).subscribeOn(Schedulers.computation()); - TestObserver ts = new TestObserver(); - Observable.ambArray(o1, o2).subscribe(ts); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); - ts.assertNoErrors(); + TestObserver to = new TestObserver(); + Observable.ambArray(o1, o2).subscribe(to); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); + to.assertNoErrors(); assertEquals(2, count.get()); } @@ -210,9 +210,9 @@ public void testAmbCancelsOthers() { PublishSubject source2 = PublishSubject.create(); PublishSubject source3 = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.ambArray(source1, source2, source3).subscribe(ts); + Observable.ambArray(source1, source2, source3).subscribe(to); assertTrue("Source 1 doesn't have subscribers!", source1.hasObservers()); assertTrue("Source 2 doesn't have subscribers!", source2.hasObservers()); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableAnyTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableAnyTest.java index 3ad9314430..5ada2a774e 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableAnyTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableAnyTest.java @@ -246,7 +246,7 @@ public Observable apply(Boolean t1) { @Test public void testPredicateThrowsExceptionAndValueInCauseMessageObservable() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); Observable.just("Boo!").any(new Predicate() { @@ -254,12 +254,12 @@ public void testPredicateThrowsExceptionAndValueInCauseMessageObservable() { public boolean test(String v) { throw ex; } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME value as last cause? // assertTrue(ex.getCause().getMessage().contains("Boo!")); } @@ -467,7 +467,7 @@ public Observable apply(Boolean t1) { @Test public void testPredicateThrowsExceptionAndValueInCauseMessage() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final IllegalArgumentException ex = new IllegalArgumentException(); Observable.just("Boo!").any(new Predicate() { @@ -475,12 +475,12 @@ public void testPredicateThrowsExceptionAndValueInCauseMessage() { public boolean test(String v) { throw ex; } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(ex); + to.assertTerminated(); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(ex); // FIXME value as last cause? // assertTrue(ex.getCause().getMessage().contains("Boo!")); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableBufferTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableBufferTest.java index 517a99a3c6..1e7407c121 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableBufferTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableBufferTest.java @@ -344,7 +344,7 @@ public void testBufferStopsWhenUnsubscribed1() { Observable source = Observable.never(); Observer> o = TestHelper.mockObserver(); - TestObserver> ts = new TestObserver>(o); + TestObserver> to = new TestObserver>(o); source.buffer(100, 200, TimeUnit.MILLISECONDS, scheduler) .doOnNext(new Consumer>() { @@ -353,7 +353,7 @@ public void accept(List pv) { System.out.println(pv); } }) - .subscribe(ts); + .subscribe(to); InOrder inOrder = Mockito.inOrder(o); @@ -361,7 +361,7 @@ public void accept(List pv) { inOrder.verify(o, times(5)).onNext(Arrays. asList()); - ts.dispose(); + to.dispose(); scheduler.advanceTimeBy(999, TimeUnit.MILLISECONDS); @@ -1104,9 +1104,9 @@ public Collection call() throws Exception { @Test public void boundaryCancel() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver> ts = pp + TestObserver> to = ps .buffer(Functions.justCallable(Observable.never()), new Callable>() { @Override public Collection call() throws Exception { @@ -1115,11 +1115,11 @@ public Collection call() throws Exception { }) .test(); - assertTrue(pp.hasObservers()); + assertTrue(ps.hasObservers()); - ts.dispose(); + to.dispose(); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); } @Test @@ -1173,9 +1173,9 @@ public Collection call() throws Exception { @SuppressWarnings("unchecked") @Test public void boundaryMainError() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver> ts = pp + TestObserver> to = ps .buffer(Functions.justCallable(Observable.never()), new Callable>() { @Override public Collection call() throws Exception { @@ -1184,17 +1184,17 @@ public Collection call() throws Exception { }) .test(); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @SuppressWarnings("unchecked") @Test public void boundaryBoundaryError() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver> ts = pp + TestObserver> to = ps .buffer(Functions.justCallable(Observable.error(new TestException())), new Callable>() { @Override public Collection call() throws Exception { @@ -1203,9 +1203,9 @@ public Collection call() throws Exception { }) .test(); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -1409,7 +1409,7 @@ public void withTimeAndSizeCapacityRace() { final PublishSubject ps = PublishSubject.create(); - TestObserver> ts = ps.buffer(1, TimeUnit.SECONDS, scheduler, 5).test(); + TestObserver> to = ps.buffer(1, TimeUnit.SECONDS, scheduler, 5).test(); ps.onNext(1); ps.onNext(2); @@ -1435,7 +1435,7 @@ public void run() { ps.onComplete(); int items = 0; - for (List o : ts.values()) { + for (List o : to.values()) { items += o.size(); } @@ -1512,7 +1512,7 @@ public void boundaryOpenCloseDisposedOnComplete() { PublishSubject closeIndicator = PublishSubject.create(); - TestObserver> ts = source + TestObserver> to = source .buffer(openIndicator, Functions.justFunction(closeIndicator)) .test(); @@ -1527,7 +1527,7 @@ public void boundaryOpenCloseDisposedOnComplete() { source.onComplete(); - ts.assertResult(Collections.emptyList()); + to.assertResult(Collections.emptyList()); assertFalse(openIndicator.hasObservers()); assertFalse(closeIndicator.hasObservers()); @@ -1635,7 +1635,7 @@ public void openCloseOpenCompletes() { PublishSubject closeIndicator = PublishSubject.create(); - TestObserver> ts = source + TestObserver> to = source .buffer(openIndicator, Functions.justFunction(closeIndicator)) .test(); @@ -1652,7 +1652,7 @@ public void openCloseOpenCompletes() { assertFalse(source.hasObservers()); - ts.assertResult(Collections.emptyList()); + to.assertResult(Collections.emptyList()); } @Test @@ -1664,7 +1664,7 @@ public void openCloseOpenCompletesNoBuffers() { PublishSubject closeIndicator = PublishSubject.create(); - TestObserver> ts = source + TestObserver> to = source .buffer(openIndicator, Functions.justFunction(closeIndicator)) .test(); @@ -1681,7 +1681,7 @@ public void openCloseOpenCompletesNoBuffers() { assertFalse(source.hasObservers()); - ts.assertResult(Collections.emptyList()); + to.assertResult(Collections.emptyList()); } @Test @@ -1693,7 +1693,7 @@ public void openCloseTake() { PublishSubject closeIndicator = PublishSubject.create(); - TestObserver> ts = source + TestObserver> to = source .buffer(openIndicator, Functions.justFunction(closeIndicator)) .take(1) .test(); @@ -1705,7 +1705,7 @@ public void openCloseTake() { assertFalse(openIndicator.hasObservers()); assertFalse(closeIndicator.hasObservers()); - ts.assertResult(Collections.emptyList()); + to.assertResult(Collections.emptyList()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableCacheTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableCacheTest.java index e7d7e35f16..c664c2591c 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableCacheTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableCacheTest.java @@ -39,16 +39,16 @@ public void testColdReplayNoBackpressure() { assertFalse("Source is connected!", source.isConnected()); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.subscribe(ts); + source.subscribe(to); assertTrue("Source is not connected!", source.isConnected()); assertFalse("Subscribers retained!", source.hasObservers()); - ts.assertNoErrors(); - ts.assertTerminated(); - List onNextEvents = ts.values(); + to.assertNoErrors(); + to.assertTerminated(); + List onNextEvents = to.values(); assertEquals(1000, onNextEvents.size()); for (int i = 0; i < 1000; i++) { @@ -118,14 +118,14 @@ public void testUnsubscribeSource() throws Exception { @Test public void testTake() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); ObservableCache cached = (ObservableCache)ObservableCache.from(Observable.range(1, 100)); - cached.take(10).subscribe(ts); + cached.take(10).subscribe(to); - ts.assertNoErrors(); - ts.assertComplete(); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertNoErrors(); + to.assertComplete(); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); // ts.assertUnsubscribed(); // FIXME no longer valid assertFalse(cached.hasObservers()); } @@ -134,24 +134,24 @@ public void testTake() { public void testAsync() { Observable source = Observable.range(1, 10000); for (int i = 0; i < 100; i++) { - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); ObservableCache cached = (ObservableCache)ObservableCache.from(source); - cached.observeOn(Schedulers.computation()).subscribe(ts1); + cached.observeOn(Schedulers.computation()).subscribe(to1); - ts1.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts1.assertNoErrors(); - ts1.assertComplete(); - assertEquals(10000, ts1.values().size()); + to1.awaitTerminalEvent(2, TimeUnit.SECONDS); + to1.assertNoErrors(); + to1.assertComplete(); + assertEquals(10000, to1.values().size()); - TestObserver ts2 = new TestObserver(); - cached.observeOn(Schedulers.computation()).subscribe(ts2); + TestObserver to2 = new TestObserver(); + cached.observeOn(Schedulers.computation()).subscribe(to2); - ts2.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts2.assertNoErrors(); - ts2.assertComplete(); - assertEquals(10000, ts2.values().size()); + to2.awaitTerminalEvent(2, TimeUnit.SECONDS); + to2.assertNoErrors(); + to2.assertComplete(); + assertEquals(10000, to2.values().size()); } } @Test @@ -165,9 +165,9 @@ public void testAsyncComeAndGo() { List> list = new ArrayList>(100); for (int i = 0; i < 100; i++) { - TestObserver ts = new TestObserver(); - list.add(ts); - output.skip(i * 10).take(10).subscribe(ts); + TestObserver to = new TestObserver(); + list.add(to); + output.skip(i * 10).take(10).subscribe(to); } List expected = new ArrayList(); @@ -175,16 +175,16 @@ public void testAsyncComeAndGo() { expected.add((long)(i - 10)); } int j = 0; - for (TestObserver ts : list) { - ts.awaitTerminalEvent(3, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertComplete(); + for (TestObserver to : list) { + to.awaitTerminalEvent(3, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertComplete(); for (int i = j * 10; i < j * 10 + 10; i++) { expected.set(i - j * 10, (long)i); } - ts.assertValueSequence(expected); + to.assertValueSequence(expected); j++; } @@ -204,14 +204,14 @@ public void subscribe(Observer t) { } }); - TestObserver ts = new TestObserver(); - firehose.cache().observeOn(Schedulers.computation()).takeLast(100).subscribe(ts); + TestObserver to = new TestObserver(); + firehose.cache().observeOn(Schedulers.computation()).takeLast(100).subscribe(to); - ts.awaitTerminalEvent(3, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertComplete(); + to.awaitTerminalEvent(3, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertComplete(); - assertEquals(100, ts.values().size()); + assertEquals(100, to.values().size()); } @Test @@ -221,19 +221,19 @@ public void testValuesAndThenError() { .cache(); - TestObserver ts = new TestObserver(); - source.subscribe(ts); + TestObserver to = new TestObserver(); + source.subscribe(to); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertNotComplete(); + to.assertError(TestException.class); - TestObserver ts2 = new TestObserver(); - source.subscribe(ts2); + TestObserver to2 = new TestObserver(); + source.subscribe(to2); - ts2.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); - ts2.assertNotComplete(); - ts2.assertError(TestException.class); + to2.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to2.assertNotComplete(); + to2.assertError(TestException.class); } @Test @@ -250,20 +250,20 @@ public void accept(Integer t) { }) .cache(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { throw new TestException(); } }; - source.subscribe(ts); + source.subscribe(to); Assert.assertEquals(100, count.get()); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableCombineLatestTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableCombineLatestTest.java index 7595a9b893..cee12d300e 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableCombineLatestTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableCombineLatestTest.java @@ -756,14 +756,14 @@ public void accept(Notification n) { } }).take(SIZE); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.combineLatest(timer, Observable. never(), new BiFunction() { @Override public Long apply(Long t1, Integer t2) { return t1; } - }).subscribe(ts); + }).subscribe(to); if (!latch.await(SIZE + 1000, TimeUnit.MILLISECONDS)) { fail("timed out"); @@ -1170,7 +1170,7 @@ public void eagerDispose() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); @@ -1192,11 +1192,11 @@ public Integer apply(Integer t1, Integer t2) throws Exception { return t1 + t2; } }) - .subscribe(ts); + .subscribe(to); ps1.onNext(1); ps2.onNext(2); - ts.assertResult(3); + to.assertResult(3); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatMapEagerTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatMapEagerTest.java index 593febc4eb..8874eec137 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatMapEagerTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatMapEagerTest.java @@ -50,7 +50,7 @@ public ObservableSource apply(Integer t) { @Test @Ignore("Observable doesn't do backpressure") public void normalBackpressured() { -// TestObserver ts = Observable.range(1, 5) +// TestObserver to = Observable.range(1, 5) // .concatMapEager(new Function>() { // @Override // public ObservableSource apply(Integer t) { @@ -59,19 +59,19 @@ public void normalBackpressured() { // }) // .test(3); // -// ts.assertValues(1, 2, 2); +// to.assertValues(1, 2, 2); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3); +// to.assertValues(1, 2, 2, 3); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3, 3); +// to.assertValues(1, 2, 2, 3, 3); // -// ts.request(5); +// to.request(5); // -// ts.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); +// to.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); } @Test @@ -90,7 +90,7 @@ public ObservableSource apply(Integer t) { @Test @Ignore("Observable doesn't do backpressure") public void normalDelayBoundaryBackpressured() { -// TestObserver ts = Observable.range(1, 5) +// TestObserver to = Observable.range(1, 5) // .concatMapEagerDelayError(new Function>() { // @Override // public ObservableSource apply(Integer t) { @@ -99,19 +99,19 @@ public void normalDelayBoundaryBackpressured() { // }, false) // .test(3); // -// ts.assertValues(1, 2, 2); +// to.assertValues(1, 2, 2); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3); +// to.assertValues(1, 2, 2, 3); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3, 3); +// to.assertValues(1, 2, 2, 3, 3); // -// ts.request(5); +// to.request(5); // -// ts.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); +// to.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); } @Test @@ -130,7 +130,7 @@ public ObservableSource apply(Integer t) { @Test @Ignore("Observable doesn't do backpressure") public void normalDelayEndBackpressured() { -// TestObserver ts = Observable.range(1, 5) +// TestObserver to = Observable.range(1, 5) // .concatMapEagerDelayError(new Function>() { // @Override // public ObservableSource apply(Integer t) { @@ -139,19 +139,19 @@ public void normalDelayEndBackpressured() { // }, true) // .test(3); // -// ts.assertValues(1, 2, 2); +// to.assertValues(1, 2, 2); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3); +// to.assertValues(1, 2, 2, 3); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 2, 3, 3); +// to.assertValues(1, 2, 2, 3, 3); // -// ts.request(5); +// to.request(5); // -// ts.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); +// to.assertResult(1, 2, 2, 3, 3, 4, 4, 5, 5, 6); } @Test @@ -159,7 +159,7 @@ public void mainErrorsDelayBoundary() { PublishSubject main = PublishSubject.create(); final PublishSubject inner = PublishSubject.create(); - TestObserver ts = main.concatMapEagerDelayError( + TestObserver to = main.concatMapEagerDelayError( new Function>() { @Override public ObservableSource apply(Integer t) { @@ -171,16 +171,16 @@ public ObservableSource apply(Integer t) { inner.onNext(2); - ts.assertValue(2); + to.assertValue(2); main.onError(new TestException("Forced failure")); - ts.assertNoErrors(); + to.assertNoErrors(); inner.onNext(3); inner.onComplete(); - ts.assertFailureAndMessage(TestException.class, "Forced failure", 2, 3); + to.assertFailureAndMessage(TestException.class, "Forced failure", 2, 3); } @Test @@ -188,7 +188,7 @@ public void mainErrorsDelayEnd() { PublishSubject main = PublishSubject.create(); final PublishSubject inner = PublishSubject.create(); - TestObserver ts = main.concatMapEagerDelayError( + TestObserver to = main.concatMapEagerDelayError( new Function>() { @Override public ObservableSource apply(Integer t) { @@ -201,16 +201,16 @@ public ObservableSource apply(Integer t) { inner.onNext(2); - ts.assertValue(2); + to.assertValue(2); main.onError(new TestException("Forced failure")); - ts.assertNoErrors(); + to.assertNoErrors(); inner.onNext(3); inner.onComplete(); - ts.assertFailureAndMessage(TestException.class, "Forced failure", 2, 3, 2, 3); + to.assertFailureAndMessage(TestException.class, "Forced failure", 2, 3, 2, 3); } @Test @@ -218,7 +218,7 @@ public void mainErrorsImmediate() { PublishSubject main = PublishSubject.create(); final PublishSubject inner = PublishSubject.create(); - TestObserver ts = main.concatMapEager( + TestObserver to = main.concatMapEager( new Function>() { @Override public ObservableSource apply(Integer t) { @@ -231,7 +231,7 @@ public ObservableSource apply(Integer t) { inner.onNext(2); - ts.assertValue(2); + to.assertValue(2); main.onError(new TestException("Forced failure")); @@ -240,7 +240,7 @@ public ObservableSource apply(Integer t) { inner.onNext(3); inner.onComplete(); - ts.assertFailureAndMessage(TestException.class, "Forced failure", 2); + to.assertFailureAndMessage(TestException.class, "Forced failure", 2); } @Test @@ -259,7 +259,7 @@ public ObservableSource apply(Integer v) { .assertComplete(); } - TestObserver ts; + TestObserver to; Function> toJust = new Function>() { @Override @@ -277,25 +277,25 @@ public Observable apply(Integer t) { @Before public void before() { - ts = new TestObserver(); + to = new TestObserver(); } @Test public void testSimple() { - Observable.range(1, 100).concatMapEager(toJust).subscribe(ts); + Observable.range(1, 100).concatMapEager(toJust).subscribe(to); - ts.assertNoErrors(); - ts.assertValueCount(100); - ts.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(100); + to.assertComplete(); } @Test public void testSimple2() { - Observable.range(1, 100).concatMapEager(toRange).subscribe(ts); + Observable.range(1, 100).concatMapEager(toRange).subscribe(to); - ts.assertNoErrors(); - ts.assertValueCount(200); - ts.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(200); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -309,13 +309,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source).subscribe(ts); + Observable.concatArrayEager(source, source).subscribe(to); Assert.assertEquals(2, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -329,13 +329,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source).subscribe(to); Assert.assertEquals(3, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -349,13 +349,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source).subscribe(to); Assert.assertEquals(4, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -369,13 +369,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source, source).subscribe(to); Assert.assertEquals(5, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -389,13 +389,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source, source, source).subscribe(to); Assert.assertEquals(6, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -409,13 +409,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source, source, source, source).subscribe(to); Assert.assertEquals(7, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -429,13 +429,13 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source, source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source, source, source, source, source).subscribe(to); Assert.assertEquals(8, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") @@ -449,22 +449,22 @@ public void accept(Integer t) { } }).hide(); - Observable.concatArrayEager(source, source, source, source, source, source, source, source, source).subscribe(ts); + Observable.concatArrayEager(source, source, source, source, source, source, source, source, source).subscribe(to); Assert.assertEquals(9, count.get()); - ts.assertValueCount(count.get()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(count.get()); + to.assertNoErrors(); + to.assertComplete(); } @Test public void testMainError() { - Observable.error(new TestException()).concatMapEager(toJust).subscribe(ts); + Observable.error(new TestException()).concatMapEager(toJust).subscribe(to); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @SuppressWarnings("unchecked") @@ -475,23 +475,23 @@ public void testInnerError() { PublishSubject ps = PublishSubject.create(); Observable.concatArrayEager(Observable.just(1), ps) - .subscribe(ts); + .subscribe(to); ps.onError(new TestException()); - ts.assertValue(1); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertValue(1); + to.assertError(TestException.class); + to.assertNotComplete(); } @SuppressWarnings("unchecked") @Test public void testInnerEmpty() { - Observable.concatArrayEager(Observable.empty(), Observable.empty()).subscribe(ts); + Observable.concatArrayEager(Observable.empty(), Observable.empty()).subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertComplete(); } @Test @@ -501,11 +501,11 @@ public void testMapperThrows() { public Observable apply(Integer t) { throw new TestException(); } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test(expected = IllegalArgumentException.class) @@ -546,11 +546,11 @@ public void testAsynchronousRun() { public Observable apply(Integer t) { return Observable.range(1, 1000).subscribeOn(Schedulers.computation()); } - }).observeOn(Schedulers.newThread()).subscribe(ts); + }).observeOn(Schedulers.newThread()).subscribe(to); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertValueCount(2000); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertValueCount(2000); } @Test @@ -573,13 +573,13 @@ public void accept(Integer t) { } } }) - .subscribe(ts); + .subscribe(to); subject.onNext(1); - ts.assertNoErrors(); - ts.assertNotComplete(); - ts.assertValues(1, 2); + to.assertNoErrors(); + to.assertNotComplete(); + to.assertValues(1, 2); } @Test @@ -587,7 +587,7 @@ public void accept(Integer t) { public void testPrefetchIsBounded() { final AtomicInteger count = new AtomicInteger(); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); Observable.just(1).concatMapEager(new Function>() { @Override @@ -600,11 +600,11 @@ public void accept(Integer t) { } }).hide(); } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoErrors(); - ts.assertNoValues(); - ts.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); + to.assertNotComplete(); Assert.assertEquals(Observable.bufferSize(), count.get()); } @@ -616,11 +616,11 @@ public void testInnerNull() { public Observable apply(Integer t) { return Observable.just(null); } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoErrors(); - ts.assertComplete(); - ts.assertValue(null); + to.assertNoErrors(); + to.assertComplete(); + to.assertValue(null); } @@ -663,13 +663,13 @@ public void many() throws Exception { Method m = Observable.class.getMethod("concatEager", clazz); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ((Observable)m.invoke(null, (Object[])obs)).subscribe(ts); + ((Observable)m.invoke(null, (Object[])obs)).subscribe(to); - ts.assertValues(expected); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues(expected); + to.assertNoErrors(); + to.assertComplete(); } } @@ -677,37 +677,37 @@ public void many() throws Exception { @Test public void capacityHint() { Observable source = Observable.just(1); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - Observable.concatEager(Arrays.asList(source, source, source), 1, 1).subscribe(ts); + Observable.concatEager(Arrays.asList(source, source, source), 1, 1).subscribe(to); - ts.assertValues(1, 1, 1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues(1, 1, 1); + to.assertNoErrors(); + to.assertComplete(); } @Test public void Observable() { Observable source = Observable.just(1); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - Observable.concatEager(Observable.just(source, source, source)).subscribe(ts); + Observable.concatEager(Observable.just(source, source, source)).subscribe(to); - ts.assertValues(1, 1, 1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues(1, 1, 1); + to.assertNoErrors(); + to.assertComplete(); } @Test public void ObservableCapacityHint() { Observable source = Observable.just(1); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - Observable.concatEager(Observable.just(source, source, source), 1, 1).subscribe(ts); + Observable.concatEager(Observable.just(source, source, source), 1, 1).subscribe(to); - ts.assertValues(1, 1, 1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues(1, 1, 1); + to.assertNoErrors(); + to.assertComplete(); } @SuppressWarnings("unchecked") diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatTest.java index 2a158cb714..f1f95d2f68 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatTest.java @@ -393,17 +393,17 @@ public void testConcatUnsubscribe() { final TestObservable w2 = new TestObservable(callOnce, okToContinue, "four", "five", "six"); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); final Observable concat = Observable.concat(Observable.unsafeCreate(w1), Observable.unsafeCreate(w2)); try { // Subscribe - concat.subscribe(ts); + concat.subscribe(to); //Block main thread to allow Observable "w1" to complete and Observable "w2" to call onNext once. callOnce.await(); // Unsubcribe - ts.dispose(); + to.dispose(); //Unblock the Observable to continue. okToContinue.countDown(); w1.t.join(); @@ -435,19 +435,19 @@ public void testConcatUnsubscribeConcurrent() { final TestObservable w2 = new TestObservable(callOnce, okToContinue, "four", "five", "six"); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); @SuppressWarnings("unchecked") TestObservable> observableOfObservables = new TestObservable>(Observable.unsafeCreate(w1), Observable.unsafeCreate(w2)); Observable concatF = Observable.concat(Observable.unsafeCreate(observableOfObservables)); - concatF.subscribe(ts); + concatF.subscribe(to); try { //Block main thread to allow Observable "w1" to complete and Observable "w2" to call onNext exactly once. callOnce.await(); //"four" from w2 has been processed by onNext() - ts.dispose(); + to.dispose(); //"five" and "six" will NOT be processed by onNext() //Unblock the Observable to continue. okToContinue.countDown(); @@ -672,12 +672,12 @@ public void subscribe(Observer s) { }); - TestObserver ts = new TestObserver(); - Observable.concat(o, o).subscribe(ts); - ts.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValues("hello", "hello"); + TestObserver to = new TestObserver(); + Observable.concat(o, o).subscribe(to); + to.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValues("hello", "hello"); } @Test(timeout = 30000) @@ -743,7 +743,7 @@ public void concatMapRangeAsyncLoopIssue2876() { if (i % 1000 == 0) { System.out.println("concatMapRangeAsyncLoop > " + i); } - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 1000) .concatMap(new Function>() { @Override @@ -751,13 +751,13 @@ public Observable apply(Integer t) { return Observable.fromIterable(Arrays.asList(t)); } }) - .observeOn(Schedulers.computation()).subscribe(ts); + .observeOn(Schedulers.computation()).subscribe(to); - ts.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - assertEquals(1000, ts.valueCount()); - assertEquals((Integer)999, ts.values().get(999)); + to.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); + to.assertTerminated(); + to.assertNoErrors(); + assertEquals(1000, to.valueCount()); + assertEquals((Integer)999, to.values().get(999)); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithCompletableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithCompletableTest.java index c2ad3b5ae1..e6a17f1d5a 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithCompletableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithCompletableTest.java @@ -28,75 +28,75 @@ public class ObservableConcatWithCompletableTest { @Test public void normal() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Completable.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3, 4, 5, 100); + to.assertResult(1, 2, 3, 4, 5, 100); } @Test public void mainError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.error(new TestException()) .concatWith(Completable.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void otherError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Completable.error(new TestException())) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class, 1, 2, 3, 4, 5); + to.assertFailure(TestException.class, 1, 2, 3, 4, 5); } @Test public void takeMain() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Completable.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) .take(3) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3); + to.assertResult(1, 2, 3); } @Test public void cancelOther() { CompletableSubject other = CompletableSubject.create(); - TestObserver ts = Observable.empty() + TestObserver to = Observable.empty() .concatWith(other) .test(); assertTrue(other.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(other.hasObservers()); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithMaybeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithMaybeTest.java index 586d9315e4..3d323a979a 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithMaybeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithMaybeTest.java @@ -28,87 +28,87 @@ public class ObservableConcatWithMaybeTest { @Test public void normalEmpty() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Maybe.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3, 4, 5, 100); + to.assertResult(1, 2, 3, 4, 5, 100); } @Test public void normalNonEmpty() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Maybe.just(100)) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3, 4, 5, 100); + to.assertResult(1, 2, 3, 4, 5, 100); } @Test public void mainError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.error(new TestException()) .concatWith(Maybe.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void otherError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Maybe.error(new TestException())) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class, 1, 2, 3, 4, 5); + to.assertFailure(TestException.class, 1, 2, 3, 4, 5); } @Test public void takeMain() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Maybe.fromAction(new Action() { @Override public void run() throws Exception { - ts.onNext(100); + to.onNext(100); } })) .take(3) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3); + to.assertResult(1, 2, 3); } @Test public void cancelOther() { MaybeSubject other = MaybeSubject.create(); - TestObserver ts = Observable.empty() + TestObserver to = Observable.empty() .concatWith(other) .test(); assertTrue(other.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(other.hasObservers()); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithSingleTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithSingleTest.java index 5fc06d83e3..3de6edfd0f 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithSingleTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableConcatWithSingleTest.java @@ -27,60 +27,60 @@ public class ObservableConcatWithSingleTest { @Test public void normal() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Single.just(100)) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3, 4, 5, 100); + to.assertResult(1, 2, 3, 4, 5, 100); } @Test public void mainError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.error(new TestException()) .concatWith(Single.just(100)) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void otherError() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Single.error(new TestException())) - .subscribe(ts); + .subscribe(to); - ts.assertFailure(TestException.class, 1, 2, 3, 4, 5); + to.assertFailure(TestException.class, 1, 2, 3, 4, 5); } @Test public void takeMain() { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Observable.range(1, 5) .concatWith(Single.just(100)) .take(3) - .subscribe(ts); + .subscribe(to); - ts.assertResult(1, 2, 3); + to.assertResult(1, 2, 3); } @Test public void cancelOther() { SingleSubject other = SingleSubject.create(); - TestObserver ts = Observable.empty() + TestObserver to = Observable.empty() .concatWith(other) .test(); assertTrue(other.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(other.hasObservers()); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelaySubscriptionOtherTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelaySubscriptionOtherTest.java index 566bf0ffb3..6c416421a7 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelaySubscriptionOtherTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelaySubscriptionOtherTest.java @@ -31,7 +31,7 @@ public class ObservableDelaySubscriptionOtherTest { public void testNoPrematureSubscription() { PublishSubject other = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger subscribed = new AtomicInteger(); @@ -43,11 +43,11 @@ public void accept(Disposable d) { } }) .delaySubscription(other) - .subscribe(ts); + .subscribe(to); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); Assert.assertEquals("Premature subscription", 0, subscribed.get()); @@ -55,16 +55,16 @@ public void accept(Disposable d) { Assert.assertEquals("No subscription", 1, subscribed.get()); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(1); + to.assertNoErrors(); + to.assertComplete(); } @Test public void testNoMultipleSubscriptions() { PublishSubject other = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger subscribed = new AtomicInteger(); @@ -76,11 +76,11 @@ public void accept(Disposable d) { } }) .delaySubscription(other) - .subscribe(ts); + .subscribe(to); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); Assert.assertEquals("Premature subscription", 0, subscribed.get()); @@ -89,16 +89,16 @@ public void accept(Disposable d) { Assert.assertEquals("No subscription", 1, subscribed.get()); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(1); + to.assertNoErrors(); + to.assertComplete(); } @Test public void testCompleteTriggersSubscription() { PublishSubject other = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger subscribed = new AtomicInteger(); @@ -110,11 +110,11 @@ public void accept(Disposable d) { } }) .delaySubscription(other) - .subscribe(ts); + .subscribe(to); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); Assert.assertEquals("Premature subscription", 0, subscribed.get()); @@ -122,16 +122,16 @@ public void accept(Disposable d) { Assert.assertEquals("No subscription", 1, subscribed.get()); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(1); + to.assertNoErrors(); + to.assertComplete(); } @Test public void testNoPrematureSubscriptionToError() { PublishSubject other = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger subscribed = new AtomicInteger(); @@ -143,11 +143,11 @@ public void accept(Disposable d) { } }) .delaySubscription(other) - .subscribe(ts); + .subscribe(to); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); Assert.assertEquals("Premature subscription", 0, subscribed.get()); @@ -155,16 +155,16 @@ public void accept(Disposable d) { Assert.assertEquals("No subscription", 1, subscribed.get()); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test public void testNoSubscriptionIfOtherErrors() { PublishSubject other = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger subscribed = new AtomicInteger(); @@ -176,11 +176,11 @@ public void accept(Disposable d) { } }) .delaySubscription(other) - .subscribe(ts); + .subscribe(to); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); Assert.assertEquals("Premature subscription", 0, subscribed.get()); @@ -188,9 +188,9 @@ public void accept(Disposable d) { Assert.assertEquals("Premature subscription", 0, subscribed.get()); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java index 9073b4ee93..1088f2abc1 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java @@ -218,10 +218,10 @@ public void testDelaySubscriptionDisposeBeforeTime() { Observable result = Observable.just(1, 2, 3).delaySubscription(100, TimeUnit.MILLISECONDS, scheduler); Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); - result.subscribe(ts); - ts.dispose(); + result.subscribe(to); + to.dispose(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); verify(o, never()).onNext(any()); @@ -640,7 +640,7 @@ public void accept(Notification t1) { @Test public void testBackpressureWithTimedDelay() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, Flowable.bufferSize() * 2) .delay(100, TimeUnit.MILLISECONDS) .observeOn(Schedulers.computation()) @@ -659,16 +659,16 @@ public Integer apply(Integer t) { return t; } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 2, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 2, to.valueCount()); } @Test public void testBackpressureWithSubscriptionTimedDelay() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, Flowable.bufferSize() * 2) .delaySubscription(100, TimeUnit.MILLISECONDS) .delay(100, TimeUnit.MILLISECONDS) @@ -688,16 +688,16 @@ public Integer apply(Integer t) { return t; } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 2, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 2, to.valueCount()); } @Test public void testBackpressureWithSelectorDelay() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, Flowable.bufferSize() * 2) .delay(new Function>() { @@ -723,16 +723,16 @@ public Integer apply(Integer t) { return t; } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 2, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 2, to.valueCount()); } @Test public void testBackpressureWithSelectorDelayAndSubscriptionDelay() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, Flowable.bufferSize() * 2) .delay(Observable.timer(500, TimeUnit.MILLISECONDS) , new Function>() { @@ -759,11 +759,11 @@ public Integer apply(Integer t) { return t; } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 2, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 2, to.valueCount()); } @Test @@ -772,9 +772,9 @@ public void testErrorRunsBeforeOnNext() { PublishSubject ps = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - ps.delay(1, TimeUnit.SECONDS, test).subscribe(ts); + ps.delay(1, TimeUnit.SECONDS, test).subscribe(to); ps.onNext(1); @@ -784,9 +784,9 @@ public void testErrorRunsBeforeOnNext() { test.advanceTimeBy(1, TimeUnit.SECONDS); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test @@ -795,19 +795,19 @@ public void testDelaySupplierSimple() { Observable source = Observable.range(1, 5); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.delaySubscription(ps).subscribe(ts); + source.delaySubscription(ps).subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); ps.onNext(1); - ts.assertValues(1, 2, 3, 4, 5); - ts.assertComplete(); - ts.assertNoErrors(); + to.assertValues(1, 2, 3, 4, 5); + to.assertComplete(); + to.assertNoErrors(); } @Test @@ -816,20 +816,20 @@ public void testDelaySupplierCompletes() { Observable source = Observable.range(1, 5); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.delaySubscription(ps).subscribe(ts); + source.delaySubscription(ps).subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); // FIXME should this complete the source instead of consuming it? ps.onComplete(); - ts.assertValues(1, 2, 3, 4, 5); - ts.assertComplete(); - ts.assertNoErrors(); + to.assertValues(1, 2, 3, 4, 5); + to.assertComplete(); + to.assertNoErrors(); } @Test @@ -838,19 +838,19 @@ public void testDelaySupplierErrors() { Observable source = Observable.range(1, 5); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.delaySubscription(ps).subscribe(ts); + source.delaySubscription(ps).subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); ps.onError(new TestException()); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDematerializeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDematerializeTest.java index c72ae018cc..a5017c68c4 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDematerializeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDematerializeTest.java @@ -96,10 +96,10 @@ public void testCompletePassThru() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - dematerialize.subscribe(ts); + TestObserver to = new TestObserver(observer); + dematerialize.subscribe(to); - System.out.println(ts.errors()); + System.out.println(to.errors()); verify(observer, never()).onError(any(Throwable.class)); verify(observer, times(1)).onComplete(); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDetachTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDetachTest.java index 8c1ff32467..8a9c9f6daa 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDetachTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDetachTest.java @@ -35,13 +35,13 @@ public void just() throws Exception { WeakReference wr = new WeakReference(o); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(o).count().toObservable().onTerminateDetach().subscribe(ts); + Observable.just(o).count().toObservable().onTerminateDetach().subscribe(to); - ts.assertValue(1L); - ts.assertComplete(); - ts.assertNoErrors(); + to.assertValue(1L); + to.assertComplete(); + to.assertNoErrors(); o = null; @@ -54,35 +54,35 @@ public void just() throws Exception { @Test public void error() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.error(new TestException()).onTerminateDetach().subscribe(ts); + Observable.error(new TestException()).onTerminateDetach().subscribe(to); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test public void empty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.empty().onTerminateDetach().subscribe(ts); + Observable.empty().onTerminateDetach().subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertComplete(); } @Test public void range() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.range(1, 1000).onTerminateDetach().subscribe(ts); + Observable.range(1, 1000).onTerminateDetach().subscribe(to); - ts.assertValueCount(1000); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValueCount(1000); + to.assertNoErrors(); + to.assertComplete(); } @@ -93,17 +93,17 @@ public void backpressured() throws Exception { // // WeakReference wr = new WeakReference(o); // -// TestObserver ts = new TestObserver(0L); +// TestObserver to = new TestObserver(0L); // // Observable.just(o).count().onTerminateDetach().subscribe(ts); // -// ts.assertNoValues(); +// to.assertNoValues(); // -// ts.request(1); +// to.request(1); // -// ts.assertValue(1L); -// ts.assertComplete(); -// ts.assertNoErrors(); +// to.assertValue(1L); +// to.assertComplete(); +// to.assertNoErrors(); // // o = null; // @@ -119,10 +119,10 @@ public void justUnsubscribed() throws Exception { WeakReference wr = new WeakReference(o); - TestObserver ts = Observable.just(o).count().toObservable().onTerminateDetach().test(); + TestObserver to = Observable.just(o).count().toObservable().onTerminateDetach().test(); o = null; - ts.cancel(); + to.cancel(); System.gc(); Thread.sleep(200); @@ -136,26 +136,26 @@ public void justUnsubscribed() throws Exception { public void deferredUpstreamProducer() { // final AtomicReference> subscriber = new AtomicReference>(); // -// TestObserver ts = new TestObserver(0); +// TestObserver to = new TestObserver(0); // // Observable.unsafeCreate(new ObservableSource() { // @Override // public void subscribe(Subscriber t) { // subscriber.set(t); // } -// }).onTerminateDetach().subscribe(ts); +// }).onTerminateDetach().subscribe(to); // -// ts.request(2); +// to.request(2); // // new ObservableRange(1, 3).subscribe(subscriber.get()); // -// ts.assertValues(1, 2); +// to.assertValues(1, 2); // -// ts.request(1); +// to.request(1); // -// ts.assertValues(1, 2, 3); -// ts.assertComplete(); -// ts.assertNoErrors(); +// to.assertValues(1, 2, 3); +// to.assertComplete(); +// to.assertNoErrors(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctTest.java index 299a5c3010..8114d64f9a 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctTest.java @@ -30,7 +30,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.Function; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.subjects.UnicastSubject; @@ -144,19 +144,19 @@ public void error() { @Test public void fusedSync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.just(1, 1, 2, 1, 3, 2, 4, 5, 4) .distinct() .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedAsync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject us = UnicastSubject.create(); @@ -166,7 +166,7 @@ public void fusedAsync() { TestHelper.emit(us, 1, 1, 2, 1, 3, 2, 4, 5, 4); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctUntilChangedTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctUntilChangedTest.java index c519e3d036..74bc2dfbfd 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctUntilChangedTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDistinctUntilChangedTest.java @@ -26,7 +26,7 @@ import io.reactivex.disposables.Disposables; import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.subjects.*; @@ -142,7 +142,7 @@ public void testDistinctUntilChangedOfSourceWithExceptionsFromKeySelector() { public void customComparator() { Observable source = Observable.just("a", "b", "B", "A","a", "C"); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); source.distinctUntilChanged(new BiPredicate() { @Override @@ -150,18 +150,18 @@ public boolean test(String a, String b) { return a.compareToIgnoreCase(b) == 0; } }) - .subscribe(ts); + .subscribe(to); - ts.assertValues("a", "b", "A", "C"); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues("a", "b", "A", "C"); + to.assertNoErrors(); + to.assertComplete(); } @Test public void customComparatorThrows() { Observable source = Observable.just("a", "b", "B", "A","a", "C"); - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); source.distinctUntilChanged(new BiPredicate() { @Override @@ -169,16 +169,16 @@ public boolean test(String a, String b) { throw new TestException(); } }) - .subscribe(ts); + .subscribe(to); - ts.assertValue("a"); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertValue("a"); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.just(1, 2, 2, 3, 3, 4, 5) .distinctUntilChanged(new BiPredicate() { @@ -190,14 +190,14 @@ public boolean test(Integer a, Integer b) throws Exception { .subscribe(to); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.SYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5) ; } @Test public void fusedAsync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject up = UnicastSubject.create(); @@ -213,7 +213,7 @@ public boolean test(Integer a, Integer b) throws Exception { TestHelper.emit(up, 1, 2, 2, 3, 3, 4, 5); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5) ; } @@ -257,9 +257,9 @@ class Mutable { public void mutableWithSelector() { Mutable m = new Mutable(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.distinctUntilChanged(new Function() { + TestObserver to = ps.distinctUntilChanged(new Function() { @Override public Object apply(Mutable m) throws Exception { return m.value; @@ -267,11 +267,11 @@ public Object apply(Mutable m) throws Exception { }) .test(); - pp.onNext(m); + ps.onNext(m); m.value = 1; - pp.onNext(m); - pp.onComplete(); + ps.onNext(m); + ps.onComplete(); - ts.assertResult(m, m); + to.assertResult(m, m); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoAfterNextTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoAfterNextTest.java index a6002a9117..a091306b9e 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoAfterNextTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoAfterNextTest.java @@ -24,7 +24,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.Consumer; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.observers.*; import io.reactivex.subjects.UnicastSubject; @@ -39,7 +39,7 @@ public void accept(Integer e) throws Exception { } }; - final TestObserver ts = new TestObserver() { + final TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); @@ -51,7 +51,7 @@ public void onNext(Integer t) { public void just() { Observable.just(1) .doAfterNext(afterNext) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -62,7 +62,7 @@ public void justHidden() { Observable.just(1) .hide() .doAfterNext(afterNext) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -72,7 +72,7 @@ public void justHidden() { public void range() { Observable.range(1, 5) .doAfterNext(afterNext) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(1, -1, 2, -2, 3, -3, 4, -4, 5, -5), values); @@ -82,7 +82,7 @@ public void range() { public void error() { Observable.error(new TestException()) .doAfterNext(afterNext) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); @@ -92,7 +92,7 @@ public void error() { public void empty() { Observable.empty() .doAfterNext(afterNext) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(); assertTrue(values.isEmpty()); @@ -100,13 +100,13 @@ public void empty() { @Test public void syncFused() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.SYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5) .doAfterNext(afterNext) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.SYNC) + ObserverFusion.assertFusion(to0, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -114,13 +114,13 @@ public void syncFused() { @Test public void asyncFusedRejected() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.ASYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.range(1, 5) .doAfterNext(afterNext) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.NONE) + ObserverFusion.assertFusion(to0, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -128,7 +128,7 @@ public void asyncFusedRejected() { @Test public void asyncFused() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.ASYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.ASYNC); UnicastSubject up = UnicastSubject.create(); @@ -136,9 +136,9 @@ public void asyncFused() { up .doAfterNext(afterNext) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.ASYNC) + ObserverFusion.assertFusion(to0, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -154,7 +154,7 @@ public void justConditional() { Observable.just(1) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -165,7 +165,7 @@ public void rangeConditional() { Observable.range(1, 5) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(1, -1, 2, -2, 3, -3, 4, -4, 5, -5), values); @@ -176,7 +176,7 @@ public void errorConditional() { Observable.error(new TestException()) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); @@ -187,7 +187,7 @@ public void emptyConditional() { Observable.empty() .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(); assertTrue(values.isEmpty()); @@ -195,14 +195,14 @@ public void emptyConditional() { @Test public void syncFusedConditional() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.SYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.SYNC) + ObserverFusion.assertFusion(to0, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -210,14 +210,14 @@ public void syncFusedConditional() { @Test public void asyncFusedRejectedConditional() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.ASYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.range(1, 5) .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.NONE) + ObserverFusion.assertFusion(to0, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); @@ -225,7 +225,7 @@ public void asyncFusedRejectedConditional() { @Test public void asyncFusedConditional() { - TestObserver ts0 = ObserverFusion.newTest(QueueSubscription.ASYNC); + TestObserver to0 = ObserverFusion.newTest(QueueFuseable.ASYNC); UnicastSubject up = UnicastSubject.create(); @@ -234,9 +234,9 @@ public void asyncFusedConditional() { up .doAfterNext(afterNext) .filter(Functions.alwaysTrue()) - .subscribe(ts0); + .subscribe(to0); - ObserverFusion.assertFusion(ts0, QueueSubscription.ASYNC) + ObserverFusion.assertFusion(to0, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(Arrays.asList(-1, -2, -3, -4, -5), values); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoFinallyTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoFinallyTest.java index 27ae321f4f..5cdb2bed8b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoFinallyTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoFinallyTest.java @@ -26,7 +26,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.subjects.UnicastSubject; @@ -99,13 +99,13 @@ public Observable apply(Observable f) throws Exception { @Test public void syncFused() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5) .doFinally(this) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -113,13 +113,13 @@ public void syncFused() { @Test public void syncFusedBoundary() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC | QueueFuseable.BOUNDARY); Observable.range(1, 5) .doFinally(this) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -127,16 +127,16 @@ public void syncFusedBoundary() { @Test public void asyncFused() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); UnicastSubject up = UnicastSubject.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); up .doFinally(this) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -144,16 +144,16 @@ public void asyncFused() { @Test public void asyncFusedBoundary() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ASYNC | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC | QueueFuseable.BOUNDARY); UnicastSubject up = UnicastSubject.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); up .doFinally(this) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -207,14 +207,14 @@ public void normalTakeConditional() { @Test public void syncFusedConditional() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5) .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -222,13 +222,13 @@ public void syncFusedConditional() { @Test public void nonFused() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5).hide() .doFinally(this) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -236,14 +236,14 @@ public void nonFused() { @Test public void nonFusedConditional() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5).hide() .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -251,14 +251,14 @@ public void nonFusedConditional() { @Test public void syncFusedBoundaryConditional() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC | QueueFuseable.BOUNDARY); Observable.range(1, 5) .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -266,7 +266,7 @@ public void syncFusedBoundaryConditional() { @Test public void asyncFusedConditional() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); UnicastSubject up = UnicastSubject.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -274,9 +274,9 @@ public void asyncFusedConditional() { up .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -284,7 +284,7 @@ public void asyncFusedConditional() { @Test public void asyncFusedBoundaryConditional() { - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ASYNC | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC | QueueFuseable.BOUNDARY); UnicastSubject up = UnicastSubject.create(); TestHelper.emit(up, 1, 2, 3, 4, 5); @@ -292,9 +292,9 @@ public void asyncFusedBoundaryConditional() { up .doFinally(this) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); assertEquals(1, calls); @@ -359,7 +359,7 @@ public void onSubscribe(Disposable s) { @SuppressWarnings("unchecked") QueueDisposable qs = (QueueDisposable)s; - qs.requestFusion(QueueDisposable.ANY); + qs.requestFusion(QueueFuseable.ANY); assertFalse(qs.isEmpty()); @@ -406,7 +406,7 @@ public void onSubscribe(Disposable s) { @SuppressWarnings("unchecked") QueueDisposable qs = (QueueDisposable)s; - qs.requestFusion(QueueDisposable.ANY); + qs.requestFusion(QueueFuseable.ANY); assertFalse(qs.isEmpty()); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoOnEachTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoOnEachTest.java index e1640677a7..20538da8ca 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDoOnEachTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDoOnEachTest.java @@ -28,7 +28,7 @@ import io.reactivex.exceptions.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.observers.*; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.subjects.UnicastSubject; @@ -201,7 +201,7 @@ public void accept(List booleans) { @Test public void onErrorThrows() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); Observable.error(new TestException()) .doOnError(new Consumer() { @@ -209,13 +209,13 @@ public void onErrorThrows() { public void accept(Throwable e) { throw new TestException(); } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(CompositeException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(CompositeException.class); - CompositeException ex = (CompositeException)ts.errors().get(0); + CompositeException ex = (CompositeException)to.errors().get(0); List exceptions = ex.getExceptions(); assertEquals(2, exceptions.size()); @@ -451,7 +451,7 @@ public void run() throws Exception { @Test public void onErrorOnErrorCrashConditional() { - TestObserver ts = Observable.error(new TestException("Outer")) + TestObserver to = Observable.error(new TestException("Outer")) .doOnError(new Consumer() { @Override public void accept(Throwable e) throws Exception { @@ -462,7 +462,7 @@ public void accept(Throwable e) throws Exception { .test() .assertFailure(CompositeException.class); - List errors = TestHelper.compositeList(ts.errors().get(0)); + List errors = TestHelper.compositeList(to.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "Outer"); TestHelper.assertError(errors, 1, TestException.class, "Inner"); @@ -471,7 +471,7 @@ public void accept(Throwable e) throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fused() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -488,10 +488,10 @@ public void run() throws Exception { call[1]++; } }) - .subscribe(ts); + .subscribe(to); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -501,7 +501,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedOnErrorCrash() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0 }; @@ -518,10 +518,10 @@ public void run() throws Exception { call[0]++; } }) - .subscribe(ts); + .subscribe(to); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertFailure(TestException.class); assertEquals(0, call[0]); @@ -530,7 +530,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedConditional() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -548,10 +548,10 @@ public void run() throws Exception { } }) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -561,7 +561,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedOnErrorCrashConditional() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0 }; @@ -579,10 +579,10 @@ public void run() throws Exception { } }) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertFailure(TestException.class); assertEquals(0, call[0]); @@ -591,7 +591,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedAsync() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -610,12 +610,12 @@ public void run() throws Exception { call[1]++; } }) - .subscribe(ts); + .subscribe(to); TestHelper.emit(up, 1, 2, 3, 4, 5); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.ASYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -625,7 +625,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedAsyncConditional() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -645,12 +645,12 @@ public void run() throws Exception { } }) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); TestHelper.emit(up, 1, 2, 3, 4, 5); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.ASYNC)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); @@ -660,7 +660,7 @@ public void run() throws Exception { @Test @Ignore("Fusion not supported yet") // TODO decide/implement fusion public void fusedAsyncConditional2() { - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); final int[] call = { 0, 0 }; @@ -680,12 +680,12 @@ public void run() throws Exception { } }) .filter(Functions.alwaysTrue()) - .subscribe(ts); + .subscribe(to); TestHelper.emit(up, 1, 2, 3, 4, 5); - ts.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.NONE)) + to.assertOf(ObserverFusion.assertFuseable()) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2, 3, 4, 5); assertEquals(5, call[0]); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableFilterTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableFilterTest.java index 0ddb43e8b6..e855c07820 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableFilterTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableFilterTest.java @@ -23,7 +23,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.subjects.UnicastSubject; @@ -94,7 +94,7 @@ public ObservableSource apply(Observable o) throws Exception { @Test public void fusedSync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.range(1, 5) .filter(new Predicate() { @@ -105,13 +105,13 @@ public boolean test(Integer v) throws Exception { }) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(2, 4); } @Test public void fusedAsync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject us = UnicastSubject.create(); @@ -126,13 +126,13 @@ public boolean test(Integer v) throws Exception { TestHelper.emit(us, 1, 2, 3, 4, 5); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .assertResult(2, 4); } @Test public void fusedReject() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY | QueueFuseable.BOUNDARY); Observable.range(1, 5) .filter(new Predicate() { @@ -143,7 +143,7 @@ public boolean test(Integer v) throws Exception { }) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(2, 4); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapCompletableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapCompletableTest.java index 421c881c26..33ba15307e 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapCompletableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapCompletableTest.java @@ -24,7 +24,7 @@ import io.reactivex.disposables.*; import io.reactivex.exceptions.*; import io.reactivex.functions.Function; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.schedulers.Schedulers; import io.reactivex.subjects.PublishSubject; @@ -169,7 +169,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void fusedObservable() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.range(1, 10) .flatMapCompletable(new Function() { @@ -182,7 +182,7 @@ public CompletableSource apply(Integer v) throws Exception { to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } @@ -335,7 +335,7 @@ public CompletableSource apply(Integer v) throws Exception { @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.range(1, 10) .flatMapCompletable(new Function() { @@ -349,7 +349,7 @@ public CompletableSource apply(Integer v) throws Exception { to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapTest.java index 70daea3fd9..9e40bd1925 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableFlatMapTest.java @@ -338,17 +338,17 @@ public Observable apply(Integer t1) { } }, m); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.subscribe(ts); + source.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + to.awaitTerminalEvent(); + to.assertNoErrors(); Set expected = new HashSet(Arrays.asList( 10, 11, 20, 21, 30, 31, 40, 41, 50, 51, 60, 61, 70, 71, 80, 81, 90, 91, 100, 101 )); - Assert.assertEquals(expected.size(), ts.valueCount()); - Assert.assertTrue(expected.containsAll(ts.values())); + Assert.assertEquals(expected.size(), to.valueCount()); + Assert.assertTrue(expected.containsAll(to.values())); } @Test public void testFlatMapSelectorMaxConcurrent() { @@ -368,19 +368,19 @@ public Integer apply(Integer t1, Integer t2) { } }, m); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.subscribe(ts); + source.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + to.awaitTerminalEvent(); + to.assertNoErrors(); Set expected = new HashSet(Arrays.asList( 1010, 1011, 2020, 2021, 3030, 3031, 4040, 4041, 5050, 5051, 6060, 6061, 7070, 7071, 8080, 8081, 9090, 9091, 10100, 10101 )); - Assert.assertEquals(expected.size(), ts.valueCount()); - System.out.println("--> testFlatMapSelectorMaxConcurrent: " + ts.values()); - Assert.assertTrue(expected.containsAll(ts.values())); + Assert.assertEquals(expected.size(), to.valueCount()); + System.out.println("--> testFlatMapSelectorMaxConcurrent: " + to.values()); + Assert.assertTrue(expected.containsAll(to.values())); } @Test @@ -414,14 +414,14 @@ public void testFlatMapTransformsMaxConcurrentNormal() { Observable source = Observable.fromIterable(Arrays.asList(10, 20, 30)); Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); Function> just = just(onError); - source.flatMap(just(onNext), just, just0(onComplete), m).subscribe(ts); + source.flatMap(just(onNext), just, just0(onComplete), m).subscribe(to); - ts.awaitTerminalEvent(1, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertTerminated(); + to.awaitTerminalEvent(1, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertTerminated(); verify(o, times(3)).onNext(1); verify(o, times(3)).onNext(2); @@ -440,7 +440,7 @@ public void flatMapRangeAsyncLoop() { if (i % 10 == 0) { System.out.println("flatMapRangeAsyncLoop > " + i); } - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 1000) .flatMap(new Function>() { @Override @@ -449,15 +449,15 @@ public Observable apply(Integer t) { } }) .observeOn(Schedulers.computation()) - .subscribe(ts); + .subscribe(to); - ts.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); - if (ts.completions() == 0) { - System.out.println(ts.valueCount()); + to.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); + if (to.completions() == 0) { + System.out.println(to.valueCount()); } - ts.assertTerminated(); - ts.assertNoErrors(); - List list = ts.values(); + to.assertTerminated(); + to.assertNoErrors(); + List list = to.values(); assertEquals(1000, list.size()); boolean f = false; for (int j = 0; j < list.size(); j++) { @@ -477,7 +477,7 @@ public void flatMapRangeMixedAsyncLoop() { if (i % 10 == 0) { System.out.println("flatMapRangeAsyncLoop > " + i); } - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 1000) .flatMap(new Function>() { final Random rnd = new Random(); @@ -491,15 +491,15 @@ public Observable apply(Integer t) { } }) .observeOn(Schedulers.computation()) - .subscribe(ts); + .subscribe(to); - ts.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); - if (ts.completions() == 0) { - System.out.println(ts.valueCount()); + to.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); + if (to.completions() == 0) { + System.out.println(to.valueCount()); } - ts.assertTerminated(); - ts.assertNoErrors(); - List list = ts.values(); + to.assertTerminated(); + to.assertNoErrors(); + List list = to.values(); if (list.size() < 1000) { Set set = new HashSet(list); for (int j = 0; j < 1000; j++) { @@ -515,37 +515,37 @@ public Observable apply(Integer t) { @Test public void flatMapIntPassthruAsync() { for (int i = 0;i < 1000; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 1000).flatMap(new Function>() { @Override public Observable apply(Integer t) { return Observable.just(1).subscribeOn(Schedulers.computation()); } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertComplete(); - ts.assertValueCount(1000); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertComplete(); + to.assertValueCount(1000); } } @Test public void flatMapTwoNestedSync() { for (final int n : new int[] { 1, 1000, 1000000 }) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1, 2).flatMap(new Function>() { @Override public Observable apply(Integer t) { return Observable.range(1, n); } - }).subscribe(ts); + }).subscribe(to); System.out.println("flatMapTwoNestedSync >> @ " + n); - ts.assertNoErrors(); - ts.assertComplete(); - ts.assertValueCount(n * 2); + to.assertNoErrors(); + to.assertComplete(); + to.assertValueCount(n * 2); } } @@ -762,7 +762,7 @@ public Integer apply(Integer w) throws Exception { @Test public void noCrossBoundaryFusion() { for (int i = 0; i < 500; i++) { - TestObserver ts = Observable.merge( + TestObserver to = Observable.merge( Observable.just(1).observeOn(Schedulers.single()).map(new Function() { @Override public Object apply(Integer v) throws Exception { @@ -780,7 +780,7 @@ public Object apply(Integer v) throws Exception { .awaitDone(5, TimeUnit.SECONDS) .assertValueCount(2); - List list = ts.values(); + List list = to.values(); assertTrue(list.toString(), list.contains("RxSi")); assertTrue(list.toString(), list.contains("RxCo")); @@ -793,20 +793,20 @@ public void cancelScalarDrainRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishSubject> pp = PublishSubject.create(); + final PublishSubject> ps = PublishSubject.create(); - final TestObserver ts = pp.flatMap(Functions.>identity()).test(); + final TestObserver to = ps.flatMap(Functions.>identity()).test(); Runnable r1 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; @@ -826,20 +826,20 @@ public void cancelDrainRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishSubject> pp = PublishSubject.create(); + final PublishSubject> ps = PublishSubject.create(); - final TestObserver ts = pp.flatMap(Functions.>identity()).test(); + final TestObserver to = ps.flatMap(Functions.>identity()).test(); final PublishSubject just = PublishSubject.create(); final PublishSubject just2 = PublishSubject.create(); - pp.onNext(just); - pp.onNext(just2); + ps.onNext(just); + ps.onNext(just2); Runnable r1 = new Runnable() { @Override public void run() { just2.onNext(1); - ts.cancel(); + to.cancel(); } }; Runnable r2 = new Runnable() { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableFromIterableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableFromIterableTest.java index 5b121664c9..3b0a9d4970 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableFromIterableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableFromIterableTest.java @@ -29,7 +29,7 @@ import io.reactivex.disposables.Disposable; import io.reactivex.exceptions.TestException; import io.reactivex.functions.Function; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.util.CrashingIterable; import io.reactivex.observers.*; @@ -118,12 +118,12 @@ public void testObservableFromIterable() { public void testNoBackpressure() { Observable o = Observable.fromIterable(Arrays.asList(1, 2, 3, 4, 5)); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - o.subscribe(ts); + o.subscribe(to); - ts.assertValues(1, 2, 3, 4, 5); - ts.assertTerminated(); + to.assertValues(1, 2, 3, 4, 5); + to.assertTerminated(); } @Test @@ -131,13 +131,13 @@ public void testSubscribeMultipleTimes() { Observable o = Observable.fromIterable(Arrays.asList(1, 2, 3)); for (int i = 0; i < 10; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - o.subscribe(ts); + o.subscribe(to); - ts.assertValues(1, 2, 3); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues(1, 2, 3); + to.assertNoErrors(); + to.assertComplete(); } } @@ -302,12 +302,12 @@ public void remove() { @Test public void fusionRejected() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.fromIterable(Arrays.asList(1, 2, 3)) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3); } @@ -320,7 +320,7 @@ public void onSubscribe(Disposable d) { @SuppressWarnings("unchecked") QueueDisposable qd = (QueueDisposable)d; - qd.requestFusion(QueueDisposable.ANY); + qd.requestFusion(QueueFuseable.ANY); try { assertEquals(1, qd.poll().intValue()); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableFromTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableFromTest.java index f39ef54d84..586480cc5b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableFromTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableFromTest.java @@ -77,12 +77,12 @@ public ObservableSource apply(Flowable f) throws Exception { @Test public void fusionRejected() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.fromArray(1, 2, 3) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableGroupByTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableGroupByTest.java index 3ced845ea4..ae00fc2403 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableGroupByTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableGroupByTest.java @@ -1026,7 +1026,7 @@ public Boolean apply(Integer n) { @Test public void testGroupByBackpressure() throws InterruptedException { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 4000) .groupBy(IS_EVEN2) @@ -1052,9 +1052,9 @@ public String apply(Integer l) { }); } - }).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + }).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } Function just(final R value) { @@ -1153,12 +1153,12 @@ public String apply(String v) { } }); - TestObserver ts = new TestObserver(); - m.subscribe(ts); - ts.awaitTerminalEvent(); - System.out.println("ts .get " + ts.values()); - ts.assertNoErrors(); - assertEquals(ts.values(), + TestObserver to = new TestObserver(); + m.subscribe(to); + to.awaitTerminalEvent(); + System.out.println("ts .get " + to.values()); + to.assertNoErrors(); + assertEquals(to.values(), Arrays.asList("foo-0", "foo-1", "bar-0", "foo-0", "baz-0", "qux-0", "bar-1", "bar-0", "foo-1", "baz-1", "baz-0", "foo-0")); } @@ -1169,11 +1169,11 @@ public void keySelectorThrows() { Observable m = source.groupBy(fail(0), dbl).flatMap(FLATTEN_INTEGER); - TestObserver ts = new TestObserver(); - m.subscribe(ts); - ts.awaitTerminalEvent(); - assertEquals(1, ts.errorCount()); - ts.assertNoValues(); + TestObserver to = new TestObserver(); + m.subscribe(to); + to.awaitTerminalEvent(); + assertEquals(1, to.errorCount()); + to.assertNoValues(); } @Test @@ -1181,11 +1181,11 @@ public void valueSelectorThrows() { Observable source = Observable.just(0, 1, 2, 3, 4, 5, 6); Observable m = source.groupBy(identity, fail(0)).flatMap(FLATTEN_INTEGER); - TestObserver ts = new TestObserver(); - m.subscribe(ts); - ts.awaitTerminalEvent(); - assertEquals(1, ts.errorCount()); - ts.assertNoValues(); + TestObserver to = new TestObserver(); + m.subscribe(to); + to.awaitTerminalEvent(); + assertEquals(1, to.errorCount()); + to.assertNoValues(); } @@ -1195,11 +1195,11 @@ public void innerEscapeCompleted() { Observable m = source.groupBy(identity, dbl).flatMap(FLATTEN_INTEGER); - TestObserver ts = new TestObserver(); - m.subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - System.out.println(ts.values()); + TestObserver to = new TestObserver(); + m.subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + System.out.println(to.values()); } /** @@ -1239,16 +1239,16 @@ public void testError2() { Observable m = source.groupBy(identity, dbl).flatMap(FLATTEN_INTEGER); - TestObserver ts = new TestObserver(); - m.subscribe(ts); - ts.awaitTerminalEvent(); - assertEquals(1, ts.errorCount()); - ts.assertValueCount(1); + TestObserver to = new TestObserver(); + m.subscribe(to); + to.awaitTerminalEvent(); + assertEquals(1, to.errorCount()); + to.assertValueCount(1); } @Test public void testgroupByBackpressure() throws InterruptedException { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 4000).groupBy(IS_EVEN2).flatMap(new Function, Observable>() { @@ -1297,15 +1297,15 @@ public void accept(Notification t1) { System.out.println("NEXT: " + t1); } - }).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + }).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } @Test public void testgroupByBackpressure2() throws InterruptedException { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 4000).groupBy(IS_EVEN2).flatMap(new Function, Observable>() { @@ -1329,9 +1329,9 @@ public String apply(Integer l) { }); } - }).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + }).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } static Function, Observable> FLATTEN_INTEGER = new Function, Observable>() { @@ -1382,7 +1382,7 @@ public void subscribe(Observer observer) { } } ); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); o.groupBy(new Function() { @@ -1390,9 +1390,9 @@ public void subscribe(Observer observer) { public Integer apply(Integer integer) { return null; } - }).subscribe(ts); + }).subscribe(to); - ts.dispose(); + to.dispose(); verify(s).dispose(); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableIgnoreElementsTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableIgnoreElementsTest.java index 1a2e7c7782..7e75e12a8d 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableIgnoreElementsTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableIgnoreElementsTest.java @@ -57,26 +57,26 @@ public void accept(Integer t) { @Test public void testCompletedOkObservable() { - TestObserver ts = new TestObserver(); - Observable.range(1, 10).ignoreElements().toObservable().subscribe(ts); - ts.assertNoErrors(); - ts.assertNoValues(); - ts.assertTerminated(); + TestObserver to = new TestObserver(); + Observable.range(1, 10).ignoreElements().toObservable().subscribe(to); + to.assertNoErrors(); + to.assertNoValues(); + to.assertTerminated(); // FIXME no longer testable // ts.assertUnsubscribed(); } @Test public void testErrorReceivedObservable() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); TestException ex = new TestException("boo"); - Observable.error(ex).ignoreElements().toObservable().subscribe(ts); - ts.assertNoValues(); - ts.assertTerminated(); + Observable.error(ex).ignoreElements().toObservable().subscribe(to); + to.assertNoValues(); + to.assertTerminated(); // FIXME no longer testable // ts.assertUnsubscribed(); - ts.assertError(TestException.class); - ts.assertErrorMessage("boo"); + to.assertError(TestException.class); + to.assertErrorMessage("boo"); } @Test @@ -124,26 +124,26 @@ public void accept(Integer t) { @Test public void testCompletedOk() { - TestObserver ts = new TestObserver(); - Observable.range(1, 10).ignoreElements().subscribe(ts); - ts.assertNoErrors(); - ts.assertNoValues(); - ts.assertTerminated(); + TestObserver to = new TestObserver(); + Observable.range(1, 10).ignoreElements().subscribe(to); + to.assertNoErrors(); + to.assertNoValues(); + to.assertTerminated(); // FIXME no longer testable // ts.assertUnsubscribed(); } @Test public void testErrorReceived() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); TestException ex = new TestException("boo"); - Observable.error(ex).ignoreElements().subscribe(ts); - ts.assertNoValues(); - ts.assertTerminated(); + Observable.error(ex).ignoreElements().subscribe(to); + to.assertNoValues(); + to.assertTerminated(); // FIXME no longer testable // ts.assertUnsubscribed(); - ts.assertError(TestException.class); - ts.assertErrorMessage("boo"); + to.assertError(TestException.class); + to.assertErrorMessage("boo"); } @Test @@ -164,17 +164,17 @@ public void run() { @Test public void cancel() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.ignoreElements().toObservable().test(); + TestObserver to = ps.ignoreElements().toObservable().test(); - assertTrue(pp.hasObservers()); + assertTrue(ps.hasObservers()); - ts.cancel(); + to.cancel(); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); - TestHelper.checkDisposed(pp.ignoreElements().toObservable()); + TestHelper.checkDisposed(ps.ignoreElements().toObservable()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableIntervalTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableIntervalTest.java index e834a2accb..17d370a56d 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableIntervalTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableIntervalTest.java @@ -39,14 +39,14 @@ public void cancel() { @Test public void cancelledOnRun() { - TestObserver ts = new TestObserver(); - IntervalObserver is = new IntervalObserver(ts); - ts.onSubscribe(is); + TestObserver to = new TestObserver(); + IntervalObserver is = new IntervalObserver(to); + to.onSubscribe(is); is.dispose(); is.run(); - ts.assertEmpty(); + to.assertEmpty(); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMapNotificationTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMapNotificationTest.java index fae7c60afd..748078fd02 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMapNotificationTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMapNotificationTest.java @@ -28,7 +28,7 @@ public class ObservableMapNotificationTest { @Test public void testJust() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1) .flatMap( new Function>() { @@ -49,11 +49,11 @@ public Observable call() { return Observable.never(); } } - ).subscribe(ts); + ).subscribe(to); - ts.assertNoErrors(); - ts.assertNotComplete(); - ts.assertValue(2); + to.assertNoErrors(); + to.assertNotComplete(); + to.assertValue(2); } @Test @@ -89,7 +89,7 @@ public ObservableSource apply(Observable o) throws Exception { @Test public void onErrorCrash() { - TestObserver ts = Observable.error(new TestException("Outer")) + TestObserver to = Observable.error(new TestException("Outer")) .flatMap(Functions.justFunction(Observable.just(1)), new Function>() { @Override @@ -101,7 +101,7 @@ public Observable apply(Throwable t) throws Exception { .test() .assertFailure(CompositeException.class); - TestHelper.assertError(ts, 0, TestException.class, "Outer"); - TestHelper.assertError(ts, 1, TestException.class, "Inner"); + TestHelper.assertError(to, 0, TestException.class, "Outer"); + TestHelper.assertError(to, 1, TestException.class, "Inner"); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMapTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMapTest.java index 662c1ed8bb..3d824be862 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMapTest.java @@ -13,7 +13,8 @@ package io.reactivex.internal.operators.observable; -import static org.junit.Assert.*; +import static org.junit.Assert.assertNull; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; import java.util.*; @@ -25,7 +26,7 @@ import io.reactivex.Observer; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; import io.reactivex.schedulers.Schedulers; import io.reactivex.subjects.UnicastSubject; @@ -349,19 +350,19 @@ public ObservableSource apply(Observable o) throws Exception { @Test public void fusedSync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.range(1, 5) .map(Functions.identity()) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedAsync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject us = UnicastSubject.create(); @@ -371,19 +372,19 @@ public void fusedAsync() { TestHelper.emit(us, 1, 2, 3, 4, 5); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .assertResult(1, 2, 3, 4, 5); } @Test public void fusedReject() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY | QueueDisposable.BOUNDARY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY | QueueFuseable.BOUNDARY); Observable.range(1, 5) .map(Functions.identity()) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMaterializeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMaterializeTest.java index dfc7ba2fab..d163293c69 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMaterializeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMaterializeTest.java @@ -101,17 +101,17 @@ public void testMultipleSubscribes() throws InterruptedException, ExecutionExcep @Test public void testWithCompletionCausingError() { - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); final RuntimeException ex = new RuntimeException("boo"); Observable.empty().materialize().doOnNext(new Consumer() { @Override public void accept(Object t) { throw ex; } - }).subscribe(ts); - ts.assertError(ex); - ts.assertNoValues(); - ts.assertTerminated(); + }).subscribe(to); + to.assertError(ex); + to.assertNoValues(); + to.assertTerminated(); } private static class TestLocalObserver extends DefaultObserver> { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeDelayErrorTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeDelayErrorTest.java index 2ddcd54994..472a25300b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeDelayErrorTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeDelayErrorTest.java @@ -487,15 +487,15 @@ public void onComplete() { @Test public void testErrorInParentObservable() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.mergeDelayError( Observable.just(Observable.just(1), Observable.just(2)) .startWith(Observable. error(new RuntimeException())) - ).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertTerminated(); - ts.assertValues(1, 2); - assertEquals(1, ts.errorCount()); + ).subscribe(to); + to.awaitTerminalEvent(); + to.assertTerminated(); + to.assertValues(1, 2); + assertEquals(1, to.errorCount()); } @@ -516,12 +516,12 @@ public void subscribe(Observer> op) { Observer stringObserver = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(stringObserver); + TestObserver to = new TestObserver(stringObserver); Observable m = Observable.mergeDelayError(parentObservable); - m.subscribe(ts); + m.subscribe(to); System.out.println("testErrorInParentObservableDelayed | " + i); - ts.awaitTerminalEvent(2000, TimeUnit.MILLISECONDS); - ts.assertTerminated(); + to.awaitTerminalEvent(2000, TimeUnit.MILLISECONDS); + to.assertTerminated(); verify(stringObserver, times(2)).onNext("hello"); verify(stringObserver, times(1)).onError(any(NullPointerException.class)); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeMaxConcurrentTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeMaxConcurrentTest.java index 202fe7fdc8..582421d42b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeMaxConcurrentTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeMaxConcurrentTest.java @@ -156,7 +156,7 @@ public void testMergeALotOfSourcesOneByOneSynchronouslyTakeHalf() { @Test public void testSimple() { for (int i = 1; i < 100; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); List> sourceList = new ArrayList>(i); List result = new ArrayList(i); for (int j = 1; j <= i; j++) { @@ -164,17 +164,17 @@ public void testSimple() { result.add(j); } - Observable.merge(sourceList, i).subscribe(ts); + Observable.merge(sourceList, i).subscribe(to); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertValueSequence(result); + to.assertNoErrors(); + to.assertTerminated(); + to.assertValueSequence(result); } } @Test public void testSimpleOneLess() { for (int i = 2; i < 100; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); List> sourceList = new ArrayList>(i); List result = new ArrayList(i); for (int j = 1; j <= i; j++) { @@ -182,11 +182,11 @@ public void testSimpleOneLess() { result.add(j); } - Observable.merge(sourceList, i - 1).subscribe(ts); + Observable.merge(sourceList, i - 1).subscribe(to); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertValueSequence(result); + to.assertNoErrors(); + to.assertTerminated(); + to.assertValueSequence(result); } } @Test//(timeout = 20000) @@ -204,7 +204,7 @@ public void testSimpleAsyncLoop() { @Test(timeout = 30000) public void testSimpleAsync() { for (int i = 1; i < 50; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); List> sourceList = new ArrayList>(i); Set expected = new HashSet(i); for (int j = 1; j <= i; j++) { @@ -212,11 +212,11 @@ public void testSimpleAsync() { expected.add(j); } - Observable.merge(sourceList, i).subscribe(ts); + Observable.merge(sourceList, i).subscribe(to); - ts.awaitTerminalEvent(1, TimeUnit.SECONDS); - ts.assertNoErrors(); - Set actual = new HashSet(ts.values()); + to.awaitTerminalEvent(1, TimeUnit.SECONDS); + to.assertNoErrors(); + Set actual = new HashSet(to.values()); assertEquals(expected, actual); } @@ -234,7 +234,7 @@ public void testSimpleOneLessAsync() { if (System.currentTimeMillis() - t > TimeUnit.SECONDS.toMillis(9)) { break; } - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); List> sourceList = new ArrayList>(i); Set expected = new HashSet(i); for (int j = 1; j <= i; j++) { @@ -242,11 +242,11 @@ public void testSimpleOneLessAsync() { expected.add(j); } - Observable.merge(sourceList, i - 1).subscribe(ts); + Observable.merge(sourceList, i - 1).subscribe(to); - ts.awaitTerminalEvent(1, TimeUnit.SECONDS); - ts.assertNoErrors(); - Set actual = new HashSet(ts.values()); + to.awaitTerminalEvent(1, TimeUnit.SECONDS); + to.assertNoErrors(); + Set actual = new HashSet(to.values()); assertEquals(expected, actual); } @@ -260,12 +260,12 @@ public void testTake() throws Exception { sourceList.add(Observable.range(0, 100000).subscribeOn(Schedulers.io())); sourceList.add(Observable.range(0, 100000).subscribeOn(Schedulers.io())); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.merge(sourceList, 2).take(5).subscribe(ts); + Observable.merge(sourceList, 2).take(5).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - ts.assertValueCount(5); + to.awaitTerminalEvent(); + to.assertNoErrors(); + to.assertValueCount(5); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeTest.java index 85907bcf23..1b808a9234 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableMergeTest.java @@ -189,11 +189,11 @@ public void testMergeArrayWithThreading() { final TestASynchronousObservable o2 = new TestASynchronousObservable(); Observable m = Observable.merge(Observable.unsafeCreate(o1), Observable.unsafeCreate(o2)); - TestObserver ts = new TestObserver(stringObserver); - m.subscribe(ts); + TestObserver to = new TestObserver(stringObserver); + m.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + to.awaitTerminalEvent(); + to.assertNoErrors(); verify(stringObserver, never()).onError(any(Throwable.class)); verify(stringObserver, times(2)).onNext("hello"); @@ -339,7 +339,7 @@ public void testError2() { @Test @Ignore("Subscribe should not throw") public void testThrownErrorHandling() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable o1 = Observable.unsafeCreate(new ObservableSource() { @Override @@ -349,10 +349,10 @@ public void subscribe(Observer s) { }); - Observable.merge(o1, o1).subscribe(ts); - ts.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - System.out.println("Error: " + ts.errors()); + Observable.merge(o1, o1).subscribe(to); + to.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); + to.assertTerminated(); + System.out.println("Error: " + to.errors()); } private static class TestSynchronousObservable implements ObservableSource { @@ -425,16 +425,16 @@ public void testUnsubscribeAsObservablesComplete() { AtomicBoolean os2 = new AtomicBoolean(false); Observable o2 = createObservableOf5IntervalsOf1SecondIncrementsWithSubscriptionHook(scheduler2, os2); - TestObserver ts = new TestObserver(); - Observable.merge(o1, o2).subscribe(ts); + TestObserver to = new TestObserver(); + Observable.merge(o1, o2).subscribe(to); // we haven't incremented time so nothing should be received yet - ts.assertNoValues(); + to.assertNoValues(); scheduler1.advanceTimeBy(3, TimeUnit.SECONDS); scheduler2.advanceTimeBy(2, TimeUnit.SECONDS); - ts.assertValues(0L, 1L, 2L, 0L, 1L); + to.assertValues(0L, 1L, 2L, 0L, 1L); // not unsubscribed yet assertFalse(os1.get()); assertFalse(os2.get()); @@ -442,18 +442,18 @@ public void testUnsubscribeAsObservablesComplete() { // advance to the end at which point it should complete scheduler1.advanceTimeBy(3, TimeUnit.SECONDS); - ts.assertValues(0L, 1L, 2L, 0L, 1L, 3L, 4L); + to.assertValues(0L, 1L, 2L, 0L, 1L, 3L, 4L); assertTrue(os1.get()); assertFalse(os2.get()); // both should be completed now scheduler2.advanceTimeBy(3, TimeUnit.SECONDS); - ts.assertValues(0L, 1L, 2L, 0L, 1L, 3L, 4L, 2L, 3L, 4L); + to.assertValues(0L, 1L, 2L, 0L, 1L, 3L, 4L, 2L, 3L, 4L); assertTrue(os1.get()); assertTrue(os2.get()); - ts.assertTerminated(); + to.assertTerminated(); } @Test @@ -467,27 +467,27 @@ public void testEarlyUnsubscribe() { AtomicBoolean os2 = new AtomicBoolean(false); Observable o2 = createObservableOf5IntervalsOf1SecondIncrementsWithSubscriptionHook(scheduler2, os2); - TestObserver ts = new TestObserver(); - Observable.merge(o1, o2).subscribe(ts); + TestObserver to = new TestObserver(); + Observable.merge(o1, o2).subscribe(to); // we haven't incremented time so nothing should be received yet - ts.assertNoValues(); + to.assertNoValues(); scheduler1.advanceTimeBy(3, TimeUnit.SECONDS); scheduler2.advanceTimeBy(2, TimeUnit.SECONDS); - ts.assertValues(0L, 1L, 2L, 0L, 1L); + to.assertValues(0L, 1L, 2L, 0L, 1L); // not unsubscribed yet assertFalse(os1.get()); assertFalse(os2.get()); // early unsubscribe - ts.dispose(); + to.dispose(); assertTrue(os1.get()); assertTrue(os2.get()); - ts.assertValues(0L, 1L, 2L, 0L, 1L); + to.assertValues(0L, 1L, 2L, 0L, 1L); // FIXME not happening anymore // ts.assertUnsubscribed(); } @@ -540,14 +540,14 @@ public void testConcurrency() { for (int i = 0; i < 10; i++) { Observable merge = Observable.merge(o, o, o); - TestObserver ts = new TestObserver(); - merge.subscribe(ts); - - ts.awaitTerminalEvent(3, TimeUnit.SECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertComplete(); - List onNextEvents = ts.values(); + TestObserver to = new TestObserver(); + merge.subscribe(to); + + to.awaitTerminalEvent(3, TimeUnit.SECONDS); + to.assertTerminated(); + to.assertNoErrors(); + to.assertComplete(); + List onNextEvents = to.values(); assertEquals(30000, onNextEvents.size()); // System.out.println("onNext: " + onNextEvents.size() + " onComplete: " + ts.getOnCompletedEvents().size()); } @@ -593,12 +593,12 @@ public void run() { for (int i = 0; i < 10; i++) { Observable merge = Observable.merge(o, o, o); - TestObserver ts = new TestObserver(); - merge.subscribe(ts); + TestObserver to = new TestObserver(); + merge.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertComplete(); - List onNextEvents = ts.values(); + to.awaitTerminalEvent(); + to.assertComplete(); + List onNextEvents = to.values(); assertEquals(300, onNextEvents.size()); // System.out.println("onNext: " + onNextEvents.size() + " onComplete: " + ts.getOnCompletedEvents().size()); } @@ -640,13 +640,13 @@ public void run() { for (int i = 0; i < 10; i++) { Observable merge = Observable.merge(o, o, o); - TestObserver ts = new TestObserver(); - merge.subscribe(ts); + TestObserver to = new TestObserver(); + merge.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - ts.assertComplete(); - List onNextEvents = ts.values(); + to.awaitTerminalEvent(); + to.assertNoErrors(); + to.assertComplete(); + List onNextEvents = to.values(); assertEquals(30000, onNextEvents.size()); // System.out.println("onNext: " + onNextEvents.size() + " onComplete: " + ts.getOnCompletedEvents().size()); } @@ -825,18 +825,18 @@ public void onNext(Integer t) { @Ignore("Null values not permitted") public void mergeWithNullValues() { System.out.println("mergeWithNullValues"); - TestObserver ts = new TestObserver(); - Observable.merge(Observable.just(null, "one"), Observable.just("two", null)).subscribe(ts); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValues(null, "one", "two", null); + TestObserver to = new TestObserver(); + Observable.merge(Observable.just(null, "one"), Observable.just("two", null)).subscribe(to); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValues(null, "one", "two", null); } @Test @Ignore("Null values are no longer permitted") public void mergeWithTerminalEventAfterUnsubscribe() { System.out.println("mergeWithTerminalEventAfterUnsubscribe"); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable bad = Observable.unsafeCreate(new ObservableSource() { @Override @@ -848,72 +848,72 @@ public void subscribe(Observer s) { } }); - Observable.merge(Observable.just(null, "one"), bad).subscribe(ts); - ts.assertNoErrors(); - ts.assertValues(null, "one", "two"); + Observable.merge(Observable.just(null, "one"), bad).subscribe(to); + to.assertNoErrors(); + to.assertValues(null, "one", "two"); } @Test @Ignore("Null values are not permitted") public void mergingNullObservable() { - TestObserver ts = new TestObserver(); - Observable.merge(Observable.just("one"), null).subscribe(ts); - ts.assertNoErrors(); - ts.assertValue("one"); + TestObserver to = new TestObserver(); + Observable.merge(Observable.just("one"), null).subscribe(to); + to.assertNoErrors(); + to.assertValue("one"); } @Test public void merge1AsyncStreamOf1() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(1, 1).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(1, 1).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1, to.values().size()); } @Test public void merge1AsyncStreamOf1000() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(1, 1000).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(1, 1000).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1000, to.values().size()); } @Test public void merge10AsyncStreamOf1000() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(10, 1000).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(10000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(10, 1000).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(10000, to.values().size()); } @Test public void merge1000AsyncStreamOf1000() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(1000, 1000).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1000000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(1000, 1000).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1000000, to.values().size()); } @Test public void merge2000AsyncStreamOf100() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(2000, 100).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(200000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(2000, 100).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(200000, to.values().size()); } @Test public void merge100AsyncStreamOf1() { - TestObserver ts = new TestObserver(); - mergeNAsyncStreamsOfN(100, 1).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(100, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNAsyncStreamsOfN(100, 1).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(100, to.values().size()); } private Observable mergeNAsyncStreamsOfN(final int outerSize, final int innerSize) { @@ -931,47 +931,47 @@ public Observable apply(Integer i) { @Test public void merge1SyncStreamOf1() { - TestObserver ts = new TestObserver(); - mergeNSyncStreamsOfN(1, 1).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNSyncStreamsOfN(1, 1).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1, to.values().size()); } @Test public void merge1SyncStreamOf1000000() { - TestObserver ts = new TestObserver(); - mergeNSyncStreamsOfN(1, 1000000).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1000000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNSyncStreamsOfN(1, 1000000).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1000000, to.values().size()); } @Test public void merge1000SyncStreamOf1000() { - TestObserver ts = new TestObserver(); - mergeNSyncStreamsOfN(1000, 1000).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1000000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNSyncStreamsOfN(1000, 1000).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1000000, to.values().size()); } @Test public void merge10000SyncStreamOf10() { - TestObserver ts = new TestObserver(); - mergeNSyncStreamsOfN(10000, 10).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(100000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNSyncStreamsOfN(10000, 10).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(100000, to.values().size()); } @Test public void merge1000000SyncStreamOf1() { - TestObserver ts = new TestObserver(); - mergeNSyncStreamsOfN(1000000, 1).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(1000000, ts.values().size()); + TestObserver to = new TestObserver(); + mergeNSyncStreamsOfN(1000000, 1).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(1000000, to.values().size()); } private Observable mergeNSyncStreamsOfN(final int outerSize, final int innerSize) { @@ -1014,7 +1014,7 @@ public boolean hasNext() { @Test public void mergeManyAsyncSingle() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable> os = Observable.range(1, 10000) .map(new Function>() { @@ -1040,10 +1040,10 @@ public void subscribe(Observer s) { } }); - Observable.merge(os).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(10000, ts.values().size()); + Observable.merge(os).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(10000, to.values().size()); } Function> toScalar = new Function>() { @@ -1061,21 +1061,21 @@ public Observable apply(Integer t) { }; ; - void runMerge(Function> func, TestObserver ts) { + void runMerge(Function> func, TestObserver to) { List list = new ArrayList(); for (int i = 0; i < 1000; i++) { list.add(i); } Observable source = Observable.fromIterable(list); - source.flatMap(func).subscribe(ts); + source.flatMap(func).subscribe(to); - if (ts.values().size() != 1000) { - System.out.println(ts.values()); + if (to.values().size() != 1000) { + System.out.println(to.values()); } - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValueSequence(list); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValueSequence(list); } @Test @@ -1089,7 +1089,7 @@ public void testFastMergeHiddenScalar() { @Test public void testSlowMergeFullScalar() { for (final int req : new int[] { 16, 32, 64, 128, 256 }) { - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { int remaining = req; @Override @@ -1100,13 +1100,13 @@ public void onNext(Integer t) { } } }; - runMerge(toScalar, ts); + runMerge(toScalar, to); } } @Test public void testSlowMergeHiddenScalar() { for (final int req : new int[] { 16, 32, 64, 128, 256 }) { - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { int remaining = req; @Override public void onNext(Integer t) { @@ -1116,7 +1116,7 @@ public void onNext(Integer t) { } } }; - runMerge(toHiddenScalar, ts); + runMerge(toHiddenScalar, to); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableObserveOnTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableObserveOnTest.java index 8b0dedc22b..0062e220ee 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableObserveOnTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableObserveOnTest.java @@ -64,13 +64,13 @@ public void testOrdering() throws InterruptedException { Observer observer = TestHelper.mockObserver(); InOrder inOrder = inOrder(observer); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); - obs.observeOn(Schedulers.computation()).subscribe(ts); + obs.observeOn(Schedulers.computation()).subscribe(to); - ts.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); - if (ts.errors().size() > 0) { - for (Throwable t : ts.errors()) { + to.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); + if (to.errors().size() > 0) { + for (Throwable t : to.errors()) { t.printStackTrace(); } fail("failed with exception"); @@ -388,13 +388,13 @@ public void testAfterUnsubscribeCalledThenObserverOnNextNeverCalled() { final TestScheduler testScheduler = new TestScheduler(); final Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); Observable.just(1, 2, 3) .observeOn(testScheduler) - .subscribe(ts); + .subscribe(to); - ts.dispose(); + to.dispose(); testScheduler.advanceTimeBy(1, TimeUnit.SECONDS); final InOrder inOrder = inOrder(observer); @@ -429,23 +429,23 @@ public boolean hasNext() { } }); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); o .take(7) .observeOn(Schedulers.newThread()) - .subscribe(ts); + .subscribe(to); - ts.awaitTerminalEvent(); - ts.assertValues(0, 1, 2, 3, 4, 5, 6); + to.awaitTerminalEvent(); + to.assertValues(0, 1, 2, 3, 4, 5, 6); assertEquals(7, generated.get()); } @Test public void testAsyncChild() { - TestObserver ts = new TestObserver(); - Observable.range(0, 100000).observeOn(Schedulers.newThread()).observeOn(Schedulers.newThread()).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + TestObserver to = new TestObserver(); + Observable.range(0, 100000).observeOn(Schedulers.newThread()).observeOn(Schedulers.newThread()).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } @Test @@ -566,33 +566,33 @@ public void inputAsyncFusedErrorDelayed() { @Test public void outputFused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.range(1, 5).hide() .observeOn(Schedulers.single()) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertResult(1, 2, 3, 4, 5); } @Test public void outputFusedReject() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Observable.range(1, 5).hide() .observeOn(Schedulers.single()) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .awaitDone(5, TimeUnit.SECONDS) .assertResult(1, 2, 3, 4, 5); } @Test public void inputOutputAsyncFusedError() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject us = UnicastSubject.create(); @@ -605,14 +605,14 @@ public void inputOutputAsyncFusedError() { .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @Test public void inputOutputAsyncFusedErrorDelayed() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); UnicastSubject us = UnicastSubject.create(); @@ -625,7 +625,7 @@ public void inputOutputAsyncFusedErrorDelayed() { .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); - ObserverFusion.assertFusion(to, QueueDisposable.ASYNC) + ObserverFusion.assertFusion(to, QueueFuseable.ASYNC) .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class); } @@ -643,7 +643,7 @@ public void outputFusedCancelReentrant() throws Exception { @Override public void onSubscribe(Disposable d) { this.d = d; - ((QueueDisposable)d).requestFusion(QueueDisposable.ANY); + ((QueueDisposable)d).requestFusion(QueueFuseable.ANY); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java index 0a94717712..ffb1e5c37b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java @@ -151,7 +151,7 @@ public Observable apply(Throwable t1) { @Test @Ignore("Failed operator may leave the child Observer in an inconsistent state which prevents further error delivery.") public void testOnErrorResumeReceivesErrorFromPreviousNonProtectedOperator() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1).lift(new ObservableOperator() { @Override @@ -170,11 +170,11 @@ public Observable apply(Throwable t1) { } } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - System.out.println(ts.values()); - ts.assertValue("success"); + to.assertTerminated(); + System.out.println(to.values()); + to.assertValue("success"); } /** @@ -184,7 +184,7 @@ public Observable apply(Throwable t1) { @Test @Ignore("A crashing operator may leave the downstream in an inconsistent state and not suitable for event delivery") public void testOnErrorResumeReceivesErrorFromPreviousNonProtectedOperatorOnNext() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1).lift(new ObservableOperator() { @Override @@ -225,11 +225,11 @@ public Observable apply(Throwable t1) { } } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - System.out.println(ts.values()); - ts.assertValue("success"); + to.assertTerminated(); + System.out.println(to.values()); + to.assertValue("success"); } @Test @@ -262,9 +262,9 @@ public Observable apply(Throwable t1) { @SuppressWarnings("unchecked") DefaultObserver observer = mock(DefaultObserver.class); - TestObserver ts = new TestObserver(observer); - o.subscribe(ts); - ts.awaitTerminalEvent(); + TestObserver to = new TestObserver(observer); + o.subscribe(to); + to.awaitTerminalEvent(); verify(observer, Mockito.never()).onError(any(Throwable.class)); verify(observer, times(1)).onComplete(); @@ -314,7 +314,7 @@ public void run() { @Test public void testBackpressure() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 100000) .onErrorResumeNext(new Function>() { @@ -342,9 +342,9 @@ public Integer apply(Integer t1) { } }) - .subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + .subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java index b4c490524c..c0c8edc358 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java @@ -135,10 +135,10 @@ public void subscribe(Observer t1) { @SuppressWarnings("unchecked") DefaultObserver observer = mock(DefaultObserver.class); - TestObserver ts = new TestObserver(observer); - observable.subscribe(ts); + TestObserver to = new TestObserver(observer); + observable.subscribe(to); - ts.awaitTerminalEvent(); + to.awaitTerminalEvent(); verify(observer, Mockito.never()).onError(any(Throwable.class)); verify(observer, times(1)).onComplete(); @@ -190,7 +190,7 @@ public void run() { @Test public void testBackpressure() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 100000) .onErrorResumeNext(Observable.just(1)) .observeOn(Schedulers.computation()) @@ -211,8 +211,8 @@ public Integer apply(Integer t1) { } }) - .subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + .subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorReturnTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorReturnTest.java index d03b184442..18d43e90d4 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorReturnTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorReturnTest.java @@ -130,9 +130,9 @@ public String apply(Throwable t1) { @SuppressWarnings("unchecked") DefaultObserver observer = mock(DefaultObserver.class); - TestObserver ts = new TestObserver(observer); - observable.subscribe(ts); - ts.awaitTerminalEvent(); + TestObserver to = new TestObserver(observer); + observable.subscribe(to); + to.awaitTerminalEvent(); verify(observer, Mockito.never()).onError(any(Throwable.class)); verify(observer, times(1)).onComplete(); @@ -144,7 +144,7 @@ public String apply(Throwable t1) { @Test public void testBackpressure() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 100000) .onErrorReturn(new Function() { @@ -172,9 +172,9 @@ public Integer apply(Integer t1) { } }) - .subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + .subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } private static class TestObservable implements ObservableSource { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnExceptionResumeNextViaObservableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnExceptionResumeNextViaObservableTest.java index adab10b79d..173f506bce 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnExceptionResumeNextViaObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnExceptionResumeNextViaObservableTest.java @@ -186,7 +186,7 @@ public String apply(String s) { @Test public void testBackpressure() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(0, 100000) .onExceptionResumeNext(Observable.just(1)) .observeOn(Schedulers.computation()) @@ -207,9 +207,9 @@ public Integer apply(Integer t1) { } }) - .subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + .subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservablePublishTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservablePublishTest.java index 90a78db347..e280f5cf9d 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservablePublishTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservablePublishTest.java @@ -125,12 +125,12 @@ public void run() { }); - TestObserver ts = new TestObserver(); - Observable.merge(fast, slow).subscribe(ts); + TestObserver to = new TestObserver(); + Observable.merge(fast, slow).subscribe(to); is.connect(); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 4, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 4, to.valueCount()); } // use case from https://github.com/ReactiveX/RxJava/issues/1732 @@ -145,7 +145,7 @@ public void accept(Integer t1) { } }); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); xs.publish(new Function, Observable>() { @Override @@ -160,19 +160,19 @@ public boolean test(Integer i) { })); } - }).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - ts.assertValues(0, 1, 2, 3); + }).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + to.assertValues(0, 1, 2, 3); assertEquals(5, emitted.get()); - System.out.println(ts.values()); + System.out.println(to.values()); } // use case from https://github.com/ReactiveX/RxJava/issues/1732 @Test public void testTakeUntilWithPublishedStream() { Observable xs = Observable.range(0, Flowable.bufferSize() * 2); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); ConnectableObservable xsp = xs.publish(); xsp.takeUntil(xsp.skipWhile(new Predicate() { @@ -181,9 +181,9 @@ public boolean test(Integer i) { return i <= 3; } - })).subscribe(ts); + })).subscribe(to); xsp.connect(); - System.out.println(ts.values()); + System.out.println(to.values()); } @Test(timeout = 10000) @@ -208,9 +208,9 @@ public void run() { final AtomicBoolean child1Unsubscribed = new AtomicBoolean(); final AtomicBoolean child2Unsubscribed = new AtomicBoolean(); - final TestObserver ts2 = new TestObserver(); + final TestObserver to2 = new TestObserver(); - final TestObserver ts1 = new TestObserver() { + final TestObserver to1 = new TestObserver() { @Override public void onNext(Integer t) { if (valueCount() == 2) { @@ -219,7 +219,7 @@ public void onNext(Integer t) { public void run() { child2Unsubscribed.set(true); } - }).take(5).subscribe(ts2); + }).take(5).subscribe(to2); } super.onNext(t); } @@ -231,20 +231,20 @@ public void run() { child1Unsubscribed.set(true); } }).take(5) - .subscribe(ts1); + .subscribe(to1); - ts1.awaitTerminalEvent(); - ts2.awaitTerminalEvent(); + to1.awaitTerminalEvent(); + to2.awaitTerminalEvent(); - ts1.assertNoErrors(); - ts2.assertNoErrors(); + to1.assertNoErrors(); + to2.assertNoErrors(); assertTrue(sourceUnsubscribed.get()); assertTrue(child1Unsubscribed.get()); assertTrue(child2Unsubscribed.get()); - ts1.assertValues(1, 2, 3, 4, 5); - ts2.assertValues(4, 5, 6, 7, 8); + to1.assertValues(1, 2, 3, 4, 5); + to2.assertValues(4, 5, 6, 7, 8); assertEquals(8, sourceEmission.get()); } @@ -269,25 +269,25 @@ public void testConnectWithNoSubscriber() { public void testSubscribeAfterDisconnectThenConnect() { ConnectableObservable source = Observable.just(1).publish(); - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); - source.subscribe(ts1); + source.subscribe(to1); Disposable s = source.connect(); - ts1.assertValue(1); - ts1.assertNoErrors(); - ts1.assertTerminated(); + to1.assertValue(1); + to1.assertNoErrors(); + to1.assertTerminated(); - TestObserver ts2 = new TestObserver(); + TestObserver to2 = new TestObserver(); - source.subscribe(ts2); + source.subscribe(to2); Disposable s2 = source.connect(); - ts2.assertValue(1); - ts2.assertNoErrors(); - ts2.assertTerminated(); + to2.assertValue(1); + to2.assertNoErrors(); + to2.assertTerminated(); System.out.println(s); System.out.println(s2); @@ -297,19 +297,19 @@ public void testSubscribeAfterDisconnectThenConnect() { public void testNoSubscriberRetentionOnCompleted() { ObservablePublish source = (ObservablePublish)Observable.just(1).publish(); - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); - source.subscribe(ts1); + source.subscribe(to1); - ts1.assertNoValues(); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertNoValues(); + to1.assertNoErrors(); + to1.assertNotComplete(); source.connect(); - ts1.assertValue(1); - ts1.assertNoErrors(); - ts1.assertTerminated(); + to1.assertValue(1); + to1.assertNoErrors(); + to1.assertTerminated(); assertNull(source.current.get()); } @@ -378,20 +378,20 @@ public void testObserveOn() { Observable obs = co.observeOn(Schedulers.computation()); for (int i = 0; i < 1000; i++) { for (int j = 1; j < 6; j++) { - List> tss = new ArrayList>(); + List> tos = new ArrayList>(); for (int k = 1; k < j; k++) { - TestObserver ts = new TestObserver(); - tss.add(ts); - obs.subscribe(ts); + TestObserver to = new TestObserver(); + tos.add(to); + obs.subscribe(to); } Disposable s = co.connect(); - for (TestObserver ts : tss) { - ts.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts.assertTerminated(); - ts.assertNoErrors(); - assertEquals(1000, ts.valueCount()); + for (TestObserver to : tos) { + to.awaitTerminalEvent(2, TimeUnit.SECONDS); + to.assertTerminated(); + to.assertNoErrors(); + assertEquals(1000, to.valueCount()); } s.dispose(); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeLongTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeLongTest.java index e06da6205b..d09ec0d6ce 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeLongTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeLongTest.java @@ -24,7 +24,7 @@ import io.reactivex.*; import io.reactivex.functions.Consumer; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.observers.*; public class ObservableRangeLongTest { @@ -99,12 +99,12 @@ public void testNoBackpressure() { Observable o = Observable.rangeLong(1, list.size()); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - o.subscribe(ts); + o.subscribe(to); - ts.assertValueSequence(list); - ts.assertTerminated(); + to.assertValueSequence(list); + to.assertTerminated(); } @Test @@ -136,12 +136,12 @@ public void onNext(Long t) { @Test(timeout = 1000) public void testNearMaxValueWithoutBackpressure() { - TestObserver ts = new TestObserver(); - Observable.rangeLong(Long.MAX_VALUE - 1L, 2L).subscribe(ts); + TestObserver to = new TestObserver(); + Observable.rangeLong(Long.MAX_VALUE - 1L, 2L).subscribe(to); - ts.assertComplete(); - ts.assertNoErrors(); - ts.assertValues(Long.MAX_VALUE - 1, Long.MAX_VALUE); + to.assertComplete(); + to.assertNoErrors(); + to.assertValues(Long.MAX_VALUE - 1, Long.MAX_VALUE); } @Test @@ -170,21 +170,21 @@ public void noOverflow() { @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Observable.rangeLong(1, 2).subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.SYNC) + ObserverFusion.assertFusion(to, QueueFuseable.SYNC) .assertResult(1L, 2L); } @Test public void fusedReject() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.rangeLong(1, 2).subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1L, 2L); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeTest.java index 3fe8a047f0..cbdc0130ec 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRangeTest.java @@ -14,6 +14,7 @@ package io.reactivex.internal.operators.observable; import static org.junit.Assert.*; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; import java.util.ArrayList; @@ -23,7 +24,7 @@ import io.reactivex.*; import io.reactivex.functions.Consumer; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.observers.*; public class ObservableRangeTest { @@ -99,12 +100,12 @@ public void testNoBackpressure() { Observable o = Observable.range(1, list.size()); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - o.subscribe(ts); + o.subscribe(to); - ts.assertValueSequence(list); - ts.assertTerminated(); + to.assertValueSequence(list); + to.assertTerminated(); } @Test @@ -136,12 +137,12 @@ public void onNext(Integer t) { @Test(timeout = 1000) public void testNearMaxValueWithoutBackpressure() { - TestObserver ts = new TestObserver(); - Observable.range(Integer.MAX_VALUE - 1, 2).subscribe(ts); + TestObserver to = new TestObserver(); + Observable.range(Integer.MAX_VALUE - 1, 2).subscribe(to); - ts.assertComplete(); - ts.assertNoErrors(); - ts.assertValues(Integer.MAX_VALUE - 1, Integer.MAX_VALUE); + to.assertComplete(); + to.assertNoErrors(); + to.assertValues(Integer.MAX_VALUE - 1, Integer.MAX_VALUE); } @Test @@ -156,12 +157,12 @@ public void negativeCount() { @Test public void requestWrongFusion() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ASYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ASYNC); Observable.range(1, 5) .subscribe(to); - ObserverFusion.assertFusion(to, QueueDisposable.NONE) + ObserverFusion.assertFusion(to, QueueFuseable.NONE) .assertResult(1, 2, 3, 4, 5); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRefCountTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRefCountTest.java index abd93aa73b..4df48c59ac 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRefCountTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRefCountTest.java @@ -186,20 +186,20 @@ public void run() { .publish().refCount(); for (int i = 0; i < 10; i++) { - TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver(); - r.subscribe(ts1); - r.subscribe(ts2); + TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver(); + r.subscribe(to1); + r.subscribe(to2); try { Thread.sleep(50); } catch (InterruptedException e) { } - ts1.dispose(); - ts2.dispose(); - ts1.assertNoErrors(); - ts2.assertNoErrors(); - assertTrue(ts1.valueCount() > 0); - assertTrue(ts2.valueCount() > 0); + to1.dispose(); + to2.dispose(); + to1.assertNoErrors(); + to2.assertNoErrors(); + assertTrue(to1.valueCount() > 0); + assertTrue(to2.valueCount() > 0); } assertEquals(10, subscribeCount.get()); @@ -494,19 +494,19 @@ public Integer apply(Integer t1, Integer t2) { }) .publish().refCount(); - TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver(); + TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver(); - combined.subscribe(ts1); - combined.subscribe(ts2); + combined.subscribe(to1); + combined.subscribe(to2); - ts1.assertTerminated(); - ts1.assertNoErrors(); - ts1.assertValue(30); + to1.assertTerminated(); + to1.assertNoErrors(); + to1.assertValue(30); - ts2.assertTerminated(); - ts2.assertNoErrors(); - ts2.assertValue(30); + to2.assertTerminated(); + to2.assertNoErrors(); + to2.assertValue(30); } @Test(timeout = 10000) diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRepeatTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRepeatTest.java index 04fc4cddf8..3616ef729f 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRepeatTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRepeatTest.java @@ -162,20 +162,20 @@ public void testRepeatAndDistinctUnbounded() { .repeat(3) .distinct(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - src.subscribe(ts); + src.subscribe(to); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertValues(1, 2, 3); + to.assertNoErrors(); + to.assertTerminated(); + to.assertValues(1, 2, 3); } /** Issue #2844: wrong target of request. */ @Test(timeout = 3000) public void testRepeatRetarget() { final List concatBase = new ArrayList(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1, 2) .repeat(5) .concatMap(new Function>() { @@ -187,11 +187,11 @@ public Observable apply(Integer x) { .delay(200, TimeUnit.MILLISECONDS); } }) - .subscribe(ts); + .subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - ts.assertNoValues(); + to.awaitTerminalEvent(); + to.assertNoErrors(); + to.assertNoValues(); assertEquals(Arrays.asList(1, 2, 1, 2, 1, 2, 1, 2, 1, 2), concatBase); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableReplayTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableReplayTest.java index 0d64c4308f..8c483fc40d 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableReplayTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableReplayTest.java @@ -872,13 +872,13 @@ public void testSizedTruncation() { public void testColdReplayNoBackpressure() { Observable source = Observable.range(0, 1000).replay().autoConnect(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.subscribe(ts); + source.subscribe(to); - ts.assertNoErrors(); - ts.assertTerminated(); - List onNextEvents = ts.values(); + to.assertNoErrors(); + to.assertTerminated(); + List onNextEvents = to.values(); assertEquals(1000, onNextEvents.size()); for (int i = 0; i < 1000; i++) { @@ -950,14 +950,14 @@ public void testUnsubscribeSource() throws Exception { @Test public void testTake() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable cached = Observable.range(1, 100).replay().autoConnect(); - cached.take(10).subscribe(ts); + cached.take(10).subscribe(to); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertNoErrors(); + to.assertTerminated(); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); // FIXME no longer assertable // ts.assertUnsubscribed(); } @@ -966,24 +966,24 @@ public void testTake() { public void testAsync() { Observable source = Observable.range(1, 10000); for (int i = 0; i < 100; i++) { - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); Observable cached = source.replay().autoConnect(); - cached.observeOn(Schedulers.computation()).subscribe(ts1); + cached.observeOn(Schedulers.computation()).subscribe(to1); - ts1.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts1.assertNoErrors(); - ts1.assertTerminated(); - assertEquals(10000, ts1.values().size()); + to1.awaitTerminalEvent(2, TimeUnit.SECONDS); + to1.assertNoErrors(); + to1.assertTerminated(); + assertEquals(10000, to1.values().size()); - TestObserver ts2 = new TestObserver(); - cached.observeOn(Schedulers.computation()).subscribe(ts2); + TestObserver to2 = new TestObserver(); + cached.observeOn(Schedulers.computation()).subscribe(to2); - ts2.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts2.assertNoErrors(); - ts2.assertTerminated(); - assertEquals(10000, ts2.values().size()); + to2.awaitTerminalEvent(2, TimeUnit.SECONDS); + to2.assertNoErrors(); + to2.assertTerminated(); + assertEquals(10000, to2.values().size()); } } @Test @@ -997,9 +997,9 @@ public void testAsyncComeAndGo() { List> list = new ArrayList>(100); for (int i = 0; i < 100; i++) { - TestObserver ts = new TestObserver(); - list.add(ts); - output.skip(i * 10).take(10).subscribe(ts); + TestObserver to = new TestObserver(); + list.add(to); + output.skip(i * 10).take(10).subscribe(to); } List expected = new ArrayList(); @@ -1007,16 +1007,16 @@ public void testAsyncComeAndGo() { expected.add((long)(i - 10)); } int j = 0; - for (TestObserver ts : list) { - ts.awaitTerminalEvent(3, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertTerminated(); + for (TestObserver to : list) { + to.awaitTerminalEvent(3, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertTerminated(); for (int i = j * 10; i < j * 10 + 10; i++) { expected.set(i - j * 10, (long)i); } - ts.assertValueSequence(expected); + to.assertValueSequence(expected); j++; } @@ -1036,14 +1036,14 @@ public void subscribe(Observer t) { } }); - TestObserver ts = new TestObserver(); - firehose.replay().autoConnect().observeOn(Schedulers.computation()).takeLast(100).subscribe(ts); + TestObserver to = new TestObserver(); + firehose.replay().autoConnect().observeOn(Schedulers.computation()).takeLast(100).subscribe(to); - ts.awaitTerminalEvent(3, TimeUnit.SECONDS); - ts.assertNoErrors(); - ts.assertTerminated(); + to.awaitTerminalEvent(3, TimeUnit.SECONDS); + to.assertNoErrors(); + to.assertTerminated(); - assertEquals(100, ts.values().size()); + assertEquals(100, to.values().size()); } @Test @@ -1053,19 +1053,19 @@ public void testValuesAndThenError() { .replay().autoConnect(); - TestObserver ts = new TestObserver(); - source.subscribe(ts); + TestObserver to = new TestObserver(); + source.subscribe(to); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); - ts.assertNotComplete(); - Assert.assertEquals(1, ts.errors().size()); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertNotComplete(); + Assert.assertEquals(1, to.errors().size()); - TestObserver ts2 = new TestObserver(); - source.subscribe(ts2); + TestObserver to2 = new TestObserver(); + source.subscribe(to2); - ts2.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); - ts2.assertNotComplete(); - Assert.assertEquals(1, ts2.errors().size()); + to2.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to2.assertNotComplete(); + Assert.assertEquals(1, to2.errors().size()); } @Test @@ -1082,20 +1082,20 @@ public void accept(Integer t) { }) .replay().autoConnect(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { throw new TestException(); } }; - source.subscribe(ts); + source.subscribe(to); Assert.assertEquals(100, count.get()); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryTest.java index 2d5e3d2aa8..a776cc97a7 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryTest.java @@ -60,7 +60,7 @@ public void subscribe(Observer t1) { } }); - TestObserver ts = new TestObserver(consumer); + TestObserver to = new TestObserver(consumer); producer.retryWhen(new Function, Observable>() { @Override @@ -86,9 +86,9 @@ public Observable apply(Tuple t) { Observable.timer(t.count * 1L, TimeUnit.MILLISECONDS); }}).cast(Object.class); } - }).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + }).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); InOrder inOrder = inOrder(consumer); inOrder.verify(consumer, never()).onError(any(Throwable.class)); @@ -451,7 +451,7 @@ public void run() { public void testSourceObservableCallsUnsubscribe() throws InterruptedException { final AtomicInteger subsCount = new AtomicInteger(0); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); ObservableSource onSubscribe = new ObservableSource() { @Override @@ -474,7 +474,7 @@ public void subscribe(Observer s) { } }; - Observable.unsafeCreate(onSubscribe).retry(3).subscribe(ts); + Observable.unsafeCreate(onSubscribe).retry(3).subscribe(to); assertEquals(4, subsCount.get()); // 1 + 3 retries } @@ -482,7 +482,7 @@ public void subscribe(Observer s) { public void testSourceObservableRetry1() throws InterruptedException { final AtomicInteger subsCount = new AtomicInteger(0); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); ObservableSource onSubscribe = new ObservableSource() { @Override @@ -493,7 +493,7 @@ public void subscribe(Observer s) { } }; - Observable.unsafeCreate(onSubscribe).retry(1).subscribe(ts); + Observable.unsafeCreate(onSubscribe).retry(1).subscribe(to); assertEquals(2, subsCount.get()); } @@ -501,7 +501,7 @@ public void subscribe(Observer s) { public void testSourceObservableRetry0() throws InterruptedException { final AtomicInteger subsCount = new AtomicInteger(0); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); ObservableSource onSubscribe = new ObservableSource() { @Override @@ -512,7 +512,7 @@ public void subscribe(Observer s) { } }; - Observable.unsafeCreate(onSubscribe).retry(0).subscribe(ts); + Observable.unsafeCreate(onSubscribe).retry(0).subscribe(to); assertEquals(1, subsCount.get()); } @@ -663,9 +663,9 @@ public void testRetryWithBackpressure() throws InterruptedException { for (int i = 0; i < 400; i++) { Observer observer = TestHelper.mockObserver(); Observable origin = Observable.unsafeCreate(new FuncWithErrors(NUM_RETRIES)); - TestObserver ts = new TestObserver(observer); - origin.retry().observeOn(Schedulers.computation()).subscribe(ts); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); + TestObserver to = new TestObserver(observer); + origin.retry().observeOn(Schedulers.computation()).subscribe(to); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); InOrder inOrder = inOrder(observer); // should have no errors @@ -706,16 +706,16 @@ public void run() { final AtomicInteger nexts = new AtomicInteger(); try { Observable origin = Observable.unsafeCreate(new FuncWithErrors(NUM_RETRIES)); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); origin.retry() - .observeOn(Schedulers.computation()).subscribe(ts); - ts.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); - List onNextEvents = new ArrayList(ts.values()); + .observeOn(Schedulers.computation()).subscribe(to); + to.awaitTerminalEvent(2500, TimeUnit.MILLISECONDS); + List onNextEvents = new ArrayList(to.values()); if (onNextEvents.size() != NUM_RETRIES + 2) { - for (Throwable t : ts.errors()) { + for (Throwable t : to.errors()) { onNextEvents.add(t.toString()); } - for (long err = ts.completions(); err != 0; err--) { + for (long err = to.completions(); err != 0; err--) { onNextEvents.add("onComplete"); } data.put(j, onNextEvents); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryWithPredicateTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryWithPredicateTest.java index 1763f74d9f..db87844952 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryWithPredicateTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableRetryWithPredicateTest.java @@ -277,7 +277,7 @@ public void testTimeoutWithRetry() { @Test public void testIssue2826() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final RuntimeException e = new RuntimeException("You shall not pass"); final AtomicInteger c = new AtomicInteger(); Observable.just(1).map(new Function() { @@ -286,11 +286,11 @@ public Integer apply(Integer t1) { c.incrementAndGet(); throw e; } - }).retry(retry5).subscribe(ts); + }).retry(retry5).subscribe(to); - ts.assertTerminated(); + to.assertTerminated(); assertEquals(6, c.get()); - assertEquals(Collections.singletonList(e), ts.errors()); + assertEquals(Collections.singletonList(e), to.errors()); } @Test public void testJustAndRetry() throws Exception { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableSampleTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableSampleTest.java index 92569c5d92..3ad79160a0 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableSampleTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableSampleTest.java @@ -323,17 +323,17 @@ public void emitLastTimedRunCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final TestScheduler scheduler = new TestScheduler(); - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.sample(1, TimeUnit.SECONDS, scheduler, true) + TestObserver to = ps.sample(1, TimeUnit.SECONDS, scheduler, true) .test(); - pp.onNext(1); + ps.onNext(1); Runnable r1 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; @@ -346,7 +346,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(1); + to.assertResult(1); } } @@ -369,18 +369,18 @@ public void emitLastOtherEmpty() { @Test public void emitLastOtherRunCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); final PublishSubject sampler = PublishSubject.create(); - TestObserver ts = pp.sample(sampler, true) + TestObserver to = ps.sample(sampler, true) .test(); - pp.onNext(1); + ps.onNext(1); Runnable r1 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; @@ -393,24 +393,24 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(1); + to.assertResult(1); } } @Test public void emitLastOtherCompleteCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); final PublishSubject sampler = PublishSubject.create(); - TestObserver ts = pp.sample(sampler, true).test(); + TestObserver to = ps.sample(sampler, true).test(); - pp.onNext(1); + ps.onNext(1); Runnable r1 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; @@ -423,7 +423,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(1); + to.assertResult(1); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableScalarXMapTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableScalarXMapTest.java index ba401f5124..cb4661943c 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableScalarXMapTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableScalarXMapTest.java @@ -73,85 +73,85 @@ public Integer call() throws Exception { @Test public void tryScalarXMap() { - TestObserver ts = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new CallablePublisher(), ts, new Function>() { + TestObserver to = new TestObserver(); + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new CallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { return Observable.just(1); } })); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void emptyXMap() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new EmptyCallablePublisher(), ts, new Function>() { + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new EmptyCallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { return Observable.just(1); } })); - ts.assertResult(); + to.assertResult(); } @Test public void mapperCrashes() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), ts, new Function>() { + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { throw new TestException(); } })); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void mapperToJust() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), ts, new Function>() { + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { return Observable.just(1); } })); - ts.assertResult(1); + to.assertResult(1); } @Test public void mapperToEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), ts, new Function>() { + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { return Observable.empty(); } })); - ts.assertResult(); + to.assertResult(); } @Test public void mapperToCrashingCallable() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), ts, new Function>() { + assertTrue(ObservableScalarXMap.tryScalarXMapSubscribe(new OneCallablePublisher(), to, new Function>() { @Override public ObservableSource apply(Integer f) throws Exception { return new CallablePublisher(); } })); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableScanTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableScanTest.java index 8baf9b427e..8cd3aa75b6 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableScanTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableScanTest.java @@ -115,7 +115,7 @@ public Integer apply(Integer t1, Integer t2) { @Test public void shouldNotEmitUntilAfterSubscription() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 100).scan(0, new BiFunction() { @Override @@ -131,9 +131,9 @@ public boolean test(Integer t1) { return t1 > 0; } - }).subscribe(ts); + }).subscribe(to); - assertEquals(100, ts.values().size()); + assertEquals(100, to.values().size()); } @Test @@ -219,18 +219,18 @@ public Integer apply(Integer t1, Integer t2) { public void testInitialValueEmittedNoProducer() { PublishSubject source = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); source.scan(0, new BiFunction() { @Override public Integer apply(Integer t1, Integer t2) { return t1 + t2; } - }).subscribe(ts); + }).subscribe(to); - ts.assertNoErrors(); - ts.assertNotComplete(); - ts.assertValue(0); + to.assertNoErrors(); + to.assertNotComplete(); + to.assertValue(0); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipLastTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipLastTest.java index b88bd7855b..b89d70b8df 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipLastTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipLastTest.java @@ -96,11 +96,11 @@ public void testSkipLastWithNull() { @Test public void testSkipLastWithBackpressure() { Observable o = Observable.range(0, Flowable.bufferSize() * 2).skipLast(Flowable.bufferSize() + 10); - TestObserver ts = new TestObserver(); - o.observeOn(Schedulers.computation()).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals((Flowable.bufferSize()) - 10, ts.valueCount()); + TestObserver to = new TestObserver(); + o.observeOn(Schedulers.computation()).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals((Flowable.bufferSize()) - 10, to.valueCount()); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipTest.java index 681475c22c..d787de26bf 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableSkipTest.java @@ -137,12 +137,12 @@ public void testSkipError() { @Test public void testRequestOverflowDoesNotOccur() { - TestObserver ts = new TestObserver(); - Observable.range(1, 10).skip(5).subscribe(ts); - ts.assertTerminated(); - ts.assertComplete(); - ts.assertNoErrors(); - assertEquals(Arrays.asList(6,7,8,9,10), ts.values()); + TestObserver to = new TestObserver(); + Observable.range(1, 10).skip(5).subscribe(to); + to.assertTerminated(); + to.assertComplete(); + to.assertNoErrors(); + assertEquals(Arrays.asList(6,7,8,9,10), to.values()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableSubscribeOnTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableSubscribeOnTest.java index 6418c5338f..03e5472bde 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableSubscribeOnTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableSubscribeOnTest.java @@ -74,7 +74,7 @@ public void subscribe( @Test @Ignore("ObservableSource.subscribe can't throw") public void testThrownErrorHandling() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.unsafeCreate(new ObservableSource() { @Override @@ -82,14 +82,14 @@ public void subscribe(Observer s) { throw new RuntimeException("fail"); } - }).subscribeOn(Schedulers.computation()).subscribe(ts); - ts.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); - ts.assertTerminated(); + }).subscribeOn(Schedulers.computation()).subscribe(to); + to.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); + to.assertTerminated(); } @Test public void testOnError() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.unsafeCreate(new ObservableSource() { @Override @@ -98,9 +98,9 @@ public void subscribe(Observer s) { s.onError(new RuntimeException("fail")); } - }).subscribeOn(Schedulers.computation()).subscribe(ts); - ts.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); - ts.assertTerminated(); + }).subscribeOn(Schedulers.computation()).subscribe(to); + to.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); + to.assertTerminated(); } public static class SlowScheduler extends Scheduler { @@ -162,7 +162,7 @@ public Disposable schedule(@NonNull final Runnable action, final long delayTime, @Test(timeout = 5000) public void testUnsubscribeInfiniteStream() throws InterruptedException { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger count = new AtomicInteger(); Observable.unsafeCreate(new ObservableSource() { @@ -176,12 +176,12 @@ public void subscribe(Observer sub) { } } - }).subscribeOn(Schedulers.newThread()).take(10).subscribe(ts); + }).subscribeOn(Schedulers.newThread()).take(10).subscribe(to); - ts.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); - ts.dispose(); + to.awaitTerminalEvent(1000, TimeUnit.MILLISECONDS); + to.dispose(); Thread.sleep(200); // give time for the loop to continue - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); assertEquals(10, count.get()); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableSwitchTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableSwitchTest.java index 034890b1bd..680eb17753 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableSwitchTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableSwitchTest.java @@ -461,7 +461,7 @@ public String apply(Long i) { .share() ; - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(String t) { super.onNext(t); @@ -471,16 +471,16 @@ public void onNext(String t) { } } }; - src.subscribe(ts); + src.subscribe(to); - ts.awaitTerminalEvent(10, TimeUnit.SECONDS); + to.awaitTerminalEvent(10, TimeUnit.SECONDS); - System.out.println("> testIssue2654: " + ts.valueCount()); + System.out.println("> testIssue2654: " + to.valueCount()); - ts.assertTerminated(); - ts.assertNoErrors(); + to.assertTerminated(); + to.assertNoErrors(); - Assert.assertEquals(250, ts.valueCount()); + Assert.assertEquals(250, to.valueCount()); } @@ -488,10 +488,10 @@ public void onNext(String t) { public void delayErrors() { PublishSubject> source = PublishSubject.create(); - TestObserver ts = source.switchMapDelayError(Functions.>identity()) + TestObserver to = source.switchMapDelayError(Functions.>identity()) .test(); - ts.assertNoValues() + to.assertNoValues() .assertNoErrors() .assertNotComplete(); @@ -507,11 +507,11 @@ public void delayErrors() { source.onError(new TestException("Forced failure 3")); - ts.assertValues(1, 2, 3, 4, 5) + to.assertValues(1, 2, 3, 4, 5) .assertNotComplete() .assertError(CompositeException.class); - List errors = ExceptionHelper.flatten(ts.errors().get(0)); + List errors = ExceptionHelper.flatten(to.errors().get(0)); TestHelper.assertError(errors, 0, TestException.class, "Forced failure 1"); TestHelper.assertError(errors, 1, TestException.class, "Forced failure 2"); @@ -522,40 +522,40 @@ public void delayErrors() { public void switchOnNextDelayError() { PublishSubject> ps = PublishSubject.create(); - TestObserver ts = Observable.switchOnNextDelayError(ps).test(); + TestObserver to = Observable.switchOnNextDelayError(ps).test(); ps.onNext(Observable.just(1)); ps.onNext(Observable.range(2, 4)); ps.onComplete(); - ts.assertResult(1, 2, 3, 4, 5); + to.assertResult(1, 2, 3, 4, 5); } @Test public void switchOnNextDelayErrorWithError() { PublishSubject> ps = PublishSubject.create(); - TestObserver ts = Observable.switchOnNextDelayError(ps).test(); + TestObserver to = Observable.switchOnNextDelayError(ps).test(); ps.onNext(Observable.just(1)); ps.onNext(Observable.error(new TestException())); ps.onNext(Observable.range(2, 4)); ps.onComplete(); - ts.assertFailure(TestException.class, 1, 2, 3, 4, 5); + to.assertFailure(TestException.class, 1, 2, 3, 4, 5); } @Test public void switchOnNextDelayErrorBufferSize() { PublishSubject> ps = PublishSubject.create(); - TestObserver ts = Observable.switchOnNextDelayError(ps, 2).test(); + TestObserver to = Observable.switchOnNextDelayError(ps, 2).test(); ps.onNext(Observable.just(1)); ps.onNext(Observable.range(2, 4)); ps.onComplete(); - ts.assertResult(1, 2, 3, 4, 5); + to.assertResult(1, 2, 3, 4, 5); } @Test @@ -610,17 +610,17 @@ public ObservableSource apply(Object v) throws Exception { @Test public void switchMapInnerCancelled() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = Observable.just(1) - .switchMap(Functions.justFunction(pp)) + TestObserver to = Observable.just(1) + .switchMap(Functions.justFunction(ps)) .test(); - assertTrue(pp.hasObservers()); + assertTrue(ps.hasObservers()); - ts.cancel(); + to.cancel(); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeLastTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeLastTest.java index e2c91fb6a4..27327bffcf 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeLastTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeLastTest.java @@ -103,23 +103,23 @@ public void testTakeLastWithNegativeCount() { @Test public void testBackpressure1() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 100000).takeLast(1) .observeOn(Schedulers.newThread()) - .map(newSlowProcessor()).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - ts.assertValue(100000); + .map(newSlowProcessor()).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + to.assertValue(100000); } @Test public void testBackpressure2() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 100000).takeLast(Flowable.bufferSize() * 4) - .observeOn(Schedulers.newThread()).map(newSlowProcessor()).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Flowable.bufferSize() * 4, ts.valueCount()); + .observeOn(Schedulers.newThread()).map(newSlowProcessor()).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Flowable.bufferSize() * 4, to.valueCount()); } private Function newSlowProcessor() { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeTest.java index c094ad0c06..f966cd8647 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeTest.java @@ -281,12 +281,12 @@ public void subscribe(Observer op) { @Test(timeout = 2000) public void testTakeObserveOn() { Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); INFINITE_OBSERVABLE - .observeOn(Schedulers.newThread()).take(1).subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + .observeOn(Schedulers.newThread()).take(1).subscribe(to); + to.awaitTerminalEvent(); + to.assertNoErrors(); verify(o).onNext(1L); verify(o, never()).onNext(2L); @@ -323,38 +323,38 @@ public void accept(Integer t1) { public void takeFinalValueThrows() { Observable source = Observable.just(1).take(1); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { throw new TestException(); } }; - source.safeSubscribe(ts); + source.safeSubscribe(to); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test public void testReentrantTake() { final PublishSubject source = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); source.take(1).doOnNext(new Consumer() { @Override public void accept(Integer v) { source.onNext(2); } - }).subscribe(ts); + }).subscribe(to); source.onNext(1); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(1); + to.assertNoErrors(); + to.assertComplete(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilPredicateTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilPredicateTest.java index 6e3614525b..722da7890a 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilPredicateTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilPredicateTest.java @@ -136,7 +136,7 @@ public boolean test(Integer v) { @Test public void testErrorIncludesLastValueAsCause() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final TestException e = new TestException("Forced failure"); Predicate predicate = (new Predicate() { @Override @@ -144,11 +144,11 @@ public boolean test(String t) { throw e; } }); - Observable.just("abc").takeUntil(predicate).subscribe(ts); + Observable.just("abc").takeUntil(predicate).subscribe(to); - ts.assertTerminated(); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertTerminated(); + to.assertNotComplete(); + to.assertError(TestException.class); // FIXME last cause value is not saved // assertTrue(ts.errors().get(0).getCause().getMessage().contains("abc")); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilTest.java index 9c6fcba337..7a2f139da9 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeUntilTest.java @@ -188,21 +188,21 @@ public void testUntilFires() { PublishSubject source = PublishSubject.create(); PublishSubject until = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.takeUntil(until).subscribe(ts); + source.takeUntil(until).subscribe(to); assertTrue(source.hasObservers()); assertTrue(until.hasObservers()); source.onNext(1); - ts.assertValue(1); + to.assertValue(1); until.onNext(1); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertTerminated(); + to.assertValue(1); + to.assertNoErrors(); + to.assertTerminated(); assertFalse("Source still has observers", source.hasObservers()); assertFalse("Until still has observers", until.hasObservers()); @@ -214,9 +214,9 @@ public void testMainCompletes() { PublishSubject source = PublishSubject.create(); PublishSubject until = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.takeUntil(until).subscribe(ts); + source.takeUntil(until).subscribe(to); assertTrue(source.hasObservers()); assertTrue(until.hasObservers()); @@ -224,9 +224,9 @@ public void testMainCompletes() { source.onNext(1); source.onComplete(); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertTerminated(); + to.assertValue(1); + to.assertNoErrors(); + to.assertTerminated(); assertFalse("Source still has observers", source.hasObservers()); assertFalse("Until still has observers", until.hasObservers()); @@ -238,18 +238,18 @@ public void testDownstreamUnsubscribes() { PublishSubject source = PublishSubject.create(); PublishSubject until = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.takeUntil(until).take(1).subscribe(ts); + source.takeUntil(until).take(1).subscribe(to); assertTrue(source.hasObservers()); assertTrue(until.hasObservers()); source.onNext(1); - ts.assertValue(1); - ts.assertNoErrors(); - ts.assertTerminated(); + to.assertValue(1); + to.assertNoErrors(); + to.assertTerminated(); assertFalse("Source still has observers", source.hasObservers()); assertFalse("Until still has observers", until.hasObservers()); @@ -266,8 +266,8 @@ public void dispose() { public void doubleOnSubscribe() { TestHelper.checkDoubleOnSubscribeObservable(new Function, Observable>() { @Override - public Observable apply(Observable c) throws Exception { - return c.takeUntil(Observable.never()); + public Observable apply(Observable o) throws Exception { + return o.takeUntil(Observable.never()); } }); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeWhileTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeWhileTest.java index 545cb4e65e..4b615de665 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeWhileTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTakeWhileTest.java @@ -221,12 +221,12 @@ public boolean test(Integer t1) { return t1 < 2; } }); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - source.subscribe(ts); + source.subscribe(to); - ts.assertNoErrors(); - ts.assertValue(1); + to.assertNoErrors(); + to.assertValue(1); // 2.0.2 - not anymore // Assert.assertTrue("Not cancelled!", ts.isCancelled()); @@ -234,17 +234,17 @@ public boolean test(Integer t1) { @Test public void testErrorCauseIncludesLastValue() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just("abc").takeWhile(new Predicate() { @Override public boolean test(String t1) { throw new TestException(); } - }).subscribe(ts); + }).subscribe(to); - ts.assertTerminated(); - ts.assertNoValues(); - ts.assertError(TestException.class); + to.assertTerminated(); + to.assertNoValues(); + to.assertError(TestException.class); // FIXME last cause value not recorded // assertTrue(ts.getOnErrorEvents().get(0).getCause().getMessage().contains("abc")); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutTests.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutTests.java index 3c244964c9..07e7c4c39b 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutTests.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutTests.java @@ -50,24 +50,24 @@ public void setUp() { @Test public void shouldNotTimeoutIfOnNextWithinTimeout() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); - withTimeout.subscribe(ts); + withTimeout.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); verify(observer).onNext("One"); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); verify(observer, never()).onError(any(Throwable.class)); - ts.dispose(); + to.dispose(); } @Test public void shouldNotTimeoutIfSecondOnNextWithinTimeout() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); - withTimeout.subscribe(ts); + withTimeout.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); @@ -76,57 +76,57 @@ public void shouldNotTimeoutIfSecondOnNextWithinTimeout() { verify(observer).onNext("Two"); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); verify(observer, never()).onError(any(Throwable.class)); - ts.dispose(); + to.dispose(); } @Test public void shouldTimeoutIfOnNextNotWithinTimeout() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); - withTimeout.subscribe(ts); + withTimeout.subscribe(to); testScheduler.advanceTimeBy(TIMEOUT + 1, TimeUnit.SECONDS); verify(observer).onError(any(TimeoutException.class)); - ts.dispose(); + to.dispose(); } @Test public void shouldTimeoutIfSecondOnNextNotWithinTimeout() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); withTimeout.subscribe(observer); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); verify(observer).onNext("One"); testScheduler.advanceTimeBy(TIMEOUT + 1, TimeUnit.SECONDS); verify(observer).onError(any(TimeoutException.class)); - ts.dispose(); + to.dispose(); } @Test public void shouldCompleteIfUnderlyingComletes() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); withTimeout.subscribe(observer); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onComplete(); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); verify(observer).onComplete(); verify(observer, never()).onError(any(Throwable.class)); - ts.dispose(); + to.dispose(); } @Test public void shouldErrorIfUnderlyingErrors() { Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); withTimeout.subscribe(observer); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onError(new UnsupportedOperationException()); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); verify(observer).onError(any(UnsupportedOperationException.class)); - ts.dispose(); + to.dispose(); } @Test @@ -135,8 +135,8 @@ public void shouldSwitchToOtherIfOnNextNotWithinTimeout() { Observable source = underlyingSubject.timeout(TIMEOUT, TIME_UNIT, testScheduler, other); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - source.subscribe(ts); + TestObserver to = new TestObserver(observer); + source.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); @@ -149,7 +149,7 @@ public void shouldSwitchToOtherIfOnNextNotWithinTimeout() { inOrder.verify(observer, times(1)).onNext("c"); inOrder.verify(observer, times(1)).onComplete(); inOrder.verifyNoMoreInteractions(); - ts.dispose(); + to.dispose(); } @Test @@ -158,8 +158,8 @@ public void shouldSwitchToOtherIfOnErrorNotWithinTimeout() { Observable source = underlyingSubject.timeout(TIMEOUT, TIME_UNIT, testScheduler, other); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - source.subscribe(ts); + TestObserver to = new TestObserver(observer); + source.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); @@ -172,7 +172,7 @@ public void shouldSwitchToOtherIfOnErrorNotWithinTimeout() { inOrder.verify(observer, times(1)).onNext("c"); inOrder.verify(observer, times(1)).onComplete(); inOrder.verifyNoMoreInteractions(); - ts.dispose(); + to.dispose(); } @Test @@ -181,8 +181,8 @@ public void shouldSwitchToOtherIfOnCompletedNotWithinTimeout() { Observable source = underlyingSubject.timeout(TIMEOUT, TIME_UNIT, testScheduler, other); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - source.subscribe(ts); + TestObserver to = new TestObserver(observer); + source.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); @@ -195,7 +195,7 @@ public void shouldSwitchToOtherIfOnCompletedNotWithinTimeout() { inOrder.verify(observer, times(1)).onNext("c"); inOrder.verify(observer, times(1)).onComplete(); inOrder.verifyNoMoreInteractions(); - ts.dispose(); + to.dispose(); } @Test @@ -204,8 +204,8 @@ public void shouldSwitchToOtherAndCanBeUnsubscribedIfOnNextNotWithinTimeout() { Observable source = underlyingSubject.timeout(TIMEOUT, TIME_UNIT, testScheduler, other); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - source.subscribe(ts); + TestObserver to = new TestObserver(observer); + source.subscribe(to); testScheduler.advanceTimeBy(2, TimeUnit.SECONDS); underlyingSubject.onNext("One"); @@ -214,7 +214,7 @@ public void shouldSwitchToOtherAndCanBeUnsubscribedIfOnNextNotWithinTimeout() { other.onNext("a"); other.onNext("b"); - ts.dispose(); + to.dispose(); // The following messages should not be delivered. other.onNext("c"); @@ -235,7 +235,7 @@ public void shouldTimeoutIfSynchronizedObservableEmitFirstOnNextNotWithinTimeout final CountDownLatch timeoutSetuped = new CountDownLatch(1); final Observer observer = TestHelper.mockObserver(); - final TestObserver ts = new TestObserver(observer); + final TestObserver to = new TestObserver(observer); new Thread(new Runnable() { @@ -257,7 +257,7 @@ public void subscribe(Observer observer) { } }).timeout(1, TimeUnit.SECONDS, testScheduler) - .subscribe(ts); + .subscribe(to); } }).start(); @@ -287,8 +287,8 @@ public void subscribe(Observer observer) { Observable observableWithTimeout = never.timeout(1000, TimeUnit.MILLISECONDS, testScheduler); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - observableWithTimeout.subscribe(ts); + TestObserver to = new TestObserver(observer); + observableWithTimeout.subscribe(to); testScheduler.advanceTimeBy(2000, TimeUnit.MILLISECONDS); @@ -318,8 +318,8 @@ public void subscribe(Observer observer) { testScheduler); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - observableWithTimeout.subscribe(ts); + TestObserver to = new TestObserver(observer); + observableWithTimeout.subscribe(to); testScheduler.advanceTimeBy(2000, TimeUnit.MILLISECONDS); @@ -349,8 +349,8 @@ public void subscribe(Observer observer) { testScheduler); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - observableWithTimeout.subscribe(ts); + TestObserver to = new TestObserver(observer); + observableWithTimeout.subscribe(to); testScheduler.advanceTimeBy(2000, TimeUnit.MILLISECONDS); @@ -524,14 +524,14 @@ public void onNextOnTimeoutRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final TestScheduler sch = new TestScheduler(); - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.timeout(1, TimeUnit.SECONDS, sch).test(); + TestObserver to = ps.timeout(1, TimeUnit.SECONDS, sch).test(); Runnable r1 = new Runnable() { @Override public void run() { - pp.onNext(1); + ps.onNext(1); } }; @@ -544,14 +544,14 @@ public void run() { TestHelper.race(r1, r2); - if (ts.valueCount() != 0) { - if (ts.errorCount() != 0) { - ts.assertFailure(TimeoutException.class, 1); + if (to.valueCount() != 0) { + if (to.errorCount() != 0) { + to.assertFailure(TimeoutException.class, 1); } else { - ts.assertValuesOnly(1); + to.assertValuesOnly(1); } } else { - ts.assertFailure(TimeoutException.class); + to.assertFailure(TimeoutException.class); } } } @@ -561,14 +561,14 @@ public void onNextOnTimeoutRaceFallback() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final TestScheduler sch = new TestScheduler(); - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.timeout(1, TimeUnit.SECONDS, sch, Observable.just(2)).test(); + TestObserver to = ps.timeout(1, TimeUnit.SECONDS, sch, Observable.just(2)).test(); Runnable r1 = new Runnable() { @Override public void run() { - pp.onNext(1); + ps.onNext(1); } }; @@ -581,16 +581,16 @@ public void run() { TestHelper.race(r1, r2); - if (ts.isTerminated()) { - int c = ts.valueCount(); + if (to.isTerminated()) { + int c = to.valueCount(); if (c == 1) { - int v = ts.values().get(0); + int v = to.values().get(0); assertTrue("" + v, v == 1 || v == 2); } else { - ts.assertResult(1, 2); + to.assertResult(1, 2); } } else { - ts.assertValuesOnly(1); + to.assertValuesOnly(1); } } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutWithSelectorTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutWithSelectorTest.java index 276971e5c9..921cd50383 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutWithSelectorTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimeoutWithSelectorTest.java @@ -328,14 +328,14 @@ public Void answer(InvocationOnMock invocation) throws Throwable { }).when(o).onComplete(); - final TestObserver ts = new TestObserver(o); + final TestObserver to = new TestObserver(o); new Thread(new Runnable() { @Override public void run() { PublishSubject source = PublishSubject.create(); - source.timeout(timeoutFunc, Observable.just(3)).subscribe(ts); + source.timeout(timeoutFunc, Observable.just(3)).subscribe(to); source.onNext(1); // start timeout try { if (!enteredTimeoutOne.await(30, TimeUnit.SECONDS)) { @@ -568,7 +568,7 @@ protected void subscribeActual( } }; - TestObserver ts = ps.timeout(Functions.justFunction(pp2)).test(); + TestObserver to = ps.timeout(Functions.justFunction(pp2)).test(); ps.onNext(0); @@ -590,7 +590,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValueAt(0, 0); + to.assertValueAt(0, 0); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); @@ -623,7 +623,7 @@ protected void subscribeActual( } }; - TestObserver ts = ps.timeout(Functions.justFunction(pp2), Observable.never()).test(); + TestObserver to = ps.timeout(Functions.justFunction(pp2), Observable.never()).test(); ps.onNext(0); @@ -645,7 +645,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValueAt(0, 0); + to.assertValueAt(0, 0); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); @@ -678,7 +678,7 @@ protected void subscribeActual( } }; - TestObserver ts = ps.timeout(Functions.justFunction(pp2)).test(); + TestObserver to = ps.timeout(Functions.justFunction(pp2)).test(); ps.onNext(0); @@ -700,7 +700,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValueAt(0, 0); + to.assertValueAt(0, 0); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); @@ -733,7 +733,7 @@ protected void subscribeActual( } }; - TestObserver ts = ps.timeout(Functions.justFunction(pp2)).test(); + TestObserver to = ps.timeout(Functions.justFunction(pp2)).test(); ps.onNext(0); @@ -753,7 +753,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValueAt(0, 0); + to.assertValueAt(0, 0); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); @@ -786,7 +786,7 @@ protected void subscribeActual( } }; - TestObserver ts = ps.timeout(Functions.justFunction(pp2), Observable.never()).test(); + TestObserver to = ps.timeout(Functions.justFunction(pp2), Observable.never()).test(); ps.onNext(0); @@ -806,7 +806,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValueAt(0, 0); + to.assertValueAt(0, 0); if (!errors.isEmpty()) { TestHelper.assertUndeliverable(errors, 0, TestException.class); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimerTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimerTest.java index 6101e11977..416a5e10e0 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableTimerTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableTimerTest.java @@ -63,169 +63,169 @@ public void testTimerOnce() { @Test public void testTimerPeriodically() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.interval(100, 100, TimeUnit.MILLISECONDS, scheduler).subscribe(ts); + Observable.interval(100, 100, TimeUnit.MILLISECONDS, scheduler).subscribe(to); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValue(0L); + to.assertValue(0L); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValues(0L, 1L); + to.assertValues(0L, 1L); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValues(0L, 1L, 2L); + to.assertValues(0L, 1L, 2L); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValues(0L, 1L, 2L, 3L); + to.assertValues(0L, 1L, 2L, 3L); - ts.dispose(); + to.dispose(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValues(0L, 1L, 2L, 3L); + to.assertValues(0L, 1L, 2L, 3L); - ts.assertNotComplete(); - ts.assertNoErrors(); + to.assertNotComplete(); + to.assertNoErrors(); } @Test public void testInterval() { Observable w = Observable.interval(1, TimeUnit.SECONDS, scheduler); - TestObserver ts = new TestObserver(); - w.subscribe(ts); + TestObserver to = new TestObserver(); + w.subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertNotComplete(); scheduler.advanceTimeTo(2, TimeUnit.SECONDS); - ts.assertValues(0L, 1L); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertValues(0L, 1L); + to.assertNoErrors(); + to.assertNotComplete(); - ts.dispose(); + to.dispose(); scheduler.advanceTimeTo(4, TimeUnit.SECONDS); - ts.assertValues(0L, 1L); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertValues(0L, 1L); + to.assertNoErrors(); + to.assertNotComplete(); } @Test public void testWithMultipleSubscribersStartingAtSameTime() { Observable w = Observable.interval(1, TimeUnit.SECONDS, scheduler); - TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver(); + TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver(); - w.subscribe(ts1); - w.subscribe(ts2); + w.subscribe(to1); + w.subscribe(to2); - ts1.assertNoValues(); - ts2.assertNoValues(); + to1.assertNoValues(); + to2.assertNoValues(); scheduler.advanceTimeTo(2, TimeUnit.SECONDS); - ts1.assertValues(0L, 1L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertValues(0L, 1L); - ts2.assertNoErrors(); - ts2.assertNotComplete(); + to2.assertValues(0L, 1L); + to2.assertNoErrors(); + to2.assertNotComplete(); - ts1.dispose(); - ts2.dispose(); + to1.dispose(); + to2.dispose(); scheduler.advanceTimeTo(4, TimeUnit.SECONDS); - ts1.assertValues(0L, 1L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertValues(0L, 1L); - ts2.assertNoErrors(); - ts2.assertNotComplete(); + to2.assertValues(0L, 1L); + to2.assertNoErrors(); + to2.assertNotComplete(); } @Test public void testWithMultipleStaggeredSubscribers() { Observable w = Observable.interval(1, TimeUnit.SECONDS, scheduler); - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); - w.subscribe(ts1); + w.subscribe(to1); - ts1.assertNoErrors(); + to1.assertNoErrors(); scheduler.advanceTimeTo(2, TimeUnit.SECONDS); - TestObserver ts2 = new TestObserver(); + TestObserver to2 = new TestObserver(); - w.subscribe(ts2); + w.subscribe(to2); - ts1.assertValues(0L, 1L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertNoValues(); + to2.assertNoValues(); scheduler.advanceTimeTo(4, TimeUnit.SECONDS); - ts1.assertValues(0L, 1L, 2L, 3L); + to1.assertValues(0L, 1L, 2L, 3L); - ts2.assertValues(0L, 1L); + to2.assertValues(0L, 1L); - ts1.dispose(); - ts2.dispose(); + to1.dispose(); + to2.dispose(); - ts1.assertValues(0L, 1L, 2L, 3L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L, 2L, 3L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertValues(0L, 1L); - ts2.assertNoErrors(); - ts2.assertNotComplete(); + to2.assertValues(0L, 1L); + to2.assertNoErrors(); + to2.assertNotComplete(); } @Test public void testWithMultipleStaggeredSubscribersAndPublish() { ConnectableObservable w = Observable.interval(1, TimeUnit.SECONDS, scheduler).publish(); - TestObserver ts1 = new TestObserver(); + TestObserver to1 = new TestObserver(); - w.subscribe(ts1); + w.subscribe(to1); w.connect(); - ts1.assertNoValues(); + to1.assertNoValues(); scheduler.advanceTimeTo(2, TimeUnit.SECONDS); - TestObserver ts2 = new TestObserver(); - w.subscribe(ts2); + TestObserver to2 = new TestObserver(); + w.subscribe(to2); - ts1.assertValues(0L, 1L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertNoValues(); + to2.assertNoValues(); scheduler.advanceTimeTo(4, TimeUnit.SECONDS); - ts1.assertValues(0L, 1L, 2L, 3L); + to1.assertValues(0L, 1L, 2L, 3L); - ts2.assertValues(2L, 3L); + to2.assertValues(2L, 3L); - ts1.dispose(); - ts2.dispose(); + to1.dispose(); + to2.dispose(); - ts1.assertValues(0L, 1L, 2L, 3L); - ts1.assertNoErrors(); - ts1.assertNotComplete(); + to1.assertValues(0L, 1L, 2L, 3L); + to1.assertNoErrors(); + to1.assertNotComplete(); - ts2.assertValues(2L, 3L); - ts2.assertNoErrors(); - ts2.assertNotComplete(); + to2.assertValues(2L, 3L); + to2.assertNoErrors(); + to2.assertNotComplete(); } @Test public void testOnceObserverThrows() { @@ -315,7 +315,7 @@ public void timerInterruptible() throws Exception { try { for (Scheduler s : new Scheduler[] { Schedulers.single(), Schedulers.computation(), Schedulers.newThread(), Schedulers.io(), Schedulers.from(exec) }) { final AtomicBoolean interrupted = new AtomicBoolean(); - TestObserver ts = Observable.timer(1, TimeUnit.MILLISECONDS, s) + TestObserver to = Observable.timer(1, TimeUnit.MILLISECONDS, s) .map(new Function() { @Override public Long apply(Long v) throws Exception { @@ -331,7 +331,7 @@ public Long apply(Long v) throws Exception { Thread.sleep(500); - ts.cancel(); + to.cancel(); Thread.sleep(500); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableToFutureTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableToFutureTest.java index 5de707f461..4cd7e26076 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableToFutureTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableToFutureTest.java @@ -35,11 +35,11 @@ public void testSuccess() throws Exception { Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); - Observable.fromFuture(future).subscribe(ts); + Observable.fromFuture(future).subscribe(to); - ts.dispose(); + to.dispose(); verify(o, times(1)).onNext(value); verify(o, times(1)).onComplete(); @@ -57,9 +57,9 @@ public void testSuccessOperatesOnSuppliedScheduler() throws Exception { Observer o = TestHelper.mockObserver(); TestScheduler scheduler = new TestScheduler(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); - Observable.fromFuture(future, scheduler).subscribe(ts); + Observable.fromFuture(future, scheduler).subscribe(to); verify(o, never()).onNext(value); @@ -77,11 +77,11 @@ public void testFailure() throws Exception { Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); - Observable.fromFuture(future).subscribe(ts); + Observable.fromFuture(future).subscribe(to); - ts.dispose(); + to.dispose(); verify(o, never()).onNext(null); verify(o, never()).onComplete(); @@ -98,13 +98,13 @@ public void testCancelledBeforeSubscribe() throws Exception { Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); - ts.dispose(); + TestObserver to = new TestObserver(o); + to.dispose(); - Observable.fromFuture(future).subscribe(ts); + Observable.fromFuture(future).subscribe(to); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertNoErrors(); + to.assertNotComplete(); } @Test @@ -144,17 +144,17 @@ public Object get(long timeout, TimeUnit unit) throws InterruptedException, Exec Observer o = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o); + TestObserver to = new TestObserver(o); Observable futureObservable = Observable.fromFuture(future); - futureObservable.subscribeOn(Schedulers.computation()).subscribe(ts); + futureObservable.subscribeOn(Schedulers.computation()).subscribe(to); Thread.sleep(100); - ts.dispose(); + to.dispose(); - ts.assertNoErrors(); - ts.assertNoValues(); - ts.assertNotComplete(); + to.assertNoErrors(); + to.assertNoValues(); + to.assertNotComplete(); } } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithObservableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithObservableTest.java index 6c084f01d6..000b116615 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithObservableTest.java @@ -253,7 +253,7 @@ public void onComplete() { @Test public void testWindowNoDuplication() { final PublishSubject source = PublishSubject.create(); - final TestObserver tsw = new TestObserver() { + final TestObserver tow = new TestObserver() { boolean once; @Override public void onNext(Integer t) { @@ -264,10 +264,10 @@ public void onNext(Integer t) { super.onNext(t); } }; - TestObserver> ts = new TestObserver>() { + TestObserver> to = new TestObserver>() { @Override public void onNext(Observable t) { - t.subscribe(tsw); + t.subscribe(tow); super.onNext(t); } }; @@ -276,13 +276,13 @@ public void onNext(Observable t) { public Observable call() { return Observable.never(); } - }).subscribe(ts); + }).subscribe(to); source.onNext(1); source.onComplete(); - ts.assertValueCount(1); - tsw.assertValues(1, 2); + to.assertValueCount(1); + tow.assertValues(1, 2); } @Test @@ -295,12 +295,12 @@ public Observable call() { } }; - TestObserver> ts = new TestObserver>(); - source.window(boundary).subscribe(ts); + TestObserver> to = new TestObserver>(); + source.window(boundary).subscribe(to); // 2.0.2 - not anymore // assertTrue("Not cancelled!", ts.isCancelled()); - ts.assertComplete(); + to.assertComplete(); } @Test @@ -314,8 +314,8 @@ public Observable call() { } }; - TestObserver> ts = new TestObserver>(); - source.window(boundaryFunc).subscribe(ts); + TestObserver> to = new TestObserver>(); + source.window(boundaryFunc).subscribe(to); assertTrue(source.hasObservers()); assertTrue(boundary.hasObservers()); @@ -325,9 +325,9 @@ public Observable call() { assertFalse(source.hasObservers()); assertFalse(boundary.hasObservers()); - ts.assertComplete(); - ts.assertNoErrors(); - ts.assertValueCount(1); + to.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(1); } @Test public void testMainUnsubscribedOnBoundaryCompletion() { @@ -340,8 +340,8 @@ public Observable call() { } }; - TestObserver> ts = new TestObserver>(); - source.window(boundaryFunc).subscribe(ts); + TestObserver> to = new TestObserver>(); + source.window(boundaryFunc).subscribe(to); assertTrue(source.hasObservers()); assertTrue(boundary.hasObservers()); @@ -352,9 +352,9 @@ public Observable call() { assertFalse(source.hasObservers()); assertFalse(boundary.hasObservers()); - ts.assertComplete(); - ts.assertNoErrors(); - ts.assertValueCount(1); + to.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(1); } @Test @@ -368,25 +368,25 @@ public Observable call() { } }; - TestObserver> ts = new TestObserver>(); - source.window(boundaryFunc).subscribe(ts); + TestObserver> to = new TestObserver>(); + source.window(boundaryFunc).subscribe(to); assertTrue(source.hasObservers()); assertTrue(boundary.hasObservers()); - ts.dispose(); + to.dispose(); assertTrue(source.hasObservers()); assertFalse(boundary.hasObservers()); - ts.values().get(0).test(true); + to.values().get(0).test(true); assertFalse(source.hasObservers()); - ts.assertNotComplete(); - ts.assertNoErrors(); - ts.assertValueCount(1); + to.assertNotComplete(); + to.assertNoErrors(); + to.assertValueCount(1); } @Test @@ -402,8 +402,8 @@ public Observable call() { } }; - TestObserver> ts = new TestObserver>(); - source.window(boundaryFunc).subscribe(ts); + TestObserver> to = new TestObserver>(); + source.window(boundaryFunc).subscribe(to); source.onNext(1); boundary.onNext(1); @@ -420,9 +420,9 @@ public Observable call() { source.onNext(4); source.onComplete(); - ts.assertNoErrors(); - ts.assertValueCount(4); - ts.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(4); + to.assertComplete(); assertFalse(source.hasObservers()); assertFalse(boundary.hasObservers()); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithSizeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithSizeTest.java index 5be74817a8..a3f2fedc41 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithSizeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithSizeTest.java @@ -105,7 +105,7 @@ public void testSkipAndCountWindowsWithGaps() { @Test public void testWindowUnsubscribeNonOverlapping() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger count = new AtomicInteger(); Observable.merge(Observable.range(1, 10000).doOnNext(new Consumer() { @@ -114,17 +114,17 @@ public void accept(Integer t1) { count.incrementAndGet(); } - }).window(5).take(2)).subscribe(ts); - ts.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + }).window(5).take(2)).subscribe(to); + to.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); + to.assertTerminated(); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); // System.out.println(ts.getOnNextEvents()); assertEquals(10, count.get()); } @Test public void testWindowUnsubscribeNonOverlappingAsyncSource() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger count = new AtomicInteger(); Observable.merge(Observable.range(1, 100000) .doOnNext(new Consumer() { @@ -145,17 +145,17 @@ public void accept(Integer t1) { .observeOn(Schedulers.computation()) .window(5) .take(2)) - .subscribe(ts); - ts.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - ts.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + .subscribe(to); + to.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); + to.assertTerminated(); + to.assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); // make sure we don't emit all values ... the unsubscribe should propagate assertTrue(count.get() < 100000); } @Test public void testWindowUnsubscribeOverlapping() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger count = new AtomicInteger(); Observable.merge(Observable.range(1, 10000).doOnNext(new Consumer() { @@ -164,17 +164,17 @@ public void accept(Integer t1) { count.incrementAndGet(); } - }).window(5, 4).take(2)).subscribe(ts); - ts.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); + }).window(5, 4).take(2)).subscribe(to); + to.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); + to.assertTerminated(); // System.out.println(ts.getOnNextEvents()); - ts.assertValues(1, 2, 3, 4, 5, 5, 6, 7, 8, 9); + to.assertValues(1, 2, 3, 4, 5, 5, 6, 7, 8, 9); assertEquals(9, count.get()); } @Test public void testWindowUnsubscribeOverlappingAsyncSource() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger count = new AtomicInteger(); Observable.merge(Observable.range(1, 100000) .doOnNext(new Consumer() { @@ -188,10 +188,10 @@ public void accept(Integer t1) { .observeOn(Schedulers.computation()) .window(5, 4) .take(2), 128) - .subscribe(ts); - ts.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); - ts.assertTerminated(); - ts.assertValues(1, 2, 3, 4, 5, 5, 6, 7, 8, 9); + .subscribe(to); + to.awaitTerminalEvent(500, TimeUnit.MILLISECONDS); + to.assertTerminated(); + to.assertValues(1, 2, 3, 4, 5, 5, 6, 7, 8, 9); // make sure we don't emit all values ... the unsubscribe should propagate // assertTrue(count.get() < 100000); // disabled: a small hiccup in the consumption may allow the source to run to completion } @@ -231,7 +231,7 @@ public void subscribe(Observer s) { @Test public void testTakeFlatMapCompletes() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final int indicator = 999999999; @@ -243,11 +243,11 @@ public void testTakeFlatMapCompletes() { public Observable apply(Observable w) { return w.startWith(indicator); } - }).subscribe(ts); + }).subscribe(to); - ts.awaitTerminalEvent(2, TimeUnit.SECONDS); - ts.assertComplete(); - ts.assertValueCount(22); + to.awaitTerminalEvent(2, TimeUnit.SECONDS); + to.assertComplete(); + to.assertValueCount(22); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java index 35a8bb3b60..41f3163f98 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithStartEndObservableTest.java @@ -202,14 +202,14 @@ public void testNoUnsubscribeAndNoLeak() { PublishSubject open = PublishSubject.create(); final PublishSubject close = PublishSubject.create(); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); source.window(open, new Function>() { @Override public Observable apply(Integer t) { return close; } - }).subscribe(ts); + }).subscribe(to); open.onNext(1); source.onNext(1); @@ -223,9 +223,9 @@ public Observable apply(Integer t) { source.onComplete(); - ts.assertComplete(); - ts.assertNoErrors(); - ts.assertValueCount(1); + to.assertComplete(); + to.assertNoErrors(); + to.assertValueCount(1); // 2.0.2 - not anymore // assertTrue("Not cancelled!", ts.isCancelled()); @@ -240,21 +240,21 @@ public void testUnsubscribeAll() { PublishSubject open = PublishSubject.create(); final PublishSubject close = PublishSubject.create(); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); source.window(open, new Function>() { @Override public Observable apply(Integer t) { return close; } - }).subscribe(ts); + }).subscribe(to); open.onNext(1); assertTrue(open.hasObservers()); assertTrue(close.hasObservers()); - ts.dispose(); + to.dispose(); // FIXME subject has subscribers because of the open window assertTrue(open.hasObservers()); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithTimeTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithTimeTest.java index d481991a24..bfccb343da 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithTimeTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableWindowWithTimeTest.java @@ -181,7 +181,7 @@ public void testExactWindowSize() { @Test public void testTakeFlatMapCompletes() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); final AtomicInteger wip = new AtomicInteger(); @@ -215,11 +215,11 @@ public void accept(Integer pv) { System.out.println(pv); } }) - .subscribe(ts); + .subscribe(to); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); - ts.assertComplete(); - Assert.assertTrue(ts.valueCount() != 0); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); + to.assertComplete(); + Assert.assertTrue(to.valueCount() != 0); } @Test @@ -306,107 +306,107 @@ public void timeskipJustSkip() { public void timeskipSkipping() { TestScheduler scheduler = new TestScheduler(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.window(1, 2, TimeUnit.SECONDS, scheduler) + TestObserver to = ps.window(1, 2, TimeUnit.SECONDS, scheduler) .flatMap(Functions.>identity()) .test(); - pp.onNext(1); - pp.onNext(2); + ps.onNext(1); + ps.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(3); - pp.onNext(4); + ps.onNext(3); + ps.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(5); - pp.onNext(6); + ps.onNext(5); + ps.onNext(6); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(7); - pp.onComplete(); + ps.onNext(7); + ps.onComplete(); - ts.assertResult(1, 2, 5, 6); + to.assertResult(1, 2, 5, 6); } @Test public void timeskipOverlapping() { TestScheduler scheduler = new TestScheduler(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.window(2, 1, TimeUnit.SECONDS, scheduler) + TestObserver to = ps.window(2, 1, TimeUnit.SECONDS, scheduler) .flatMap(Functions.>identity()) .test(); - pp.onNext(1); - pp.onNext(2); + ps.onNext(1); + ps.onNext(2); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(3); - pp.onNext(4); + ps.onNext(3); + ps.onNext(4); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(5); - pp.onNext(6); + ps.onNext(5); + ps.onNext(6); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - pp.onNext(7); - pp.onComplete(); + ps.onNext(7); + ps.onComplete(); - ts.assertResult(1, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7); + to.assertResult(1, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7); } @Test public void exactOnError() { TestScheduler scheduler = new TestScheduler(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.window(1, 1, TimeUnit.SECONDS, scheduler) + TestObserver to = ps.window(1, 1, TimeUnit.SECONDS, scheduler) .flatMap(Functions.>identity()) .test(); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void overlappingOnError() { TestScheduler scheduler = new TestScheduler(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.window(2, 1, TimeUnit.SECONDS, scheduler) + TestObserver to = ps.window(2, 1, TimeUnit.SECONDS, scheduler) .flatMap(Functions.>identity()) .test(); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void skipOnError() { TestScheduler scheduler = new TestScheduler(); - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.window(1, 2, TimeUnit.SECONDS, scheduler) + TestObserver to = ps.window(1, 2, TimeUnit.SECONDS, scheduler) .flatMap(Functions.>identity()) .test(); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -591,17 +591,17 @@ public void sizeTimeTimeout() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 100) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 100) .test() .assertValueCount(1); scheduler.advanceTimeBy(5, TimeUnit.MILLISECONDS); - ts.assertValueCount(2) + to.assertValueCount(2) .assertNoErrors() .assertNotComplete(); - ts.values().get(0).test().assertResult(); + to.values().get(0).test().assertResult(); } @Test @@ -609,12 +609,12 @@ public void periodicWindowCompletion() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, Long.MAX_VALUE, false) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, Long.MAX_VALUE, false) .test(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValueCount(21) + to.assertValueCount(21) .assertNoErrors() .assertNotComplete(); } @@ -624,12 +624,12 @@ public void periodicWindowCompletionRestartTimer() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, Long.MAX_VALUE, true) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, Long.MAX_VALUE, true) .test(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValueCount(21) + to.assertValueCount(21) .assertNoErrors() .assertNotComplete(); } @@ -639,12 +639,12 @@ public void periodicWindowCompletionBounded() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, false) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, false) .test(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValueCount(21) + to.assertValueCount(21) .assertNoErrors() .assertNotComplete(); } @@ -654,12 +654,12 @@ public void periodicWindowCompletionRestartTimerBounded() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, true) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, true) .test(); scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValueCount(21) + to.assertValueCount(21) .assertNoErrors() .assertNotComplete(); } @@ -669,7 +669,7 @@ public void periodicWindowCompletionRestartTimerBoundedSomeData() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 2, true) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 2, true) .test(); ps.onNext(1); @@ -677,7 +677,7 @@ public void periodicWindowCompletionRestartTimerBoundedSomeData() { scheduler.advanceTimeBy(100, TimeUnit.MILLISECONDS); - ts.assertValueCount(22) + to.assertValueCount(22) .assertNoErrors() .assertNotComplete(); } @@ -687,7 +687,7 @@ public void countRestartsOnTimeTick() { TestScheduler scheduler = new TestScheduler(); Subject ps = PublishSubject.create(); - TestObserver> ts = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, true) + TestObserver> to = ps.window(5, TimeUnit.MILLISECONDS, scheduler, 5, true) .test(); // window #1 @@ -702,7 +702,7 @@ public void countRestartsOnTimeTick() { ps.onNext(5); ps.onNext(6); - ts.assertValueCount(2) + to.assertValueCount(2) .assertNoErrors() .assertNotComplete(); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableWithLatestFromTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableWithLatestFromTest.java index 4cba999e51..9b1ea3e54e 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableWithLatestFromTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableWithLatestFromTest.java @@ -89,9 +89,9 @@ public void testEmptySource() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -100,9 +100,9 @@ public void testEmptySource() { source.onComplete(); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertNoValues(); + to.assertNoErrors(); + to.assertTerminated(); + to.assertNoValues(); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -115,9 +115,9 @@ public void testEmptyOther() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -126,9 +126,9 @@ public void testEmptyOther() { source.onComplete(); - ts.assertNoErrors(); - ts.assertTerminated(); - ts.assertNoValues(); + to.assertNoErrors(); + to.assertTerminated(); + to.assertNoValues(); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -142,9 +142,9 @@ public void testUnsubscription() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -152,11 +152,11 @@ public void testUnsubscription() { other.onNext(1); source.onNext(1); - ts.dispose(); + to.dispose(); - ts.assertValue((1 << 8) + 1); - ts.assertNoErrors(); - ts.assertNotComplete(); + to.assertValue((1 << 8) + 1); + to.assertNoErrors(); + to.assertNotComplete(); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -169,9 +169,9 @@ public void testSourceThrows() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -181,10 +181,10 @@ public void testSourceThrows() { source.onError(new TestException()); - ts.assertTerminated(); - ts.assertValue((1 << 8) + 1); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertTerminated(); + to.assertValue((1 << 8) + 1); + to.assertError(TestException.class); + to.assertNotComplete(); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -196,9 +196,9 @@ public void testOtherThrows() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -208,10 +208,10 @@ public void testOtherThrows() { other.onError(new TestException()); - ts.assertTerminated(); - ts.assertValue((1 << 8) + 1); - ts.assertNotComplete(); - ts.assertError(TestException.class); + to.assertTerminated(); + to.assertValue((1 << 8) + 1); + to.assertNotComplete(); + to.assertError(TestException.class); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -224,9 +224,9 @@ public void testFunctionThrows() { Observable result = source.withLatestFrom(other, COMBINER_ERROR); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); assertTrue(source.hasObservers()); assertTrue(other.hasObservers()); @@ -234,10 +234,10 @@ public void testFunctionThrows() { other.onNext(1); source.onNext(1); - ts.assertTerminated(); - ts.assertNotComplete(); - ts.assertNoValues(); - ts.assertError(TestException.class); + to.assertTerminated(); + to.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); assertFalse(source.hasObservers()); assertFalse(other.hasObservers()); @@ -250,9 +250,9 @@ public void testNoDownstreamUnsubscribe() { Observable result = source.withLatestFrom(other, COMBINER); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - result.subscribe(ts); + result.subscribe(to); source.onComplete(); @@ -275,40 +275,40 @@ public void manySources() { PublishSubject ps3 = PublishSubject.create(); PublishSubject main = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); main.withLatestFrom(new Observable[] { ps1, ps2, ps3 }, toArray) - .subscribe(ts); + .subscribe(to); main.onNext("1"); - ts.assertNoValues(); + to.assertNoValues(); ps1.onNext("a"); - ts.assertNoValues(); + to.assertNoValues(); ps2.onNext("A"); - ts.assertNoValues(); + to.assertNoValues(); ps3.onNext("="); - ts.assertNoValues(); + to.assertNoValues(); main.onNext("2"); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps2.onNext("B"); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps3.onComplete(); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps1.onNext("b"); main.onNext("3"); - ts.assertValues("[2, a, A, =]", "[3, b, B, =]"); + to.assertValues("[2, a, A, =]", "[3, b, B, =]"); main.onComplete(); - ts.assertValues("[2, a, A, =]", "[3, b, B, =]"); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues("[2, a, A, =]", "[3, b, B, =]"); + to.assertNoErrors(); + to.assertComplete(); assertFalse("ps1 has subscribers?", ps1.hasObservers()); assertFalse("ps2 has subscribers?", ps2.hasObservers()); @@ -322,40 +322,40 @@ public void manySourcesIterable() { PublishSubject ps3 = PublishSubject.create(); PublishSubject main = PublishSubject.create(); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); main.withLatestFrom(Arrays.>asList(ps1, ps2, ps3), toArray) - .subscribe(ts); + .subscribe(to); main.onNext("1"); - ts.assertNoValues(); + to.assertNoValues(); ps1.onNext("a"); - ts.assertNoValues(); + to.assertNoValues(); ps2.onNext("A"); - ts.assertNoValues(); + to.assertNoValues(); ps3.onNext("="); - ts.assertNoValues(); + to.assertNoValues(); main.onNext("2"); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps2.onNext("B"); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps3.onComplete(); - ts.assertValues("[2, a, A, =]"); + to.assertValues("[2, a, A, =]"); ps1.onNext("b"); main.onNext("3"); - ts.assertValues("[2, a, A, =]", "[3, b, B, =]"); + to.assertValues("[2, a, A, =]", "[3, b, B, =]"); main.onComplete(); - ts.assertValues("[2, a, A, =]", "[3, b, B, =]"); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValues("[2, a, A, =]", "[3, b, B, =]"); + to.assertNoErrors(); + to.assertComplete(); assertFalse("ps1 has subscribers?", ps1.hasObservers()); assertFalse("ps2 has subscribers?", ps2.hasObservers()); @@ -376,20 +376,20 @@ public void manySourcesIterableSweep() { expected.add(String.valueOf(val)); } - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); PublishSubject main = PublishSubject.create(); - main.withLatestFrom(sources, toArray).subscribe(ts); + main.withLatestFrom(sources, toArray).subscribe(to); - ts.assertNoValues(); + to.assertNoValues(); main.onNext(val); main.onComplete(); - ts.assertValue(expected.toString()); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(expected.toString()); + to.assertNoErrors(); + to.assertComplete(); } } } @@ -400,18 +400,18 @@ public void backpressureNoSignal() { // PublishSubject ps1 = PublishSubject.create(); // PublishSubject ps2 = PublishSubject.create(); // -// TestObserver ts = new TestObserver(); +// TestObserver to = new TestObserver(); // // Observable.range(1, 10).withLatestFrom(new Observable[] { ps1, ps2 }, toArray) -// .subscribe(ts); +// .subscribe(to); // -// ts.assertNoValues(); +// to.assertNoValues(); // -// ts.request(1); +// to.request(1); // -// ts.assertNoValues(); -// ts.assertNoErrors(); -// ts.assertComplete(); +// to.assertNoValues(); +// to.assertNoErrors(); +// to.assertComplete(); // // assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); // assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); @@ -423,29 +423,29 @@ public void backpressureWithSignal() { // PublishSubject ps1 = PublishSubject.create(); // PublishSubject ps2 = PublishSubject.create(); // -// TestObserver ts = new TestObserver(); +// TestObserver to = new TestObserver(); // // Observable.range(1, 3).withLatestFrom(new Observable[] { ps1, ps2 }, toArray) // .subscribe(ts); // -// ts.assertNoValues(); +// to.assertNoValues(); // // ps1.onNext("1"); // ps2.onNext("1"); // -// ts.request(1); +// to.request(1); // -// ts.assertValue("[1, 1, 1]"); +// to.assertValue("[1, 1, 1]"); // -// ts.request(1); +// to.request(1); // -// ts.assertValues("[1, 1, 1]", "[2, 1, 1]"); +// to.assertValues("[1, 1, 1]", "[2, 1, 1]"); // -// ts.request(1); +// to.request(1); // -// ts.assertValues("[1, 1, 1]", "[2, 1, 1]", "[3, 1, 1]"); -// ts.assertNoErrors(); -// ts.assertComplete(); +// to.assertValues("[1, 1, 1]", "[2, 1, 1]", "[3, 1, 1]"); +// to.assertNoErrors(); +// to.assertComplete(); // // assertFalse("ps1 has subscribers?", ps1.hasSubscribers()); // assertFalse("ps2 has subscribers?", ps2.hasSubscribers()); @@ -453,48 +453,48 @@ public void backpressureWithSignal() { @Test public void withEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 3).withLatestFrom( new Observable[] { Observable.just(1), Observable.empty() }, toArray) - .subscribe(ts); + .subscribe(to); - ts.assertNoValues(); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertNoValues(); + to.assertNoErrors(); + to.assertComplete(); } @Test public void withError() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.range(1, 3).withLatestFrom( new Observable[] { Observable.just(1), Observable.error(new TestException()) }, toArray) - .subscribe(ts); + .subscribe(to); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test public void withMainError() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.error(new TestException()).withLatestFrom( new Observable[] { Observable.just(1), Observable.just(1) }, toArray) - .subscribe(ts); + .subscribe(to); - ts.assertNoValues(); - ts.assertError(TestException.class); - ts.assertNotComplete(); + to.assertNoValues(); + to.assertError(TestException.class); + to.assertNotComplete(); } @Test public void with2Others() { Observable just = Observable.just(1); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); just.withLatestFrom(just, just, new Function3>() { @Override @@ -502,18 +502,18 @@ public List apply(Integer a, Integer b, Integer c) { return Arrays.asList(a, b, c); } }) - .subscribe(ts); + .subscribe(to); - ts.assertValue(Arrays.asList(1, 1, 1)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 1, 1)); + to.assertNoErrors(); + to.assertComplete(); } @Test public void with3Others() { Observable just = Observable.just(1); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); just.withLatestFrom(just, just, just, new Function4>() { @Override @@ -521,18 +521,18 @@ public List apply(Integer a, Integer b, Integer c, Integer d) { return Arrays.asList(a, b, c, d); } }) - .subscribe(ts); + .subscribe(to); - ts.assertValue(Arrays.asList(1, 1, 1, 1)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 1, 1, 1)); + to.assertNoErrors(); + to.assertComplete(); } @Test public void with4Others() { Observable just = Observable.just(1); - TestObserver> ts = new TestObserver>(); + TestObserver> to = new TestObserver>(); just.withLatestFrom(just, just, just, just, new Function5>() { @Override @@ -540,11 +540,11 @@ public List apply(Integer a, Integer b, Integer c, Integer d, Integer e return Arrays.asList(a, b, c, d, e); } }) - .subscribe(ts); + .subscribe(to); - ts.assertValue(Arrays.asList(1, 1, 1, 1, 1)); - ts.assertNoErrors(); - ts.assertComplete(); + to.assertValue(Arrays.asList(1, 1, 1, 1, 1)); + to.assertNoErrors(); + to.assertComplete(); } @Test diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableZipTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableZipTest.java index 475cceeca7..ac68979af9 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableZipTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableZipTest.java @@ -349,9 +349,9 @@ public void testAggregatorUnsubscribe() { PublishSubject r2 = PublishSubject.create(); /* define an Observer to receive aggregated events */ Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); + TestObserver to = new TestObserver(observer); - Observable.zip(r1, r2, zipr2).subscribe(ts); + Observable.zip(r1, r2, zipr2).subscribe(to); /* simulate the Observables pushing data into the aggregator */ r1.onNext("hello"); @@ -361,7 +361,7 @@ public void testAggregatorUnsubscribe() { verify(observer, never()).onComplete(); verify(observer, times(1)).onNext("helloworld"); - ts.dispose(); + to.dispose(); r1.onNext("hello"); r2.onNext("again"); @@ -794,16 +794,16 @@ public String apply(Integer a, Integer b) { } }).take(5); - TestObserver ts = new TestObserver(); - os.subscribe(ts); + TestObserver to = new TestObserver(); + os.subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); + to.awaitTerminalEvent(); + to.assertNoErrors(); - assertEquals(5, ts.valueCount()); - assertEquals("1-1", ts.values().get(0)); - assertEquals("2-2", ts.values().get(1)); - assertEquals("5-5", ts.values().get(4)); + assertEquals(5, to.valueCount()); + assertEquals("1-1", to.values().get(0)); + assertEquals("2-2", to.values().get(1)); + assertEquals("5-5", to.values().get(4)); } @Test @@ -969,10 +969,10 @@ public Object apply(final Object[] args) { } }); - TestObserver ts = new TestObserver(); - o.subscribe(ts); - ts.awaitTerminalEvent(200, TimeUnit.MILLISECONDS); - ts.assertNoValues(); + TestObserver to = new TestObserver(); + o.subscribe(to); + to.awaitTerminalEvent(200, TimeUnit.MILLISECONDS); + to.assertNoValues(); } /** @@ -1003,7 +1003,7 @@ public void testDownstreamBackpressureRequestsWithFiniteSyncObservables() { Observable o1 = createInfiniteObservable(generatedA).take(Observable.bufferSize() * 2); Observable o2 = createInfiniteObservable(generatedB).take(Observable.bufferSize() * 2); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.zip(o1, o2, new BiFunction() { @Override @@ -1011,11 +1011,11 @@ public String apply(Integer t1, Integer t2) { return t1 + "-" + t2; } - }).observeOn(Schedulers.computation()).take(Observable.bufferSize() * 2).subscribe(ts); + }).observeOn(Schedulers.computation()).take(Observable.bufferSize() * 2).subscribe(to); - ts.awaitTerminalEvent(); - ts.assertNoErrors(); - assertEquals(Observable.bufferSize() * 2, ts.valueCount()); + to.awaitTerminalEvent(); + to.assertNoErrors(); + assertEquals(Observable.bufferSize() * 2, to.valueCount()); System.out.println("Generated => A: " + generatedA.get() + " B: " + generatedB.get()); assertTrue(generatedA.get() < (Observable.bufferSize() * 3)); assertTrue(generatedB.get() < (Observable.bufferSize() * 3)); @@ -1363,7 +1363,7 @@ public Object apply(Integer a, Integer b) throws Exception { @Test public void noCrossBoundaryFusion() { for (int i = 0; i < 500; i++) { - TestObserver> ts = Observable.zip( + TestObserver> to = Observable.zip( Observable.just(1).observeOn(Schedulers.single()).map(new Function() { @Override public Object apply(Integer v) throws Exception { @@ -1387,7 +1387,7 @@ public List apply(Object t1, Object t2) throws Exception { .awaitDone(5, TimeUnit.SECONDS) .assertValueCount(1); - List list = ts.values().get(0); + List list = to.values().get(0); assertTrue(list.toString(), list.contains("RxSi")); assertTrue(list.toString(), list.contains("RxCo")); @@ -1399,7 +1399,7 @@ public void eagerDispose() { final PublishSubject ps1 = PublishSubject.create(); final PublishSubject ps2 = PublishSubject.create(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); @@ -1421,10 +1421,10 @@ public Integer apply(Integer t1, Integer t2) throws Exception { return t1 + t2; } }) - .subscribe(ts); + .subscribe(to); ps1.onNext(1); ps2.onNext(2); - ts.assertResult(3); + to.assertResult(3); } } diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleAmbTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleAmbTest.java index e07b27129c..1bc00dedd6 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleAmbTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleAmbTest.java @@ -32,7 +32,7 @@ public void ambWithFirstFires() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = pp1.single(-99).ambWith(pp2.single(-99)).test(); + TestObserver to = pp1.single(-99).ambWith(pp2.single(-99)).test(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -43,7 +43,7 @@ public void ambWithFirstFires() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @@ -52,7 +52,7 @@ public void ambWithSecondFires() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = pp1.single(-99).ambWith(pp2.single(-99)).test(); + TestObserver to = pp1.single(-99).ambWith(pp2.single(-99)).test(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -63,7 +63,7 @@ public void ambWithSecondFires() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @SuppressWarnings("unchecked") @@ -73,7 +73,7 @@ public void ambIterableWithFirstFires() { PublishProcessor pp2 = PublishProcessor.create(); List> singles = Arrays.asList(pp1.single(-99), pp2.single(-99)); - TestObserver ts = Single.amb(singles).test(); + TestObserver to = Single.amb(singles).test(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -84,7 +84,7 @@ public void ambIterableWithFirstFires() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @@ -95,7 +95,7 @@ public void ambIterableWithSecondFires() { PublishProcessor pp2 = PublishProcessor.create(); List> singles = Arrays.asList(pp1.single(-99), pp2.single(-99)); - TestObserver ts = Single.amb(singles).test(); + TestObserver to = Single.amb(singles).test(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -106,7 +106,7 @@ public void ambIterableWithSecondFires() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @SuppressWarnings("unchecked") diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleCacheTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleCacheTest.java index cd56bb5fe9..ce348eebeb 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleCacheTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleCacheTest.java @@ -28,12 +28,12 @@ public void cancelImmediately() { Single cached = pp.single(-99).cache(); - TestObserver ts = cached.test(true); + TestObserver to = cached.test(true); pp.onNext(1); pp.onComplete(); - ts.assertEmpty(); + to.assertEmpty(); cached.test().assertResult(1); } @@ -45,12 +45,12 @@ public void addRemoveRace() { final Single cached = pp.single(-99).cache(); - final TestObserver ts1 = cached.test(); + final TestObserver to1 = cached.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterSuccessTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterSuccessTest.java index 7dbe7729c6..d0e3376307 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterSuccessTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterSuccessTest.java @@ -38,7 +38,7 @@ public void accept(Integer e) throws Exception { } }; - final TestObserver ts = new TestObserver() { + final TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); @@ -50,7 +50,7 @@ public void onNext(Integer t) { public void just() { Single.just(1) .doAfterSuccess(afterSuccess) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -60,7 +60,7 @@ public void just() { public void error() { Single.error(new TestException()) .doAfterSuccess(afterSuccess) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); @@ -76,7 +76,7 @@ public void justConditional() { Single.just(1) .doAfterSuccess(afterSuccess) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertEquals(Arrays.asList(1, -1), values); @@ -87,7 +87,7 @@ public void errorConditional() { Single.error(new TestException()) .doAfterSuccess(afterSuccess) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertTrue(values.isEmpty()); diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterTerminateTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterTerminateTest.java index b1a55dc588..b7566cce30 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterTerminateTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleDoAfterTerminateTest.java @@ -40,13 +40,13 @@ public void run() throws Exception { } }; - private final TestObserver ts = new TestObserver(); + private final TestObserver to = new TestObserver(); @Test public void just() { Single.just(1) .doAfterTerminate(afterTerminate) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertAfterTerminateCalledOnce(); @@ -56,7 +56,7 @@ public void just() { public void error() { Single.error(new TestException()) .doAfterTerminate(afterTerminate) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertAfterTerminateCalledOnce(); @@ -72,7 +72,7 @@ public void justConditional() { Single.just(1) .doAfterTerminate(afterTerminate) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertResult(1); assertAfterTerminateCalledOnce(); @@ -83,7 +83,7 @@ public void errorConditional() { Single.error(new TestException()) .doAfterTerminate(afterTerminate) .filter(Functions.alwaysTrue()) - .subscribeWith(ts) + .subscribeWith(to) .assertFailure(TestException.class); assertAfterTerminateCalledOnce(); diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableFlowableTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableFlowableTest.java index 749e326ce6..086f72f838 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableFlowableTest.java @@ -19,7 +19,7 @@ import java.util.concurrent.TimeUnit; import org.junit.Test; -import org.reactivestreams.*; +import org.reactivestreams.Subscription; import io.reactivex.*; import io.reactivex.exceptions.TestException; @@ -108,7 +108,7 @@ public Iterable apply(Integer v) throws Exception { @Test public void fused() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Single.just(1).flattenAsFlowable(new Function>() { @Override @@ -116,17 +116,17 @@ public Iterable apply(Integer v) throws Exception { return Arrays.asList(v, v + 1); } }) - .subscribe(to); + .subscribe(ts); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.ASYNC)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2); ; } @Test public void fusedNoSync() { - TestSubscriber to = SubscriberFusion.newTest(QueueDisposable.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); Single.just(1).flattenAsFlowable(new Function>() { @Override @@ -134,10 +134,10 @@ public Iterable apply(Integer v) throws Exception { return Arrays.asList(v, v + 1); } }) - .subscribe(to); + .subscribe(ts); - to.assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueDisposable.NONE)) + ts.assertOf(SubscriberFusion.assertFuseable()) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2); ; } @@ -292,7 +292,7 @@ public Iterable apply(Object v) throws Exception { public void onSubscribe(Subscription d) { qd = (QueueSubscription)d; - assertEquals(QueueSubscription.ASYNC, qd.requestFusion(QueueSubscription.ANY)); + assertEquals(QueueFuseable.ASYNC, qd.requestFusion(QueueFuseable.ANY)); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableObservableTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableObservableTest.java index f1079e4669..8ae89d62d0 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleFlatMapIterableObservableTest.java @@ -25,7 +25,7 @@ import io.reactivex.disposables.Disposable; import io.reactivex.exceptions.TestException; import io.reactivex.functions.Function; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.util.CrashingIterable; import io.reactivex.observers.*; import io.reactivex.schedulers.Schedulers; @@ -86,7 +86,7 @@ public Iterable apply(Integer v) throws Exception { @Test public void fused() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); Single.just(1).flattenAsObservable(new Function>() { @Override @@ -97,14 +97,14 @@ public Iterable apply(Integer v) throws Exception { .subscribe(to); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2); ; } @Test public void fusedNoSync() { - TestObserver to = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); Single.just(1).flattenAsObservable(new Function>() { @Override @@ -115,7 +115,7 @@ public Iterable apply(Integer v) throws Exception { .subscribe(to); to.assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.NONE)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertResult(1, 2); ; } @@ -295,7 +295,7 @@ public Iterable apply(Object v) throws Exception { public void onSubscribe(Disposable d) { qd = (QueueDisposable)d; - assertEquals(QueueDisposable.ASYNC, qd.requestFusion(QueueDisposable.ANY)); + assertEquals(QueueFuseable.ASYNC, qd.requestFusion(QueueFuseable.ANY)); } @Override diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleFromPublisherTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleFromPublisherTest.java index c6cc2f46d5..b7231738a6 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleFromPublisherTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleFromPublisherTest.java @@ -61,13 +61,13 @@ public void error() { public void dispose() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = Single.fromPublisher(pp).test(); + TestObserver to = Single.fromPublisher(pp).test(); assertTrue(pp.hasSubscribers()); pp.onNext(1); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleSubscribeOnTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleSubscribeOnTest.java index ff669d0203..6f8b247056 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleSubscribeOnTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleSubscribeOnTest.java @@ -35,13 +35,13 @@ public void normal() { try { TestScheduler scheduler = new TestScheduler(); - TestObserver ts = Single.just(1) + TestObserver to = Single.just(1) .subscribeOn(scheduler) .test(); scheduler.advanceTimeBy(1, TimeUnit.SECONDS); - ts.assertResult(1); + to.assertResult(1); assertTrue(list.toString(), list.isEmpty()); } finally { diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleTakeUntilTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleTakeUntilTest.java index c9d7ab4467..07dd073f35 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleTakeUntilTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleTakeUntilTest.java @@ -33,13 +33,13 @@ public void mainSuccessPublisher() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp) + TestObserver to = source.single(-99).takeUntil(pp) .test(); source.onNext(1); source.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -47,13 +47,13 @@ public void mainSuccessSingle() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.single(-99)) + TestObserver to = source.single(-99).takeUntil(pp.single(-99)) .test(); source.onNext(1); source.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @@ -62,13 +62,13 @@ public void mainSuccessCompletable() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.ignoreElements()) + TestObserver to = source.single(-99).takeUntil(pp.ignoreElements()) .test(); source.onNext(1); source.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -76,12 +76,12 @@ public void mainErrorPublisher() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp) + TestObserver to = source.single(-99).takeUntil(pp) .test(); source.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -89,12 +89,12 @@ public void mainErrorSingle() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.single(-99)) + TestObserver to = source.single(-99).takeUntil(pp.single(-99)) .test(); source.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -102,12 +102,12 @@ public void mainErrorCompletable() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.ignoreElements()) + TestObserver to = source.single(-99).takeUntil(pp.ignoreElements()) .test(); source.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -115,12 +115,12 @@ public void otherOnNextPublisher() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp) + TestObserver to = source.single(-99).takeUntil(pp) .test(); pp.onNext(1); - ts.assertFailure(CancellationException.class); + to.assertFailure(CancellationException.class); } @Test @@ -128,13 +128,13 @@ public void otherOnNextSingle() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.single(-99)) + TestObserver to = source.single(-99).takeUntil(pp.single(-99)) .test(); pp.onNext(1); pp.onComplete(); - ts.assertFailure(CancellationException.class); + to.assertFailure(CancellationException.class); } @Test @@ -142,13 +142,13 @@ public void otherOnNextCompletable() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.ignoreElements()) + TestObserver to = source.single(-99).takeUntil(pp.ignoreElements()) .test(); pp.onNext(1); pp.onComplete(); - ts.assertFailure(CancellationException.class); + to.assertFailure(CancellationException.class); } @Test @@ -156,12 +156,12 @@ public void otherOnCompletePublisher() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp) + TestObserver to = source.single(-99).takeUntil(pp) .test(); pp.onComplete(); - ts.assertFailure(CancellationException.class); + to.assertFailure(CancellationException.class); } @Test @@ -169,12 +169,12 @@ public void otherOnCompleteCompletable() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.ignoreElements()) + TestObserver to = source.single(-99).takeUntil(pp.ignoreElements()) .test(); pp.onComplete(); - ts.assertFailure(CancellationException.class); + to.assertFailure(CancellationException.class); } @Test @@ -182,12 +182,12 @@ public void otherErrorPublisher() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp) + TestObserver to = source.single(-99).takeUntil(pp) .test(); pp.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -195,12 +195,12 @@ public void otherErrorSingle() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.single(-99)) + TestObserver to = source.single(-99).takeUntil(pp.single(-99)) .test(); pp.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -208,12 +208,12 @@ public void otherErrorCompletable() { PublishProcessor pp = PublishProcessor.create(); PublishProcessor source = PublishProcessor.create(); - TestObserver ts = source.single(-99).takeUntil(pp.ignoreElements()) + TestObserver to = source.single(-99).takeUntil(pp.ignoreElements()) .test(); pp.onError(new TestException()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test @@ -227,24 +227,24 @@ public void onErrorRace() { List errors = TestHelper.trackPluginErrors(); try { - final PublishProcessor ps1 = PublishProcessor.create(); - final PublishProcessor ps2 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + final PublishProcessor pp2 = PublishProcessor.create(); - TestObserver to = ps1.singleOrError().takeUntil(ps2).test(); + TestObserver to = pp1.singleOrError().takeUntil(pp2).test(); final TestException ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - ps1.onError(ex); + pp1.onError(ex); } }; Runnable r2 = new Runnable() { @Override public void run() { - ps2.onError(ex); + pp2.onError(ex); } }; diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleTimerTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleTimerTest.java index 93719ed764..55932efb37 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleTimerTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleTimerTest.java @@ -38,7 +38,7 @@ public void timerInterruptible() throws Exception { try { for (Scheduler s : new Scheduler[] { Schedulers.single(), Schedulers.computation(), Schedulers.newThread(), Schedulers.io(), Schedulers.from(exec) }) { final AtomicBoolean interrupted = new AtomicBoolean(); - TestObserver ts = Single.timer(1, TimeUnit.MILLISECONDS, s) + TestObserver to = Single.timer(1, TimeUnit.MILLISECONDS, s) .map(new Function() { @Override public Long apply(Long v) throws Exception { @@ -54,7 +54,7 @@ public Long apply(Long v) throws Exception { Thread.sleep(500); - ts.cancel(); + to.cancel(); Thread.sleep(500); diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleUsingTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleUsingTest.java index c0d3229e59..f49c35144d 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleUsingTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleUsingTest.java @@ -101,11 +101,11 @@ public void errorNonEager() { @Test public void eagerMapperThrowsDisposerThrows() { - TestObserver ts = Single.using(Functions.justCallable(Disposables.empty()), mapperThrows, disposerThrows) + TestObserver to = Single.using(Functions.justCallable(Disposables.empty()), mapperThrows, disposerThrows) .test() .assertFailure(CompositeException.class); - List ce = TestHelper.compositeList(ts.errors().get(0)); + List ce = TestHelper.compositeList(to.errors().get(0)); TestHelper.assertError(ce, 0, TestException.class, "Mapper"); TestHelper.assertError(ce, 1, TestException.class, "Disposer"); } @@ -182,7 +182,7 @@ public void disposerThrowsNonEager() { @Test public void errorAndDisposerThrowsEager() { - TestObserver ts = Single.using(Functions.justCallable(Disposables.empty()), + TestObserver to = Single.using(Functions.justCallable(Disposables.empty()), new Function>() { @Override public SingleSource apply(Disposable v) throws Exception { @@ -192,7 +192,7 @@ public SingleSource apply(Disposable v) throws Exception { .test() .assertFailure(CompositeException.class); - List ce = TestHelper.compositeList(ts.errors().get(0)); + List ce = TestHelper.compositeList(to.errors().get(0)); TestHelper.assertError(ce, 0, TestException.class, "Mapper-run"); TestHelper.assertError(ce, 1, TestException.class, "Disposer"); } @@ -224,7 +224,7 @@ public void successDisposeRace() { Disposable d = Disposables.empty(); - final TestObserver ts = Single.using(Functions.justCallable(d), new Function>() { + final TestObserver to = Single.using(Functions.justCallable(d), new Function>() { @Override public SingleSource apply(Disposable v) throws Exception { return pp.single(-99); @@ -243,7 +243,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -299,7 +299,7 @@ public void errorDisposeRace() { Disposable d = Disposables.empty(); - final TestObserver ts = Single.using(Functions.justCallable(d), new Function>() { + final TestObserver to = Single.using(Functions.justCallable(d), new Function>() { @Override public SingleSource apply(Disposable v) throws Exception { return pp.single(-99); @@ -318,7 +318,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; diff --git a/src/test/java/io/reactivex/internal/subscribers/DeferredScalarSubscriberTest.java b/src/test/java/io/reactivex/internal/subscribers/DeferredScalarSubscriberTest.java index 59a7f22fc4..c6ec1c24ee 100644 --- a/src/test/java/io/reactivex/internal/subscribers/DeferredScalarSubscriberTest.java +++ b/src/test/java/io/reactivex/internal/subscribers/DeferredScalarSubscriberTest.java @@ -106,13 +106,13 @@ public void error() { @Test public void unsubscribeComposes() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); TestSubscriber ts = TestSubscriber.create(0L); TestingDeferredScalarSubscriber ds = new TestingDeferredScalarSubscriber(ts); - ps.subscribe(ds); + pp.subscribe(ds); - assertTrue("No subscribers?", ps.hasSubscribers()); + assertTrue("No subscribers?", pp.hasSubscribers()); ts.cancel(); @@ -125,7 +125,7 @@ public void unsubscribeComposes() { ts.assertNoErrors(); ts.assertNotComplete(); - assertFalse("Subscribers?", ps.hasSubscribers()); + assertFalse("Subscribers?", pp.hasSubscribers()); assertTrue("Deferred not unsubscribed?", ds.isCancelled()); } diff --git a/src/test/java/io/reactivex/internal/subscribers/LambdaSubscriberTest.java b/src/test/java/io/reactivex/internal/subscribers/LambdaSubscriberTest.java index f07d7bdc30..b6eef24c5e 100644 --- a/src/test/java/io/reactivex/internal/subscribers/LambdaSubscriberTest.java +++ b/src/test/java/io/reactivex/internal/subscribers/LambdaSubscriberTest.java @@ -290,11 +290,11 @@ public void accept(Subscription s) throws Exception { @Test public void onNextThrowsCancelsUpstream() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); final List errors = new ArrayList(); - ps.subscribe(new Consumer() { + pp.subscribe(new Consumer() { @Override public void accept(Integer v) throws Exception { throw new TestException(); @@ -306,12 +306,12 @@ public void accept(Throwable e) throws Exception { } }); - assertTrue("No observers?!", ps.hasSubscribers()); + assertTrue("No observers?!", pp.hasSubscribers()); assertTrue("Has errors already?!", errors.isEmpty()); - ps.onNext(1); + pp.onNext(1); - assertFalse("Has observers?!", ps.hasSubscribers()); + assertFalse("Has observers?!", pp.hasSubscribers()); assertFalse("No errors?!", errors.isEmpty()); assertTrue(errors.toString(), errors.get(0) instanceof TestException); @@ -319,11 +319,11 @@ public void accept(Throwable e) throws Exception { @Test public void onSubscribeThrowsCancelsUpstream() { - PublishProcessor ps = PublishProcessor.create(); + PublishProcessor pp = PublishProcessor.create(); final List errors = new ArrayList(); - ps.subscribe(new Consumer() { + pp.subscribe(new Consumer() { @Override public void accept(Integer v) throws Exception { } @@ -343,7 +343,7 @@ public void accept(Subscription s) throws Exception { } }); - assertFalse("Has observers?!", ps.hasSubscribers()); + assertFalse("Has observers?!", pp.hasSubscribers()); assertFalse("No errors?!", errors.isEmpty()); assertTrue(errors.toString(), errors.get(0) instanceof TestException); diff --git a/src/test/java/io/reactivex/internal/subscriptions/DeferredScalarSubscriptionTest.java b/src/test/java/io/reactivex/internal/subscriptions/DeferredScalarSubscriptionTest.java index 6ad325a9d4..430e3c71c5 100644 --- a/src/test/java/io/reactivex/internal/subscriptions/DeferredScalarSubscriptionTest.java +++ b/src/test/java/io/reactivex/internal/subscriptions/DeferredScalarSubscriptionTest.java @@ -18,7 +18,7 @@ import org.junit.Test; import io.reactivex.TestHelper; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.subscribers.TestSubscriber; public class DeferredScalarSubscriptionTest { @@ -27,7 +27,7 @@ public class DeferredScalarSubscriptionTest { public void queueSubscriptionSyncRejected() { DeferredScalarSubscription ds = new DeferredScalarSubscription(new TestSubscriber()); - assertEquals(QueueSubscription.NONE, ds.requestFusion(QueueSubscription.SYNC)); + assertEquals(QueueFuseable.NONE, ds.requestFusion(QueueFuseable.SYNC)); } @Test diff --git a/src/test/java/io/reactivex/internal/util/HalfSerializerObserverTest.java b/src/test/java/io/reactivex/internal/util/HalfSerializerObserverTest.java index a0262cd328..38e099db23 100644 --- a/src/test/java/io/reactivex/internal/util/HalfSerializerObserverTest.java +++ b/src/test/java/io/reactivex/internal/util/HalfSerializerObserverTest.java @@ -207,28 +207,28 @@ public void onNextOnCompleteRace() { final AtomicInteger wip = new AtomicInteger(); final AtomicThrowable error = new AtomicThrowable(); - final TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + final TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); Runnable r1 = new Runnable() { @Override public void run() { - HalfSerializer.onNext(ts, 1, wip, error); + HalfSerializer.onNext(to, 1, wip, error); } }; Runnable r2 = new Runnable() { @Override public void run() { - HalfSerializer.onComplete(ts, wip, error); + HalfSerializer.onComplete(to, wip, error); } }; TestHelper.race(r1, r2); - ts.assertComplete().assertNoErrors(); + to.assertComplete().assertNoErrors(); - assertTrue(ts.valueCount() <= 1); + assertTrue(to.valueCount() <= 1); } } @@ -239,32 +239,32 @@ public void onErrorOnCompleteRace() { final AtomicInteger wip = new AtomicInteger(); final AtomicThrowable error = new AtomicThrowable(); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); final TestException ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - HalfSerializer.onError(ts, ex, wip, error); + HalfSerializer.onError(to, ex, wip, error); } }; Runnable r2 = new Runnable() { @Override public void run() { - HalfSerializer.onComplete(ts, wip, error); + HalfSerializer.onComplete(to, wip, error); } }; TestHelper.race(r1, r2); - if (ts.completions() != 0) { - ts.assertResult(); + if (to.completions() != 0) { + to.assertResult(); } else { - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } } } diff --git a/src/test/java/io/reactivex/internal/util/QueueDrainHelperTest.java b/src/test/java/io/reactivex/internal/util/QueueDrainHelperTest.java index dded845762..14375b506a 100644 --- a/src/test/java/io/reactivex/internal/util/QueueDrainHelperTest.java +++ b/src/test/java/io/reactivex/internal/util/QueueDrainHelperTest.java @@ -598,8 +598,8 @@ public boolean accept(Subscriber a, Integer v) { @Test public void observerCheckTerminatedDelayErrorEmpty() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -634,15 +634,15 @@ public void accept(Observer a, Integer v) { SpscArrayQueue q = new SpscArrayQueue(32); - QueueDrainHelper.checkTerminated(true, true, ts, true, q, null, qd); + QueueDrainHelper.checkTerminated(true, true, to, true, q, null, qd); - ts.assertResult(); + to.assertResult(); } @Test public void observerCheckTerminatedDelayErrorEmptyResource() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -679,17 +679,17 @@ public void accept(Observer a, Integer v) { Disposable d = Disposables.empty(); - QueueDrainHelper.checkTerminated(true, true, ts, true, q, d, qd); + QueueDrainHelper.checkTerminated(true, true, to, true, q, d, qd); - ts.assertResult(); + to.assertResult(); assertTrue(d.isDisposed()); } @Test public void observerCheckTerminatedDelayErrorNonEmpty() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -724,15 +724,15 @@ public void accept(Observer a, Integer v) { SpscArrayQueue q = new SpscArrayQueue(32); - QueueDrainHelper.checkTerminated(true, false, ts, true, q, null, qd); + QueueDrainHelper.checkTerminated(true, false, to, true, q, null, qd); - ts.assertEmpty(); + to.assertEmpty(); } @Test public void observerCheckTerminatedDelayErrorEmptyError() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -767,15 +767,15 @@ public void accept(Observer a, Integer v) { SpscArrayQueue q = new SpscArrayQueue(32); - QueueDrainHelper.checkTerminated(true, true, ts, true, q, null, qd); + QueueDrainHelper.checkTerminated(true, true, to, true, q, null, qd); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void observerCheckTerminatedNonDelayErrorError() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -810,14 +810,14 @@ public void accept(Observer a, Integer v) { SpscArrayQueue q = new SpscArrayQueue(32); - QueueDrainHelper.checkTerminated(true, false, ts, false, q, null, qd); + QueueDrainHelper.checkTerminated(true, false, to, false, q, null, qd); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @Test public void observerCheckTerminatedNonDelayErrorErrorResource() { - TestObserver ts = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + TestObserver to = new TestObserver(); + to.onSubscribe(Disposables.empty()); ObservableQueueDrain qd = new ObservableQueueDrain() { @Override @@ -854,9 +854,9 @@ public void accept(Observer a, Integer v) { Disposable d = Disposables.empty(); - QueueDrainHelper.checkTerminated(true, false, ts, false, q, d, qd); + QueueDrainHelper.checkTerminated(true, false, to, false, q, d, qd); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); assertTrue(d.isDisposed()); } diff --git a/src/test/java/io/reactivex/maybe/MaybeTest.java b/src/test/java/io/reactivex/maybe/MaybeTest.java index 14705243ea..18fe1fea4c 100644 --- a/src/test/java/io/reactivex/maybe/MaybeTest.java +++ b/src/test/java/io/reactivex/maybe/MaybeTest.java @@ -30,7 +30,7 @@ import io.reactivex.exceptions.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.internal.operators.flowable.FlowableZipTest.ArgsToString; import io.reactivex.internal.operators.maybe.*; import io.reactivex.observers.TestObserver; @@ -89,11 +89,11 @@ public void fromFlowableMany() { public void fromFlowableDisposeComposesThrough() { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().test(); + TestObserver to = pp.singleElement().test(); assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); } @@ -144,24 +144,24 @@ public void fromObservableMany() { @Test public void fromObservableDisposeComposesThrough() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.singleElement().test(false); + TestObserver to = ps.singleElement().test(false); - assertTrue(pp.hasObservers()); + assertTrue(ps.hasObservers()); - ts.cancel(); + to.cancel(); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); } @Test public void fromObservableDisposeComposesThroughImmediatelyCancelled() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - pp.singleElement().test(true); + ps.singleElement().test(true); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); } @Test @@ -542,9 +542,9 @@ public boolean test(Integer v) throws Exception { @Test public void cast() { - TestObserver ts = Maybe.just(1).cast(Number.class).test(); + TestObserver to = Maybe.just(1).cast(Number.class).test(); // don'n inline this due to the generic type - ts.assertResult((Number)1); + to.assertResult((Number)1); } @Test(expected = NullPointerException.class) @@ -870,7 +870,7 @@ public void doOnDisposeThrows() { try { PublishProcessor pp = PublishProcessor.create(); - TestObserver ts = pp.singleElement().doOnDispose(new Action() { + TestObserver to = pp.singleElement().doOnDispose(new Action() { @Override public void run() throws Exception { throw new TestException(); @@ -880,11 +880,11 @@ public void run() throws Exception { assertTrue(pp.hasSubscribers()); - ts.cancel(); + to.cancel(); assertFalse(pp.hasSubscribers()); - ts.assertSubscribed() + to.assertSubscribed() .assertNoValues() .assertNoErrors() .assertNotComplete(); @@ -1623,10 +1623,10 @@ public void ambArray1SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1637,7 +1637,7 @@ public void ambArray1SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @SuppressWarnings("unchecked") @@ -1646,10 +1646,10 @@ public void ambArray2SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1660,7 +1660,7 @@ public void ambArray2SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @SuppressWarnings("unchecked") @@ -1669,10 +1669,10 @@ public void ambArray1SignalsError() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1682,7 +1682,7 @@ public void ambArray1SignalsError() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @SuppressWarnings("unchecked") @@ -1691,10 +1691,10 @@ public void ambArray2SignalsError() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1704,7 +1704,7 @@ public void ambArray2SignalsError() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @SuppressWarnings("unchecked") @@ -1713,10 +1713,10 @@ public void ambArray1SignalsComplete() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1726,7 +1726,7 @@ public void ambArray1SignalsComplete() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @SuppressWarnings("unchecked") @@ -1735,10 +1735,10 @@ public void ambArray2SignalsComplete() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) + TestObserver to = Maybe.ambArray(pp1.singleElement(), pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1748,7 +1748,7 @@ public void ambArray2SignalsComplete() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @SuppressWarnings("unchecked") @@ -1757,10 +1757,10 @@ public void ambIterable1SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1771,7 +1771,7 @@ public void ambIterable1SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @SuppressWarnings("unchecked") @@ -1780,10 +1780,10 @@ public void ambIterable2SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1794,7 +1794,7 @@ public void ambIterable2SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @SuppressWarnings("unchecked") @@ -1803,10 +1803,10 @@ public void ambIterable2SignalsSuccessWithOverlap() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1818,7 +1818,7 @@ public void ambIterable2SignalsSuccessWithOverlap() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @SuppressWarnings("unchecked") @@ -1827,10 +1827,10 @@ public void ambIterable1SignalsError() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1840,7 +1840,7 @@ public void ambIterable1SignalsError() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @SuppressWarnings("unchecked") @@ -1849,10 +1849,10 @@ public void ambIterable2SignalsError() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1862,7 +1862,7 @@ public void ambIterable2SignalsError() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } @SuppressWarnings("unchecked") @@ -1871,10 +1871,10 @@ public void ambIterable2SignalsErrorWithOverlap() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1885,7 +1885,7 @@ public void ambIterable2SignalsErrorWithOverlap() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertFailureAndMessage(TestException.class, "2"); + to.assertFailureAndMessage(TestException.class, "2"); } @SuppressWarnings("unchecked") @@ -1894,10 +1894,10 @@ public void ambIterable1SignalsComplete() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1907,7 +1907,7 @@ public void ambIterable1SignalsComplete() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @SuppressWarnings("unchecked") @@ -1916,10 +1916,10 @@ public void ambIterable2SignalsComplete() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) + TestObserver to = Maybe.amb(Arrays.asList(pp1.singleElement(), pp2.singleElement())) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -1929,7 +1929,7 @@ public void ambIterable2SignalsComplete() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(); + to.assertResult(); } @Test(expected = NullPointerException.class) @@ -2076,13 +2076,13 @@ public void mergeArrayBackpressuredMixed3() { @SuppressWarnings("unchecked") @Test public void mergeArrayFused() { - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.mergeArray(Maybe.just(1), Maybe.just(2), Maybe.just(3)).subscribe(ts); ts.assertSubscribed() .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1, 2, 3); } @@ -2093,13 +2093,13 @@ public void mergeArrayFusedRace() { final PublishProcessor pp1 = PublishProcessor.create(); final PublishProcessor pp2 = PublishProcessor.create(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.mergeArray(pp1.singleElement(), pp2.singleElement()).subscribe(ts); ts.assertSubscribed() .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) ; TestHelper.race(new Runnable() { @@ -2210,14 +2210,14 @@ public void mergeALotFused() { Maybe[] sources = new Maybe[Flowable.bufferSize() * 2]; Arrays.fill(sources, Maybe.just(1)); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); Maybe.mergeArray(sources).subscribe(ts); ts .assertSubscribed() .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertValueCount(sources.length) .assertNoErrors() .assertComplete(); @@ -2420,7 +2420,7 @@ public void accept(Integer v, Throwable e) throws Exception { @Test public void doOnEventErrorThrows() { - TestObserver ts = Maybe.error(new TestException("Outer")) + TestObserver to = Maybe.error(new TestException("Outer")) .doOnEvent(new BiConsumer() { @Override public void accept(Integer v, Throwable e) throws Exception { @@ -2430,7 +2430,7 @@ public void accept(Integer v, Throwable e) throws Exception { .test() .assertFailure(CompositeException.class); - List list = TestHelper.compositeList(ts.errors().get(0)); + List list = TestHelper.compositeList(to.errors().get(0)); TestHelper.assertError(list, 0, TestException.class, "Outer"); TestHelper.assertError(list, 1, TestException.class, "Inner"); assertEquals(2, list.size()); @@ -2989,10 +2989,10 @@ public void ambWith1SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = pp1.singleElement().ambWith(pp2.singleElement()) + TestObserver to = pp1.singleElement().ambWith(pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -3003,7 +3003,7 @@ public void ambWith1SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -3011,10 +3011,10 @@ public void ambWith2SignalsSuccess() { PublishProcessor pp1 = PublishProcessor.create(); PublishProcessor pp2 = PublishProcessor.create(); - TestObserver ts = pp1.singleElement().ambWith(pp2.singleElement()) + TestObserver to = pp1.singleElement().ambWith(pp2.singleElement()) .test(); - ts.assertEmpty(); + to.assertEmpty(); assertTrue(pp1.hasSubscribers()); assertTrue(pp2.hasSubscribers()); @@ -3025,7 +3025,7 @@ public void ambWith2SignalsSuccess() { assertFalse(pp1.hasSubscribers()); assertFalse(pp2.hasSubscribers()); - ts.assertResult(2); + to.assertResult(2); } @Test diff --git a/src/test/java/io/reactivex/observable/ObservableCovarianceTest.java b/src/test/java/io/reactivex/observable/ObservableCovarianceTest.java index 5861cbfd57..5b2206001d 100644 --- a/src/test/java/io/reactivex/observable/ObservableCovarianceTest.java +++ b/src/test/java/io/reactivex/observable/ObservableCovarianceTest.java @@ -66,7 +66,7 @@ public int compare(Media t1, Media t2) { @Test public void testGroupByCompose() { Observable movies = Observable.just(new HorrorMovie(), new ActionMovie(), new Movie()); - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); movies .groupBy(new Function() { @Override @@ -105,11 +105,11 @@ public String apply(Movie v) { }); } }) - .subscribe(ts); - ts.assertTerminated(); - ts.assertNoErrors(); + .subscribe(to); + to.assertTerminated(); + to.assertNoErrors(); // System.out.println(ts.getOnNextEvents()); - assertEquals(6, ts.valueCount()); + assertEquals(6, to.valueCount()); } @SuppressWarnings("unused") diff --git a/src/test/java/io/reactivex/observable/ObservableFuseableTest.java b/src/test/java/io/reactivex/observable/ObservableFuseableTest.java index ba65019910..070810461c 100644 --- a/src/test/java/io/reactivex/observable/ObservableFuseableTest.java +++ b/src/test/java/io/reactivex/observable/ObservableFuseableTest.java @@ -17,7 +17,7 @@ import org.junit.Test; import io.reactivex.Observable; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.observers.ObserverFusion; public class ObservableFuseableTest { @@ -26,8 +26,8 @@ public class ObservableFuseableTest { public void syncRange() { Observable.range(1, 10) - .to(ObserverFusion.test(QueueSubscription.ANY, false)) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -37,8 +37,8 @@ public void syncRange() { public void syncArray() { Observable.fromArray(new Integer[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 }) - .to(ObserverFusion.test(QueueSubscription.ANY, false)) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -48,8 +48,8 @@ public void syncArray() { public void syncIterable() { Observable.fromIterable(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)) - .to(ObserverFusion.test(QueueSubscription.ANY, false)) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.SYNC)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -59,9 +59,9 @@ public void syncIterable() { public void syncRangeHidden() { Observable.range(1, 10).hide() - .to(ObserverFusion.test(QueueSubscription.ANY, false)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) .assertOf(ObserverFusion.assertNotFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -71,9 +71,9 @@ public void syncRangeHidden() { public void syncArrayHidden() { Observable.fromArray(new Integer[] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 }) .hide() - .to(ObserverFusion.test(QueueSubscription.ANY, false)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) .assertOf(ObserverFusion.assertNotFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); @@ -83,9 +83,9 @@ public void syncArrayHidden() { public void syncIterableHidden() { Observable.fromIterable(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)) .hide() - .to(ObserverFusion.test(QueueSubscription.ANY, false)) + .to(ObserverFusion.test(QueueFuseable.ANY, false)) .assertOf(ObserverFusion.assertNotFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.NONE)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.NONE)) .assertValues(1, 2, 3, 4, 5, 6, 7, 8, 9, 10) .assertNoErrors() .assertComplete(); diff --git a/src/test/java/io/reactivex/observable/ObservableNullTests.java b/src/test/java/io/reactivex/observable/ObservableNullTests.java index bc97de83d7..105a429b1f 100644 --- a/src/test/java/io/reactivex/observable/ObservableNullTests.java +++ b/src/test/java/io/reactivex/observable/ObservableNullTests.java @@ -368,11 +368,11 @@ public void fromFutureReturnsNull() { FutureTask f = new FutureTask(Functions.EMPTY_RUNNABLE, null); f.run(); - TestObserver ts = new TestObserver(); - Observable.fromFuture(f).subscribe(ts); - ts.assertNoValues(); - ts.assertNotComplete(); - ts.assertError(NullPointerException.class); + TestObserver to = new TestObserver(); + Observable.fromFuture(f).subscribe(to); + to.assertNoValues(); + to.assertNotComplete(); + to.assertError(NullPointerException.class); } @Test(expected = NullPointerException.class) diff --git a/src/test/java/io/reactivex/observable/ObservableSubscriberTest.java b/src/test/java/io/reactivex/observable/ObservableSubscriberTest.java index a6761dc9e4..5e927ad46b 100644 --- a/src/test/java/io/reactivex/observable/ObservableSubscriberTest.java +++ b/src/test/java/io/reactivex/observable/ObservableSubscriberTest.java @@ -174,10 +174,10 @@ public void methodTestCancelled() { @Test public void safeSubscriberAlreadySafe() { - TestObserver ts = new TestObserver(); - Observable.just(1).safeSubscribe(new SafeObserver(ts)); + TestObserver to = new TestObserver(); + Observable.just(1).safeSubscribe(new SafeObserver(to)); - ts.assertResult(1); + to.assertResult(1); } diff --git a/src/test/java/io/reactivex/observable/ObservableTest.java b/src/test/java/io/reactivex/observable/ObservableTest.java index fc79edaa9c..9b549670a8 100644 --- a/src/test/java/io/reactivex/observable/ObservableTest.java +++ b/src/test/java/io/reactivex/observable/ObservableTest.java @@ -1026,23 +1026,23 @@ public void testRangeWithScheduler() { @Test public void testMergeWith() { - TestObserver ts = new TestObserver(); - Observable.just(1).mergeWith(Observable.just(2)).subscribe(ts); - ts.assertValues(1, 2); + TestObserver to = new TestObserver(); + Observable.just(1).mergeWith(Observable.just(2)).subscribe(to); + to.assertValues(1, 2); } @Test public void testConcatWith() { - TestObserver ts = new TestObserver(); - Observable.just(1).concatWith(Observable.just(2)).subscribe(ts); - ts.assertValues(1, 2); + TestObserver to = new TestObserver(); + Observable.just(1).concatWith(Observable.just(2)).subscribe(to); + to.assertValues(1, 2); } @Test public void testAmbWith() { - TestObserver ts = new TestObserver(); - Observable.just(1).ambWith(Observable.just(2)).subscribe(ts); - ts.assertValue(1); + TestObserver to = new TestObserver(); + Observable.just(1).ambWith(Observable.just(2)).subscribe(to); + to.assertValue(1); } @Test @@ -1072,7 +1072,7 @@ public void accept(List booleans) { @Test public void testCompose() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Observable.just(1, 2, 3).compose(new ObservableTransformer() { @Override public Observable apply(Observable t1) { @@ -1084,10 +1084,10 @@ public String apply(Integer v) { }); } }) - .subscribe(ts); - ts.assertTerminated(); - ts.assertNoErrors(); - ts.assertValues("1", "2", "3"); + .subscribe(to); + to.assertTerminated(); + to.assertNoErrors(); + to.assertValues("1", "2", "3"); } @Test diff --git a/src/test/java/io/reactivex/observers/ObserverFusion.java b/src/test/java/io/reactivex/observers/ObserverFusion.java index a70c577ca3..22b3466b19 100644 --- a/src/test/java/io/reactivex/observers/ObserverFusion.java +++ b/src/test/java/io/reactivex/observers/ObserverFusion.java @@ -32,7 +32,7 @@ public enum ObserverFusion { * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(QueueDisposable.ANY, false))
+     * .to(ObserverFusion.test(QueueFuseable.ANY, false))
      * .assertResult(0);
      * 
* @param the value type @@ -52,7 +52,7 @@ public static Function, TestObserver> test( * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(0, QueueDisposable.ANY, false))
+     * .to(ObserverFusion.test(0, QueueFuseable.ANY, false))
      * .assertOf(ObserverFusion.assertFuseable());
      * 
* @param the value type @@ -71,8 +71,8 @@ static final class AssertFusionConsumer implements Consumer> } @Override - public void accept(TestObserver ts) throws Exception { - ts.assertFusionMode(mode); + public void accept(TestObserver to) throws Exception { + to.assertFusionMode(mode); } } @@ -87,21 +87,21 @@ static final class TestFunctionCallback implements Function, Te @Override public TestObserver apply(Observable t) throws Exception { - TestObserver ts = new TestObserver(); - ts.setInitialFusionMode(mode); + TestObserver to = new TestObserver(); + to.setInitialFusionMode(mode); if (cancelled) { - ts.cancel(); + to.cancel(); } - t.subscribe(ts); - return ts; + t.subscribe(to); + return to; } } enum AssertFuseable implements Consumer> { INSTANCE; @Override - public void accept(TestObserver ts) throws Exception { - ts.assertFuseable(); + public void accept(TestObserver to) throws Exception { + to.assertFuseable(); } } @@ -112,7 +112,7 @@ public void accept(TestObserver ts) throws Exception { * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(0, QueueDisposable.ANY, false))
+     * .to(ObserverFusion.test(0, QueueFuseable.ANY, false))
      * .assertOf(ObserverFusion.assertNotFuseable());
      * 
* @param the value type @@ -126,8 +126,8 @@ public static Consumer> assertNotFuseable() { enum AssertNotFuseable implements Consumer> { INSTANCE; @Override - public void accept(TestObserver ts) throws Exception { - ts.assertNotFuseable(); + public void accept(TestObserver to) throws Exception { + to.assertNotFuseable(); } } @@ -139,11 +139,11 @@ public void accept(TestObserver ts) throws Exception { * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(0, QueueDisposable.ANY, false))
-     * .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.SYNC));
+     * .to(ObserverFusion.test(0, QueueFuseable.ANY, false))
+     * .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.SYNC));
      * 
* @param the value type - * @param mode the expected established fusion mode, see {@link QueueDisposable} constants. + * @param mode the expected established fusion mode, see {@link QueueFuseable} constants. * @return the new Consumer instance */ public static Consumer> assertFusionMode(final int mode) { @@ -154,25 +154,25 @@ public static Consumer> assertFusionMode(final int mode) { /** * Constructs a TestObserver with the given required fusion mode. * @param the value type - * @param mode the requested fusion mode, see {@link QueueSubscription} constants + * @param mode the requested fusion mode, see {@link QueueFuseable} constants * @return the new TestSubscriber */ public static TestObserver newTest(int mode) { - TestObserver ts = new TestObserver(); - ts.setInitialFusionMode(mode); - return ts; + TestObserver to = new TestObserver(); + to.setInitialFusionMode(mode); + return to; } /** - * Assert that the TestSubscriber received a fuseabe QueueSubscription and + * Assert that the TestSubscriber received a fuseabe QueueFuseable.and * is in the given fusion mode. * @param the value type - * @param ts the TestSubscriber instance + * @param to the TestSubscriber instance * @param mode the expected mode * @return the TestSubscriber */ - public static TestObserver assertFusion(TestObserver ts, int mode) { - return ts.assertOf(ObserverFusion.assertFuseable()) + public static TestObserver assertFusion(TestObserver to, int mode) { + return to.assertOf(ObserverFusion.assertFuseable()) .assertOf(ObserverFusion.assertFusionMode(mode)); } } diff --git a/src/test/java/io/reactivex/observers/SafeObserverTest.java b/src/test/java/io/reactivex/observers/SafeObserverTest.java index cf92a7139c..ee6eb83f43 100644 --- a/src/test/java/io/reactivex/observers/SafeObserverTest.java +++ b/src/test/java/io/reactivex/observers/SafeObserverTest.java @@ -490,15 +490,15 @@ public void onComplete() { @Test public void dispose() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); Disposable d = Disposables.empty(); so.onSubscribe(d); - ts.dispose(); + to.dispose(); assertTrue(d.isDisposed()); @@ -507,9 +507,9 @@ public void dispose() { @Test public void onNextAfterComplete() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); Disposable d = Disposables.empty(); @@ -523,14 +523,14 @@ public void onNextAfterComplete() { so.onComplete(); - ts.assertResult(); + to.assertResult(); } @Test public void onNextNull() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); Disposable d = Disposables.empty(); @@ -538,50 +538,50 @@ public void onNextNull() { so.onNext(null); - ts.assertFailure(NullPointerException.class); + to.assertFailure(NullPointerException.class); } @Test public void onNextWithoutOnSubscribe() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); so.onNext(1); - ts.assertFailureAndMessage(NullPointerException.class, "Subscription not set!"); + to.assertFailureAndMessage(NullPointerException.class, "Subscription not set!"); } @Test public void onErrorWithoutOnSubscribe() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); so.onError(new TestException()); - ts.assertFailure(CompositeException.class); + to.assertFailure(CompositeException.class); - TestHelper.assertError(ts, 0, TestException.class); - TestHelper.assertError(ts, 1, NullPointerException.class, "Subscription not set!"); + TestHelper.assertError(to, 0, TestException.class); + TestHelper.assertError(to, 1, NullPointerException.class, "Subscription not set!"); } @Test public void onCompleteWithoutOnSubscribe() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); so.onComplete(); - ts.assertFailureAndMessage(NullPointerException.class, "Subscription not set!"); + to.assertFailureAndMessage(NullPointerException.class, "Subscription not set!"); } @Test public void onNextNormal() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SafeObserver so = new SafeObserver(ts); + SafeObserver so = new SafeObserver(to); Disposable d = Disposables.empty(); @@ -590,7 +590,7 @@ public void onNextNormal() { so.onNext(1); so.onComplete(); - ts.assertResult(1); + to.assertResult(1); } static final class CrashDummy implements Observer, Disposable { diff --git a/src/test/java/io/reactivex/observers/SerializedObserverTest.java b/src/test/java/io/reactivex/observers/SerializedObserverTest.java index ee50af3730..720964c1c0 100644 --- a/src/test/java/io/reactivex/observers/SerializedObserverTest.java +++ b/src/test/java/io/reactivex/observers/SerializedObserverTest.java @@ -957,7 +957,7 @@ public void onNext(Integer t) { public void testErrorReentry() { final AtomicReference> serial = new AtomicReference>(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer v) { serial.get().onError(new TestException()); @@ -965,20 +965,20 @@ public void onNext(Integer v) { super.onNext(v); } }; - SerializedObserver sobs = new SerializedObserver(ts); + SerializedObserver sobs = new SerializedObserver(to); sobs.onSubscribe(Disposables.empty()); serial.set(sobs); sobs.onNext(1); - ts.assertValue(1); - ts.assertError(TestException.class); + to.assertValue(1); + to.assertError(TestException.class); } @Test public void testCompleteReentry() { final AtomicReference> serial = new AtomicReference>(); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer v) { serial.get().onComplete(); @@ -986,22 +986,22 @@ public void onNext(Integer v) { super.onNext(v); } }; - SerializedObserver sobs = new SerializedObserver(ts); + SerializedObserver sobs = new SerializedObserver(to); sobs.onSubscribe(Disposables.empty()); serial.set(sobs); sobs.onNext(1); - ts.assertValue(1); - ts.assertComplete(); - ts.assertNoErrors(); + to.assertValue(1); + to.assertComplete(); + to.assertNoErrors(); } @Test public void dispose() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - SerializedObserver so = new SerializedObserver(ts); + SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1009,7 +1009,7 @@ public void dispose() { assertFalse(so.isDisposed()); - ts.cancel(); + to.cancel(); assertTrue(so.isDisposed()); @@ -1019,9 +1019,9 @@ public void dispose() { @Test public void onCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1036,7 +1036,7 @@ public void run() { TestHelper.race(r, r); - ts.awaitDone(5, TimeUnit.SECONDS) + to.awaitDone(5, TimeUnit.SECONDS) .assertResult(); } @@ -1045,9 +1045,9 @@ public void run() { @Test public void onNextOnCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1069,11 +1069,11 @@ public void run() { TestHelper.race(r1, r2); - ts.awaitDone(5, TimeUnit.SECONDS) + to.awaitDone(5, TimeUnit.SECONDS) .assertNoErrors() .assertComplete(); - assertTrue(ts.valueCount() <= 1); + assertTrue(to.valueCount() <= 1); } } @@ -1081,9 +1081,9 @@ public void run() { @Test public void onNextOnErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1107,11 +1107,11 @@ public void run() { TestHelper.race(r1, r2); - ts.awaitDone(5, TimeUnit.SECONDS) + to.awaitDone(5, TimeUnit.SECONDS) .assertError(ex) .assertNotComplete(); - assertTrue(ts.valueCount() <= 1); + assertTrue(to.valueCount() <= 1); } } @@ -1119,9 +1119,9 @@ public void run() { @Test public void onNextOnErrorRaceDelayError() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts, true); + final SerializedObserver so = new SerializedObserver(to, true); Disposable d = Disposables.empty(); @@ -1145,11 +1145,11 @@ public void run() { TestHelper.race(r1, r2); - ts.awaitDone(5, TimeUnit.SECONDS) + to.awaitDone(5, TimeUnit.SECONDS) .assertError(ex) .assertNotComplete(); - assertTrue(ts.valueCount() <= 1); + assertTrue(to.valueCount() <= 1); } } @@ -1160,9 +1160,9 @@ public void startOnce() { List error = TestHelper.trackPluginErrors(); try { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); so.onSubscribe(Disposables.empty()); @@ -1184,9 +1184,9 @@ public void onCompleteOnErrorRace() { List errors = TestHelper.trackPluginErrors(); try { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1210,12 +1210,12 @@ public void run() { TestHelper.race(r1, r2); - ts.awaitDone(5, TimeUnit.SECONDS); + to.awaitDone(5, TimeUnit.SECONDS); - if (ts.completions() != 0) { - ts.assertResult(); + if (to.completions() != 0) { + to.assertResult(); } else { - ts.assertFailure(TestException.class).assertError(ex); + to.assertFailure(TestException.class).assertError(ex); } for (Throwable e : errors) { @@ -1231,9 +1231,9 @@ public void run() { @Test public void nullOnNext() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - final SerializedObserver so = new SerializedObserver(ts); + final SerializedObserver so = new SerializedObserver(to); Disposable d = Disposables.empty(); @@ -1241,6 +1241,6 @@ public void nullOnNext() { so.onNext(null); - ts.assertFailureAndMessage(NullPointerException.class, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); + to.assertFailureAndMessage(NullPointerException.class, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); } } diff --git a/src/test/java/io/reactivex/observers/TestObserverTest.java b/src/test/java/io/reactivex/observers/TestObserverTest.java index d2896519a8..cca65c0b72 100644 --- a/src/test/java/io/reactivex/observers/TestObserverTest.java +++ b/src/test/java/io/reactivex/observers/TestObserverTest.java @@ -32,7 +32,7 @@ import io.reactivex.exceptions.TestException; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueDisposable; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.operators.observable.ObservableScalarXMap.ScalarDisposable; import io.reactivex.internal.subscriptions.EmptySubscription; import io.reactivex.processors.PublishProcessor; @@ -197,46 +197,46 @@ public void testErrorSwallowed() { @Test public void testGetEvents() { - TestSubscriber to = new TestSubscriber(); - to.onSubscribe(EmptySubscription.INSTANCE); - to.onNext(1); - to.onNext(2); + TestSubscriber ts = new TestSubscriber(); + ts.onSubscribe(EmptySubscription.INSTANCE); + ts.onNext(1); + ts.onNext(2); assertEquals(Arrays.asList(Arrays.asList(1, 2), Collections.emptyList(), - Collections.emptyList()), to.getEvents()); + Collections.emptyList()), ts.getEvents()); - to.onComplete(); + ts.onComplete(); assertEquals(Arrays.asList(Arrays.asList(1, 2), Collections.emptyList(), - Collections.singletonList(Notification.createOnComplete())), to.getEvents()); + Collections.singletonList(Notification.createOnComplete())), ts.getEvents()); TestException ex = new TestException(); - TestSubscriber to2 = new TestSubscriber(); - to2.onSubscribe(EmptySubscription.INSTANCE); - to2.onNext(1); - to2.onNext(2); + TestSubscriber ts2 = new TestSubscriber(); + ts2.onSubscribe(EmptySubscription.INSTANCE); + ts2.onNext(1); + ts2.onNext(2); assertEquals(Arrays.asList(Arrays.asList(1, 2), Collections.emptyList(), - Collections.emptyList()), to2.getEvents()); + Collections.emptyList()), ts2.getEvents()); - to2.onError(ex); + ts2.onError(ex); assertEquals(Arrays.asList( Arrays.asList(1, 2), Collections.singletonList(ex), Collections.emptyList()), - to2.getEvents()); + ts2.getEvents()); } @Test public void testNullExpected() { - TestSubscriber to = new TestSubscriber(); - to.onNext(1); + TestSubscriber ts = new TestSubscriber(); + ts.onNext(1); try { - to.assertValue((Integer) null); + ts.assertValue((Integer) null); } catch (AssertionError ex) { // this is expected return; @@ -246,11 +246,11 @@ public void testNullExpected() { @Test public void testNullActual() { - TestSubscriber to = new TestSubscriber(); - to.onNext(null); + TestSubscriber ts = new TestSubscriber(); + ts.onNext(null); try { - to.assertValue(1); + ts.assertValue(1); } catch (AssertionError ex) { // this is expected return; @@ -260,12 +260,12 @@ public void testNullActual() { @Test public void testTerminalErrorOnce() { - TestSubscriber to = new TestSubscriber(); - to.onError(new TestException()); - to.onError(new TestException()); + TestSubscriber ts = new TestSubscriber(); + ts.onError(new TestException()); + ts.onError(new TestException()); try { - to.assertTerminated(); + ts.assertTerminated(); } catch (AssertionError ex) { // this is expected return; @@ -274,12 +274,12 @@ public void testTerminalErrorOnce() { } @Test public void testTerminalCompletedOnce() { - TestSubscriber to = new TestSubscriber(); - to.onComplete(); - to.onComplete(); + TestSubscriber ts = new TestSubscriber(); + ts.onComplete(); + ts.onComplete(); try { - to.assertTerminated(); + ts.assertTerminated(); } catch (AssertionError ex) { // this is expected return; @@ -289,12 +289,12 @@ public void testTerminalCompletedOnce() { @Test public void testTerminalOneKind() { - TestSubscriber to = new TestSubscriber(); - to.onError(new TestException()); - to.onComplete(); + TestSubscriber ts = new TestSubscriber(); + ts.onError(new TestException()); + ts.onComplete(); try { - to.assertTerminated(); + ts.assertTerminated(); } catch (AssertionError ex) { // this is expected return; @@ -304,68 +304,68 @@ public void testTerminalOneKind() { @Test public void createDelegate() { - TestObserver ts1 = TestObserver.create(); + TestObserver to1 = TestObserver.create(); - TestObserver ts = TestObserver.create(ts1); + TestObserver to = TestObserver.create(to1); - ts.assertNotSubscribed(); + to.assertNotSubscribed(); - assertFalse(ts.hasSubscription()); + assertFalse(to.hasSubscription()); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); try { - ts.assertNotSubscribed(); + to.assertNotSubscribed(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } - assertTrue(ts.hasSubscription()); + assertTrue(to.hasSubscription()); - assertFalse(ts.isDisposed()); + assertFalse(to.isDisposed()); - ts.onNext(1); - ts.onError(new TestException()); - ts.onComplete(); + to.onNext(1); + to.onError(new TestException()); + to.onComplete(); - ts1.assertValue(1).assertError(TestException.class).assertComplete(); + to1.assertValue(1).assertError(TestException.class).assertComplete(); - ts.dispose(); + to.dispose(); - assertTrue(ts.isDisposed()); + assertTrue(to.isDisposed()); - assertTrue(ts.isTerminated()); + assertTrue(to.isTerminated()); - assertSame(Thread.currentThread(), ts.lastThread()); + assertSame(Thread.currentThread(), to.lastThread()); try { - ts.assertNoValues(); + to.assertNoValues(); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertValueCount(0); + to.assertValueCount(0); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } - ts.assertValueSequence(Collections.singletonList(1)); + to.assertValueSequence(Collections.singletonList(1)); try { - ts.assertValueSequence(Collections.singletonList(2)); + to.assertValueSequence(Collections.singletonList(2)); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } - ts.assertValueSet(Collections.singleton(1)); + to.assertValueSet(Collections.singleton(1)); try { - ts.assertValueSet(Collections.singleton(2)); + to.assertValueSet(Collections.singleton(2)); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected @@ -375,115 +375,115 @@ public void createDelegate() { @Test public void assertError() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); try { - ts.assertError(TestException.class); + to.assertError(TestException.class); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertError(new TestException()); + to.assertError(new TestException()); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertError(Functions.alwaysTrue()); + to.assertError(Functions.alwaysTrue()); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertErrorMessage(""); + to.assertErrorMessage(""); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertSubscribed(); + to.assertSubscribed(); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertTerminated(); + to.assertTerminated(); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.assertSubscribed(); + to.assertSubscribed(); - ts.assertNoErrors(); + to.assertNoErrors(); TestException ex = new TestException("Forced failure"); - ts.onError(ex); + to.onError(ex); - ts.assertError(ex); + to.assertError(ex); - ts.assertError(TestException.class); + to.assertError(TestException.class); - ts.assertError(Functions.alwaysTrue()); + to.assertError(Functions.alwaysTrue()); - ts.assertError(new Predicate() { + to.assertError(new Predicate() { @Override public boolean test(Throwable t) throws Exception { return t.getMessage() != null && t.getMessage().contains("Forced"); } }); - ts.assertErrorMessage("Forced failure"); + to.assertErrorMessage("Forced failure"); try { - ts.assertErrorMessage(""); + to.assertErrorMessage(""); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertError(new RuntimeException()); + to.assertError(new RuntimeException()); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertError(IOException.class); + to.assertError(IOException.class); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertError(Functions.alwaysFalse()); + to.assertError(Functions.alwaysFalse()); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } try { - ts.assertNoErrors(); + to.assertNoErrors(); throw new RuntimeException("Should have thrown"); } catch (AssertionError exc) { // expected } - ts.assertTerminated(); + to.assertTerminated(); - ts.assertValueCount(0); + to.assertValueCount(0); - ts.assertNoValues(); + to.assertNoValues(); } @@ -502,67 +502,67 @@ public void valueAndClass() { @Test public void assertFailure() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.onError(new TestException("Forced failure")); + to.onError(new TestException("Forced failure")); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); - ts.assertFailure(Functions.alwaysTrue()); + to.assertFailure(Functions.alwaysTrue()); - ts.assertFailureAndMessage(TestException.class, "Forced failure"); + to.assertFailureAndMessage(TestException.class, "Forced failure"); - ts.onNext(1); + to.onNext(1); - ts.assertFailure(TestException.class, 1); + to.assertFailure(TestException.class, 1); - ts.assertFailure(Functions.alwaysTrue(), 1); + to.assertFailure(Functions.alwaysTrue(), 1); - ts.assertFailureAndMessage(TestException.class, "Forced failure", 1); + to.assertFailureAndMessage(TestException.class, "Forced failure", 1); } @Test public void assertFuseable() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.assertNotFuseable(); + to.assertNotFuseable(); try { - ts.assertFuseable(); + to.assertFuseable(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertFusionMode(QueueDisposable.SYNC); + to.assertFusionMode(QueueFuseable.SYNC); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } - ts = TestObserver.create(); - ts.setInitialFusionMode(QueueDisposable.ANY); + to = TestObserver.create(); + to.setInitialFusionMode(QueueFuseable.ANY); - ts.onSubscribe(new ScalarDisposable(ts, 1)); + to.onSubscribe(new ScalarDisposable(to, 1)); - ts.assertFuseable(); + to.assertFuseable(); - ts.assertFusionMode(QueueDisposable.SYNC); + to.assertFusionMode(QueueFuseable.SYNC); try { - ts.assertFusionMode(QueueDisposable.NONE); + to.assertFusionMode(QueueFuseable.NONE); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertNotFuseable(); + to.assertNotFuseable(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected @@ -572,14 +572,14 @@ public void assertFuseable() { @Test public void assertTerminated() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.assertNotTerminated(); + to.assertNotTerminated(); - ts.onError(null); + to.onError(null); try { - ts.assertNotTerminated(); + to.assertNotTerminated(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected @@ -588,9 +588,9 @@ public void assertTerminated() { @Test public void assertOf() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.assertOf(new Consumer>() { + to.assertOf(new Consumer>() { @Override public void accept(TestObserver f) throws Exception { f.assertNotSubscribed(); @@ -598,7 +598,7 @@ public void accept(TestObserver f) throws Exception { }); try { - ts.assertOf(new Consumer>() { + to.assertOf(new Consumer>() { @Override public void accept(TestObserver f) throws Exception { f.assertSubscribed(); @@ -610,7 +610,7 @@ public void accept(TestObserver f) throws Exception { } try { - ts.assertOf(new Consumer>() { + to.assertOf(new Consumer>() { @Override public void accept(TestObserver f) throws Exception { throw new IllegalArgumentException(); @@ -624,34 +624,34 @@ public void accept(TestObserver f) throws Exception { @Test public void assertResult() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.onComplete(); + to.onComplete(); - ts.assertResult(); + to.assertResult(); try { - ts.assertResult(1); + to.assertResult(1); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } - ts.onNext(1); + to.onNext(1); - ts.assertResult(1); + to.assertResult(1); try { - ts.assertResult(2); + to.assertResult(2); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertResult(); + to.assertResult(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected @@ -661,139 +661,139 @@ public void assertResult() { @Test(timeout = 5000) public void await() throws Exception { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - assertFalse(ts.await(100, TimeUnit.MILLISECONDS)); + assertFalse(to.await(100, TimeUnit.MILLISECONDS)); - ts.awaitDone(100, TimeUnit.MILLISECONDS); + to.awaitDone(100, TimeUnit.MILLISECONDS); - assertTrue(ts.isDisposed()); + assertTrue(to.isDisposed()); - assertFalse(ts.awaitTerminalEvent(100, TimeUnit.MILLISECONDS)); + assertFalse(to.awaitTerminalEvent(100, TimeUnit.MILLISECONDS)); - assertEquals(0, ts.completions()); - assertEquals(0, ts.errorCount()); + assertEquals(0, to.completions()); + assertEquals(0, to.errorCount()); - ts.onComplete(); + to.onComplete(); - assertTrue(ts.await(100, TimeUnit.MILLISECONDS)); + assertTrue(to.await(100, TimeUnit.MILLISECONDS)); - ts.await(); + to.await(); - ts.awaitDone(5, TimeUnit.SECONDS); + to.awaitDone(5, TimeUnit.SECONDS); - assertEquals(1, ts.completions()); - assertEquals(0, ts.errorCount()); + assertEquals(1, to.completions()); + assertEquals(0, to.errorCount()); - assertTrue(ts.awaitTerminalEvent()); + assertTrue(to.awaitTerminalEvent()); - final TestObserver ts1 = TestObserver.create(); + final TestObserver to1 = TestObserver.create(); - ts1.onSubscribe(Disposables.empty()); + to1.onSubscribe(Disposables.empty()); Schedulers.single().scheduleDirect(new Runnable() { @Override public void run() { - ts1.onComplete(); + to1.onComplete(); } }, 200, TimeUnit.MILLISECONDS); - ts1.await(); + to1.await(); - ts1.assertValueSet(Collections.emptySet()); + to1.assertValueSet(Collections.emptySet()); } @Test public void errors() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - assertEquals(0, ts.errors().size()); + assertEquals(0, to.errors().size()); - ts.onError(new TestException()); + to.onError(new TestException()); - assertEquals(1, ts.errors().size()); + assertEquals(1, to.errors().size()); - TestHelper.assertError(ts.errors(), 0, TestException.class); + TestHelper.assertError(to.errors(), 0, TestException.class); } @SuppressWarnings("unchecked") @Test public void onNext() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - assertEquals(0, ts.valueCount()); + assertEquals(0, to.valueCount()); - assertEquals(Collections.emptyList(), ts.values()); + assertEquals(Collections.emptyList(), to.values()); - ts.onNext(1); + to.onNext(1); - assertEquals(Collections.singletonList(1), ts.values()); + assertEquals(Collections.singletonList(1), to.values()); - ts.cancel(); + to.cancel(); - assertTrue(ts.isCancelled()); - assertTrue(ts.isDisposed()); + assertTrue(to.isCancelled()); + assertTrue(to.isDisposed()); - ts.assertValue(1); + to.assertValue(1); - assertEquals(Arrays.asList(Collections.singletonList(1), Collections.emptyList(), Collections.emptyList()), ts.getEvents()); + assertEquals(Arrays.asList(Collections.singletonList(1), Collections.emptyList(), Collections.emptyList()), to.getEvents()); - ts.onComplete(); + to.onComplete(); - assertEquals(Arrays.asList(Collections.singletonList(1), Collections.emptyList(), Collections.singletonList(Notification.createOnComplete())), ts.getEvents()); + assertEquals(Arrays.asList(Collections.singletonList(1), Collections.emptyList(), Collections.singletonList(Notification.createOnComplete())), to.getEvents()); } @Test public void fusionModeToString() { - assertEquals("NONE", TestObserver.fusionModeToString(QueueDisposable.NONE)); - assertEquals("SYNC", TestObserver.fusionModeToString(QueueDisposable.SYNC)); - assertEquals("ASYNC", TestObserver.fusionModeToString(QueueDisposable.ASYNC)); + assertEquals("NONE", TestObserver.fusionModeToString(QueueFuseable.NONE)); + assertEquals("SYNC", TestObserver.fusionModeToString(QueueFuseable.SYNC)); + assertEquals("ASYNC", TestObserver.fusionModeToString(QueueFuseable.ASYNC)); assertEquals("Unknown(100)", TestObserver.fusionModeToString(100)); } @Test public void multipleTerminals() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.assertNotComplete(); + to.assertNotComplete(); - ts.onComplete(); + to.onComplete(); try { - ts.assertNotComplete(); + to.assertNotComplete(); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected } - ts.assertTerminated(); + to.assertTerminated(); - ts.onComplete(); + to.onComplete(); try { - ts.assertComplete(); + to.assertComplete(); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected } try { - ts.assertTerminated(); + to.assertTerminated(); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected } try { - ts.assertNotComplete(); + to.assertNotComplete(); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected @@ -802,32 +802,32 @@ public void multipleTerminals() { @Test public void assertValue() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); try { - ts.assertValue(1); + to.assertValue(1); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected } - ts.onNext(1); + to.onNext(1); - ts.assertValue(1); + to.assertValue(1); try { - ts.assertValue(2); + to.assertValue(2); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected } - ts.onNext(2); + to.onNext(2); try { - ts.assertValue(1); + to.assertValue(1); throw new RuntimeException("Should have thrown"); } catch (Throwable ex) { // expected @@ -836,77 +836,77 @@ public void assertValue() { @Test public void onNextMisbehave() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onNext(1); + to.onNext(1); - ts.assertError(IllegalStateException.class); + to.assertError(IllegalStateException.class); - ts = TestObserver.create(); + to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.onNext(null); + to.onNext(null); - ts.assertFailure(NullPointerException.class, (Integer)null); + to.assertFailure(NullPointerException.class, (Integer)null); } @Test public void awaitTerminalEventInterrupt() { - final TestObserver ts = TestObserver.create(); + final TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); Thread.currentThread().interrupt(); - ts.awaitTerminalEvent(); + to.awaitTerminalEvent(); assertTrue(Thread.interrupted()); Thread.currentThread().interrupt(); - ts.awaitTerminalEvent(5, TimeUnit.SECONDS); + to.awaitTerminalEvent(5, TimeUnit.SECONDS); assertTrue(Thread.interrupted()); } @Test public void assertTerminated2() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - assertFalse(ts.isTerminated()); + assertFalse(to.isTerminated()); - ts.onError(new TestException()); - ts.onError(new IOException()); + to.onError(new TestException()); + to.onError(new IOException()); - assertTrue(ts.isTerminated()); + assertTrue(to.isTerminated()); try { - ts.assertTerminated(); + to.assertTerminated(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } try { - ts.assertError(TestException.class); + to.assertError(TestException.class); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } - ts = TestObserver.create(); + to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.onError(new TestException()); - ts.onComplete(); + to.onError(new TestException()); + to.onComplete(); try { - ts.assertTerminated(); + to.assertTerminated(); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected @@ -915,30 +915,30 @@ public void assertTerminated2() { @Test public void onSubscribe() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(null); + to.onSubscribe(null); - ts.assertError(NullPointerException.class); + to.assertError(NullPointerException.class); - ts = TestObserver.create(); + to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); Disposable d1 = Disposables.empty(); - ts.onSubscribe(d1); + to.onSubscribe(d1); assertTrue(d1.isDisposed()); - ts.assertError(IllegalStateException.class); + to.assertError(IllegalStateException.class); - ts = TestObserver.create(); - ts.dispose(); + to = TestObserver.create(); + to.dispose(); d1 = Disposables.empty(); - ts.onSubscribe(d1); + to.onSubscribe(d1); assertTrue(d1.isDisposed()); @@ -946,31 +946,31 @@ public void onSubscribe() { @Test public void assertValueSequence() { - TestObserver ts = TestObserver.create(); + TestObserver to = TestObserver.create(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.onNext(1); - ts.onNext(2); + to.onNext(1); + to.onNext(2); try { - ts.assertValueSequence(Collections.emptyList()); + to.assertValueSequence(Collections.emptyList()); throw new RuntimeException("Should have thrown"); } catch (AssertionError expected) { assertTrue(expected.getMessage(), expected.getMessage().startsWith("More values received than expected (0)")); } try { - ts.assertValueSequence(Collections.singletonList(1)); + to.assertValueSequence(Collections.singletonList(1)); throw new RuntimeException("Should have thrown"); } catch (AssertionError expected) { assertTrue(expected.getMessage(), expected.getMessage().startsWith("More values received than expected (1)")); } - ts.assertValueSequence(Arrays.asList(1, 2)); + to.assertValueSequence(Arrays.asList(1, 2)); try { - ts.assertValueSequence(Arrays.asList(1, 2, 3)); + to.assertValueSequence(Arrays.asList(1, 2, 3)); throw new RuntimeException("Should have thrown"); } catch (AssertionError expected) { assertTrue(expected.getMessage(), expected.getMessage().startsWith("Fewer values received than expected (2)")); @@ -979,23 +979,23 @@ public void assertValueSequence() { @Test public void assertEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); try { - ts.assertEmpty(); + to.assertEmpty(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected } - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); - ts.assertEmpty(); + to.assertEmpty(); - ts.onNext(1); + to.onNext(1); try { - ts.assertEmpty(); + to.assertEmpty(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected @@ -1004,12 +1004,12 @@ public void assertEmpty() { @Test public void awaitDoneTimed() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); Thread.currentThread().interrupt(); try { - ts.awaitDone(5, TimeUnit.SECONDS); + to.awaitDone(5, TimeUnit.SECONDS); } catch (RuntimeException ex) { assertTrue(ex.toString(), ex.getCause() instanceof InterruptedException); } @@ -1017,14 +1017,14 @@ public void awaitDoneTimed() { @Test public void assertNotSubscribed() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - ts.assertNotSubscribed(); + to.assertNotSubscribed(); - ts.errors().add(new TestException()); + to.errors().add(new TestException()); try { - ts.assertNotSubscribed(); + to.assertNotSubscribed(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected @@ -1033,32 +1033,32 @@ public void assertNotSubscribed() { @Test public void assertErrorMultiple() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); TestException e = new TestException(); - ts.errors().add(e); - ts.errors().add(new TestException()); + to.errors().add(e); + to.errors().add(new TestException()); try { - ts.assertError(TestException.class); + to.assertError(TestException.class); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected } try { - ts.assertError(e); + to.assertError(e); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected } try { - ts.assertError(Functions.alwaysTrue()); + to.assertError(Functions.alwaysTrue()); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected } try { - ts.assertErrorMessage(""); + to.assertErrorMessage(""); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected @@ -1067,10 +1067,10 @@ public void assertErrorMultiple() { @Test public void testErrorInPredicate() { - TestObserver ts = new TestObserver(); - ts.onError(new RuntimeException()); + TestObserver to = new TestObserver(); + to.onError(new RuntimeException()); try { - ts.assertError(new Predicate() { + to.assertError(new Predicate() { @Override public boolean test(Throwable throwable) throws Exception { throw new TestException(); @@ -1085,25 +1085,25 @@ public boolean test(Throwable throwable) throws Exception { @Test public void assertComplete() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); try { - ts.assertComplete(); + to.assertComplete(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected } - ts.onComplete(); + to.onComplete(); - ts.assertComplete(); + to.assertComplete(); - ts.onComplete(); + to.onComplete(); try { - ts.assertComplete(); + to.assertComplete(); throw new RuntimeException("Should have thrown!"); } catch (AssertionError ex) { // expected @@ -1112,16 +1112,16 @@ public void assertComplete() { @Test public void completeWithoutOnSubscribe() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - ts.onComplete(); + to.onComplete(); - ts.assertError(IllegalStateException.class); + to.assertError(IllegalStateException.class); } @Test public void completeDelegateThrows() { - TestObserver ts = new TestObserver(new Observer() { + TestObserver to = new TestObserver(new Observer() { @Override public void onSubscribe(Disposable d) { @@ -1145,19 +1145,19 @@ public void onComplete() { }); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); try { - ts.onComplete(); + to.onComplete(); throw new RuntimeException("Should have thrown!"); } catch (TestException ex) { - assertTrue(ts.isTerminated()); + assertTrue(to.isTerminated()); } } @Test public void errorDelegateThrows() { - TestObserver ts = new TestObserver(new Observer() { + TestObserver to = new TestObserver(new Observer() { @Override public void onSubscribe(Disposable d) { @@ -1181,38 +1181,38 @@ public void onComplete() { }); - ts.onSubscribe(Disposables.empty()); + to.onSubscribe(Disposables.empty()); try { - ts.onError(new IOException()); + to.onError(new IOException()); throw new RuntimeException("Should have thrown!"); } catch (TestException ex) { - assertTrue(ts.isTerminated()); + assertTrue(to.isTerminated()); } } @Test public void syncQueueThrows() { - TestObserver ts = new TestObserver(); - ts.setInitialFusionMode(QueueDisposable.SYNC); + TestObserver to = new TestObserver(); + to.setInitialFusionMode(QueueFuseable.SYNC); Observable.range(1, 5) .map(new Function() { @Override public Object apply(Integer v) throws Exception { throw new TestException(); } }) - .subscribe(ts); + .subscribe(to); - ts.assertSubscribed() + to.assertSubscribed() .assertFuseable() - .assertFusionMode(QueueDisposable.SYNC) + .assertFusionMode(QueueFuseable.SYNC) .assertFailure(TestException.class); } @Test public void asyncQueueThrows() { - TestObserver ts = new TestObserver(); - ts.setInitialFusionMode(QueueDisposable.ANY); + TestObserver to = new TestObserver(); + to.setInitialFusionMode(QueueFuseable.ANY); UnicastSubject up = UnicastSubject.create(); @@ -1221,13 +1221,13 @@ public void asyncQueueThrows() { @Override public Object apply(Integer v) throws Exception { throw new TestException(); } }) - .subscribe(ts); + .subscribe(to); up.onNext(1); - ts.assertSubscribed() + to.assertSubscribed() .assertFuseable() - .assertFusionMode(QueueDisposable.ASYNC) + .assertFusionMode(QueueFuseable.ASYNC) .assertFailure(TestException.class); } @@ -1249,32 +1249,32 @@ public void errorMeansDisposed() { @Test public void asyncFusion() { - TestObserver ts = new TestObserver(); - ts.setInitialFusionMode(QueueDisposable.ANY); + TestObserver to = new TestObserver(); + to.setInitialFusionMode(QueueFuseable.ANY); UnicastSubject up = UnicastSubject.create(); up - .subscribe(ts); + .subscribe(to); up.onNext(1); up.onComplete(); - ts.assertSubscribed() + to.assertSubscribed() .assertFuseable() - .assertFusionMode(QueueDisposable.ASYNC) + .assertFusionMode(QueueFuseable.ASYNC) .assertResult(1); } @Test public void assertValuePredicateEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.empty().subscribe(ts); + Observable.empty().subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("No values"); - ts.assertValue(new Predicate() { + to.assertValue(new Predicate() { @Override public boolean test(final Object o) throws Exception { return false; } @@ -1283,11 +1283,11 @@ public void assertValuePredicateEmpty() { @Test public void assertValuePredicateMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1).subscribe(ts); + Observable.just(1).subscribe(to); - ts.assertValue(new Predicate() { + to.assertValue(new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o == 1; } @@ -1296,13 +1296,13 @@ public void assertValuePredicateMatch() { @Test public void assertValuePredicateNoMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1).subscribe(ts); + Observable.just(1).subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Value not present"); - ts.assertValue(new Predicate() { + to.assertValue(new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o != 1; } @@ -1311,13 +1311,13 @@ public void assertValuePredicateNoMatch() { @Test public void assertValuePredicateMatchButMore() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1, 2).subscribe(ts); + Observable.just(1, 2).subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Value present but other values as well"); - ts.assertValue(new Predicate() { + to.assertValue(new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o == 1; } @@ -1326,13 +1326,13 @@ public void assertValuePredicateMatchButMore() { @Test public void assertValueAtPredicateEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.empty().subscribe(ts); + Observable.empty().subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("No values"); - ts.assertValueAt(0, new Predicate() { + to.assertValueAt(0, new Predicate() { @Override public boolean test(final Object o) throws Exception { return false; } @@ -1341,11 +1341,11 @@ public void assertValueAtPredicateEmpty() { @Test public void assertValueAtPredicateMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1, 2).subscribe(ts); + Observable.just(1, 2).subscribe(to); - ts.assertValueAt(1, new Predicate() { + to.assertValueAt(1, new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o == 2; } @@ -1354,13 +1354,13 @@ public void assertValueAtPredicateMatch() { @Test public void assertValueAtPredicateNoMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1, 2, 3).subscribe(ts); + Observable.just(1, 2, 3).subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Value not present"); - ts.assertValueAt(2, new Predicate() { + to.assertValueAt(2, new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o != 3; } @@ -1369,13 +1369,13 @@ public void assertValueAtPredicateNoMatch() { @Test public void assertValueAtInvalidIndex() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just(1, 2).subscribe(ts); + Observable.just(1, 2).subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Invalid index: 2 (latch = 0, values = 2, errors = 0, completions = 1)"); - ts.assertValueAt(2, new Predicate() { + to.assertValueAt(2, new Predicate() { @Override public boolean test(final Integer o) throws Exception { return o == 1; } @@ -1384,44 +1384,44 @@ public void assertValueAtInvalidIndex() { @Test public void assertValueAtIndexEmpty() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.empty().subscribe(ts); + Observable.empty().subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("No values"); - ts.assertValueAt(0, "a"); + to.assertValueAt(0, "a"); } @Test public void assertValueAtIndexMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just("a", "b").subscribe(ts); + Observable.just("a", "b").subscribe(to); - ts.assertValueAt(1, "b"); + to.assertValueAt(1, "b"); } @Test public void assertValueAtIndexNoMatch() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just("a", "b", "c").subscribe(ts); + Observable.just("a", "b", "c").subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Expected: b (class: String), Actual: c (class: String) (latch = 0, values = 3, errors = 0, completions = 1)"); - ts.assertValueAt(2, "b"); + to.assertValueAt(2, "b"); } @Test public void assertValueAtIndexInvalidIndex() { - TestObserver ts = new TestObserver(); + TestObserver to = new TestObserver(); - Observable.just("a", "b").subscribe(ts); + Observable.just("a", "b").subscribe(to); thrown.expect(AssertionError.class); thrown.expectMessage("Invalid index: 2 (latch = 0, values = 2, errors = 0, completions = 1)"); - ts.assertValueAt(2, "c"); + to.assertValueAt(2, "c"); } @Test diff --git a/src/test/java/io/reactivex/parallel/ParallelFromPublisherTest.java b/src/test/java/io/reactivex/parallel/ParallelFromPublisherTest.java index 69ccfc3db6..baa37e3fee 100644 --- a/src/test/java/io/reactivex/parallel/ParallelFromPublisherTest.java +++ b/src/test/java/io/reactivex/parallel/ParallelFromPublisherTest.java @@ -25,7 +25,7 @@ import io.reactivex.exceptions.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.*; import io.reactivex.internal.subscribers.BasicFuseableSubscriber; import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.processors.UnicastProcessor; @@ -93,11 +93,11 @@ public void onNext(T t) { public int requestFusion(int mode) { QueueSubscription fs = qs; if (fs != null) { - int m = fs.requestFusion(mode & ~QueueSubscription.BOUNDARY); + int m = fs.requestFusion(mode & ~QueueFuseable.BOUNDARY); this.sourceMode = m; return m; } - return QueueSubscription.NONE; + return QueueFuseable.NONE; } @Override diff --git a/src/test/java/io/reactivex/processors/AsyncProcessorTest.java b/src/test/java/io/reactivex/processors/AsyncProcessorTest.java index 488b58ac88..71251e7c9c 100644 --- a/src/test/java/io/reactivex/processors/AsyncProcessorTest.java +++ b/src/test/java/io/reactivex/processors/AsyncProcessorTest.java @@ -27,7 +27,7 @@ import io.reactivex.TestHelper; import io.reactivex.exceptions.TestException; import io.reactivex.functions.Consumer; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.subscribers.*; @@ -391,13 +391,13 @@ public void testCurrentStateMethodsError() { public void fusionLive() { AsyncProcessor ap = new AsyncProcessor(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); ap.subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)); + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)); ts.assertNoValues().assertNoErrors().assertNotComplete(); @@ -416,13 +416,13 @@ public void fusionOfflie() { ap.onNext(1); ap.onComplete(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); ap.subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1); } diff --git a/src/test/java/io/reactivex/processors/PublishProcessorTest.java b/src/test/java/io/reactivex/processors/PublishProcessorTest.java index ae0248a8c5..9989f6b392 100644 --- a/src/test/java/io/reactivex/processors/PublishProcessorTest.java +++ b/src/test/java/io/reactivex/processors/PublishProcessorTest.java @@ -260,14 +260,14 @@ public void accept(String v) { */ @Test public void testReSubscribe() { - final PublishProcessor ps = PublishProcessor.create(); + final PublishProcessor pp = PublishProcessor.create(); Subscriber o1 = TestHelper.mockSubscriber(); TestSubscriber ts = new TestSubscriber(o1); - ps.subscribe(ts); + pp.subscribe(ts); // emit - ps.onNext(1); + pp.onNext(1); // validate we got it InOrder inOrder1 = inOrder(o1); @@ -278,14 +278,14 @@ public void testReSubscribe() { ts.dispose(); // emit again but nothing will be there to receive it - ps.onNext(2); + pp.onNext(2); Subscriber o2 = TestHelper.mockSubscriber(); TestSubscriber ts2 = new TestSubscriber(o2); - ps.subscribe(ts2); + pp.subscribe(ts2); // emit - ps.onNext(3); + pp.onNext(3); // validate we got it InOrder inOrder2 = inOrder(o2); diff --git a/src/test/java/io/reactivex/processors/UnicastProcessorTest.java b/src/test/java/io/reactivex/processors/UnicastProcessorTest.java index 63e0c840d4..c822d61a00 100644 --- a/src/test/java/io/reactivex/processors/UnicastProcessorTest.java +++ b/src/test/java/io/reactivex/processors/UnicastProcessorTest.java @@ -39,13 +39,13 @@ protected FlowableProcessor create() { public void fusionLive() { UnicastProcessor ap = UnicastProcessor.create(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); ap.subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)); + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)); ts.assertNoValues().assertNoErrors().assertNotComplete(); @@ -64,13 +64,13 @@ public void fusionOfflie() { ap.onNext(1); ap.onComplete(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); ap.subscribe(ts); ts .assertOf(SubscriberFusion.assertFuseable()) - .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1); } @@ -95,7 +95,7 @@ public void failFastFusionOffline() { ap.onNext(1); ap.onError(new RuntimeException()); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); ap.subscribe(ts); ts @@ -263,11 +263,11 @@ public void onErrorStatePeeking() { public void rejectSyncFusion() { UnicastProcessor p = UnicastProcessor.create(); - TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.SYNC); + TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.SYNC); p.subscribe(ts); - SubscriberFusion.assertFusion(ts, QueueSubscription.NONE); + SubscriberFusion.assertFusion(ts, QueueFuseable.NONE); } @Test @@ -297,7 +297,7 @@ public void fusedDrainCancel() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final UnicastProcessor p = UnicastProcessor.create(); - final TestSubscriber ts = SubscriberFusion.newTest(QueueSubscription.ANY); + final TestSubscriber ts = SubscriberFusion.newTest(QueueFuseable.ANY); p.subscribe(ts); @@ -360,11 +360,11 @@ public void hasObservers() { assertFalse(us.hasSubscribers()); - TestSubscriber to = us.test(); + TestSubscriber ts = us.test(); assertTrue(us.hasSubscribers()); - to.cancel(); + ts.cancel(); assertFalse(us.hasSubscribers()); } @@ -374,12 +374,12 @@ public void drainFusedFailFast() { UnicastProcessor us = UnicastProcessor.create(false); - TestSubscriber to = us.to(SubscriberFusion.test(1, QueueDisposable.ANY, false)); + TestSubscriber ts = us.to(SubscriberFusion.test(1, QueueFuseable.ANY, false)); us.done = true; - us.drainFused(to); + us.drainFused(ts); - to.assertResult(); + ts.assertResult(); } @Test @@ -387,22 +387,22 @@ public void drainFusedFailFastEmpty() { UnicastProcessor us = UnicastProcessor.create(false); - TestSubscriber to = us.to(SubscriberFusion.test(1, QueueDisposable.ANY, false)); + TestSubscriber ts = us.to(SubscriberFusion.test(1, QueueFuseable.ANY, false)); - us.drainFused(to); + us.drainFused(ts); - to.assertEmpty(); + ts.assertEmpty(); } @Test public void checkTerminatedFailFastEmpty() { UnicastProcessor us = UnicastProcessor.create(false); - TestSubscriber to = us.to(SubscriberFusion.test(1, QueueDisposable.ANY, false)); + TestSubscriber ts = us.to(SubscriberFusion.test(1, QueueFuseable.ANY, false)); - us.checkTerminated(true, true, false, to, us.queue); + us.checkTerminated(true, true, false, ts, us.queue); - to.assertEmpty(); + ts.assertEmpty(); } @Test diff --git a/src/test/java/io/reactivex/single/SingleCacheTest.java b/src/test/java/io/reactivex/single/SingleCacheTest.java index acdf75679a..ddfa964ac0 100644 --- a/src/test/java/io/reactivex/single/SingleCacheTest.java +++ b/src/test/java/io/reactivex/single/SingleCacheTest.java @@ -55,15 +55,15 @@ public void delayed() { PublishSubject ps = PublishSubject.create(); Single cache = ps.single(-99).cache(); - TestObserver ts1 = cache.test(); + TestObserver to1 = cache.test(); - TestObserver ts2 = cache.test(); + TestObserver to2 = cache.test(); ps.onNext(1); ps.onComplete(); - ts1.assertResult(1); - ts2.assertResult(1); + to1.assertResult(1); + to2.assertResult(1); } @Test @@ -71,17 +71,17 @@ public void delayedDisposed() { PublishSubject ps = PublishSubject.create(); Single cache = ps.single(-99).cache(); - TestObserver ts1 = cache.test(); + TestObserver to1 = cache.test(); - TestObserver ts2 = cache.test(); + TestObserver to2 = cache.test(); - ts1.cancel(); + to1.cancel(); ps.onNext(1); ps.onComplete(); - ts1.assertNoValues().assertNoErrors().assertNotComplete(); - ts2.assertResult(1); + to1.assertNoValues().assertNoErrors().assertNotComplete(); + to2.assertResult(1); } @Test diff --git a/src/test/java/io/reactivex/subjects/AsyncSubjectTest.java b/src/test/java/io/reactivex/subjects/AsyncSubjectTest.java index b1fbf0efe9..9376962b95 100644 --- a/src/test/java/io/reactivex/subjects/AsyncSubjectTest.java +++ b/src/test/java/io/reactivex/subjects/AsyncSubjectTest.java @@ -27,7 +27,7 @@ import io.reactivex.disposables.*; import io.reactivex.exceptions.TestException; import io.reactivex.functions.Consumer; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.observers.*; public class AsyncSubjectTest extends SubjectTest { @@ -151,13 +151,13 @@ public void testUnsubscribeBeforeCompleted() { AsyncSubject subject = AsyncSubject.create(); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - subject.subscribe(ts); + TestObserver to = new TestObserver(observer); + subject.subscribe(to); subject.onNext("one"); subject.onNext("two"); - ts.dispose(); + to.dispose(); verify(observer, Mockito.never()).onNext(anyString()); verify(observer, Mockito.never()).onError(any(Throwable.class)); @@ -282,8 +282,8 @@ public void run() { // AsyncSubject ps = AsyncSubject.create(); // // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // // try { // ps.onError(new RuntimeException("an exception")); @@ -292,7 +292,7 @@ public void run() { // // ignore // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } @@ -306,8 +306,8 @@ public void run() { // // ps.subscribe(); // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // ps.subscribe(); // ps.subscribe(); // ps.subscribe(); @@ -320,7 +320,7 @@ public void run() { // assertEquals(5, e.getExceptions().size()); // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } @Test @@ -391,23 +391,23 @@ public void testCurrentStateMethodsError() { public void fusionLive() { AsyncSubject ap = new AsyncSubject(); - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); - ap.subscribe(ts); + ap.subscribe(to); - ts + to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.ASYNC)); + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)); - ts.assertNoValues().assertNoErrors().assertNotComplete(); + to.assertNoValues().assertNoErrors().assertNotComplete(); ap.onNext(1); - ts.assertNoValues().assertNoErrors().assertNotComplete(); + to.assertNoValues().assertNoErrors().assertNotComplete(); ap.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -416,13 +416,13 @@ public void fusionOfflie() { ap.onNext(1); ap.onComplete(); - TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); - ap.subscribe(ts); + ap.subscribe(to); - ts + to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueSubscription.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1); } @@ -464,20 +464,20 @@ public void cancelRace() { AsyncSubject p = AsyncSubject.create(); for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestObserver ts1 = p.test(); - final TestObserver ts2 = p.test(); + final TestObserver to1 = p.test(); + final TestObserver to2 = p.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ts2.cancel(); + to2.cancel(); } }; @@ -491,12 +491,12 @@ public void onErrorCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final AsyncSubject p = AsyncSubject.create(); - final TestObserver ts1 = p.test(); + final TestObserver to1 = p.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; @@ -511,10 +511,10 @@ public void run() { TestHelper.race(r1, r2); - if (ts1.errorCount() != 0) { - ts1.assertFailure(TestException.class); + if (to1.errorCount() != 0) { + to1.assertFailure(TestException.class); } else { - ts1.assertEmpty(); + to1.assertEmpty(); } } } @@ -523,66 +523,66 @@ public void run() { public void onNextCrossCancel() { AsyncSubject p = AsyncSubject.create(); - final TestObserver ts2 = new TestObserver(); - TestObserver ts1 = new TestObserver() { + final TestObserver to2 = new TestObserver(); + TestObserver to1 = new TestObserver() { @Override public void onNext(Object t) { - ts2.cancel(); + to2.cancel(); super.onNext(t); } }; - p.subscribe(ts1); - p.subscribe(ts2); + p.subscribe(to1); + p.subscribe(to2); p.onNext(1); p.onComplete(); - ts1.assertResult(1); - ts2.assertEmpty(); + to1.assertResult(1); + to2.assertEmpty(); } @Test public void onErrorCrossCancel() { AsyncSubject p = AsyncSubject.create(); - final TestObserver ts2 = new TestObserver(); - TestObserver ts1 = new TestObserver() { + final TestObserver to2 = new TestObserver(); + TestObserver to1 = new TestObserver() { @Override public void onError(Throwable t) { - ts2.cancel(); + to2.cancel(); super.onError(t); } }; - p.subscribe(ts1); - p.subscribe(ts2); + p.subscribe(to1); + p.subscribe(to2); p.onError(new TestException()); - ts1.assertFailure(TestException.class); - ts2.assertEmpty(); + to1.assertFailure(TestException.class); + to2.assertEmpty(); } @Test public void onCompleteCrossCancel() { AsyncSubject p = AsyncSubject.create(); - final TestObserver ts2 = new TestObserver(); - TestObserver ts1 = new TestObserver() { + final TestObserver to2 = new TestObserver(); + TestObserver to1 = new TestObserver() { @Override public void onComplete() { - ts2.cancel(); + to2.cancel(); super.onComplete(); } }; - p.subscribe(ts1); - p.subscribe(ts2); + p.subscribe(to1); + p.subscribe(to2); p.onComplete(); - ts1.assertResult(); - ts2.assertEmpty(); + to1.assertResult(); + to2.assertEmpty(); } } diff --git a/src/test/java/io/reactivex/subjects/BehaviorSubjectTest.java b/src/test/java/io/reactivex/subjects/BehaviorSubjectTest.java index 1d57599d16..f8044d5a11 100644 --- a/src/test/java/io/reactivex/subjects/BehaviorSubjectTest.java +++ b/src/test/java/io/reactivex/subjects/BehaviorSubjectTest.java @@ -135,9 +135,9 @@ public void testCompletedStopsEmittingData() { Observer observerB = TestHelper.mockObserver(); Observer observerC = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observerA); + TestObserver to = new TestObserver(observerA); - channel.subscribe(ts); + channel.subscribe(to); channel.subscribe(observerB); InOrder inOrderA = inOrder(observerA); @@ -152,7 +152,7 @@ public void testCompletedStopsEmittingData() { inOrderA.verify(observerA).onNext(42); inOrderB.verify(observerB).onNext(42); - ts.dispose(); + to.dispose(); inOrderA.verifyNoMoreInteractions(); channel.onNext(4711); @@ -367,8 +367,8 @@ public void testTakeOneSubscriber() { // BehaviorSubject ps = BehaviorSubject.create(); // // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // // try { // ps.onError(new RuntimeException("an exception")); @@ -377,7 +377,7 @@ public void testTakeOneSubscriber() { // // ignore // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } // FIXME RS subscribers are not allowed to throw @@ -390,8 +390,8 @@ public void testTakeOneSubscriber() { // // ps.subscribe(); // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // ps.subscribe(); // ps.subscribe(); // ps.subscribe(); @@ -404,7 +404,7 @@ public void testTakeOneSubscriber() { // assertEquals(5, e.getExceptions().size()); // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } @Test public void testEmissionSubscriptionRace() throws Exception { @@ -619,14 +619,14 @@ public void onErrorAfterComplete() { public void cancelOnArrival2() { BehaviorSubject p = BehaviorSubject.create(); - TestObserver ts = p.test(); + TestObserver to = p.test(); p.test(true).assertEmpty(); p.onNext(1); p.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -634,7 +634,7 @@ public void addRemoveRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final BehaviorSubject p = BehaviorSubject.create(); - final TestObserver ts = p.test(); + final TestObserver to = p.test(); Runnable r1 = new Runnable() { @Override @@ -646,7 +646,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -660,12 +660,12 @@ public void subscribeOnNextRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final BehaviorSubject p = BehaviorSubject.createDefault((Object)1); - final TestObserver[] ts = { null }; + final TestObserver[] to = { null }; Runnable r1 = new Runnable() { @Override public void run() { - ts[0] = p.test(); + to[0] = p.test(); } }; @@ -678,10 +678,10 @@ public void run() { TestHelper.race(r1, r2); - if (ts[0].valueCount() == 1) { - ts[0].assertValue(2).assertNoErrors().assertNotComplete(); + if (to[0].valueCount() == 1) { + to[0].assertValue(2).assertNoErrors().assertNotComplete(); } else { - ts[0].assertValues(1, 2).assertNoErrors().assertNotComplete(); + to[0].assertValues(1, 2).assertNoErrors().assertNotComplete(); } } } @@ -722,12 +722,12 @@ public void completeSubscribeRace() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final BehaviorSubject p = BehaviorSubject.create(); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Runnable r1 = new Runnable() { @Override public void run() { - p.subscribe(ts); + p.subscribe(to); } }; @@ -740,7 +740,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(); + to.assertResult(); } } @@ -749,14 +749,14 @@ public void errorSubscribeRace() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final BehaviorSubject p = BehaviorSubject.create(); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); final TestException ex = new TestException(); Runnable r1 = new Runnable() { @Override public void run() { - p.subscribe(ts); + p.subscribe(to); } }; @@ -769,7 +769,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); } } diff --git a/src/test/java/io/reactivex/subjects/PublishSubjectTest.java b/src/test/java/io/reactivex/subjects/PublishSubjectTest.java index bfe9f7c02b..3d93324d94 100644 --- a/src/test/java/io/reactivex/subjects/PublishSubjectTest.java +++ b/src/test/java/io/reactivex/subjects/PublishSubjectTest.java @@ -67,9 +67,9 @@ public void testCompletedStopsEmittingData() { Observer observerB = TestHelper.mockObserver(); Observer observerC = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observerA); + TestObserver to = new TestObserver(observerA); - channel.subscribe(ts); + channel.subscribe(to); channel.subscribe(observerB); InOrder inOrderA = inOrder(observerA); @@ -81,7 +81,7 @@ public void testCompletedStopsEmittingData() { inOrderA.verify(observerA).onNext(42); inOrderB.verify(observerB).onNext(42); - ts.dispose(); + to.dispose(); inOrderA.verifyNoMoreInteractions(); channel.onNext(4711); @@ -176,13 +176,13 @@ public void testUnsubscribeFirstSubscriber() { PublishSubject subject = PublishSubject.create(); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - subject.subscribe(ts); + TestObserver to = new TestObserver(observer); + subject.subscribe(to); subject.onNext("one"); subject.onNext("two"); - ts.dispose(); + to.dispose(); assertObservedUntilTwo(observer); Observer anotherSubscriber = TestHelper.mockObserver(); @@ -262,8 +262,8 @@ public void testReSubscribe() { final PublishSubject ps = PublishSubject.create(); Observer o1 = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(o1); - ps.subscribe(ts); + TestObserver to = new TestObserver(o1); + ps.subscribe(to); // emit ps.onNext(1); @@ -274,14 +274,14 @@ public void testReSubscribe() { inOrder1.verifyNoMoreInteractions(); // unsubscribe - ts.dispose(); + to.dispose(); // emit again but nothing will be there to receive it ps.onNext(2); Observer o2 = TestHelper.mockObserver(); - TestObserver ts2 = new TestObserver(o2); - ps.subscribe(ts2); + TestObserver to2 = new TestObserver(o2); + ps.subscribe(to2); // emit ps.onNext(3); @@ -291,7 +291,7 @@ public void testReSubscribe() { inOrder2.verify(o2, times(1)).onNext(3); inOrder2.verifyNoMoreInteractions(); - ts2.dispose(); + to2.dispose(); } private final Throwable testException = new Throwable(); @@ -345,8 +345,8 @@ public void onComplete() { // PublishSubject ps = PublishSubject.create(); // // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // // try { // ps.onError(new RuntimeException("an exception")); @@ -355,7 +355,7 @@ public void onComplete() { // // ignore // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } // FIXME RS subscribers are not allowed to throw @@ -368,8 +368,8 @@ public void onComplete() { // // ps.subscribe(); // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // ps.subscribe(); // ps.subscribe(); // ps.subscribe(); @@ -382,7 +382,7 @@ public void onComplete() { // assertEquals(5, e.getExceptions().size()); // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } @Test public void testCurrentStateMethodsNormal() { @@ -442,83 +442,83 @@ public void requestValidation() { @Test public void crossCancel() { - final TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver() { + final TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver() { @Override public void onNext(Integer t) { super.onNext(t); - ts1.cancel(); + to1.cancel(); } }; - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - pp.subscribe(ts2); - pp.subscribe(ts1); + ps.subscribe(to2); + ps.subscribe(to1); - pp.onNext(1); + ps.onNext(1); - ts2.assertValue(1); + to2.assertValue(1); - ts1.assertNoValues(); + to1.assertNoValues(); } @Test public void crossCancelOnError() { - final TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver() { + final TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver() { @Override public void onError(Throwable t) { super.onError(t); - ts1.cancel(); + to1.cancel(); } }; - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - pp.subscribe(ts2); - pp.subscribe(ts1); + ps.subscribe(to2); + ps.subscribe(to1); - pp.onError(new TestException()); + ps.onError(new TestException()); - ts2.assertError(TestException.class); + to2.assertError(TestException.class); - ts1.assertNoErrors(); + to1.assertNoErrors(); } @Test public void crossCancelOnComplete() { - final TestObserver ts1 = new TestObserver(); - TestObserver ts2 = new TestObserver() { + final TestObserver to1 = new TestObserver(); + TestObserver to2 = new TestObserver() { @Override public void onComplete() { super.onComplete(); - ts1.cancel(); + to1.cancel(); } }; - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - pp.subscribe(ts2); - pp.subscribe(ts1); + ps.subscribe(to2); + ps.subscribe(to1); - pp.onComplete(); + ps.onComplete(); - ts2.assertComplete(); + to2.assertComplete(); - ts1.assertNotComplete(); + to1.assertNotComplete(); } @Test @Ignore("Observable doesn't do backpressure") public void backpressureOverflow() { -// PublishSubject pp = PublishSubject.create(); +// PublishSubject ps = PublishSubject.create(); // -// TestObserver ts = pp.test(0L); +// TestObserver to = ps.test(0L); // -// pp.onNext(1); +// ps.onNext(1); // -// ts.assertNoValues() +// to.assertNoValues() // .assertNotComplete() // .assertError(MissingBackpressureException.class) // ; @@ -526,11 +526,11 @@ public void backpressureOverflow() { @Test public void onSubscribeCancelsImmediately() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.test(); + TestObserver to = ps.test(); - pp.subscribe(new Observer() { + ps.subscribe(new Observer() { @Override public void onSubscribe(Disposable s) { @@ -555,29 +555,29 @@ public void onComplete() { }); - ts.cancel(); + to.cancel(); - assertFalse(pp.hasObservers()); + assertFalse(ps.hasObservers()); } @Test public void terminateRace() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - TestObserver ts = pp.test(); + TestObserver to = ps.test(); Runnable task = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; TestHelper.race(task, task); - ts + to .awaitDone(5, TimeUnit.SECONDS) .assertResult(); } @@ -587,20 +587,20 @@ public void run() { public void addRemoveRance() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - final TestObserver ts = pp.test(); + final TestObserver to = ps.test(); Runnable r1 = new Runnable() { @Override public void run() { - pp.subscribe(); + ps.subscribe(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -612,18 +612,18 @@ public void run() { public void addTerminateRance() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); Runnable r1 = new Runnable() { @Override public void run() { - pp.subscribe(); + ps.subscribe(); } }; Runnable r2 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; @@ -635,56 +635,56 @@ public void run() { public void addCompleteRance() throws Exception { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject pp = PublishSubject.create(); + final PublishSubject ps = PublishSubject.create(); - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); Runnable r1 = new Runnable() { @Override public void run() { - pp.subscribe(ts); + ps.subscribe(to); } }; Runnable r2 = new Runnable() { @Override public void run() { - pp.onComplete(); + ps.onComplete(); } }; TestHelper.race(r1, r2); - ts.awaitDone(5, TimeUnit.SECONDS) + to.awaitDone(5, TimeUnit.SECONDS) .assertResult(); } } @Test public void subscribeToAfterComplete() { - PublishSubject pp = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); - pp.onComplete(); + ps.onComplete(); - PublishSubject pp2 = PublishSubject.create(); + PublishSubject ps2 = PublishSubject.create(); - pp2.subscribe(pp); + ps2.subscribe(ps); - assertFalse(pp2.hasObservers()); + assertFalse(ps2.hasObservers()); } @Test public void subscribedTo() { - PublishSubject pp = PublishSubject.create(); - PublishSubject pp2 = PublishSubject.create(); + PublishSubject ps = PublishSubject.create(); + PublishSubject ps2 = PublishSubject.create(); - pp.subscribe(pp2); + ps.subscribe(ps2); - TestObserver ts = pp2.test(); + TestObserver to = ps2.test(); - pp.onNext(1); - pp.onNext(2); - pp.onComplete(); + ps.onNext(1); + ps.onNext(2); + ps.onComplete(); - ts.assertResult(1, 2); + to.assertResult(1, 2); } } diff --git a/src/test/java/io/reactivex/subjects/ReplaySubjectBoundedConcurrencyTest.java b/src/test/java/io/reactivex/subjects/ReplaySubjectBoundedConcurrencyTest.java index e93b4860da..4a03449597 100644 --- a/src/test/java/io/reactivex/subjects/ReplaySubjectBoundedConcurrencyTest.java +++ b/src/test/java/io/reactivex/subjects/ReplaySubjectBoundedConcurrencyTest.java @@ -294,11 +294,11 @@ public void run() { public void testRaceForTerminalState() { final List expected = Arrays.asList(1); for (int i = 0; i < 100000; i++) { - TestObserver ts = new TestObserver(); - Observable.just(1).subscribeOn(Schedulers.computation()).cache().subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertValueSequence(expected); - ts.assertTerminated(); + TestObserver to = new TestObserver(); + Observable.just(1).subscribeOn(Schedulers.computation()).cache().subscribe(to); + to.awaitTerminalEvent(); + to.assertValueSequence(expected); + to.assertTerminated(); } } diff --git a/src/test/java/io/reactivex/subjects/ReplaySubjectConcurrencyTest.java b/src/test/java/io/reactivex/subjects/ReplaySubjectConcurrencyTest.java index 7275df7cd0..adf238118f 100644 --- a/src/test/java/io/reactivex/subjects/ReplaySubjectConcurrencyTest.java +++ b/src/test/java/io/reactivex/subjects/ReplaySubjectConcurrencyTest.java @@ -294,11 +294,11 @@ public void run() { public void testRaceForTerminalState() { final List expected = Arrays.asList(1); for (int i = 0; i < 100000; i++) { - TestObserver ts = new TestObserver(); - Observable.just(1).subscribeOn(Schedulers.computation()).cache().subscribe(ts); - ts.awaitTerminalEvent(); - ts.assertValueSequence(expected); - ts.assertTerminated(); + TestObserver to = new TestObserver(); + Observable.just(1).subscribeOn(Schedulers.computation()).cache().subscribe(to); + to.awaitTerminalEvent(); + to.assertValueSequence(expected); + to.assertTerminated(); } } diff --git a/src/test/java/io/reactivex/subjects/ReplaySubjectTest.java b/src/test/java/io/reactivex/subjects/ReplaySubjectTest.java index ccb5047cff..870b53e2d9 100644 --- a/src/test/java/io/reactivex/subjects/ReplaySubjectTest.java +++ b/src/test/java/io/reactivex/subjects/ReplaySubjectTest.java @@ -72,9 +72,9 @@ public void testCompletedStopsEmittingData() { Observer observerB = TestHelper.mockObserver(); Observer observerC = TestHelper.mockObserver(); Observer observerD = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observerA); + TestObserver to = new TestObserver(observerA); - channel.subscribe(ts); + channel.subscribe(to); channel.subscribe(observerB); InOrder inOrderA = inOrder(observerA); @@ -88,7 +88,7 @@ public void testCompletedStopsEmittingData() { inOrderA.verify(observerA).onNext(42); inOrderB.verify(observerB).onNext(42); - ts.dispose(); + to.dispose(); // a should receive no more inOrderA.verifyNoMoreInteractions(); @@ -223,13 +223,13 @@ public void testUnsubscribeFirstSubscriber() { ReplaySubject subject = ReplaySubject.create(); Observer observer = TestHelper.mockObserver(); - TestObserver ts = new TestObserver(observer); - subject.subscribe(ts); + TestObserver to = new TestObserver(observer); + subject.subscribe(to); subject.onNext("one"); subject.onNext("two"); - ts.dispose(); + to.dispose(); assertObservedUntilTwo(observer); Observer anotherSubscriber = TestHelper.mockObserver(); @@ -541,8 +541,8 @@ public void testReplayTimestampedDirectly() { // ReplaySubject ps = ReplaySubject.create(); // // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // // try { // ps.onError(new RuntimeException("an exception")); @@ -551,7 +551,7 @@ public void testReplayTimestampedDirectly() { // // ignore // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.errors().size()); +// assertEquals(1, to.errors().size()); // } // FIXME RS subscribers can't throw @@ -564,8 +564,8 @@ public void testReplayTimestampedDirectly() { // // ps.subscribe(); // ps.subscribe(); -// TestObserver ts = new TestObserver(); -// ps.subscribe(ts); +// TestObserver to = new TestObserver(); +// ps.subscribe(to); // ps.subscribe(); // ps.subscribe(); // ps.subscribe(); @@ -578,7 +578,7 @@ public void testReplayTimestampedDirectly() { // assertEquals(5, e.getExceptions().size()); // } // // even though the onError above throws we should still receive it on the other subscriber -// assertEquals(1, ts.getOnErrorEvents().size()); +// assertEquals(1, to.getOnErrorEvents().size()); // } @Test @@ -780,8 +780,8 @@ public void testSizeAndHasAnyValueSizeBounded() { @Test public void testSizeAndHasAnyValueTimeBounded() { - TestScheduler ts = new TestScheduler(); - ReplaySubject rs = ReplaySubject.createWithTime(1, TimeUnit.SECONDS, ts); + TestScheduler to = new TestScheduler(); + ReplaySubject rs = ReplaySubject.createWithTime(1, TimeUnit.SECONDS, to); assertEquals(0, rs.size()); assertFalse(rs.hasValue()); @@ -790,7 +790,7 @@ public void testSizeAndHasAnyValueTimeBounded() { rs.onNext(i); assertEquals(1, rs.size()); assertTrue(rs.hasValue()); - ts.advanceTimeBy(2, TimeUnit.SECONDS); + to.advanceTimeBy(2, TimeUnit.SECONDS); assertEquals(0, rs.size()); assertFalse(rs.hasValue()); } @@ -864,11 +864,11 @@ public void hasSubscribers() { assertFalse(rp.hasObservers()); - TestObserver ts = rp.test(); + TestObserver to = rp.test(); assertTrue(rp.hasObservers()); - ts.cancel(); + to.cancel(); assertFalse(rp.hasObservers()); } @@ -972,21 +972,21 @@ public void capacityHint() { @Test public void subscribeCancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final TestObserver ts = new TestObserver(); + final TestObserver to = new TestObserver(); final ReplaySubject rp = ReplaySubject.create(); Runnable r1 = new Runnable() { @Override public void run() { - rp.subscribe(ts); + rp.subscribe(to); } }; Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -1028,11 +1028,11 @@ public void cancelUpfront() { rp.test(); rp.test(); - TestObserver ts = rp.test(true); + TestObserver to = rp.test(true); assertEquals(2, rp.observerCount()); - ts.assertEmpty(); + to.assertEmpty(); } @Test @@ -1040,20 +1040,20 @@ public void cancelRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final ReplaySubject rp = ReplaySubject.create(); - final TestObserver ts1 = rp.test(); - final TestObserver ts2 = rp.test(); + final TestObserver to1 = rp.test(); + final TestObserver to2 = rp.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts1.cancel(); + to1.cancel(); } }; Runnable r2 = new Runnable() { @Override public void run() { - ts2.cancel(); + to2.cancel(); } }; @@ -1140,7 +1140,7 @@ public void reentrantDrain() { final ReplaySubject rp = ReplaySubject.createWithTimeAndSize(1, TimeUnit.SECONDS, scheduler, 2); - TestObserver ts = new TestObserver() { + TestObserver to = new TestObserver() { @Override public void onNext(Integer t) { if (t == 1) { @@ -1150,12 +1150,12 @@ public void onNext(Integer t) { } }; - rp.subscribe(ts); + rp.subscribe(to); rp.onNext(1); rp.onComplete(); - ts.assertResult(1, 2); + to.assertResult(1, 2); } @Test diff --git a/src/test/java/io/reactivex/subjects/SerializedSubjectTest.java b/src/test/java/io/reactivex/subjects/SerializedSubjectTest.java index b3d22d83c5..e1042c8680 100644 --- a/src/test/java/io/reactivex/subjects/SerializedSubjectTest.java +++ b/src/test/java/io/reactivex/subjects/SerializedSubjectTest.java @@ -23,22 +23,20 @@ import io.reactivex.TestHelper; import io.reactivex.disposables.*; import io.reactivex.exceptions.TestException; -import io.reactivex.internal.subscriptions.BooleanSubscription; -import io.reactivex.observers.TestObserver; +import io.reactivex.observers.*; import io.reactivex.plugins.RxJavaPlugins; -import io.reactivex.subscribers.*; public class SerializedSubjectTest { @Test public void testBasic() { SerializedSubject subject = new SerializedSubject(PublishSubject. create()); - TestObserver ts = new TestObserver(); - subject.subscribe(ts); + TestObserver to = new TestObserver(); + subject.subscribe(to); subject.onNext("hello"); subject.onComplete(); - ts.awaitTerminalEvent(); - ts.assertValue("hello"); + to.awaitTerminalEvent(); + to.assertValue("hello"); } @Test @@ -407,11 +405,11 @@ public void testDontWrapSerializedSubjectAgain() { public void normal() { Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); Observable.range(1, 10).subscribe(s); - ts.assertResult(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); + to.assertResult(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); assertFalse(s.hasObservers()); @@ -437,7 +435,7 @@ public void onNextOnNextRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); Runnable r1 = new Runnable() { @Override @@ -455,7 +453,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertSubscribed().assertNoErrors().assertNotComplete() + to.assertSubscribed().assertNoErrors().assertNotComplete() .assertValueSet(Arrays.asList(1, 2)); } } @@ -465,7 +463,7 @@ public void onNextOnErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); final TestException ex = new TestException(); @@ -485,10 +483,10 @@ public void run() { TestHelper.race(r1, r2); - ts.assertError(ex).assertNotComplete(); + to.assertError(ex).assertNotComplete(); - if (ts.valueCount() != 0) { - ts.assertValue(1); + if (to.valueCount() != 0) { + to.assertValue(1); } } } @@ -498,7 +496,7 @@ public void onNextOnCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); Runnable r1 = new Runnable() { @Override @@ -516,10 +514,10 @@ public void run() { TestHelper.race(r1, r2); - ts.assertComplete().assertNoErrors(); + to.assertComplete().assertNoErrors(); - if (ts.valueCount() != 0) { - ts.assertValue(1); + if (to.valueCount() != 0) { + to.assertValue(1); } } } @@ -529,7 +527,7 @@ public void onNextOnSubscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); final Disposable bs = Disposables.empty(); @@ -549,7 +547,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertValue(1).assertNotComplete().assertNoErrors(); + to.assertValue(1).assertNotComplete().assertNoErrors(); } } @@ -558,7 +556,7 @@ public void onCompleteOnSubscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); final Disposable bs = Disposables.empty(); @@ -578,7 +576,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(); + to.assertResult(); } } @@ -587,7 +585,7 @@ public void onCompleteOnCompleteRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); Runnable r1 = new Runnable() { @Override @@ -605,7 +603,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertResult(); + to.assertResult(); } } @@ -614,7 +612,7 @@ public void onErrorOnErrorRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); final TestException ex = new TestException(); @@ -636,7 +634,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertFailure(TestException.class); + to.assertFailure(TestException.class); TestHelper.assertUndeliverable(errors, 0, TestException.class); } finally { @@ -650,7 +648,7 @@ public void onSubscribeOnSubscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final Subject s = PublishSubject.create().toSerialized(); - TestObserver ts = s.test(); + TestObserver to = s.test(); final Disposable bs1 = Disposables.empty(); final Disposable bs2 = Disposables.empty(); @@ -671,21 +669,7 @@ public void run() { TestHelper.race(r1, r2); - ts.assertEmpty(); + to.assertEmpty(); } } - - @Test - public void nullOnNext() { - - TestSubscriber ts = new TestSubscriber(); - - final SerializedSubscriber so = new SerializedSubscriber(ts); - - so.onSubscribe(new BooleanSubscription()); - - so.onNext(null); - - ts.assertFailureAndMessage(NullPointerException.class, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); - } } diff --git a/src/test/java/io/reactivex/subjects/UnicastSubjectTest.java b/src/test/java/io/reactivex/subjects/UnicastSubjectTest.java index c05855dcf5..41a1d3e759 100644 --- a/src/test/java/io/reactivex/subjects/UnicastSubjectTest.java +++ b/src/test/java/io/reactivex/subjects/UnicastSubjectTest.java @@ -39,23 +39,23 @@ protected Subject create() { public void fusionLive() { UnicastSubject ap = UnicastSubject.create(); - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); - ap.subscribe(ts); + ap.subscribe(to); - ts + to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)); + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)); - ts.assertNoValues().assertNoErrors().assertNotComplete(); + to.assertNoValues().assertNoErrors().assertNotComplete(); ap.onNext(1); - ts.assertValue(1).assertNoErrors().assertNotComplete(); + to.assertValue(1).assertNoErrors().assertNotComplete(); ap.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -64,13 +64,13 @@ public void fusionOfflie() { ap.onNext(1); ap.onComplete(); - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ANY); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); - ap.subscribe(ts); + ap.subscribe(to); - ts + to .assertOf(ObserverFusion.assertFuseable()) - .assertOf(ObserverFusion.assertFusionMode(QueueDisposable.ASYNC)) + .assertOf(ObserverFusion.assertFusionMode(QueueFuseable.ASYNC)) .assertResult(1); } @@ -79,10 +79,10 @@ public void failFast() { UnicastSubject ap = UnicastSubject.create(false); ap.onNext(1); ap.onError(new RuntimeException()); - TestObserver ts = TestObserver.create(); - ap.subscribe(ts); + TestObserver to = TestObserver.create(); + ap.subscribe(to); - ts + to .assertValueCount(0) .assertError(RuntimeException.class); } @@ -93,10 +93,10 @@ public void threeArgsFactoryFailFast() { UnicastSubject ap = UnicastSubject.create(16, noop, false); ap.onNext(1); ap.onError(new RuntimeException()); - TestObserver ts = TestObserver.create(); - ap.subscribe(ts); + TestObserver to = TestObserver.create(); + ap.subscribe(to); - ts + to .assertValueCount(0) .assertError(RuntimeException.class); } @@ -107,10 +107,10 @@ public void threeArgsFactoryDelayError() { UnicastSubject ap = UnicastSubject.create(16, noop, true); ap.onNext(1); ap.onError(new RuntimeException()); - TestObserver ts = TestObserver.create(); - ap.subscribe(ts); + TestObserver to = TestObserver.create(); + ap.subscribe(to); - ts + to .assertValueCount(1) .assertError(RuntimeException.class); } @@ -120,10 +120,10 @@ public void fusionOfflineFailFast() { UnicastSubject ap = UnicastSubject.create(false); ap.onNext(1); ap.onError(new RuntimeException()); - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ANY); - ap.subscribe(ts); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); + ap.subscribe(to); - ts + to .assertValueCount(0) .assertError(RuntimeException.class); } @@ -135,10 +135,10 @@ public void fusionOfflineFailFastMultipleEvents() { ap.onNext(2); ap.onNext(3); ap.onComplete(); - TestObserver ts = ObserverFusion.newTest(QueueDisposable.ANY); - ap.subscribe(ts); + TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); + ap.subscribe(to); - ts + to .assertValueCount(3) .assertComplete(); } @@ -150,10 +150,10 @@ public void failFastMultipleEvents() { ap.onNext(2); ap.onNext(3); ap.onComplete(); - TestObserver ts = TestObserver.create(); - ap.subscribe(ts); + TestObserver to = TestObserver.create(); + ap.subscribe(to); - ts + to .assertValueCount(3) .assertComplete(); } @@ -231,12 +231,12 @@ public void run() { } }); - final TestObserver ts = up.test(); + final TestObserver to = up.test(); Runnable r1 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -299,11 +299,11 @@ public void onErrorStatePeeking() { public void rejectSyncFusion() { UnicastSubject p = UnicastSubject.create(); - TestObserver ts = ObserverFusion.newTest(QueueDisposable.SYNC); + TestObserver to = ObserverFusion.newTest(QueueFuseable.SYNC); - p.subscribe(ts); + p.subscribe(to); - ObserverFusion.assertFusion(ts, QueueDisposable.NONE); + ObserverFusion.assertFusion(to, QueueFuseable.NONE); } @Test @@ -317,7 +317,7 @@ public void cancelOnArrival() { public void multiSubscriber() { UnicastSubject p = UnicastSubject.create(); - TestObserver ts = p.test(); + TestObserver to = p.test(); p.test() .assertFailure(IllegalStateException.class); @@ -325,7 +325,7 @@ public void multiSubscriber() { p.onNext(1); p.onComplete(); - ts.assertResult(1); + to.assertResult(1); } @Test @@ -333,9 +333,9 @@ public void fusedDrainCancel() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final UnicastSubject p = UnicastSubject.create(); - final TestObserver ts = ObserverFusion.newTest(QueueSubscription.ANY); + final TestObserver to = ObserverFusion.newTest(QueueFuseable.ANY); - p.subscribe(ts); + p.subscribe(to); Runnable r1 = new Runnable() { @Override @@ -347,7 +347,7 @@ public void run() { Runnable r2 = new Runnable() { @Override public void run() { - ts.cancel(); + to.cancel(); } }; @@ -389,30 +389,30 @@ public void subscribeRace() { for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { final UnicastSubject us = UnicastSubject.create(); - final TestObserver ts1 = new TestObserver(); - final TestObserver ts2 = new TestObserver(); + final TestObserver to1 = new TestObserver(); + final TestObserver to2 = new TestObserver(); Runnable r1 = new Runnable() { @Override public void run() { - us.subscribe(ts1); + us.subscribe(to1); } }; Runnable r2 = new Runnable() { @Override public void run() { - us.subscribe(ts2); + us.subscribe(to2); } }; TestHelper.race(r1, r2); - if (ts1.errorCount() == 0) { - ts2.assertFailure(IllegalStateException.class); + if (to1.errorCount() == 0) { + to2.assertFailure(IllegalStateException.class); } else - if (ts2.errorCount() == 0) { - ts1.assertFailure(IllegalStateException.class); + if (to2.errorCount() == 0) { + to1.assertFailure(IllegalStateException.class); } else { fail("Neither TestObserver failed"); } @@ -439,7 +439,7 @@ public void drainFusedFailFast() { UnicastSubject us = UnicastSubject.create(false); - TestObserver to = us.to(ObserverFusion.test(QueueDisposable.ANY, false)); + TestObserver to = us.to(ObserverFusion.test(QueueFuseable.ANY, false)); us.done = true; us.drainFused(to); @@ -452,7 +452,7 @@ public void drainFusedFailFastEmpty() { UnicastSubject us = UnicastSubject.create(false); - TestObserver to = us.to(ObserverFusion.test(QueueDisposable.ANY, false)); + TestObserver to = us.to(ObserverFusion.test(QueueFuseable.ANY, false)); us.drainFused(to); diff --git a/src/test/java/io/reactivex/subscribers/SerializedSubscriberTest.java b/src/test/java/io/reactivex/subscribers/SerializedSubscriberTest.java index e70777edc5..6f2e6fc7e6 100644 --- a/src/test/java/io/reactivex/subscribers/SerializedSubscriberTest.java +++ b/src/test/java/io/reactivex/subscribers/SerializedSubscriberTest.java @@ -14,6 +14,7 @@ package io.reactivex.subscribers; import static org.junit.Assert.*; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; import java.util.List; @@ -25,7 +26,7 @@ import io.reactivex.*; import io.reactivex.exceptions.TestException; -import io.reactivex.internal.subscriptions.*; +import io.reactivex.internal.subscriptions.BooleanSubscription; import io.reactivex.plugins.RxJavaPlugins; import io.reactivex.schedulers.Schedulers; @@ -266,7 +267,7 @@ public void testNotificationDelay() throws InterruptedException { final CountDownLatch latch = new CountDownLatch(1); final CountDownLatch running = new CountDownLatch(2); - TestSubscriber to = new TestSubscriber(new DefaultSubscriber() { + TestSubscriber ts = new TestSubscriber(new DefaultSubscriber() { @Override public void onComplete() { @@ -289,7 +290,7 @@ public void onNext(String t) { } }); - Subscriber o = serializedSubscriber(to); + Subscriber o = serializedSubscriber(ts); Future f1 = tp1.submit(new OnNextThread(o, 1, onNextCount, running)); Future f2 = tp2.submit(new OnNextThread(o, 1, onNextCount, running)); @@ -298,7 +299,7 @@ public void onNext(String t) { firstOnNext.await(); - Thread t1 = to.lastThread(); + Thread t1 = ts.lastThread(); System.out.println("first onNext on thread: " + t1); latch.countDown(); @@ -306,16 +307,16 @@ public void onNext(String t) { waitOnThreads(f1, f2); // not completed yet - assertEquals(2, to.valueCount()); + assertEquals(2, ts.valueCount()); - Thread t2 = to.lastThread(); + Thread t2 = ts.lastThread(); System.out.println("second onNext on thread: " + t2); assertSame(t1, t2); - System.out.println(to.values()); + System.out.println(ts.values()); o.onComplete(); - System.out.println(to.values()); + System.out.println(ts.values()); } } finally { tp1.shutdown(); @@ -347,7 +348,7 @@ public void onNext(String t) { @Test public void testThreadStarvation() throws InterruptedException { - TestSubscriber to = new TestSubscriber(new DefaultSubscriber() { + TestSubscriber ts = new TestSubscriber(new DefaultSubscriber() { @Override public void onComplete() { @@ -369,7 +370,7 @@ public void onNext(String t) { } }); - final Subscriber o = serializedSubscriber(to); + final Subscriber o = serializedSubscriber(ts); AtomicInteger p1 = new AtomicInteger(); AtomicInteger p2 = new AtomicInteger(); @@ -839,7 +840,7 @@ protected void captureMaxThreads() { @Ignore("Null values not permitted") public void testSerializeNull() { final AtomicReference> serial = new AtomicReference>(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t != null && t == 0) { @@ -849,25 +850,25 @@ public void onNext(Integer t) { } }; - SerializedSubscriber sobs = new SerializedSubscriber(to); + SerializedSubscriber sobs = new SerializedSubscriber(ts); serial.set(sobs); sobs.onNext(0); - to.assertValues(0, null); + ts.assertValues(0, null); } @Test @Ignore("Subscribers can't throw") public void testSerializeAllowsOnError() { - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { throw new TestException(); } }; - SerializedSubscriber sobs = new SerializedSubscriber(to); + SerializedSubscriber sobs = new SerializedSubscriber(ts); try { sobs.onNext(0); @@ -875,14 +876,14 @@ public void onNext(Integer t) { sobs.onError(ex); } - to.assertError(TestException.class); + ts.assertError(TestException.class); } @Test @Ignore("Null values no longer permitted") public void testSerializeReentrantNullAndComplete() { final AtomicReference> serial = new AtomicReference>(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { serial.get().onComplete(); @@ -890,7 +891,7 @@ public void onNext(Integer t) { } }; - SerializedSubscriber sobs = new SerializedSubscriber(to); + SerializedSubscriber sobs = new SerializedSubscriber(ts); serial.set(sobs); try { @@ -899,15 +900,15 @@ public void onNext(Integer t) { sobs.onError(ex); } - to.assertError(TestException.class); - to.assertNotComplete(); + ts.assertError(TestException.class); + ts.assertNotComplete(); } @Test @Ignore("Subscribers can't throw") public void testSerializeReentrantNullAndError() { final AtomicReference> serial = new AtomicReference>(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { serial.get().onError(new RuntimeException()); @@ -915,7 +916,7 @@ public void onNext(Integer t) { } }; - SerializedSubscriber sobs = new SerializedSubscriber(to); + SerializedSubscriber sobs = new SerializedSubscriber(ts); serial.set(sobs); try { @@ -924,15 +925,15 @@ public void onNext(Integer t) { sobs.onError(ex); } - to.assertError(TestException.class); - to.assertNotComplete(); + ts.assertError(TestException.class); + ts.assertNotComplete(); } @Test @Ignore("Null values no longer permitted") public void testSerializeDrainPhaseThrows() { final AtomicReference> serial = new AtomicReference>(); - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts = new TestSubscriber() { @Override public void onNext(Integer t) { if (t != null && t == 0) { @@ -945,13 +946,13 @@ public void onNext(Integer t) { } }; - SerializedSubscriber sobs = new SerializedSubscriber(to); + SerializedSubscriber sobs = new SerializedSubscriber(ts); serial.set(sobs); sobs.onNext(0); - to.assertError(TestException.class); - to.assertNotComplete(); + ts.assertError(TestException.class); + ts.assertNotComplete(); } @Test @@ -1214,4 +1215,18 @@ public void run() { } } + + @Test + public void nullOnNext() { + + TestSubscriber ts = new TestSubscriber(); + + final SerializedSubscriber so = new SerializedSubscriber(ts); + + so.onSubscribe(new BooleanSubscription()); + + so.onNext(null); + + ts.assertFailureAndMessage(NullPointerException.class, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); + } } diff --git a/src/test/java/io/reactivex/subscribers/SubscriberFusion.java b/src/test/java/io/reactivex/subscribers/SubscriberFusion.java index 43e15e350b..02e1f3a9a5 100644 --- a/src/test/java/io/reactivex/subscribers/SubscriberFusion.java +++ b/src/test/java/io/reactivex/subscribers/SubscriberFusion.java @@ -32,12 +32,12 @@ public enum SubscriberFusion { * Use this as follows: *
      * source
-     * .to(SubscriberFusion.test(0, QueueSubscription.ANY, false))
+     * .to(SubscriberFusion.test(0, QueueFuseable.ANY, false))
      * .assertResult(0);
      * 
* @param the value type * @param initialRequest the initial request amount, non-negative - * @param mode the fusion mode to request, see {@link QueueSubscription} constants. + * @param mode the fusion mode to request, see {@link QueueFuseable} constants. * @param cancelled should the TestSubscriber cancelled before the subscription even happens? * @return the new Function instance */ @@ -52,7 +52,7 @@ public static Function, TestSubscriber> test( * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(0, QueueDisposable.ANY, false))
+     * .to(ObserverFusion.test(0, QueueFuseable.ANY, false))
      * .assertOf(ObserverFusion.assertFuseable());
      * 
* @param the value type @@ -114,7 +114,7 @@ public void accept(TestSubscriber ts) throws Exception { * Use this as follows: *
      * source
-     * .to(ObserverFusion.test(0, QueueDisposable.ANY, false))
+     * .to(ObserverFusion.test(0, QueueFuseable.ANY, false))
      * .assertOf(ObserverFusion.assertNotFuseable());
      * 
* @param the value type @@ -135,17 +135,17 @@ public void accept(TestSubscriber ts) throws Exception { /** * Returns a Consumer that asserts on its TestSubscriber parameter that - * the upstream is Fuseable (sent a QueueSubscription subclass in onSubscribe) + * the upstream is Fuseable (sent a QueueFuseable.subclass in onSubscribe) * and the established the given fusion mode. *

* Use this as follows: *

      * source
-     * .to(SubscriberFusion.test(0, QueueSubscription.ANY, false))
-     * .assertOf(SubscriberFusion.assertFusionMode(QueueSubscription.SYNC));
+     * .to(SubscriberFusion.test(0, QueueFuseable.ANY, false))
+     * .assertOf(SubscriberFusion.assertFusionMode(QueueFuseable.SYNC));
      * 
* @param the value type - * @param mode the expected established fusion mode, see {@link QueueSubscription} constants. + * @param mode the expected established fusion mode, see {@link QueueFuseable} constants. * @return the new Consumer instance */ public static Consumer> assertFusionMode(final int mode) { @@ -156,7 +156,7 @@ public static Consumer> assertFusionMode(final int mode) { * Constructs a TestSubscriber with the given initial request and required fusion mode. * @param the value type * @param initialRequest the initial request, non-negative - * @param mode the requested fusion mode, see {@link QueueSubscription} constants + * @param mode the requested fusion mode, see {@link QueueFuseable} constants * @return the new TestSubscriber */ public static TestSubscriber newTest(long initialRequest, int mode) { @@ -168,7 +168,7 @@ public static TestSubscriber newTest(long initialRequest, int mode) { /** * Constructs a TestSubscriber with the given required fusion mode. * @param the value type - * @param mode the requested fusion mode, see {@link QueueSubscription} constants + * @param mode the requested fusion mode, see {@link QueueFuseable} constants * @return the new TestSubscriber */ public static TestSubscriber newTest(int mode) { @@ -178,7 +178,7 @@ public static TestSubscriber newTest(int mode) { } /** - * Assert that the TestSubscriber received a fuseabe QueueSubscription and + * Assert that the TestSubscriber received a fuseabe QueueFuseable.and * is in the given fusion mode. * @param the value type * @param ts the TestSubscriber instance diff --git a/src/test/java/io/reactivex/subscribers/TestSubscriberTest.java b/src/test/java/io/reactivex/subscribers/TestSubscriberTest.java index 39a384168d..ba04b04762 100644 --- a/src/test/java/io/reactivex/subscribers/TestSubscriberTest.java +++ b/src/test/java/io/reactivex/subscribers/TestSubscriberTest.java @@ -31,7 +31,7 @@ import io.reactivex.exceptions.*; import io.reactivex.functions.*; import io.reactivex.internal.functions.Functions; -import io.reactivex.internal.fuseable.QueueSubscription; +import io.reactivex.internal.fuseable.QueueFuseable; import io.reactivex.internal.subscriptions.*; import io.reactivex.observers.BaseTestConsumer; import io.reactivex.observers.BaseTestConsumer.TestWaitStrategy; @@ -243,13 +243,13 @@ public void testNullDelegate3() { @Test public void testDelegate1() { - TestSubscriber to = new TestSubscriber(); - to.onSubscribe(EmptySubscription.INSTANCE); + TestSubscriber ts0 = new TestSubscriber(); + ts0.onSubscribe(EmptySubscription.INSTANCE); - TestSubscriber ts = new TestSubscriber(to); + TestSubscriber ts = new TestSubscriber(ts0); ts.onComplete(); - to.assertTerminated(); + ts0.assertTerminated(); } @Test @@ -710,13 +710,13 @@ public void testValueCount() { @Test(timeout = 1000) public void testOnCompletedCrashCountsDownLatch() { - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts0 = new TestSubscriber() { @Override public void onComplete() { throw new TestException(); } }; - TestSubscriber ts = new TestSubscriber(to); + TestSubscriber ts = new TestSubscriber(ts0); try { ts.onComplete(); @@ -729,13 +729,13 @@ public void onComplete() { @Test(timeout = 1000) public void testOnErrorCrashCountsDownLatch() { - TestSubscriber to = new TestSubscriber() { + TestSubscriber ts0 = new TestSubscriber() { @Override public void onError(Throwable e) { throw new TestException(); } }; - TestSubscriber ts = new TestSubscriber(to); + TestSubscriber ts = new TestSubscriber(ts0); try { ts.onError(new RuntimeException()); @@ -984,22 +984,22 @@ public void assertFuseable() { } try { - ts.assertFusionMode(QueueSubscription.SYNC); + ts.assertFusionMode(QueueFuseable.SYNC); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected } ts = TestSubscriber.create(); - ts.setInitialFusionMode(QueueSubscription.ANY); + ts.setInitialFusionMode(QueueFuseable.ANY); ts.onSubscribe(new ScalarSubscription(ts, 1)); ts.assertFuseable(); - ts.assertFusionMode(QueueSubscription.SYNC); + ts.assertFusionMode(QueueFuseable.SYNC); try { - ts.assertFusionMode(QueueSubscription.NONE); + ts.assertFusionMode(QueueFuseable.NONE); throw new RuntimeException("Should have thrown"); } catch (AssertionError ex) { // expected @@ -1195,9 +1195,9 @@ public void onNext() { @Test public void fusionModeToString() { - assertEquals("NONE", TestSubscriber.fusionModeToString(QueueSubscription.NONE)); - assertEquals("SYNC", TestSubscriber.fusionModeToString(QueueSubscription.SYNC)); - assertEquals("ASYNC", TestSubscriber.fusionModeToString(QueueSubscription.ASYNC)); + assertEquals("NONE", TestSubscriber.fusionModeToString(QueueFuseable.NONE)); + assertEquals("SYNC", TestSubscriber.fusionModeToString(QueueFuseable.SYNC)); + assertEquals("ASYNC", TestSubscriber.fusionModeToString(QueueFuseable.ASYNC)); assertEquals("Unknown(100)", TestSubscriber.fusionModeToString(100)); } @@ -1615,7 +1615,7 @@ public void onComplete() { @Test public void syncQueueThrows() { TestSubscriber ts = new TestSubscriber(); - ts.setInitialFusionMode(QueueSubscription.SYNC); + ts.setInitialFusionMode(QueueFuseable.SYNC); Flowable.range(1, 5) .map(new Function() { @@ -1626,14 +1626,14 @@ public void syncQueueThrows() { ts.assertSubscribed() .assertFuseable() - .assertFusionMode(QueueSubscription.SYNC) + .assertFusionMode(QueueFuseable.SYNC) .assertFailure(TestException.class); } @Test public void asyncQueueThrows() { TestSubscriber ts = new TestSubscriber(); - ts.setInitialFusionMode(QueueSubscription.ANY); + ts.setInitialFusionMode(QueueFuseable.ANY); UnicastProcessor up = UnicastProcessor.create(); @@ -1648,7 +1648,7 @@ public void asyncQueueThrows() { ts.assertSubscribed() .assertFuseable() - .assertFusionMode(QueueSubscription.ASYNC) + .assertFusionMode(QueueFuseable.ASYNC) .assertFailure(TestException.class); }