-
Notifications
You must be signed in to change notification settings - Fork 7.6k
concatArrayEagerDelayError documented but missing? 2.16 #6082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like |
Yes, I've overlooked that, might've been because I'm on my laptop right now and it's chugging along slowly on those large files on GitHub. Is the plan to expose this in the future? |
No plans and there was no feature request for them. It would require 6~8 new methods:
and at least 2 diagrams per base class. |
I'm up for providing a PR if that's welcome. Thank you in advance for providing me with the methods that would need to be implemented. I haven't dabbled into the RxJava source, but I guess I can figure it out. What would I need to create the diagrams? Looking at the tests for concatArrayEager, and concatArrayDelayError. I assume that I only have to implement the tests like |
I draw them in Excel but others use OmniGraffle or Inkscape. You can try making a PR. |
Small update. I was on holiday and am currently studying for exams for another month so it'll be more than a month till I can get to this unfortunately. |
I've done it and the necessary marbles in #6143. |
Too bad for me, I was looking forward to it. :( Great to have it exposed now though. |
On 2.1.16 it is documented in the wiki and on readthedocs that
concatArrayEagerDelayError
is new in RxJava 2 together with:concatArray
concatArrayDelayError
concatArrayEager
Those are all there, but
concatArrayEagerDelayError
doesn't seem to be implemented:Observable.concatArrayEagerDelayError()
Am I perhaps missing something?
The text was updated successfully, but these errors were encountered: