Skip to content

concatArrayEagerDelayError documented but missing? 2.16 #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasBackx opened this issue Jul 16, 2018 · 8 comments
Closed

concatArrayEagerDelayError documented but missing? 2.16 #6082

AndreasBackx opened this issue Jul 16, 2018 · 8 comments

Comments

@AndreasBackx
Copy link

On 2.1.16 it is documented in the wiki and on readthedocs that concatArrayEagerDelayError is new in RxJava 2 together with:

Those are all there, but concatArrayEagerDelayError doesn't seem to be implemented:

Observable.concatArrayEagerDelayError()

Am I perhaps missing something?

@akarnokd
Copy link
Member

Looks like concatArrayEagerDelayError has not been exposed so far: https://github.com/ReactiveX/RxJava/blob/2.x/src/main/java/io/reactivex/Observable.java#L1341

@AndreasBackx
Copy link
Author

Yes, I've overlooked that, might've been because I'm on my laptop right now and it's chugging along slowly on those large files on GitHub.

Is the plan to expose this in the future?

@akarnokd
Copy link
Member

No plans and there was no feature request for them. It would require 6~8 new methods:

{Flowable|Observable}.concatArrayEagerDelayError([tillTheEnd[, maxConcurrency [, prefetch]]], sources...)

and at least 2 diagrams per base class.

@AndreasBackx
Copy link
Author

AndreasBackx commented Jul 16, 2018

I'm up for providing a PR if that's welcome. Thank you in advance for providing me with the methods that would need to be implemented. I haven't dabbled into the RxJava source, but I guess I can figure it out. What would I need to create the diagrams?

Looking at the tests for concatArrayEager, and concatArrayDelayError. I assume that I only have to implement the tests like concatArrayDelay but for concatArrayEagerDelayError.

@akarnokd
Copy link
Member

I draw them in Excel but others use OmniGraffle or Inkscape.

You can try making a PR.

@AndreasBackx
Copy link
Author

AndreasBackx commented Aug 5, 2018

Small update. I was on holiday and am currently studying for exams for another month so it'll be more than a month till I can get to this unfortunately.

@akarnokd
Copy link
Member

akarnokd commented Aug 6, 2018

I've done it and the necessary marbles in #6143.

@AndreasBackx
Copy link
Author

Too bad for me, I was looking forward to it. :(

Great to have it exposed now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants