2.x: dematerialize and completion

[davidmoten]

I do not expect Flowable.just(Notification.createOnNext(1)).dematerialize() to complete but it does.

Do you think this is a bug too? If so I can submit a PR.

[davidmoten]

Ditto Observable.dematerialize

[akarnokd]

It't not a bug.

[davidmoten]

Yes I agree that formally it's not a bug because the javadoc for dematerialize says:

Returns a Flowable that reverses the effect of materialize by transforming the Notification objects emitted by the source Publisher into the items or notifications they represent.

A simpler example of the issue is that Flowable.empty().dematerialize() should not complete because Notification.onComplete/Notification.onError were not emitted by Flowable.empty(). I think the current behaviour is counter-intuitive and should be changed (will not contradict the javadoc by the way because its behaviour was undefined).

@akarnokd If you don't agree that the current behaviour should be changed then I suggest I supplement the javadoc to describe the operator's behaviour more precisely.

[akarnokd]

You can suppress the terminal event by concatenating with never. You can post a PR that adds more clarification.

[akarnokd]

PR welcome.

[davidmoten]

Will do, I'll make it this weekend.

…

On 6 July 2017 at 08:29, David Karnok ***@***.***> wrote: PR welcome. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5261 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATa6_G7dhJycDRIxNgPcEA6ty08s2k6ks5sLA4vgaJpZM4MxA-L> .

[akarnokd]

Do you still want to contribute the clarification?