Skip to content

Execution hook for Single #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phajduk opened this issue Jan 2, 2016 · 3 comments
Closed

Execution hook for Single #3595

phajduk opened this issue Jan 2, 2016 · 3 comments
Labels
Feature-Request

Comments

@phajduk
Copy link

phajduk commented Jan 2, 2016

RxJavaObservableExecutionHook is not compatible with Single type. For example: RxJavaObservableExecutionHook#onCreate method tooks Observable#OnSubscribe type as a parameter. However, Single is using it's own OnSubscribe type. Shall we implement new class to handle Single's hooks let's say RxJavaSingleExecutionHook ?
@phajduk phajduk changed the title Execition hook for Single Execution hook for Single Jan 2, 2016
@akarnokd
Copy link
Member

akarnokd commented Feb 9, 2016

Would you like to post a PR for this?

@phajduk
Copy link
Author

phajduk commented Feb 9, 2016

If you agree with my proposition then I will create PR for that feature for sure.

@akarnokd
Copy link
Member

akarnokd commented Feb 9, 2016

I don't see anything wrong upfront so go ahead with the PR.

@phajduk phajduk mentioned this issue Feb 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akarnokd @phajduk