Simplify CI and fix issues on 3.14 CI #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is ready now, I think. |
Collaborator
Author
|
@lysnikolaou this one too please! |
lysnikolaou
approved these changes
Jul 24, 2025
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
Looks good! Thanks @ngoldbaum!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the CI results for #96 I noticed some weirdness on the 3.14 CI I missed in #84.
I think the 3.14 CI jobs aren't working correctly because
tox-ghneeds explicit support for each new python version. Let's just not use it and instead use the python from setup-python and pass-eto tox explicitly.Github actions doesn't have a way to do string processing, so I just added the names of the tox environments to the build matrix.
I might need to do an iteration or two to get this right, sorry for the noise.