-
-
Notifications
You must be signed in to change notification settings - Fork 76
Fee off by 1 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Upon further investigation, we may need to sum raw values and use This is occurring when trying to submit through Blockfrost. |
Makes sense to round up (using |
@theeldermillenial It would be great if you could provide a failing example so I can find where the root cause is and add it to test. |
I'm running into a case where building a transaction with a script input is resulting in an incorrect fee calculation, which is off by 1.
Doing some debugging on
pycardano.utils.fee
, it looks like everything is rounded down with a cast toint
. Would it make sense to add all raw values and round? In some cases, the values sum to a value with 0.5 ADA getting rounded down, and if we just rounded up this would resolve the issue.The text was updated successfully, but these errors were encountered: