Skip to content

Allow str addresses as change address in txbuilder #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nielstron opened this issue Mar 26, 2023 · 1 comment
Closed

Allow str addresses as change address in txbuilder #187

nielstron opened this issue Mar 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nielstron
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A lot of users put a Bech32 encoded address as change address in the txbuilder, which seems natural as a user flow. The returned error message is usually quite obscure.

Describe the solution you'd like
For this reason, the txbuilder should check and optimally directly transform a passed-in str object to a PyCardano address object to reduce friction.

Describe alternatives you've considered
The txbuilder could check that it is passed an address object and raise an error otherwise. The process to transform a string to address is very automatizable though, so it should directly apply this.

Additional context
CC @while0x1

@cffls
Copy link
Collaborator

cffls commented Mar 26, 2023

Looks like this issue will be resolved in the next release with this commit: 4bf6a62

Any string address passed to transaction output will be converted automatically.

@cffls cffls added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants