UPDATE. ensure only bytes values are evaluated for PointerAddress.from_primitive()

Author: daehan-koreapool

pycardano/address.py

@@ -19,7 +19,7 @@
 )
 from pycardano.hash import VERIFICATION_KEY_HASH_SIZE, ScriptHash, VerificationKeyHash
 from pycardano.network import Network
-from pycardano.serialization import CBORSerializable
+from pycardano.serialization import CBORSerializable, Primitive
 
 __all__ = ["AddressType", "PointerAddress", "Address"]
 
@@ -160,7 +160,11 @@ def to_primitive(self) -> bytes:
         return self.encode()
 
     @classmethod
-    def from_primitive(cls: Type[PointerAddress], value: bytes) -> PointerAddress:
+    def from_primitive(cls: Type[PointerAddress], value: Primitive) -> PointerAddress:
+        if not isinstance(value, bytes):
+            raise DeserializeException(
+                f"A bytes value is required for deserialization: {value}"
+            )
         return cls.decode(value)
 
     def __eq__(self, other):

test/pycardano/test_address.py

@@ -1,4 +1,7 @@
-from pycardano.address import Address
+from unittest import TestCase
+
+from pycardano.address import Address, PointerAddress
+from pycardano.exception import DeserializeException
 from pycardano.key import PaymentVerificationKey
 from pycardano.network import Network
 
@@ -15,3 +18,9 @@ def test_payment_addr():
         Address(vk.hash(), network=Network.TESTNET).encode()
         == "addr_test1vr2p8st5t5cxqglyjky7vk98k7jtfhdpvhl4e97cezuhn0cqcexl7"
     )
+
+
+class PointerAddressTest(TestCase):
+    def test_from_primitive_invalid_value(self):
+        with self.assertRaises(DeserializeException):
+            PointerAddress.from_primitive(1)