Skip to content

Conversation

@chazuttu
Copy link
Collaborator

@chazuttu chazuttu commented Aug 9, 2021

Summary

This PR adds unit tests for the script pyi25.py and increased coverage.

  • added unit tests for the script pyi25.py
  • updated requirements-dev.txt file
  • updated .coveragerc
  • increased coverage upto 82%

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

Python 3

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_pyi25.py

============================= test session starts =========================
platform win32 -- Python 3.9.6, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\pyafipws, configfile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-3.1.1, metadata-1.11.0, mock-3.6.1, vcr-1.0.2
collected 5 items

tests\test_pyi25.py .....                                                                                                                                                                                        [100%]


----------- coverage: platform win32, python 3.9.6-final-0 -----------
Name                                                                                       Stmts   Miss  Cover
--------------------------------------------------------------------------------------------------------------
test3\Lib\site-packages\PyAfipWs-3.9.b_2572_-py3.9.egg\pyafipws\__init__.py                    4      0   100%
test3\Lib\site-packages\PyAfipWs-3.9.b_2572_-py3.9.egg\pyafipws\pyi25.py                     111     20    82%
--------------------------------------------------------------------------------------------------------------

====================== 5 passed, 2 warnings in 3.37s =====================

Python 2

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_pyi25.py

============================= test session starts =============================
platform win32 -- Python 2.7.18, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\pyafipws, inifile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-1.22.1, metadata-1.11.0, mock-2.0.0, vcr-1.0.2
collected 5 items

tests\test_pyi25.py .....                                                [100%]

---------- coverage: platform win32, python 2.7.18-final-0 -----------
Name                                                                                    Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------
test2\Lib\site-packages\PyAfipWs-2.7.2572-py2.7.egg\pyafipws\__init__.py                    4      0   100%
test2\Lib\site-packages\PyAfipWs-2.7.2572-py2.7.egg\pyafipws\pyi25.py                     111     20    82%
-----------------------------------------------------------------------------------------------------------


========================== 5 passed in 3.85 seconds ===========================

Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
@chazuttu chazuttu requested a review from reingart August 9, 2021 06:22
@reingart reingart merged commit 27006ed into PyAr:main Aug 13, 2021
reingart added a commit that referenced this pull request Mar 19, 2023
Fix #94 SSL: DH_KEY_TOO_SMALL (python 3.10 win)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants