Skip to content

Fix Cypress test to work with lesson numbers greater than 9 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
terichadbourne opened this issue Aug 19, 2019 · 2 comments
Closed

Fix Cypress test to work with lesson numbers greater than 9 #291

terichadbourne opened this issue Aug 19, 2019 · 2 comments
Assignees
@fsdiogo
Labels
bug Something isn't working

Comments

@terichadbourne
Copy link
Member

Cypress logic will currently only work for tutorials with fewer than 10 lessons because of the way string concatenation is handled. Should be a quick fix to future-proof.
@terichadbourne terichadbourne added the bug Something isn't working label Aug 19, 2019
@fsdiogo
Copy link
Collaborator

fsdiogo commented Aug 20, 2019

I've fixed this in commit aab498b, so when #282 gets merged, we can close this one.

@fsdiogo
Copy link
Collaborator

fsdiogo commented Aug 20, 2019

Fixed in #282.

@fsdiogo fsdiogo closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsdiogo fsdiogo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terichadbourne @fsdiogo