Skip to content

Unnecessary file upload step in MFS - Lesson 9 (Copy a file or directory) #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Frijol opened this issue Jun 21, 2019 · 2 comments
Open
Labels
lesson-feedback Feedback on a specific lesson

Comments

@Frijol
Copy link
Contributor

Frijol commented Jun 21, 2019

Have a question or suggestion regarding a specific ProtoSchool lesson? Please use this template to share it!

URL of the lesson that's confusing:
https://proto.school/#/mutable-file-system/09

What's confusing about this lesson?

This step still calls for an upload of files, but there's no need to do so for this exercise! I know we keep the code for moving files, but it feels pretty weird to still make this 2-step.

Fairly minor nit.
Screen Shot 2019-06-21 at 1 53 20 PM

What additional context could we provide to help you succeed?

Remove Step 1 from this lesson?

What other feedback would you like to share about ProtoSchool?

@Frijol Frijol added the lesson-feedback Feedback on a specific lesson label Jun 21, 2019
@terichadbourne
Copy link
Member

I'm digging through issues today and love seeing all of your feedback @Frijol!

My gut, although I understand why it feels awkward, is that it might be too disruptive to the way our code works to remove, but ccing @zebateira for a second opinion with fresh eyes.

@terichadbourne terichadbourne changed the title Lesson Feedback: Mutable file system - Lesson 9 (Copy a file or directory) Unnecessary file upload step in MFS - Lesson 9 (Copy a file or directory) Sep 18, 2020
@zebateira
Copy link
Contributor

It does look awkward to have to upload files that are not needed for this lesson.
I guess we went for consistency (building up the solution code) and so that required us to keep the file upload feature in this lesson.

Even so, I'd say it's a useful insight to have: the fact that we can copy files from several places, like uploads and ipfs itself, and then see them together in the same ipfs directory.
Although it might not be the case for some users, most of the users should have come from previous lessons with the files already selected to upload.

So I guess it comes down to please all the users by changing this lesson's code solution, or keep the code solution consistent throughout the tutorial.
I'm fine with both solutions, but more torn to the latter (current one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lesson-feedback Feedback on a specific lesson
Projects
None yet
Development

No branches or pull requests

3 participants