Skip to content

add update workflow endpoint #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2022
Merged

add update workflow endpoint #153

merged 4 commits into from
Jun 10, 2022

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Jun 7, 2022 •
edited
Loading

Changes required for #61 .

Description

Add update workflow endpoint

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
  • Any new files have copyright headers
  • Code coverage above 70%
  • TODO items resolved

@jackschofield23 jackschofield23 marked this pull request as ready for review June 7, 2022 13:58
@jackschofield23 jackschofield23 force-pushed the jschofield/update-workflow-api branch from 37f7a10 to 498c6fd Compare June 7, 2022 14:00
@jackschofield23 jackschofield23 self-assigned this Jun 7, 2022
lillie-dae
lillie-dae reviewed Jun 8, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the jschofield/update-workflow-api branch 3 times, most recently from 6224037 to bc68990 Compare June 8, 2022 14:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

59.6% 59.6% Coverage
0.0% 0.0% Duplication

mocsharp
mocsharp reviewed Jun 8, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the jschofield/update-workflow-api branch 2 times, most recently from 61d1c23 to 503898b Compare June 10, 2022 09:23
@jackschofield23
add update workflow endpoint
7d5bb51 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
address comments
fd990ab 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23 jackschofield23 force-pushed the jschofield/update-workflow-api branch from 503898b to fd990ab Compare June 10, 2022 09:24
jackschofield23 and others added 2 commits June 10, 2022 11:07
@jackschofield23
fix issues
b28bd77 
Signed-off-by: Jack Schofield <[email protected]>
@JoeBatt1989
Workflow update api integration tests
1c7b131 
Signed-off-by: Joe Batt <[email protected]>
@jackschofield23 jackschofield23 merged commit 074fb83 into develop Jun 10, 2022
@jackschofield23 jackschofield23 deleted the jschofield/update-workflow-api branch June 10, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mocsharp mocsharp mocsharp left review comments

@lillie-dae lillie-dae lillie-dae approved these changes

Assignees

@jackschofield23 jackschofield23

Labels

Awaiting Integration Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackschofield23 @mocsharp @lillie-dae @JoeBatt1989