Skip to content

70 workflow instance #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 6, 2022
Merged

70 workflow instance #101

merged 17 commits into from
May 6, 2022

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented May 3, 2022 •
edited
Loading

Fixes #70 and #86.

Description

This is to implement the creation of the workflow instance, complete with the creation of the workflow instance within the database. The task dispatch message is also created and fired off.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@jackschofield23 jackschofield23 force-pushed the origin/70-workflow-instance branch from 9c006fa to 276626e Compare May 3, 2022 13:04
@jackschofield23 jackschofield23 self-assigned this May 3, 2022
@jackschofield23 jackschofield23 force-pushed the origin/70-workflow-instance branch from 5735723 to 017e66c Compare May 3, 2022 13:17
@jackschofield23 jackschofield23 marked this pull request as ready for review May 3, 2022 14:33
@jackschofield23 jackschofield23 force-pushed the origin/70-workflow-instance branch 3 times, most recently from 1daf418 to 03b93de Compare May 4, 2022 13:44
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 4, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the origin/70-workflow-instance branch from fc16be7 to cd4f476 Compare May 5, 2022 14:53
@jackschofield23 jackschofield23 requested a review from mocsharp May 5, 2022 14:53
mocsharp
mocsharp reviewed May 5, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 5, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 5, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 5, 2022
View reviewed changes
mocsharp
mocsharp reviewed May 5, 2022
View reviewed changes
babarmahmood81 and others added 17 commits May 6, 2022 09:25
@babarmahmood81 @jackschofield23
Intyerim changes
b0d9fc6 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
Add storage service and add file headers
1fa72a5 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
Update workflow executer service
549be40 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add database layer
86d88da 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add dependency injection
64760df 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add task dispatch
a6d2f17 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add taskdispatch mapper
b29f2c5 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
workflow executer service tests
b379485 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add null checks to workflow repositories
d69f94e 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
fix guids not working in mongodb
0616653 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
address code smells
3a103b7 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add workflow instance checks
1e8fec5 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
fixed tests and added duplicate check
0a4c116 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
add docker-compose and address comments
e0fd3b2 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
Add support for already dispatched tasks
d58802f 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
Add configuration keys
c174267 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23
update messaging package and task status enum
4dfa189 
Signed-off-by: jackschofield23 <[email protected]>
@jackschofield23 jackschofield23 force-pushed the origin/70-workflow-instance branch from 07301fa to 4dfa189 Compare May 6, 2022 08:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 31 Code Smells

48.5% 48.5% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit 38072dc into develop May 6, 2022
@jackschofield23 jackschofield23 deleted the origin/70-workflow-instance branch May 18, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mocsharp mocsharp mocsharp approved these changes

@joshliberty joshliberty Awaiting requested review from joshliberty

@JJFinnerty JJFinnerty Awaiting requested review from JJFinnerty

Assignees

@jackschofield23 jackschofield23

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trigger new workflow

4 participants

@jackschofield23 @mocsharp @babarmahmood81