Skip to content

Remove temporary dotnet publish workaround #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andyleejordan opened this issue Feb 2, 2022 · 0 comments · Fixed by #1698
Closed

Remove temporary dotnet publish workaround #1697

andyleejordan opened this issue Feb 2, 2022 · 0 comments · Fixed by #1698
Assignees
@andyleejordan
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).

Comments

@andyleejordan
Copy link
Member

We should remove the following workaround:

PowerShellEditorServices/src/PowerShellEditorServices.Hosting/PowerShellEditorServices.Hosting.csproj

Lines 9 to 19 in 00c7824

<!-- HACK: This is a temporary workaround of `dotnet publish` -->
<Target Name="InjectNetStandardFacadesToPublishDirectory"
BeforeTargets="ComputeResolvedFilesToPublishList"
Condition="'@(_NETStandardLibraryNETFrameworkLib)' != ''">
<ItemGroup>
<_ResolvedCopyLocalPublishAssets
Include="@(_NETStandardLibraryNETFrameworkLib)"
Condition="'%(_NETStandardLibraryNETFrameworkLib.FileName)' != 'netfx.force.conflicts'"
/>
</ItemGroup>
</Target>

now that it's been resolved upstream: dotnet/sdk#18101 (comment)
@andyleejordan andyleejordan self-assigned this Feb 2, 2022
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Feb 2, 2022
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Feb 2, 2022
@andyleejordan andyleejordan mentioned this issue Feb 2, 2022
Merged
@ghost ghost added the Status: In PR label Feb 2, 2022
@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Feb 2, 2022
Repository owner moved this from In Progress to Done in Sea Biscuit Feb 3, 2022
@ghost ghost added Status: Fixed and removed Status: In PR labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Sea Biscuit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove temporary dotnet publish workaround PowerShell/PowerShellEditorServices
1 participant
@andyleejordan