Skip to content

Add a Trace equivalent to extension's logging setting #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andyleejordan opened this issue May 13, 2021 · 1 comment
Closed

Add a Trace equivalent to extension's logging setting #1478

andyleejordan opened this issue May 13, 2021 · 1 comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).

Comments

@andyleejordan
Copy link
Member

Noted in #1474, I think we should add a Trace equivalent to the extension's logging setting and our loose abstraction of PsesLogLevel. Notably, we're not sure right now how to get existing trace logs, and moreover, the assembly load events are super noisy and should be moved to a Trace level.

I think settings Diagnostics in the extension gets Trace logs because in the end that's an int with the value 0. Obviously we need to clean this up.
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Logging labels May 13, 2021
@ghost ghost added the Needs: Triage Maintainer attention needed! label May 13, 2021
@andyleejordan
Copy link
Member Author

Ah ha, got an answer. Microsoft.Extensions.Logging.LogLevel.Trace shows up as "Verbose" in out log emitter.

@SydneyhSmith SydneyhSmith removed the Needs: Triage Maintainer attention needed! label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyleejordan @SydneyhSmith