Update PackageManagement

Author: TylerLeonhardt

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs

@@ -3,14 +3,18 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 //
 
+using System;
 using System.Collections.Generic;
 using System.Management.Automation;
+using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using Microsoft.PowerShell.EditorServices.Services;
 using MediatR;
 using OmniSharp.Extensions.JsonRpc;
+using OmniSharp.Extensions.LanguageServer.Protocol.Server;
+using OmniSharp.Extensions.LanguageServer.Protocol.Models;
 
 namespace Microsoft.PowerShell.EditorServices.Handlers
 {
@@ -36,24 +40,26 @@ internal class GetCommandHandler : IGetCommandHandler
     {
         private readonly ILogger<GetCommandHandler> _logger;
         private readonly PowerShellContextService _powerShellContextService;
+        private readonly ILanguageServer _languageServer;
 
-        public GetCommandHandler(ILoggerFactory factory, PowerShellContextService powerShellContextService)
+        private bool _skipPackageManagementCheck;
+
+        public GetCommandHandler(ILoggerFactory factory, PowerShellContextService powerShellContextService, ILanguageServer languageServer)
         {
             _logger = factory.CreateLogger<GetCommandHandler>();
             _powerShellContextService = powerShellContextService;
+            _languageServer = languageServer;
         }
 
         public async Task<List<PSCommandMessage>> Handle(GetCommandParams request, CancellationToken cancellationToken)
         {
             PSCommand psCommand = new PSCommand();
 
             // Executes the following:
-            // Get-Command -CommandType Function,Cmdlet,ExternalScript | Select-Object -Property Name,ModuleName | Sort-Object -Property Name
+            // Get-Command -CommandType Function,Cmdlet,ExternalScript | Sort-Object -Property Name
             psCommand
                 .AddCommand("Microsoft.PowerShell.Core\\Get-Command")
                     .AddParameter("CommandType", new[] { "Function", "Cmdlet", "ExternalScript" })
-                .AddCommand("Microsoft.PowerShell.Utility\\Select-Object")
-                    .AddParameter("Property", new[] { "Name", "ModuleName" })
                 .AddCommand("Microsoft.PowerShell.Utility\\Sort-Object")
                     .AddParameter("Property", "Name");
 
@@ -64,6 +70,65 @@ public async Task<List<PSCommandMessage>> Handle(GetCommandParams request, Cance
             {
                 foreach (dynamic command in result)
                 {
+                    if (!_skipPackageManagementCheck && command.ModuleName == "PackageManagement" && command.Version < new Version(1, 4, 6))
+                    {
+                        _logger.LogDebug("Old version of PackageManagement detected. Attempting to update.");
+
+                        var takeActionText = "Yes";
+                        MessageActionItem messageAction = await _languageServer.Window.ShowMessage(new ShowMessageRequestParams()
+                        {
+                            Message = "You have a version of PackageManagement that causes issues with the PowerShell extension. Would you like to update PackageManagement (You will need to restart the PowerShell extension after)?",
+                            Type = MessageType.Warning,
+                            Actions = new MessageActionItem[]
+                            {
+                                new MessageActionItem
+                                {
+                                    Title = takeActionText
+                                },
+                                new MessageActionItem
+                                {
+                                    Title = "Not now"
+                                }
+                            }
+                        });
+
+                        // If the user chose "Not now" ignore it for the rest of the session.
+                        if (messageAction?.Title != takeActionText)
+                        {
+                            _skipPackageManagementCheck = true;
+                        }
+                        else
+                        {
+                            // Update PackageManagement
+                            psCommand
+                                .AddCommand("PowerShellGet\\Install-Module")
+                                    .AddParameter("Name", "PackageManagement")
+                                    .AddParameter("Force")
+                                    .AddParameter("AllowClobber");
+
+                            StringBuilder errors = new StringBuilder();
+                            await _powerShellContextService.ExecuteCommandAsync<object>(psCommand, errorMessages: errors, sendOutputToHost: true).ConfigureAwait(false);
+
+                            // There were errors installing PackageManagement.
+                            if (errors.Length == 0)
+                            {
+                                _languageServer.Window.ShowMessage(new ShowMessageParams
+                                {
+                                    Type = MessageType.Warning,
+                                    Message = "PackageManagement updated, please restart the PowerShell extension."
+                                });
+                            }
+                            else
+                            {
+                                _languageServer.Window.ShowMessage(new ShowMessageParams
+                                {
+                                    Type = MessageType.Error,
+                                    Message = "PackageManagement update failed. Please run the following command in a Windows PowerShell prompt and restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber`"
+                                });
+                            }
+                        }
+                    }
+
                     commandList.Add(new PSCommandMessage
                     {
                         Name = command.Name,