codacy

Author: TylerLeonhardt

src/PowerShellEditorServices/Services/DebugAdapter/BreakpointService.cs

@@ -9,6 +9,7 @@
 using System.Linq;
 using System.Management.Automation;
 using System.Management.Automation.Language;
+using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using Microsoft.PowerShell.EditorServices.Logging;
@@ -23,9 +24,6 @@ internal class BreakpointService
         private readonly ILogger<BreakpointService> _logger;
         private readonly PowerShellContextService _powerShellContextService;
 
-        private readonly ConcurrentDictionary<string, List<Breakpoint>> _breakpointsPerFile =
-            new ConcurrentDictionary<string, List<Breakpoint>>();
-
         private static int breakpointHitCounter;
 
         public BreakpointService(
@@ -298,8 +296,10 @@ private ScriptBlock GetBreakpointActionScriptBlock(
 
                         if (hitCount.HasValue)
                         {
+                            Interlocked.Increment(ref breakpointHitCounter);
+
                             string globalHitCountVarName =
-                                $"$global:{s_psesGlobalVariableNamePrefix}BreakHitCounter_{breakpointHitCounter++}";
+                                $"$global:{s_psesGlobalVariableNamePrefix}BreakHitCounter_{breakpointHitCounter}";
 
                             wrappedCondition =
                                 $"if ({breakpoint.Condition}) {{ if (++{globalHitCountVarName} -eq {hitCount}) {{ break }} }}";
@@ -404,7 +404,7 @@ private string ExtractAndScrubParseExceptionMessage(ParseException parseExceptio
             return FormatInvalidBreakpointConditionMessage(condition, parseException.Message);
         }
 
-        private string FormatInvalidBreakpointConditionMessage(string condition, string message)
+        private static string FormatInvalidBreakpointConditionMessage(string condition, string message)
         {
             return $"'{condition}' is not a valid PowerShell expression. {message}";
         }

src/PowerShellEditorServices/Services/DebugAdapter/Debugging/BreakpointApiUtils.cs

@@ -25,10 +25,6 @@ internal static class BreakpointApiUtils
 
         private static readonly Lazy<Func<Debugger, Breakpoint, bool>> s_removeBreakpointLazy;
 
-        private static readonly Lazy<Func<string, int, int, ScriptBlock, LineBreakpoint>> s_newLineBreakpointLazy;
-
-        private static readonly Lazy<Func<string, WildcardPattern, string, ScriptBlock, CommandBreakpoint>> s_newCommandBreakpointLazy;
-
         #endregion
 
         #region Static Constructor
@@ -95,10 +91,6 @@ static BreakpointApiUtils()
 
         private static Func<Debugger, Breakpoint, bool> RemoveBreakpointDelegate => s_removeBreakpointLazy.Value;
 
-        private static Func<string, int, int, ScriptBlock, LineBreakpoint> CreateLineBreakpointDelegate => s_newLineBreakpointLazy.Value;
-
-        private static Func<string, WildcardPattern, string, ScriptBlock, CommandBreakpoint> CreateCommandBreakpointDelegate => s_newCommandBreakpointLazy.Value;
-
         #endregion
 
         #region Public Static Methods