Skip to content

Commit 471de8d

Browse files
committed
Convert PsesSignatureHelpHandler to inherit SignatureHelpHandlerBase
1 parent 7f03a73 commit 471de8d

File tree

1 file changed

+7
-17
lines changed

1 file changed

+7
-17
lines changed

src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717

1818
namespace Microsoft.PowerShell.EditorServices.Handlers
1919
{
20-
internal class PsesSignatureHelpHandler : ISignatureHelpHandler
20+
internal class PsesSignatureHelpHandler : SignatureHelpHandlerBase
2121
{
2222
private readonly ILogger _logger;
2323
private readonly SymbolsService _symbolsService;
2424
private readonly WorkspaceService _workspaceService;
2525
private readonly PowerShellContextService _powerShellContextService;
2626

27-
private SignatureHelpCapability _capability;
28-
2927
public PsesSignatureHelpHandler(
3028
ILoggerFactory factory,
3129
SymbolsService symbolsService,
@@ -38,17 +36,14 @@ public PsesSignatureHelpHandler(
3836
_powerShellContextService = powerShellContextService;
3937
}
4038

41-
public SignatureHelpRegistrationOptions GetRegistrationOptions()
39+
protected override SignatureHelpRegistrationOptions CreateRegistrationOptions(SignatureHelpCapability capability, ClientCapabilities clientCapabilities) => new SignatureHelpRegistrationOptions
4240
{
43-
return new SignatureHelpRegistrationOptions
44-
{
45-
DocumentSelector = LspUtils.PowerShellDocumentSelector,
46-
// A sane default of " ". We may be able to include others like "-".
47-
TriggerCharacters = new Container<string>(" ")
48-
};
49-
}
41+
DocumentSelector = LspUtils.PowerShellDocumentSelector,
42+
// A sane default of " ". We may be able to include others like "-".
43+
TriggerCharacters = new Container<string>(" ")
44+
};
5045

51-
public async Task<SignatureHelp> Handle(SignatureHelpParams request, CancellationToken cancellationToken)
46+
public override async Task<SignatureHelp> Handle(SignatureHelpParams request, CancellationToken cancellationToken)
5247
{
5348
if (cancellationToken.IsCancellationRequested)
5449
{
@@ -95,11 +90,6 @@ await _symbolsService.FindParameterSetsInFileAsync(
9590
};
9691
}
9792

98-
public void SetCapability(SignatureHelpCapability capability)
99-
{
100-
_capability = capability;
101-
}
102-
10393
private static ParameterInformation CreateParameterInfo(ParameterInfo parameterInfo)
10494
{
10595
return new ParameterInformation

0 commit comments

Comments
 (0)