Document "method lacks 'await'" warnings

andyleejordan · andyleejordan · commit 2762feab9ec2 · 2021-03-24T16:38:23.000-07:00
diff --git a/src/PowerShellEditorServices/Server/PsesLanguageServer.cs b/src/PowerShellEditorServices/Server/PsesLanguageServer.cs
@@ -94,6 +94,7 @@ public async Task StartAsync()
                     .WithHandler<ExpandAliasHandler>()
                     .WithHandler<PsesSemanticTokensHandler>()
                     .OnInitialize(
+                        // TODO: Either fix or ignore "method lacks 'await'" warning.
                         async (languageServer, request, cancellationToken) =>
                         {
                             var serviceProvider = languageServer.Services;
diff --git a/src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs b/src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs
@@ -39,6 +39,7 @@ public PsesCodeActionHandler(ILoggerFactory factory, AnalysisService analysisSer
             CodeActionKinds = new CodeActionKind[] { CodeActionKind.QuickFix }
         };
 
+        // TODO: Either fix or ignore "method lacks 'await'" warning.
         public override async Task<CodeAction> Handle(CodeAction request, CancellationToken cancellationToken)
         {
             // TODO: How on earth do we handle a CodeAction? This is new...

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ public async Task StartAsync()`
`94`	`94`	`.WithHandler<ExpandAliasHandler>()`
`95`	`95`	`.WithHandler<PsesSemanticTokensHandler>()`
`96`	`96`	`.OnInitialize(`
	`97`	`+ // TODO: Either fix or ignore "method lacks 'await'" warning.`
`97`	`98`	`async (languageServer, request, cancellationToken) =>`
`98`	`99`	`{`
`99`	`100`	`var serviceProvider = languageServer.Services;`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ public PsesCodeActionHandler(ILoggerFactory factory, AnalysisService analysisSer`
`39`	`39`	`CodeActionKinds = new CodeActionKind[] { CodeActionKind.QuickFix }`
`40`	`40`	`};`
`41`	`41`
	`42`	`+ // TODO: Either fix or ignore "method lacks 'await'" warning.`
`42`	`43`	`public override async Task<CodeAction> Handle(CodeAction request, CancellationToken cancellationToken)`
`43`	`44`	`{`
`44`	`45`	`// TODO: How on earth do we handle a CodeAction? This is new...`