If no path is found or when using the -ScriptDefinition parameter set, default to the current location for the directory search of the implicit settings file (#979)

* If no path is found or when using the -ScriptDefinition parameter set, default to the current location for the directory search of the implicit settings file

* add test case

* fix test so that it would actually fail if the bug got re-introduced

Author: bergmeister

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -291,7 +291,7 @@ protected override void BeginProcessing()
             {
                 var settingsObj = PSSASettings.Create(
                     settings,
-                    processedPaths == null || processedPaths.Count == 0 ? null : processedPaths[0],
+                    processedPaths == null || processedPaths.Count == 0 ? CurrentProviderLocation("FileSystem").ProviderPath : processedPaths[0],
                     this,
                     GetResolvedProviderPathFromPSPath);
                 if (settingsObj != null)

Tests/Engine/Settings.tests.ps1

@@ -14,12 +14,21 @@ Describe "Settings Precedence" {
     }
 
     Context "settings file is implicit" {
-        It "runs rules from the implicit setting file" {
+        It "runs rules from the implicit setting file using the -Path parameter set" {
             $violations = Invoke-ScriptAnalyzer -Path $project1Root -Recurse
             $violations.Count | Should -Be 1
             $violations[0].RuleName | Should -Be "PSAvoidUsingCmdletAliases"
         }
 
+        It "runs rules from the implicit setting file using the -ScriptDefinition parameter set" {
+            Push-Location $project1Root
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition 'gci; Write-Host' -Recurse
+            Pop-Location
+            $violations.Count | Should -Be 1
+            $violations[0].RuleName | Should -Be "PSAvoidUsingCmdletAliases" `
+                -Because 'the implicit settings file should have run only the PSAvoidUsingCmdletAliases rule but not PSAvoidUsingWriteHost'
+        }
+
         It "cannot find file if not named PSScriptAnalyzerSettings.psd1" {
             $violations = Invoke-ScriptAnalyzer -Path $project2Root -Recurse
             $violations.Count | Should -Be 2