Skip to content

Commit 6222e40

Browse files
authored
change release build to be more specific with regard to the assemblies to check with binskim (#1703)
* Binskim should only check the assemblies we provide as part of analyzer * add pluralize.net.dll to assemblies that need 3rd party signing. * be sure to include minimatch option
1 parent d1942a1 commit 6222e40

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.ci/releaseBuild.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,12 @@ stages:
129129
# the certificate ID to use
130130
# we'll need to change this to the 3rd party cert id
131131
certificateId: "CP-231522"
132-
# the file pattern to use - only sign newtonsoft
133-
pattern: 'Newtonsoft*.dll'
132+
# use minimatch because we need to exclude the NewtonSoft assembly
133+
useMinimatch: true
134+
# the file pattern to use - only sign newtonsoft and pluralize
135+
pattern: |
136+
**/Pluralize*.dll
137+
**/Newtonsoft*.dll
134138
135139
# now create the nupkg which we will use to publish the module
136140
# to the powershell gallery (not part of this yaml)
@@ -173,7 +177,7 @@ stages:
173177
# component-governance - the path to sources
174178
sourceScanPath: '$(Build.SourcesDirectory)/OSS_Microsoft_PSSA'
175179
# binskim - this isn't recursive, so you need the path to the assemblies
176-
AnalyzeTarget: '$(Pipeline.Workspace)\build\bin\PSV7Release\netcoreapp3.1\*.dll'
180+
AnalyzeTarget: '$(Pipeline.Workspace)\build\bin\PSV7Release\netcoreapp3.1\Microsoft.Windows.PowerShell.ScriptAnalyzer*.dll'
177181
# credscan - scan the repo for credentials
178182
# you can suppress some files with this.
179183
suppressionsFile: '$(Build.SourcesDirectory)/OSS_Microsoft_PSSA/tools/ReleaseBuild/CredScan.Suppressions.json'

0 commit comments

Comments
 (0)