fix: Fix issue where configured non-loopback addresses become invalid due to DNS rebinding protection. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otection Previously, the DNS rebinding protection only allowed localhost and 127.0.0.1, which prevented the plugin from working when a non-loopback address was configured in the host setting. Changes: - Updated isValidOrigin(), isValidHost(), and isValidReferer() to accept the configured host address as an allowed host - Added configured host to CORS allowHost list when it's not localhost/127.0.0.1 - All validation functions now check against the configured host in addition to the default loopback addresses This fix ensures that when users configure a non-loopback address (e.g., 0.0.0.0 or a specific IP), requests from that address will pass validation while maintaining protection against DNS rebinding attacks.
Airis101
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the DNS rebinding protection only allowed localhost and 127.0.0.1, which prevented the plugin from working when a non-loopback address was configured in the host setting.
Changes:
This fix ensures that when users configure a non-loopback address (e.g., 0.0.0.0 or a specific IP), requests from that address will pass validation while maintaining protection against DNS rebinding attacks.
Before: DNS Rebinding Protection Restriction
After: Enhanced Validation with Configured Host Support
