Skip to content

5.24 and earlier don’t have .git/ ? #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FGasper opened this issue Apr 9, 2021 · 6 comments
Closed

5.24 and earlier don’t have .git/ ? #18

FGasper opened this issue Apr 9, 2021 · 6 comments

Comments

@FGasper
Copy link

FGasper commented Apr 9, 2021

https://github.com/FGasper/p5-TOML-XS/actions/runs/731758471

^ If you look at the failures here, they all fail because there’s no .git/ directory.

5.26:
image
https://github.com/FGasper/p5-TOML-XS/runs/2302718045?check_suite_focus=true

5.24:
image
https://github.com/FGasper/p5-TOML-XS/runs/2302718053?check_suite_focus=true

Is this an intentional difference between the images?

Thank you!

@oalders
Copy link
Collaborator

oalders commented Apr 10, 2021

It looks like the checkout action doesn't like the version of git that it's finding.

https://github.com/FGasper/p5-TOML-XS/runs/2302718053?check_suite_focus=true#step:3:25

Not quite sure what's going on there, since they all use the same base Ubuntu.

@FGasper
Copy link
Author

FGasper commented Apr 10, 2021

Weird. Yeah, even when I put apt upgrade git as the first action it says 2.11 is already the latest available git.

@FGasper
Copy link
Author

FGasper commented Apr 10, 2021

Actually the 5.24 ones report being on stretch; 5.26 report buster. @oalders

@FGasper
Copy link
Author

FGasper commented Apr 10, 2021

@atoomic
Copy link
Member

atoomic commented Apr 10, 2021

The checkout action cannot find git >= 2.18 and so use the API to download a tarball
this why you have no .git set...

You would have to initialize the git repo and set the submodule if needed manually
if you cannot update to 2.18

https://github.com/FGasper/p5-TOML-XS/runs/2313744629?check_suite_focus=true#step:6:25

Deleting the contents of '/__w/p5-TOML-XS/p5-TOML-XS'
The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

@atoomic
Copy link
Member

atoomic commented Apr 10, 2021

IMO this is not an issue with the image but the way git checkout action works...
@FGasper I am going to close this case as this is not related to the images themselves but to the version of git available from the distro.

We probably want to rebuild the images with a more modern git binary... I guess that GitHub does not use older version of git due to CVEs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants