msglist: Mostly translate remaining strings on message list page

PIG208 · PIG208 · commit c774dba557ed · 2025-01-15T22:49:44.000+08:00
Ideally we should implement zulip#1080 for DMs title, but we might switch to showing avatars as the TODO indicated before we work on lists' proper translation. Signed-off-by: Zixuan James Li <zixuan@zulip.com>
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -355,6 +355,13 @@
       "others": {"type": "String", "example": "Alice, Bob"}
     }
   },
+  "messageListDMsWithOthers": "DMs with {others}",
+  "@messageListDMsWithOthers": {
+    "description": "Message list page title for a DM group with others.",
+    "placeholders": {
+      "others": {"type": "String", "example": "Alice, Bob"}
+    }
+  },
   "messageListGroupYouWithYourself": "You with yourself",
   "@messageListGroupYouWithYourself": {
     "description": "Message list recipient header for a DM group that only includes yourself."
@@ -716,5 +723,13 @@
   "videoDurationLabel": "Video duration",
   "@videoDurationLabel": {
     "description": "The total duration of the video."
+  },
+  "noEarlierMessages": "No earlier messages",
+  "@noEarlierMessages": {
+    "description": "Text to show at the start of a message list if there is no earlier messages."
+  },
+  "scrollToBottomTooltip": "Scroll to bottom",
+  "@scrollToBottomTooltip": {
+    "description": "Tooltip for button to scroll to bottom."
   }
 }
diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -573,6 +573,12 @@ abstract class ZulipLocalizations {
   /// **'You and {others}'**
   String messageListGroupYouAndOthers(String others);
 
+  /// Message list page title for a DM group with others.
+  ///
+  /// In en, this message translates to:
+  /// **'DMs with {others}'**
+  String messageListDMsWithOthers(String others);
+
   /// Message list recipient header for a DM group that only includes yourself.
   ///
   /// In en, this message translates to:
@@ -1064,6 +1070,18 @@ abstract class ZulipLocalizations {
   /// In en, this message translates to:
   /// **'Video duration'**
   String get videoDurationLabel;
+
+  /// Text to show at the start of a message list if there is no earlier messages.
+  ///
+  /// In en, this message translates to:
+  /// **'No earlier messages'**
+  String get noEarlierMessages;
+
+  /// Tooltip for button to scroll to bottom.
+  ///
+  /// In en, this message translates to:
+  /// **'Scroll to bottom'**
+  String get scrollToBottomTooltip;
 }
 
 class _ZulipLocalizationsDelegate extends LocalizationsDelegate<ZulipLocalizations> {
diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
     return 'You and $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'You with yourself';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
     return 'You and $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'You with yourself';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
     return 'You and $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'You with yourself';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/generated/l10n/zulip_localizations_nb.dart b/lib/generated/l10n/zulip_localizations_nb.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
     return 'You and $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'You with yourself';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
     return 'Ty i $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'Ty ze sobą';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -280,6 +280,11 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
     return 'You and $others';
   }
 
+  @override
+  String messageListDMsWithOthers(String others) {
+    return 'DMs with $others';
+  }
+
   @override
   String get messageListGroupYouWithYourself => 'You with yourself';
 
@@ -563,4 +568,10 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
 
   @override
   String get videoDurationLabel => 'Video duration';
+
+  @override
+  String get noEarlierMessages => 'No earlier messages';
+
+  @override
+  String get scrollToBottomTooltip => 'Scroll to bottom';
 }
diff --git a/lib/widgets/message_list.dart b/lib/widgets/message_list.dart
@@ -426,7 +426,9 @@ class MessageListAppBarTitle extends StatelessWidget {
         } else {
           final names = otherRecipientIds.map(
             (id) => store.users[id]?.fullName ?? zulipLocalizations.unknownUserName);
-          return Text("DMs with ${names.join(", ")}"); // TODO show avatars
+          // TODO show avatars
+          return Text(
+            zulipLocalizations.messageListDMsWithOthers(names.join(', ')));
         }
     }
   }
@@ -567,6 +569,7 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
   Widget _buildListView(BuildContext context) {
     final length = model!.items.length;
     const centerSliverKey = ValueKey('center sliver');
+    final zulipLocalizations = ZulipLocalizations.of(context);
 
     Widget sliver = SliverStickyHeaderList(
       headerPlacement: HeaderPlacement.scrollingStart,
@@ -603,7 +606,7 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
           if (i == 2) return TypingStatusWidget(narrow: widget.narrow);
 
           final data = model!.items[length - 1 - (i - 3)];
-          return _buildItem(data, i);
+          return _buildItem(zulipLocalizations, data, i);
         }));
 
     if (!ComposeBox.hasComposeBox(widget.narrow)) {
@@ -639,13 +642,13 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
       ]);
   }
 
-  Widget _buildItem(MessageListItem data, int i) {
+  Widget _buildItem(ZulipLocalizations zulipLocalizations, MessageListItem data, int i) {
     switch (data) {
       case MessageListHistoryStartItem():
-        return const Center(
+        return Center(
           child: Padding(
-            padding: EdgeInsets.symmetric(vertical: 16.0),
-            child: Text("No earlier messages."))); // TODO use an icon
+            padding: const EdgeInsets.symmetric(vertical: 16.0),
+            child: Text(zulipLocalizations.noEarlierMessages))); // TODO use an icon
       case MessageListLoadingItem():
         return const Center(
           child: Padding(
@@ -689,14 +692,15 @@ class ScrollToBottomButton extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     return ValueListenableBuilder<bool>(
       valueListenable: visibleValue,
       builder: (BuildContext context, bool value, Widget? child) {
         return (value && child != null) ? child : const SizedBox.shrink();
       },
       // TODO: fix hardcoded values for size and style here
       child: IconButton(
-        tooltip: "Scroll to bottom",
+        tooltip: zulipLocalizations.scrollToBottomTooltip,
         icon: const Icon(Icons.expand_circle_down_rounded),
         iconSize: 40,
         // Web has the same color in light and dark mode.
