Skip to content

Commit 5d975a3

Browse files
janeli-100005636499545Othinn
authored andcommitted
Fix flickering (facebook#41461)
Summary: Pull Request resolved: facebook#41461 D51179007 updated the layout spec so that we wouldn't have the weird spacing. However, it introduced some weird flickering through the app. Upon investigating in layout inspector, I found that the issue actually isn't the rn_fragment, it's the rootview being created without the proper specs. This updates the ReactNavigationFragment so that the root view gets the correct specs, similar to how it's done here: https://www.internalfb.com/code/fbsource/[80683c89da108bba70bfe60340f80c6613960119]/fbandroid/java/com/facebook/fbreact/navigation/ReactNavigationActivityDelegate.java?lines=109 [changelog] internal Reviewed By: jessebwr Differential Revision: D51267353 fbshipit-source-id: 6deb5f29e8a73d9cf38cb9445d69ab041b974ec8
1 parent 307f66b commit 5d975a3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class ReactFragment extends Fragment implements PermissionAwareActivity {
3030
protected static final String ARG_LAUNCH_OPTIONS = "arg_launch_options";
3131
protected static final String ARG_FABRIC_ENABLED = "arg_fabric_enabled";
3232

33-
private ReactDelegate mReactDelegate;
33+
protected ReactDelegate mReactDelegate;
3434

3535
@Nullable private PermissionListener mPermissionListener;
3636

0 commit comments

Comments
 (0)