Skip to content

Commit b92bfab

Browse files
committed
Improve error handling for missing JWT configuration
1 parent c578b10 commit b92bfab

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/Core/Services/TokenService.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ public TokenService(IConfiguration configuration)
2020
public string GenerateToken(User user)
2121
{
2222
IConfigurationSection jwtSettings = _configuration.GetSection("JwtSettings");
23-
2423
SymmetricSecurityKey key = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(jwtSettings["Key"]!));
2524
SigningCredentials credentials = new SigningCredentials(key, SecurityAlgorithms.HmacSha256);
2625

@@ -34,10 +33,16 @@ public string GenerateToken(User user)
3433
claims.Add(new Claim(ClaimTypes.Role, user.Role.Name));
3534
}
3635

36+
string? expiryMinutes = jwtSettings["ExpiryMinutes"];
37+
if (string.IsNullOrEmpty(expiryMinutes) || !double.TryParse(expiryMinutes, out double minutes))
38+
{
39+
throw new InvalidOperationException("JWT ExpiryMinutes is not properly configured");
40+
}
41+
3742
SecurityTokenDescriptor tokenDescriptor = new SecurityTokenDescriptor
3843
{
3944
Subject = new ClaimsIdentity(claims),
40-
Expires = DateTime.UtcNow.AddMinutes(Convert.ToDouble(jwtSettings["ExpiryMinutes"]!)),
45+
Expires = DateTime.UtcNow.AddMinutes(minutes),
4146
Issuer = jwtSettings["Issuer"],
4247
Audience = jwtSettings["Audience"],
4348
SigningCredentials = credentials

0 commit comments

Comments
 (0)