Fix file delete of customer attribute

[kiatng]

[edit] This bug affects file deletion of cusotmer attribute in both frontend and backend. It was introduced in ver 1.9.4.1:

        if (!$attribute->isAttributeValidationPassed()) {
            return $this;
        }

in the class Mage_Eav_Model_Attribute_Data_File.

[tmotyl]

Hi
Please provide a detailed description of the issue, how to reproduce it and what would you expect to happen.

[kiatng]

[edited]

To reproduce in the ver 1.9.4.x

1. Execute the MySQL statements below to add a cutomer attribute with attribute_code = 'some_csv'.
2. Render the attribute in backend customer page. See sample code at the bottom.
3. Login to backend and navigate to the customer page, upload a file to Some CSV File and press Save and Continue Edit, ensure the file is uploaded.
4. Select the Delete checkbox and press Save and Continue Edit; we expect file to be deleted, but it is still there

The reason it doesn't delete is because $attribute->isAttributeValidationPassed() is false.

Step 1, add attribute some_csv.

INSERT INTO `eav_attribute` (`attribute_id`, `entity_type_id`, `attribute_code`, `attribute_model`, `backend_model`, `backend_type`, `backend_table`, `frontend_model`, `frontend_input`, `frontend_label`, `frontend_class`, `source_model`, `is_required`, `is_user_defined`, `default_value`, `is_unique`, `note`) 
VALUES (NULL, '1', 'some_csv', NULL, NULL, 'varchar', NULL, NULL, 'file', 'Some CSV File', NULL, NULL, '0', '1', NULL, '0', 'Accept CSV only'); 

# Note the attribute_id from above
INSERT INTO `customer_eav_attribute` (`attribute_id`, `is_visible`, `input_filter`, `multiline_count`, `validate_rules`, `is_system`, `sort_order`, `data_model`) 
VALUES ({{attribute_id}}, '1', NULL, '1', 'a:1:{s:13:\"max_file_size\";i:2000000;}', '0', '4', 'customer/attribute_data_file') 

INSERT INTO `customer_form_attribute` (`form_code`, `attribute_id`) 
VALUES ('adminhtml_customer', {{attribute_id}})

Step 2, render the attribute in backend's customer page:

//  copy paste the following code in line 279 app\code\core\Mage\Adminhtml\Block\Customer\Edit\Tab\Account.php
$fieldset->addField('some_csv', 'file',
    array(
        'name'      => 'some_csv',
        'label'     => 'Some CSV File'
    )
);

[kiatng]

To trace the logic, please expand to code below to show the function compactValue, where the delete operation is carried out.

[github-actions]

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit 7a039a6.