PHPCS: ignore mcrypt related warnings
#4147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164
This reverts commit 3d7eaf6.
sreichel
changed the title
mcrypt related warningsmcrypt related warnings
kiatng
approved these changes
Aug 9, 2024
addison74
approved these changes
Aug 9, 2024
Contributor
|
Is there a case to be made here to keep the mcrypt code at all? |
Contributor
Author
|
It may be used by old extensions? |
Contributor
|
No hard objections here - just wondering if we keep this code around forever or make a plan to remove at some point. Initially I had thought other projects were removing it completely, but upon second look they are keeping it around as well (e.g. Joomla) for legacy support. LGTM. |
mattdavenport
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/OpenMage/magento-lts/actions/runs/10293142342/job/28488897656
Ignore all
mcryptrelated warnings b/c we use https://github.com/phpseclib/phpseclib.Todo: (another PR)
Fix all other errors an do NOT continue on failure.