Skip to content

Conversation

@justinbeaty
Copy link
Contributor

@justinbeaty justinbeaty commented Jun 9, 2023

Description (*)

PR #2473 upgraded ExtJS from 1.0.1 to 1.1.1, but there was a breaking change in that library. So, the extjs-tree-checkbox.js file needed to be updated. The checkbox tree file was not part of ExtJS, but a plugin that somebody wrote and included into Magento. Luckily, the author wrote a comment with the fix.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes ownerTree.container is undefined for product categories #3312

Manual testing scenarios (*)

  1. Go to Products > Any Product > Categories, at store view level
  2. Should see no errors

Questions or comments

We have an alternate solution:

var targetNode = 
    n.parentNode ? n.parentNode.ui.getContainer() : 
    (n.ownerTree.container ? n.ownerTree.container.dom : n.ownerTree.innerCt.dom);

But I don't think it's necessary, since ExtJS renamed container -> innerCt. The above would only be necessary if we need to support someone who is still using ExtJS 1.0.1.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the JavaScript Relates to js/* label Jun 9, 2023
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@fballiano fballiano merged commit f9a6159 into OpenMage:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScript Relates to js/*

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ownerTree.container is undefined for product categories

3 participants