Skip to content

Conversation

@midlan
Copy link
Contributor

@midlan midlan commented Feb 5, 2021

Description (*)

I spotted lib/Zend/Queue/Adapter/Db/postgresql.sql is using CRLF line ending. I am assuming we are using LF only. There may be more such files, I didn't check whole repository.

Related Pull Requests

Manual testing scenarios (*)

not relevant for this PR

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@midlan
Copy link
Contributor Author

midlan commented Feb 16, 2021

It can be easily checked that nothing changed by using w=1 when looking to changed files:
https://github.com/OpenMage/magento-lts/pull/1450/files?diff=unified&w=1

@Flyingmana Flyingmana merged commit 6ab0b92 into OpenMage:1.9.4.x Mar 27, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6ab0b92. ± Comparison against base commit 2310733.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: lib/* Relates to lib/*

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants