Skip to content

Windows Installer: Update Some Install Paths #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayewo opened this issue Jul 31, 2023 · 0 comments
Open

Windows Installer: Update Some Install Paths #447

ayewo opened this issue Jul 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ayewo
Copy link

ayewo commented Jul 31, 2023

Feature request

Installer Design for Windows

Before the installer script installs OpenAdapt, it first runs checks for 3 dependencies in the following order:

  • Tesseract
  • Python
  • Git
Program Current Path Proposed Path Remark
Tesseract C:\Program Files\Tesseract-OCR C:\Program Files\Tesseract-OCR No change
Python1 C:\Users\<user>\AppData\Local\Programs\Python\Python310 C:\Users\<user>\AppData\Local\Programs\Python\Python310
Git C:\Program Files\Git\ C:\Program Files\Git\ No change
OpenAdapt C:\OpenAdaptSetup\OpenAdapt C:\Users\<user>\OpenAdapt Changed

The installer script already expects to be executed with Admin privileges but the 'InstallAllUsers=0' option used to install Python will put it under C:\Users\$user\%LocalAppData% for the logged in user, unlike the other dependencies where the install path is global -- for all users.

I experimented with the option to install Python for all users to C:\Program Files\Python310 by setting 'InstallAllUsers=1' and everything worked fine until it got to the poetry install step where the script failed with a path-related error so I changed it back to 'InstallAllUsers=0'.

Thoughts?

Motivation

This will hopefully make it easier to write an uninstall.ps1 script that will leave the system in the state it was prior to the execution of installer.ps1.

Footnotes

  1. The default path is C:\Users\<user>\%LocalAppData% which usually expands to C:\Users\<user>\AppData\Local\Programs\Python\Python310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant