jeklly-serve image should not use latest tag

[OldFarmer86]

the Dockerfile:

FROM bretfisher/jekyll-serve

WORKDIR /site

# install dependencies
COPY Gemfile Gemfile.lock ./
RUN bundle install

# install the site
COPY . .

EXPOSE 4000
CMD [ "bundle", "exec", "jekyll", "serve", "--host", "0.0.0.0" ]

and I can't build docker image with bretfisher/jekyll-serve:latest:

 ---> 8bb42e818e85
Step 2/7 : WORKDIR /site
 ---> Running in c2b9ff67bc64
Removing intermediate container c2b9ff67bc64
 ---> 70ee1a2a7607
Step 3/7 : COPY Gemfile Gemfile.lock ./
 ---> 40bb084771ad
Step 4/7 : RUN bundle install
 ---> Running in 731e754f9b57
Bundler 2.5.18 is running, but your lockfile was generated with 2.5.10. Installing Bundler 2.5.10 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.5.10
Installing bundler 2.5.10
Fetching gem metadata from https://rubygems.org/..........
Fetching public_suffix 5.0.1
Fetching ffi 1.15.5
Fetching google-protobuf 3.22.2
Fetching rouge 3.30.0
Fetching concurrent-ruby 1.2.2
Fetching rubyzip 2.3.2
Fetching unicode-display_width 2.4.2
Installing public_suffix 5.0.1
Fetching addressable 2.8.1
Installing unicode-display_width 2.4.2
Installing rouge 3.30.0
Installing ffi 1.15.5 with native extensions
Installing google-protobuf 3.22.2 with native extensions
Installing rubyzip 2.3.2
Installing concurrent-ruby 1.2.2
Fetching i18n 1.12.0
Installing addressable 2.8.1
Installing i18n 1.12.0
Fetching rb-inotify 0.10.1
Fetching sass-embedded 1.58.3
Installing rb-inotify 0.10.1
Fetching listen 3.8.0
Installing sass-embedded 1.58.3 with native extensions
Installing listen 3.8.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /usr/local/bundle/gems/sass-embedded-1.58.3/ext/sass
/usr/local/bin/ruby -rrubygems
/usr/local/lib/ruby/gems/3.1.0/gems/rake-13.0.6/exe/rake
RUBYARCHDIR\=/usr/local/bundle/extensions/x86_64-linux/3.1.0/sass-embedded-1.58.3
RUBYLIBDIR\=/usr/local/bundle/extensions/x86_64-linux/3.1.0/sass-embedded-1.58.3
rake aborted!
NameError: uninitialized constant FileUtils::URI

    unless source_uri.is_a?(URI::Generic)
                            ^^^
/usr/local/bundle/gems/sass-embedded-1.58.3/ext/sass/Rakefile:141:in `fetch'
/usr/local/bundle/gems/sass-embedded-1.58.3/ext/sass/Rakefile:21:in `block in
<top (required)>'
Tasks: TOP => default => install => embedded.rb => sass_embedded
(See full trace by running task with --trace)

rake failed, exit code 1

Gem files will remain installed in /usr/local/bundle/gems/sass-embedded-1.58.3
for inspection.
Results logged to
/usr/local/bundle/extensions/x86_64-linux/3.1.0/sass-embedded-1.58.3/gem_make.out

  /usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/builder.rb:125:in `run'
  /usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/rake_builder.rb:30:in `build'
/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/builder.rb:193:in
`build_extension'
/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/builder.rb:227:in `block in
build_extensions'
  /usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/builder.rb:224:in `each'
/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/ext/builder.rb:224:in
`build_extensions'
/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/installer.rb:853:in
`build_extensions'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/rubygems_gem_installer.rb:76:in
`build_extensions'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/rubygems_gem_installer.rb:28:in
`install'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/source/rubygems.rb:205:in
`install'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/installer/gem_installer.rb:54:in
`install'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/installer/gem_installer.rb:16:in
`install_from_spec'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/installer/parallel_installer.rb:132:in
`do_install'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/installer/parallel_installer.rb:123:in
`block in worker_pool'
  /usr/local/bundle/gems/bundler-2.5.10/lib/bundler/worker.rb:62:in `apply_func'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/worker.rb:57:in `block in
process_queue'
  /usr/local/bundle/gems/bundler-2.5.10/lib/bundler/worker.rb:54:in `loop'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/worker.rb:54:in
`process_queue'
/usr/local/bundle/gems/bundler-2.5.10/lib/bundler/worker.rb:90:in `block (2
levels) in create_threads'

An error occurred while installing sass-embedded (1.58.3), and Bundler cannot
continue.

In Gemfile:
  jekyll-include-cache was resolved to 0.2.1, which depends on
    jekyll was resolved to 4.3.2, which depends on
      jekyll-sass-converter was resolved to 3.0.0, which depends on
        sass-embedded
The command '/bin/sh -c bundle install' returned a non-zero code: 5

[ralfhandl]

Wrong repository?

[handrews]

@ralfhandl we do have a Dockerfile on the gh-pages branch, and the file quoted above looks correct.

@OldFarmer86 The person who created that Dockerfile is no longer active with the project. If you have the knowledge to fix this a PR would be welcome. I don't know if we have anyone all that familiar with Docker right now (or Ruby infrastructure).

[ralfhandl]

@handrews If we don't know how to fix it we should delete it.

Instructions for testing the site locally are in the README.

[baywet]

Some additional context from the meeting:

• here is the dockerfile we're talking about
• nobody seems to be using it at the moment?
• the version used at the time might be this one or a close peer.
• the current readme instructions offer live reload on save which the image does not because of this instruction
• one should be able to just run the source (or any other equivalent) image with something like this docker run bretfisher/jekyll-serve:tag --rm -it .... without needing the dockerfile.

Decision from the meeting: we'll remove the dockerfile to reduce maintenance burden.

[lornajane]

Thanks @ralfhandl for deleting the file. I've merged that pull request and I'll close this issue but I'd like to note that if there's a need for a Dockerfile (and someone can get it to work), then that pull request would be very welcome and would get a review.