Skip to content

Anchor Links in the spec do not work anymore #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cebe opened this issue Oct 25, 2018 · 15 comments
Closed

Anchor Links in the spec do not work anymore #1726

cebe opened this issue Oct 25, 2018 · 15 comments

Comments

@cebe
Copy link
Contributor

cebe commented Oct 25, 2018

Seems github filters the <a name="..."> tags...

@MikeRalphson
Copy link
Member

Thanks for the report. We're looking into it.

@cebe
Copy link
Contributor Author

cebe commented Oct 25, 2018

As I am very sure that this has been working fine before it might be worth contacting github support and ask to revert the change or otherwise fix it.

@Gi60s
Copy link

Gi60s commented Oct 25, 2018

It's not all links, just any links that have multiple words. For example:

Works: #schema
Does not work: #infoObject

One way to fix is to update the multi-word links to use dashes instead of camel case. For example, convert #infoObject to #info-object and links will start working again.

I'm not sure why Github ever supported camel case links. I've haven't seen another markdown to HTML converter support that.

@MikeRalphson
Copy link
Member

Yes, it looks like we may have been relying on some very old compatibility behaviour.

@cebe
Copy link
Contributor Author

cebe commented Oct 25, 2018

With dashes are the links that are automatically generated by github. camelCase are anchors added in the spec markdown. If you render the spec outside of github links would be working. The filtering done here is specific to github.

@MikeRalphson
Copy link
Member

Also affects READMEs, reported on #1734

@cebe
Copy link
Contributor Author

cebe commented Nov 1, 2018

I have contacted github support about this. Will post here when I have an answer.

@cebe
Copy link
Contributor Author

cebe commented Nov 7, 2018

Looks like they fixed it. It's working again for me. Close the issue if you confirm.

@MikeRalphson
Copy link
Member

Thanks @cebe I'm still seeing the problem, but it may be a cacheing issue.

@Gi60s
Copy link

Gi60s commented Nov 7, 2018

It doesn't work for me yet. Tried on two browsers and even disabled cache.

@ramsey
Copy link

ramsey commented Nov 8, 2018

It's still not working for me. Maybe it's cached at an edge location somewhere?

@shockey
Copy link

shockey commented Nov 12, 2018

Still broken for me - I did the browser/cache dance as well 😕

@webron
Copy link
Member

webron commented Nov 12, 2018

I'm also in touch with GitHub's support about it, will update when I know more.

@cebe
Copy link
Contributor Author

cebe commented Nov 14, 2018

Got a reply from github support today:

Hey Carsten,

Our Engineering Team shipped a fix for those anchor links.

Please let us know if you have any further trouble with it.
[...]

@webron
Copy link
Member

webron commented Nov 14, 2018

Thanks, @cebe - got the same reply. Let the anchor-following resume!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants