Skip to content

Commit bf9155d

Browse files
authored
Merge pull request #4311 from ralfhandl/dev-validate-markdown-in-build-src
2 parents e8a0d07 + cde67e1 commit bf9155d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,10 @@ To do this locally, please
171171
1. Install [Node.js](https://nodejs.org/)
172172
2. Check out this repo, go to the repo root, and switch to a development branch
173173
3. Execute `npm install` (once, repeat after merging upstream changes)
174-
4. Execute `npm run build-src` after changing `src/oas.md`
175-
5. Open output file `deploy-preview/oas.html` with a browser
174+
4. Execute `npm run build-src` after changing `src/oas.md` (this first executes `npm run validate-markdown`, which can also be run separately)
175+
5. Open output file `deploy-preview/oas.html` with a browser and check your changes
176176

177-
Before creating a pull request or marking a draft pull request as ready for review, please
178-
179-
6. Execute `npm run validate-markdown` and fix any reported problems in `src/oas.md`
177+
Please make sure the markdown validates and builds using the above steps before creating a pull request or marking a draft pull request as ready for review.
180178

181179
## Reviewers
182180

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"license": "Apache-2.0",
1515
"scripts": {
1616
"build": "bash ./scripts/md2html/build.sh",
17-
"build-src": "bash ./scripts/md2html/build-src.sh",
17+
"build-src": "npm run validate-markdown && bash ./scripts/md2html/build-src.sh",
1818
"test": "c8 --100 vitest --watch=false && bash scripts/schema-test-coverage.sh",
1919
"validate-markdown": "npx mdv src/oas.md && npx markdownlint-cli src/oas.md"
2020
},

0 commit comments

Comments
 (0)