From a38281a984c9b33dd28847bdfefa8987f759238d Mon Sep 17 00:00:00 2001 From: endarova Date: Thu, 15 Aug 2019 11:01:42 +0300 Subject: [PATCH 1/2] skip failing test on windows --- tests/cli/run/templates/master_detail_ng_tests.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/cli/run/templates/master_detail_ng_tests.py b/tests/cli/run/templates/master_detail_ng_tests.py index 54c20b1c..0b51a881 100644 --- a/tests/cli/run/templates/master_detail_ng_tests.py +++ b/tests/cli/run/templates/master_detail_ng_tests.py @@ -45,6 +45,8 @@ def test_100_run_android(self): def test_100_run_ios(self): sync_master_detail_ng(self.app_name, Platform.IOS, self.sim) + @unittest.skipIf(Settings.HOST_OS == OSType.WINDOWS, 'temporary skip on windows') + #TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed def test_300_run_android_bundle_aot(self): sync_master_detail_ng(self.app_name, Platform.ANDROID, self.emu, aot=True) @@ -59,6 +61,8 @@ def test_310_run_android_bundle_uglify(self): def test_310_run_ios_bundle_uglify(self): sync_master_detail_ng(self.app_name, Platform.IOS, self.sim, uglify=True) + @unittest.skipIf(Settings.HOST_OS == OSType.WINDOWS, 'temporary skip on windows') + #TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed def test_320_run_android_bundle_aot_and_uglify(self): sync_master_detail_ng(self.app_name, Platform.ANDROID, self.emu, aot=True, uglify=True) From 264ae61b913804390b61048a4d134689c3d9ac9d Mon Sep 17 00:00:00 2001 From: endarova Date: Thu, 15 Aug 2019 11:08:59 +0300 Subject: [PATCH 2/2] fix linter --- tests/cli/run/templates/master_detail_ng_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cli/run/templates/master_detail_ng_tests.py b/tests/cli/run/templates/master_detail_ng_tests.py index 0b51a881..02ed8024 100644 --- a/tests/cli/run/templates/master_detail_ng_tests.py +++ b/tests/cli/run/templates/master_detail_ng_tests.py @@ -46,7 +46,7 @@ def test_100_run_ios(self): sync_master_detail_ng(self.app_name, Platform.IOS, self.sim) @unittest.skipIf(Settings.HOST_OS == OSType.WINDOWS, 'temporary skip on windows') - #TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed + # TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed def test_300_run_android_bundle_aot(self): sync_master_detail_ng(self.app_name, Platform.ANDROID, self.emu, aot=True) @@ -62,7 +62,7 @@ def test_310_run_ios_bundle_uglify(self): sync_master_detail_ng(self.app_name, Platform.IOS, self.sim, uglify=True) @unittest.skipIf(Settings.HOST_OS == OSType.WINDOWS, 'temporary skip on windows') - #TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed + # TODO: remove skip when https://github.com/NativeScript/nativescript-dev-webpack/issues/1021 fixed def test_320_run_android_bundle_aot_and_uglify(self): sync_master_detail_ng(self.app_name, Platform.ANDROID, self.emu, aot=True, uglify=True)