From dd117c627d4136dd18f0d154ce474cb2ff86fe55 Mon Sep 17 00:00:00 2001 From: Eduardo Speroni Date: Fri, 28 Apr 2023 17:01:52 -0300 Subject: [PATCH] fix: move TARGETED_DEVICE_FAMILY to xcconfig to allow override --- project-template/__PROJECT_NAME__.xcodeproj/project.pbxproj | 4 ---- project-template/internal/nativescript-build.xcconfig | 5 ++++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/project-template/__PROJECT_NAME__.xcodeproj/project.pbxproj b/project-template/__PROJECT_NAME__.xcodeproj/project.pbxproj index 7dd5713d..52ee9b95 100644 --- a/project-template/__PROJECT_NAME__.xcodeproj/project.pbxproj +++ b/project-template/__PROJECT_NAME__.xcodeproj/project.pbxproj @@ -349,7 +349,6 @@ SUPPORTS_UIKITFORMAC = YES; SWIFT_OBJC_BRIDGING_HEADER = "$SRCROOT/internal/Swift-ObjC-Bridging-Header.h"; SWIFT_VERSION = 4.2; - TARGETED_DEVICE_FAMILY = "1,2"; }; name = Debug; }; @@ -402,7 +401,6 @@ SUPPORTS_UIKITFORMAC = YES; SWIFT_OBJC_BRIDGING_HEADER = "$SRCROOT/internal/Swift-ObjC-Bridging-Header.h"; SWIFT_VERSION = 4.2; - TARGETED_DEVICE_FAMILY = "1,2"; VALIDATE_PRODUCT = YES; }; name = Release; @@ -432,7 +430,6 @@ "@executable_path/Frameworks", ); PRODUCT_NAME = __PROJECT_NAME__; - TARGETED_DEVICE_FAMILY = "1,2"; WRAPPER_EXTENSION = app; }; name = Debug; @@ -458,7 +455,6 @@ "@executable_path/Frameworks", ); PRODUCT_NAME = __PROJECT_NAME__; - TARGETED_DEVICE_FAMILY = "1,2"; WRAPPER_EXTENSION = app; }; name = Release; diff --git a/project-template/internal/nativescript-build.xcconfig b/project-template/internal/nativescript-build.xcconfig index f105b64e..7edbea99 100644 --- a/project-template/internal/nativescript-build.xcconfig +++ b/project-template/internal/nativescript-build.xcconfig @@ -23,4 +23,7 @@ EXCLUDED_ARCHS_x86_64 = arm64 arm64e EXCLUDED_ARCHS[sdk=iphonesimulator*] = i386 armv6 armv7 armv7s armv8 $(EXCLUDED_ARCHS_$(NATIVE_ARCH_64_BIT)) EXCLUDED_ARCHS[sdk=iphoneos*] = i386 armv6 armv7 armv7s armv8 x86_64 EXCLUDED_ARCHS[sdk=macosx*] = i386 armv6 armv7 armv7s armv8 -VALIDATE_WORKSPACE = YES \ No newline at end of file +VALIDATE_WORKSPACE = YES + +// Default value (can be overriden by user's build.xcconfig) +TARGETED_DEVICE_FAMILY = "1,2";