Skip to content

Unique all instances of Metadata::TypeEncodingsList in metadata #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ivanbuhov opened this issue Jul 7, 2015 · 2 comments
Closed

Unique all instances of Metadata::TypeEncodingsList in metadata #216

ivanbuhov opened this issue Jul 7, 2015 · 2 comments
Assignees
@tdermendjiev
Labels
done severity: medium

Comments

@ivanbuhov
Copy link
Contributor

If all signature objects in metadata are uniqued we could decrease many calculations which happen per method call (offsets calculation of arguments, construction of ffi_cifs etc). Instead of per method call they will happen per method signature.
@ivanbuhov ivanbuhov mentioned this issue Jul 7, 2015
Merged
@fealebenpae
Copy link
Contributor

This can greatly simplify the way the runtime deals with type information from the API metadata. For example, it can help compact all the type caches in our TypeFactory. Alright, let's do it.

@tdermendjiev
Copy link
Contributor

As unifying ffi signatures in metadata-generator would lead to insufficient ffi metadata in ios-runtime only ffi_cif caching in FFICall initialization is implemented: #795

@tdermendjiev tdermendjiev added done and removed planned labels Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdermendjiev tdermendjiev

Labels
done severity: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fealebenpae @ivanbuhov @etabakov @pkoleva @tdermendjiev