fix: read navigation extras from the router navigation instead of using stored values #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
once @davecoffin validates this we can remove the draft status |
facetious
reviewed
Sep 15, 2022
facetious
reviewed
Sep 15, 2022
edusperoni
force-pushed
the
fix/nav-extras
branch
from
44f1bcf to
ac3d03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
We currently store the navigation options in the location strategy. This means that multiple navigations at the same time will override each other's navigation options;
What is the new behavior?
We now get the navigation extras from the current navigation stored in the router itself, which will always return the correct information for that navigation.