Skip to content

fix: add meta for TextBase and FormattedString #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Jan 2, 2023

PR Checklist

What is the current behavior?

We currently fallback to _addChildFromBuilder for spans

What is the new behavior?

We now implement a meta that correctly implements add/remove child spans

Fixes #65

@nx-cloud
Copy link

nx-cloud bot commented Jan 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 36fa290. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@edusperoni edusperoni merged commit 8413e8e into main Jan 3, 2023
@edusperoni edusperoni deleted the fix/span-order branch January 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ngIf appends Span element in the end
1 participant