Skip to content

fix: use inject in ListViewComponent #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

We changed the ListViewComponent a while ago and it broke backwards compatibility for some plugins

What is the new behavior?

We don't rely on super() calls anymore and instead use inject()

@nx-cloud
Copy link

nx-cloud bot commented Dec 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0898b84. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Dec 14, 2022
@NathanWalker NathanWalker merged commit 9fdb0d2 into main Dec 14, 2022
@NathanWalker NathanWalker deleted the fix/listview-component-api branch December 14, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants