Skip to content

CI: Enforce SPDX identifier check #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leofang opened this issue Apr 26, 2025 · 2 comments
Open

CI: Enforce SPDX identifier check #586

leofang opened this issue Apr 26, 2025 · 2 comments
Assignees
Labels
blocked This task is currently blocked by other tasks enhancement Any code-related improvements P0 High priority - Must do! triage Needs the team's attention

Comments

@leofang
Copy link
Member

leofang commented Apr 26, 2025

Follow-up of #583. We should ensure the CI checks if each file has an SPDX-License-Identifier entry in the file header, and even better if it matches the project requirement.

@leofang leofang added blocked This task is currently blocked by other tasks CI/CD CI/CD infrastructure enhancement Any code-related improvements P0 High priority - Must do! labels Apr 26, 2025
@leofang leofang added this to the cuda.core beta 4 milestone Apr 26, 2025
@rwgk
Copy link
Collaborator

rwgk commented Apr 26, 2025

Triggering the check from pre-commit would be ideal.

It looks easy, I'm attaching a perplexity PDF which explains how.

pre-commit question__I usually run `pre-commit run.pdf

@leofang
Copy link
Member Author

leofang commented Apr 27, 2025

It might also be a good idea! We already run pre-commit checks in the CI, so if this is part of pre-commit then we do not need any CI addition.

@leofang leofang added triage Needs the team's attention and removed CI/CD CI/CD infrastructure labels Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This task is currently blocked by other tasks enhancement Any code-related improvements P0 High priority - Must do! triage Needs the team's attention
Projects
None yet
Development

No branches or pull requests

3 participants