-
Notifications
You must be signed in to change notification settings - Fork 67
Update tutorial for drawing masked sprite backgrounds #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would recommend the following in addition to this within the same PR.
docs.monogame.github.io/articles/getting_to_know/howto/graphics/HowTo_Draw_A_Sprite.md Lines 23 to 24 in 0631a66
Add a similar admonition to the How To Draw A Sprite Background stating that the page assumes the reader read the previous article on drawing a sprite (in general)
docs.monogame.github.io/articles/getting_to_know/howto/graphics/HowTo_Draw_A_Sprite.md Lines 56 to 57 in 0631a66
|
AristurtleDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes do fix the code bug, so given that I would approve these changes. Please see my other comment as well, and @SimonDarksideJ if you have any thoughts on that
|
Hello @AristurtleDev 😄 Just made the changes you suggested, I think they help on clarifying a little bit more the documentation. Thanks! |
AristurtleDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an adjustment on the links
articles/getting_to_know/howto/graphics/HowTo_Draw_Sprite_Background.md
Outdated
Show resolved
Hide resolved
|
Hello @AristurtleDev ! Just fixed the URLs and changed them to be relative to the file. And I also changed one of the URLs that was also hardcoded in the |
* Update tutorial for drawing masked sprite backgrounds * Add note on revising the How to draw a Sprite topic * Add additional link to How to Tint a Sprite guide * Add relative links instead of hardcoded ones
This pull request makes minor improvements to the sprite drawing code examples in the
HowTo_Draw_Sprite_Background.mddocumentation. The changes clarify how to use theSpriteBatch.Drawmethod by specifying the position and color parameters, to fix the errorCS1501: No overload for the method Draw takes 1 arguments._spriteBatch.Drawin code examples to include explicitVector2.Zerofor position andColor.Whitefor color. [1] [2]